Re: my comments on meeting1

2008-07-02 Thread Linus Nielsen Feltzing

Jonathan Gordon wrote:

always keeping track of bookmarks means more disk access. and that
extra main menu entry... I thought it was enabled by default and would
have no problems changing that default.


Couldn't they be cached in memory and flushed at shutdown?

Linus



Question about audiohw_set_xxx_vol

2008-07-02 Thread Christian Gmeiner
Hi all,

as the term at university is over I have some time to work more on
sound.c and affected files :)
At the moment I am looking at set_prescaled_volume in sound.c... the
big ifdef suff at the end of
this method.

#if CONFIG_CODEC == MAS3507D
dac_volume(tenthdb2reg(l), tenthdb2reg(r), false);
#elif defined(HAVE_UDA1380) || defined(HAVE_WM8975) || defined(HAVE_WM8758) \
   || defined(HAVE_WM8731) || defined(HAVE_WM8721) || defined(HAVE_WM8751) \
   || defined(HAVE_AS3514) || defined(HAVE_TSC2100)
audiohw_set_master_vol(tenthdb2master(l), tenthdb2master(r));
#if defined(HAVE_WM8975) || defined(HAVE_WM8758) \
   || (defined(HAVE_WM8751)  !defined(MROBE_100)) \
   || defined(HAVE_TSC2100) || defined(HAVE_WM8985)
audiohw_set_lineout_vol(tenthdb2master(0), tenthdb2master(0));
#endif

#elif defined(HAVE_TLV320) || defined(HAVE_WM8978) || defined(HAVE_WM8985)
audiohw_set_headphone_vol(tenthdb2master(l), tenthdb2master(r));
#endif


My goal is it to get rid of it... but there are - I think - two ways to do it.

1) Introduce an #define in each audio driver header... something like
#define audiohw_set_volume(l, r)
audiohw_set_master_vol(tenthdb2master(l), tenthdb2master(r))

Then I would use audiohw_set_volume in sound.c

2) Extend the current audiohw api with methods like
void audiohw_set_master_vol(int l, int r)
void audiohw_set_lineout_vol(int l, int r)

and use master for setting volume for headphones and lineout for
changing vol at lineout.
BUT as far as I can see lineout is not used in rockbox at the moment
(called from /apps )...

hmmm

How do we want to handle lineout? Do we really need it?

I would go for 2), as it seems for me the cleanest solution.

thanks,
Christian


Re: Question about audiohw_set_xxx_vol

2008-07-02 Thread Jonathan Gordon
2008/7/2 Christian Gmeiner [EMAIL PROTECTED]:
 How do we want to handle lineout? Do we really need it?


IMO lineout should always be set to 0dB...

Jonathan


DevCon iRiver Bootloader

2008-07-02 Thread Matthias Mohr

Hi,

it seems the DevCon Europe 2008 was a lot fun for the participants.
It's a pity that I was unable to join the party :-)

Now to my question:
Regarding to http://www.rockbox.org/twiki/bin/view/Main/DevConEuro2008
there were plans to test and maybe release an update H3x0 bootloader.
Did this happen? Did Linus  Pete met together and even talk aobut that?

Or were too much other important things to do?

with regards,
Matthias (aka Massa)



RE: DevCon iRiver Bootloader

2008-07-02 Thread Peter D'Hoye
 Now to my question:
 Regarding to http://www.rockbox.org/twiki/bin/view/Main/DevConEuro2008
 there were plans to test and maybe release an update H3x0 
 bootloader. Did this happen? Did Linus  Pete met together 
 and even talk aobut that?

Yes we did have a short chat and I gave him my h380 to abuse it for a day.
After trying various things without result (like I did), he went to do a
binary search to find which commit broke it.

He managed to find that commit by the time Devcon was over, so I hope he can
figure out what went wrong in it. FYI, the commit that broke it was his ;)


Peter



Re: my comments on meeting1

2008-07-02 Thread Nix
On 2 Jul 2008, Linus Nielsen Feltzing stated:

 Jonathan Gordon wrote:
 always keeping track of bookmarks means more disk access. and that
 extra main menu entry... I thought it was enabled by default and would
 have no problems changing that default.

 Couldn't they be cached in memory and flushed at shutdown?

That means always spinning up the disk on shutdown, doesn't it? Are
disks happy with rapid spinup-then-powerdown cycles? (Some iPod Video
disks at least made unpleasant screeching noises if you did that.)