[Citadel Development] Attachments now download with the appropriate filename.

[rss]

This was accomplished by disregarding any REST components to the right of
the part number, allowing the filename to be placed there.  The filename is
sanitized to prevent script injection.

[Citadel Development] view_mail.js: better display of attachment links; attachments are now working

[rss]

Displaying each one as a link definitely makes it stand out from the message text.
Display the size of each attachment --   _(bytes) is already in the webcit-classic translations
Downloads are working, but the wrong file name is derived

[Citadel Development] Attachment download links target to _blank

[rss]

[Citadel Development] Re: Write server PID to citadel.lock in addition to locking it.

[IGnatius T Foobar]

  
 So here's what is on my mind regarding this.  Suggestions are welcome. 
  
 `/var/run` is a good place to put the PID file, which as previously mentioned
is also the lock file.  Mounting the same database from two different instances
of `citserver` would be A Bad Thing.  (Even though I'm still freaking amazed
at how stable the database has become once we switched to the mmap-backed
environment ... I still can't make it go corrupt no matter how hard I try.)

  
 On a regular machine, or in a jail, `/var/run` is in the right place, and
does the right thing. 
  
 In a container ... `/var/run` will not be in the same persistent volume as
the database.  That means someone could accidentally start up two containers
that have different `/var/run` but the same `/usr/local/citadel/data` with
catastrophic results. 
  
 I'm tossing around a couple of ideas: 
  
 * Writing the pid file to both $ctdldir/citadel.lock
*and* /var/run/citserver.pid 
  
 * Making /var/run/citserver.pid a symbolic link to $ctdldir/citadel.lock

  
 I really don't want to make the containerized version harder to use. 
 

[Citadel Development] Where gettimeofday() is required, include both time.h and sys/time.h

[rss]