[ros-dev] Server down
Hi, both doxygen.reactos.org iso.reactos.org are down (which results in daily builds isos not being uploaded). Anyone able to fix them? Regards, P. Schweitzer ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [rharabien] 51108: Fix ProbeForRead. It wasn't ever checking if memory can be accessed. Thanks to big-endian it wasn't breaking MmUserProbeAddress as well. Code is now nearly
Am 22.03.2011 02:13, schrieb Minas Abrahamyan: At the same time, with /FIRSTCHANCE key enabled do we need ROS to popup kdbg at every start? It's so bothering... just annoying Is this being triggered by this commit? It would be interesting as it might light up a possible bug somewhere. ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] Introduction
Am 21.03.2011 16:46, schrieb Neeraj Yadav: Hello, Hi and welcome to ReactOS! ReactOS is coming as my new interest and luckily this year ReactOS has been selected as a mentoring organisation.I find myself appropriate for SSH server implementation and Audio Mixer Project. I'm the mentor of the Audio Mixer project. If you choose this project, you can reach me in IRC Freenode network in channel #reactos-dev, #reactos with nick janderwald. If you prefer email, johannes.anderw...@reactos.org is the address to discuss things. Kind regards, Johannes Anderwald ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [cfinck] 51118: Create a branch for Neeraj Yadav's work on the Audio Mixer
This seems a little premature. I assume Neeraj is aware that there's no guarantee that the audio mixer will be one of the selected GSoC projects? I'm by no means suggesting that we would do this, but good business sense says that if someone is willing to work on a component outside of GSoC, isn't it counter-productive for the project to use one of their slots up? Anyway, we'll see what we have on the April 8 deadline. I wish Neeraj luck in both his application and his forthcoming work in reactos. Ged. -Original Message- From: ros-diffs-boun...@reactos.org [mailto:ros-diffs-boun...@reactos.org] On Behalf Of cfi...@svn.reactos.org Sent: 22 March 2011 12:46 To: ros-di...@reactos.org Subject: [ros-diffs] [cfinck] 51118: Create a branch for Neeraj Yadav's work on the Audio Mixer Author: cfinck Date: Tue Mar 22 12:45:40 2011 New Revision: 51118 URL: http://svn.reactos.org/svn/reactos?rev=51118view=rev Log: Create a branch for Neeraj Yadav's work on the Audio Mixer Added: branches/nyadav-audio-branch/ - copied from r51117, trunk/ ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [gadamopoulos] 51115: [ntoskrnl] - Implement calling OkayToCloseProcedure callouts to win32k for desktop and window station objects - Fix a bug that caused ObpCloseHandle to
It's hilarious how this new code has the exact same Windows security bug I gave
a talk about at BlackHat 2-3 years ago (which Microsoft fixed in Vista).
It's sad how this code ignores the exported PsSetProcessWindowStation API and
relevant EPROCESS field.
It's awesome how nothing changes whenever I prop up to see the progress.
--
Best regards,
Alex Ionescu
On 2011-03-22, at 5:19 AM, gadamopou...@svn.reactos.org wrote:
Author: gadamopoulos
Date: Tue Mar 22 09:19:26 2011
New Revision: 51115
URL: http://svn.reactos.org/svn/reactos?rev=51115view=rev
Log:
[ntoskrnl]
- Implement calling OkayToCloseProcedure callouts to win32k for desktop and
window station objects
- Fix a bug that caused ObpCloseHandle to return success even when
OkayToCloseProcedure failed
[win32k]
- Rewrite SetProcessWindowStation to actually set the current window station
and close the previous one
- Implement OkayToCloseProcedure callouts from the kernel to prevent closing
the current desktop or window station
Modified:
trunk/reactos/ntoskrnl/ex/win32k.c
trunk/reactos/ntoskrnl/ob/obhandle.c
trunk/reactos/ntoskrnl/ps/win32.c
trunk/reactos/subsystems/win32/win32k/include/desktop.h
trunk/reactos/subsystems/win32/win32k/include/win32.h
trunk/reactos/subsystems/win32/win32k/include/winsta.h
trunk/reactos/subsystems/win32/win32k/main/dllmain.c
trunk/reactos/subsystems/win32/win32k/ntuser/desktop.c
trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c
Modified: trunk/reactos/ntoskrnl/ex/win32k.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/win32k.c?rev=51115r1=51114r2=51115view=diff
==
--- trunk/reactos/ntoskrnl/ex/win32k.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ex/win32k.c [iso-8859-1] Tue Mar 22 09:19:26 2011
@@ -37,9 +37,45 @@
PKWIN32_PARSEMETHOD_CALLOUT ExpWindowStationObjectParse = NULL;
PKWIN32_DELETEMETHOD_CALLOUT ExpWindowStationObjectDelete = NULL;
+PKWIN32_OKTOCLOSEMETHOD_CALLOUT ExpWindowStationObjectOkToClose = NULL;
+PKWIN32_OKTOCLOSEMETHOD_CALLOUT ExpDesktopObjectOkToClose = NULL;
PKWIN32_DELETEMETHOD_CALLOUT ExpDesktopObjectDelete = NULL;
/* FUNCTIONS /
+
+NTSTATUS
+NTAPI
+ExpDesktopOkToClose( IN PEPROCESS Process OPTIONAL,
+ IN PVOID Object,
+ IN HANDLE Handle,
+ IN KPROCESSOR_MODE AccessMode)
+{
+WIN32_OKAYTOCLOSEMETHOD_PARAMETERS Parameters;
+
+Parameters.Process = Process;
+Parameters.Object = Object;
+Parameters.Handle = Handle;
+Parameters.PreviousMode = AccessMode;
+
+return ExpDesktopObjectOkToClose(Parameters);
+}
+
+NTSTATUS
+NTAPI
+ExpWindowStationOkToClose( IN PEPROCESS Process OPTIONAL,
+ IN PVOID Object,
+ IN HANDLE Handle,
+ IN KPROCESSOR_MODE AccessMode)
+{
+WIN32_OKAYTOCLOSEMETHOD_PARAMETERS Parameters;
+
+Parameters.Process = Process;
+Parameters.Object = Object;
+Parameters.Handle = Handle;
+Parameters.PreviousMode = AccessMode;
+
+return ExpWindowStationObjectOkToClose(Parameters);
+}
VOID
NTAPI
@@ -114,6 +150,7 @@
ObjectTypeInitializer.PoolType = NonPagedPool;
ObjectTypeInitializer.DeleteProcedure = ExpWinStaObjectDelete;
ObjectTypeInitializer.ParseProcedure = ExpWinStaObjectParse;
+ObjectTypeInitializer.OkayToCloseProcedure = ExpWindowStationOkToClose;
ObCreateObjectType(Name,
ObjectTypeInitializer,
NULL,
@@ -124,6 +161,7 @@
ObjectTypeInitializer.GenericMapping = ExpDesktopMapping;
ObjectTypeInitializer.DeleteProcedure = ExpDesktopDelete;
ObjectTypeInitializer.ParseProcedure = NULL;
+ObjectTypeInitializer.OkayToCloseProcedure = ExpDesktopOkToClose;
ObCreateObjectType(Name,
ObjectTypeInitializer,
NULL,
Modified: trunk/reactos/ntoskrnl/ob/obhandle.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev=51115r1=51114r2=51115view=diff
==
--- trunk/reactos/ntoskrnl/ob/obhandle.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ob/obhandle.c [iso-8859-1] Tue Mar 22 09:19:26 2011
@@ -1752,7 +1752,6 @@
/* Detach and return success */
if (AttachedToProcess) KeUnstackDetachProcess(ApcState);
-Status = STATUS_SUCCESS;
}
else
{
Modified: trunk/reactos/ntoskrnl/ps/win32.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/win32.c?rev=51115r1=51114r2=51115view=diff
==
--- trunk/reactos/ntoskrnl/ps/win32.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ps/win32.c
[ros-dev] COM in reactos
Hi, i've been looking at the mmc documentation Ged kindly provided me, and i've some questions. As I understand, the mmc is a com object. It has some interfaces - described on http://msdn.microsoft.com/en-us/library/aa815078(v=VS.85).aspx -, which are exported as usual in a COM environment, via registry. My question is about the maturity of the com infrastructure in reactos; are there some com objects already exported and used ? Where i could look for more info about COM in reactos ? Thanks ! On lunes 21 de marzo de 2011 at 14:37, Ged Murphy wrote: Hi Pedro, The Microsoft Management Console sounds like it could be a good start for you to improve your skills. This is a project which would be better suited to C++, so you wouldn’t have to stick to C. It also uses XML for loading snap-ins and it quite well documented, so you shouldn’t have too much trouble looking for information to help you. Although there are aspects of COM within the MMC, you will also require knowledge of the win32 API and the windows GUI / windowing. You should also take into consideration that reactos doesn’t have MFC or ATL available, so you would need to rely on the base win32 API and your own skills. If you’d like to chat further about this or anything else, please feel free to either use this mailing list or come and visit us in IRC. IRC might be better in this situation as it’s much easier to converse. Regards, Ged Murphy. From: ros-dev-boun...@reactos.org [mailto:ros-dev-boun...@reactos.org] On Behalf Of perencia Sent: 21 March 2011 12:25 To: ros-dev@reactos.org Subject: [ros-dev] GSOC Self-Presentation Hi!, my name is Pedro, and i'm a 5th grade student of computer science in Universitat Autonoma de Barcelona ( Spain ). I'd like to apply in this gsoc, i've always wanted to be part of an open-source project, i think it can be a really profitable and exciting experience to share ideas and discuss them with other motivated coders. Now as i'm finishing my last year i've found myself attracted by low-level questions. I've been aware of ReactOS for some time now - couple of years ago I downloaded the code and submitted a patch for the build system - actually, very silly patch :). About the projects proposed, some of them seem a bit heavy for me. At first the ACPI Hal cought my attention, since i'm doing my final year project en the energy-performance tradeoff in multi-cores, but it seems very daunting, i have no experience in kernel development nor drivers. Although is in Java where i'm really experienced, I'm confident with c and c++, and i'm very interested in COM, I've done some of it in DirectX and i really enjoyed that, so i thought the MMC Console seems more affordable. Anyway, i'd like to get some advice, if that's possible, about where i could direct myself, which project my profile may fit better or which has greater priority, and what can i do to start getting in contact to the project and make a better apply proposal. I hope this would be a beginning of a great and profitable experience for me and the community :) ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [gadamopoulos] 51115: [ntoskrnl] - Implement calling OkayToCloseProcedure callouts to win32k for desktop and window station objects - Fix a bug that caused ObpCloseHandle to
On 2011-03-22, at 6:07 PM, Olaf Siejka wrote: or just pass info how to do it. Try reading the e-mail. -- Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [gadamopoulos] 51115: [ntoskrnl] - Implement calling OkayToCloseProcedure callouts to win32k for desktop and window station objects - Fix a bug that caused ObpCloseHandle to
I suppose every time someone 'writes a paper' on something you take it as bragging -- however this is called a statement of fact. Bragging sounds more like I was the only scientist capable of discovering the phenomenon and writing a paper on it. Or I wrote the seminal, ground-breaking paper on... (unless this is a well-established public fact -- but even then, one should probably not mention it in this way). We also have something called 'references'. Therefore, when someone writes In my paper published in Nature, Issue 12, Volume 192 it is not a hint, it is a reference. A competent academic would then look up the issue (and unless the author wrote two papers in the journal, you should not need any extra information). Perhaps 2-3 years ago was too vague -- although given the scarcity of papers I have published at that particular conference, it is not hard to find the correct year: 2008. Of course, the inability to make the basic Google search to discover the paper even after I referenced it, explains the inability to have read the paper before hand (hint: regular scientists will often look up papers published on the topic they're about to embark on), or to have written the code without duplicating the same security issue. If you can't read, it's hard to write. -- Best regards, Alex Ionescu On 2011-03-22, at 6:11 PM, Olaf Siejka wrote: I see mostly bragging around and bit of subtle hinting. Not that i`d care about it. 2011/3/22 Alex Ionescu ion...@videotron.ca On 2011-03-22, at 6:07 PM, Olaf Siejka wrote: or just pass info how to do it. Try reading the e-mail. -- Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [gadamopoulos] 51115: [ntoskrnl] - Implement calling OkayToCloseProcedure callouts to win32k for desktop and window station objects - Fix a bug that caused ObpCloseHandle to
Me sorry. Me too stupid. tl:dr I guess you shouldn't waste your time by any futher reply. Regards 2011/3/22 Alex Ionescu ion...@videotron.ca I suppose every time someone 'writes a paper' on something you take it as bragging -- however this is called a statement of fact. Bragging sounds more like I was the only scientist capable of discovering the phenomenon and writing a paper on it. Or I wrote the seminal, ground-breaking paper on... (unless this is a well-established public fact -- but even then, one should probably not mention it in this way). We also have something called 'references'. Therefore, when someone writes In my paper published in Nature, Issue 12, Volume 192 it is not a hint, it is a reference. A competent academic would then look up the issue (and unless the author wrote two papers in the journal, you should not need any extra information). Perhaps 2-3 years ago was too vague -- although given the scarcity of papers I have published at that particular conference, it is not hard to find the correct year: 2008. Of course, the inability to make the basic Google search to discover the paper even after I referenced it, explains the inability to have read the paper before hand (hint: regular scientists will often look up papers published on the topic they're about to embark on), or to have written the code without duplicating the same security issue. If you can't read, it's hard to write. -- Best regards, Alex Ionescu On 2011-03-22, at 6:11 PM, Olaf Siejka wrote: I see mostly bragging around and bit of subtle hinting. Not that i`d care about it. 2011/3/22 Alex Ionescu ion...@videotron.ca On 2011-03-22, at 6:07 PM, Olaf Siejka wrote: or just pass info how to do it. Try reading the e-mail. -- Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [gadamopoulos] 51115: [ntoskrnl] - Implement calling OkayToCloseProcedure callouts to win32k for desktop and window station objects - Fix a bug that caused ObpCloseHandle to
Am 22.03.2011 23:17, gab Alex Ionescu folgendes von sich: bla bla bla bla bla bla bla bla -- Best regards, Alex Ionescu Since you seem to be interested in helping the project but are uncapable of doing it correctly, let me help you a bit: The fact that you gave a talk about something is probably pretty important ... for your ego. Its irrelevant to fixing the problem though. Instead of mentioning it, and later posting quite a lot of even more unrelated, boring and useless information, you could have simply pointed out where the actual problem was. That would have helped more. Altough it would have been less fun of course and less people would google for your name / talk. (I didn't anyway) I wonder if MS really made the mistake of returning TRUE/FALSE in a function that is supposed to return an NTSTATUS. Probably not. Did you even notice this bug? If yes, thanks for not mentioning it to avoid any inconvenience. If no... nah, impossible, BTW, would you like to take part in GSoC as a student? Maybe you could do something like rewriting the kernel based on windows 8 or something? I think I could mentor you. Thanks, Timo ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [gadamopoulos] 51115: [ntoskrnl] - Implement calling OkayToCloseProcedure callouts to win32k for desktop and window station objects - Fix a bug that caused ObpCloseHandle to
Unbelievable! We should be happy that Alex even commented on this commit to point out a flaw. Spend some time looking in to what he said, and less time disrespecting a man with his name on the cover of Windows Internals. Waxy On Tue, Mar 22, 2011 at 7:35 PM, Timo Kreuzer timo.kreu...@web.de wrote: Am 22.03.2011 23:17, gab Alex Ionescu folgendes von sich: bla bla bla bla bla bla bla bla -- Best regards, Alex Ionescu -- +encoded if you square a unicorn do you get a real animal? ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
