Re: [Rpm-maint] [rpm-software-management/rpm] RFC Add OS/2 magic and dependency parser for LX executables. (#351)
ydario commented on this pull request.
> @@ -0,0 +1,3 @@
+%__os2_provides%{_rpmconfigdir}/os2deps.sh --provides
+%__os2_requires%{_rpmconfigdir}/os2deps.sh --requires
+%__os2_magic ^(32|64)-bit.*$
mmhh is it ran across which file types? e.g. DLL magic is
32-bit DLL [WINDOWCOMPAT]
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/351#discussion_r148861519___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Add OS/2 magic and dependency parser for LX executables. (#351)
ydario commented on this pull request.
> @@ -0,0 +1,3 @@
+%__os2_provides%{_rpmconfigdir}/os2deps.sh --provides
+%__os2_requires%{_rpmconfigdir}/os2deps.sh --requires
+%__os2_magic ^(32|64)-bit.*$
The full output is
32-bit OS/2 executable [WINDOWCOMPAT]
so maybe I can add 'OS/2'
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/351#discussion_r148860964___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350#pullrequestreview-74173395___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Add OS/2 magic and dependency parser for LX executables. (#351)
Conan-Kudo requested changes on this pull request.
> @@ -0,0 +1,3 @@
+%__os2_provides%{_rpmconfigdir}/os2deps.sh --provides
+%__os2_requires%{_rpmconfigdir}/os2deps.sh --requires
+%__os2_magic ^(32|64)-bit.*$
This magic is too broad. Is there a may to make this a more restrictive match
so that it doesn't just get everything?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/351#pullrequestreview-74172934___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFC Add OS/2 magic and dependency parser for LX executables. (#351)
Added file magic and parser for LX executable format. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/351 -- Commit Summary -- * Add OS/2 magic and dependency parser for LX executables. -- File Changes -- M Makefile.am (6) M fileattrs/Makefile.am (4) M scripts/Makefile.am (4) A scripts/os2deps.sh (3) A tools/lxlist.h (50) A tools/os2deps.c (127) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/351.patch https://github.com/rpm-software-management/rpm/pull/351.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/351 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)
Disable PIC flags in OS/2 build. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/350 -- Commit Summary -- * Building with PIC enabled is not supported in OS/2. -- File Changes -- M configure.ac (8) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/350.patch https://github.com/rpm-software-management/rpm/pull/350.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFC: detect OS/2 operating system (#349)
Detec OS/2 operating system when running configure script. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/349 -- Commit Summary -- * Replace hardcoded lib path with python prefix value. * Detect OS/2 operating system in configure script. -- File Changes -- M configure.ac (12) M fileattrs/python.attr (3) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/349.patch https://github.com/rpm-software-management/rpm/pull/349.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/349 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts: add brp-mangle-shebangs (#344)
Fussing with env-shebangs is the tip of a deeper problem: scripts can/will execute other executables, and there are no attempts to auto-generate rpm dependencies for other needed executables within scripts, including searching run-time (not build-time) PATH to see if executable exists. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/344#issuecomment-341767106___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)
The idea was to return a valid file name, so called code has something to open/close. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341742426___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Update Polish plural forms (#347)
I did try on Zanata, but I don’t think it allows to edit .po headers (including Plural-Forms). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/347#issuecomment-341738032___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)
@ydario Sure, but then the question becomes, why `/dev/tty` is hardcoded then? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341733198___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)
ah ok now I see. Is "Test for ctermid() existence. This is done because the OS/2 platform does not provide it" a valid commit message? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341717326___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Replace hardcoded path with _libdir macro as done in pkgconfig.attr. (#346)
I just checked SHLIB_EXT in python for OS/2, and it reports ['".dll"\r'] which is even wrong. I don't know why historically the code is compiling shared modules with PYD extension. This is a bit strange since DLL is more common and I don't see a good reason for changing it unless original porters wanted to avoid recognizing them as ordinary DLLs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/346#issuecomment-341716398___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Replace hardcoded path with _libdir macro as done in pkgconfig.attr. (#346)
I was not aware that x86_64 was already ending in 64.But python lib can be queried using the code in the 2nd comment, I just don't know how to insert into a .attr file. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/346#issuecomment-341714329___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add runtime_library_dirs for custom prefix. (#348)
Is RPATH being removed on installation? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/348#issuecomment-341713238___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)
Yes, obviously. But the rationale etc needs to be documented in commit messages, not somewhere in GH. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341713269___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)
This is a follow up of discussion on issue #260 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341710617___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add runtime_library_dirs for custom prefix. (#348)
Previously we needed to set `LD_LIBRARY_PATH` to run the Python bindings for custom prefix. ``` $ LD_LIBRARY_PATH=$HOME/git/rpm/dest/lib python3 -c 'import rpm; print(rpm.__version__)' 4.14.90 ``` This PR to do "import rpm" without LD_LIBRARY_PATH. Below is the way to reproduce and test it. This PR is related to https://github.com/rpm-software-management/rpm/pull/327 and https://github.com/rpm-software-management/rpm/issues/130 . ``` $ pwd /home/jaruga/git/rpm $ ./autogen.sh --noconfigure $ ./configure --prefix="$(pwd)/dest" $ make $ make install $ dest/bin/rpm --version RPM version 4.14.90 $ cd python/ $ which python3 /usr/local/python-3.6.2/bin/python3 $ python3 -m pip list | grep rpm $ python3 setup.py build $ sudo /usr/local/python-3.6.2/bin/python3 setup.py install $ python3 -m pip list | grep rpm rpm 4.14.90 $ cd .. $ python3 -c 'import rpm; print(rpm.__version__)' 4.14.90 ``` Ref. https://docs.python.org/3/distutils/apiref.html https://docs.python.org/2/distutils/apiref.html > runtime_library_dirs | list of directories to search for C/C++ libraries at > run time (for shared extensions, this is when the extension is loaded) You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/348 -- Commit Summary -- * Add runtime_library_dirs for custom prefix. -- File Changes -- M python/setup.py.in (3) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/348.patch https://github.com/rpm-software-management/rpm/pull/348.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/348 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix Python bindings library path for custom prefix. (#327)
@pmatilai thanks for your checking! > but I don't see this helping #130 at least in the general case. OK, perhaps, I may need to send additional PR for that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/327#issuecomment-341691588___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm with ndb fails to build on macOS due to missing "mremap()" (#334)
Dunno but seriously doubt it. Validated patches welcome ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/334#issuecomment-341685065___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Check for 'gettext' during configure script (#245)
Rpm simply does what gettext documentation recommends: ``` AM_GNU_GETTEXT([external]) ``` If you dont have/want gettext, use --disable-nls as explained in the above. I dont see anything to fix here... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/245#issuecomment-341684565___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Check for 'gettext' during configure script (#245)
Closed #245. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/245#event-1324726714___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm with ndb fails to build on macOS due to missing "mremap()" (#334)
@pmatilai Wouldn't using `unmap()` + `mmap()` work as an alternative to bombing out on `mremap()`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/334#issuecomment-341684304___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm with ndb fails to build on macOS due to missing "mremap()" (#334)
Closed #334. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/334#event-1324715733___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm with ndb fails to build on macOS due to missing "mremap()" (#334)
Fixed in commit 8c4bfd74b568d9be138e8ec4fd38dc2ca427d433. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/334#issuecomment-341682939___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts: add brp-mangle-shebangs (#344)
@ignatenkobrain If we pull in a cleaned up version of #122, we will have a consistent way to manage brp scripts via option 1. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/344#issuecomment-341679395___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: show command which is executed for dependency generator in debug mode (#338)
@pmatilai great! thanks a lot ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/338#issuecomment-341673616___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: show command which is executed for dependency generator in debug mode (#338)
Closed #338. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/338#event-1324633493___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: show command which is executed for dependency generator in debug mode (#338)
Ask nicely and you shall receive :) Example output with commit 1d1ff6c86fc9afb4c6c89b42fdb5be851f13cb7a: [pmatilai@sopuli rpm]$ rpm -ql python2-libs|./rpmdeps -R --rpmfcdebug -vv 2>&1|grep "^D: Executing"|head -5 D: Executing /usr/lib/rpm/pythondistdeps.py --provides --majorver-provides on /usr/lib/python2.7/site-packages D: Executing /usr/lib/rpm/pythondeps.sh --requires on /usr/lib/python2.7/site-packages D: Executing /usr/lib/rpm/elfdeps --provides on /usr/lib64/libpython2.7.so.1.0 D: Executing /usr/lib/rpm/elfdeps --requires on /usr/lib64/libpython2.7.so.1.0 D: Executing /usr/lib/rpm/pythondistdeps.py --provides --majorver-provides on /usr/lib64/python2.7/BaseHTTPServer.py -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/338#issuecomment-341671568___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix Python bindings library path for custom prefix. (#327)
Merged #327. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/327#event-1324601413___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix Python bindings library path for custom prefix. (#327)
Because we haven't had a chance to dig into it? I suppose it's fine for what it is, but I don't see this helping #130 at least in the general case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/327#issuecomment-341666860___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a new option --alldeps to rpmdeps (#220)
Sorry for taking so long with this, and thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/220#issuecomment-341666296___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a new option --alldeps to rpmdeps (#220)
Merged #220. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/220#event-1324596559___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Replace hardcoded path with _libdir macro as done in pkgconfig.attr. (#346)
Yup, %{_libdir} is wrong on x86_64 and technically like with %{_prefix},
there's no actual guarantee that python shares the same prefix as rpm. So I
guess the really right thing to do would be querying all those different
library paths out of python itself: we have %python_sitelib and
%python_sitearch but nothing for the standard lib, and I'm not sure they're
technically required to overlap in the way the do in eg Fedora.
Might also be that's all just being too perfect for anybodys good, and
%{_prefix} be close enough for this purpose. Dunno.
The 'pyd' addition should be in a separate commit, and explained what it is.
But for that too, the technically most correct solution would be fishing the
extension out of python itself:
```
>>> import distutils.sysconfig
>>> distutils.sysconfig.get_config_vars('SHLIB_EXT')
['".so"']
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/346#issuecomment-341652505___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts: add brp-mangle-shebangs (#344)
JFYI (Python specific) https://github.com/fedora-python/python-rpm-porting/issues/24 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/344#issuecomment-341651577___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)
I think it might be actually better to just not export posix.ctermid() on systems that don't support it. I don't see much good coming out of claiming the controlling terminal is /dev/tty on a system that doesn't have terminals at all. And yeah a bit of rationale as for the why part is in order, because ctermid() is mandated by POSIX.1-2001 and POSIX.1-2008. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341646146___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Update Polish plural forms (#347)
Merged, but in general translation updates should go through Zanata. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/347#issuecomment-341645006___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Update Polish plural forms (#347)
Merged #347. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/347#event-1324449164___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)
Some rationale (e.g. where function doesn't exist) would be good ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341633520___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Replace hardcoded path with _libdir macro as done in pkgconfig.attr. (#346)
ignatenkobrain commented on this pull request.
> @@ -1,4 +1,4 @@
%__python_provides %{_rpmconfigdir}/pythondeps.sh --provides
%__python_requires %{_rpmconfigdir}/pythondeps.sh --requires
-%__python_path
^((/usr/lib(64)?/python[[:digit:]]\\.[[:digit:]]/.*\\.(py[oc]?|so))|(%{_bindir}/python[[:digit:]]\\.[[:digit:]]))$
+%__python_path
^((%{_libdir}(64)?/python[[:digit:]]\\.[[:digit:]]/.*\\.(py[oc]?|so|pyd))|(%{_bindir}/python[[:digit:]]\\.[[:digit:]]))$
on x86_64 that would be: `/usr/lib64(64)?` which is wrong.. do you really have
very different libdir or is it %{_prefix}/lib* ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/346#pullrequestreview-74004988___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts: add brp-mangle-shebangs (#344)
> Down that path, you'd probably want to add some further restrictions to some > interpreters, eg -E / -I / -s for Python etc. This would be good idea (cc @encukou @hroncok @stratakis @torsava) > So lets just accept there are valid reasons for both, and not make life > unnecessarily hard for either case. So for this I think we need (@pmatilai) to implement either: 1. Full disabler for brp (but as you mentioned above we don't have consistent way, so do you have suggestion how to do it right?) 2. Support for exclude paths (as I mentioned above, we don't have file classifiers for brp's so immediate solution would be doing it in shell and my question whether just putting regex user specified to 'find' would be enough or we need to make sure that regex for brp is compatible with RPM regexes... how?) 3. Both -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/344#issuecomment-341633258___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts: add brp-mangle-shebangs (#344)
If an env-shebang is left alone then it's not right to filter /bin/env out of the dependencies because env is then needed for running too. The reason rpm doesn't generate dependencies for env-shebangs is that it can't be sure about the path. There was a ticket on the old rpm.org trac instance, probably dating back to last decade or so, discussed it with @scop there... Okay, these days most many distros have the everything in /usr and there are only so many things that are used in shebang to begin with... might actually be time to revisit that part, but like that's a different topic. The bigger reason for mangling env out of shebang lines is to make the interpreter of system utilities etc predictable and not subject to user environment. There is a point to that - I remember encountering and debugging some oddities that turned out to be caused by local Python installation in users path and cursing the waste of time. Down that path, you'd probably want to add some further restrictions to some interpreters, eg -E / -I / -s for Python etc. And then there are cases where that flexibility is exactly what you *want*, which is why @remicollet is less than happy about this one (or rather, the new Fedora policy). So lets just accept there are valid reasons for both, and not make life unnecessarily hard for either case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/344#issuecomment-341629250___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
