Re: [sage-devel] Re: Ticket 15003

2014-02-17 Thread Amit Jamadagni
Hello,
A review on the ticket would be great
http://trac.sagemath.org/ticket/15003. Thanks.


On Sat, Feb 15, 2014 at 7:14 AM, Amit Jamadagni wrote:

> Hello,
>  I have tried to resolve the issue. Any comments would be helpful.
> Thanks.
>
>
> On Fri, Feb 14, 2014 at 4:31 AM, Volker Braun wrote:
>
>> Never copy&paste code around. Just call gamma from factorial.
>>
>>
>> On Thursday, February 13, 2014 8:13:47 PM UTC, Amit Jamadagni wrote:
>>>
>>> Hello,
>>> I was going through this ticket http://trac.sagemath.
>>> org/ticket/15003. The factorial should return gamma(x+1) which is the
>>> necessary answer, can this be directly called or should there be a
>>> replication of the code from gamma implementation.I was going through
>>> real_mpfi.pyx. This is the first time I am trying to fix a ticket for Sage.
>>> Any help would be really great. Thanks.
>>>
>>  --
>> You received this message because you are subscribed to the Google Groups
>> "sage-devel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to sage-devel+unsubscr...@googlegroups.com.
>> To post to this group, send email to sage-devel@googlegroups.com.
>> Visit this group at http://groups.google.com/group/sage-devel.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [sage-devel] Re: Ticket 15003

2014-02-14 Thread Amit Jamadagni
Hello,
 I have tried to resolve the issue. Any comments would be helpful.
Thanks.


On Fri, Feb 14, 2014 at 4:31 AM, Volker Braun  wrote:

> Never copy&paste code around. Just call gamma from factorial.
>
>
> On Thursday, February 13, 2014 8:13:47 PM UTC, Amit Jamadagni wrote:
>>
>> Hello,
>> I was going through this ticket http://trac.sagemath.
>> org/ticket/15003. The factorial should return gamma(x+1) which is the
>> necessary answer, can this be directly called or should there be a
>> replication of the code from gamma implementation.I was going through
>> real_mpfi.pyx. This is the first time I am trying to fix a ticket for Sage.
>> Any help would be really great. Thanks.
>>
>  --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To post to this group, send email to sage-devel@googlegroups.com.
> Visit this group at http://groups.google.com/group/sage-devel.
> For more options, visit https://groups.google.com/groups/opt_out.
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/groups/opt_out.


[sage-devel] Re: Ticket 15003

2014-02-13 Thread Volker Braun
Never copy&paste code around. Just call gamma from factorial.

On Thursday, February 13, 2014 8:13:47 PM UTC, Amit Jamadagni wrote:
>
> Hello,
> I was going through this ticket 
> http://trac.sagemath.org/ticket/15003. The factorial should return 
> gamma(x+1) which is the necessary answer, can this be directly called or 
> should there be a replication of the code from gamma implementation.I was 
> going through real_mpfi.pyx. This is the first time I am trying to fix a 
> ticket for Sage. Any help would be really great. Thanks.
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/groups/opt_out.