[Samba] samba4 master-branch compiling error
Get following errors compiling samba4 master-branch in vmware virtualmachine : --- /usr/bin/ld: i386:x86-64 architecture of input file `../client/umount.cifs.o' is incompatible with i386 output /usr/bin/ld: i386:x86-64 architecture of input file `../client/mtab.o' is incompatible with i386 output --- samba-4.0.0.alpha10 compiles ok -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] windows 7 and printer sharing
Hi, On a linux server with CUPS, I installed Samba to share it with windows computers. I managed to share it with my Macbook on MacOS 10.4, with this address : | smb://login:passw...@name _of_server/name_of_printer| So I think my server is well configured. BUT I don't even see my network on a Windows 7 computer (I applied the Maybe it's because it thinks it's on a public network ? I use Linux for 10 years, but the last Windows computer I used was using NT4, it was in 2003, so I'm really lost with this Windows 7 !!! What can I do ? Even if the auto-detection doesn't work, is it possible to use a simple manual address like I do with my Macbook ? Thanks in advance ! - This is my smb.conf : # # Sample configuration file for the Samba suite for Debian GNU/Linux. # # # This is the main Samba configuration file. You should read the # smb.conf(5) manual page in order to understand the options listed # here. Samba has a huge number of configurable options most of which # are not shown in this example # # Some options that are often worth tuning have been included as # commented-out examples in this file. # - When such options are commented with ;, the proposed setting #differs from the default Samba behaviour # - When commented with #, the proposed setting is the default #behaviour of Samba but the option is considered important #enough to be mentioned here # # NOTE: Whenever you modify this file you should run the command # testparm to check that you have not made any basic syntactic # errors. # A well-established practice is to name the original file # smb.conf.master and create the real config file with # testparm -s smb.conf.master smb.conf # This minimizes the size of the really used smb.conf file # which, according to the Samba Team, impacts performance # However, use this with caution if your smb.conf file contains nested # include statements. See Debian bug #483187 for a case # where using a master file is not a good idea. # #=== Global Settings === [global] # Change this to the workgroup/NT-domain name your Samba server will part of workgroup = # server string is the equivalent of the NT Description field server string = %h server # This will prevent nmbd to search for NetBIOS names through DNS. dns proxy = no hosts allow = 192.168.1. Networking interfaces = eth0 Debugging/Accounting log file = /var/log/samba/log.%m max log size = 1000 syslog = 1 panic action = /usr/share/samba/panic-action %d ### Authentication ### security = share encrypt passwords = true passdb backend = tdbsam obey pam restrictions = yes unix password sync = yes passwd program = /usr/bin/passwd %u passwd chat = *Enter\snew\s*\spassword:* %n\n *Retype\snew\s*\spassword:* %n\n *password\supdated\ssuccessfully* . pam password change = yes ## Printing ## load printers = yes printing = cups printcap name = cups [printers] comment = All Printers browseable = yes path = /var/spool/samba printable = yes guest ok = yes read only = yes create mask = 0700 [print$] comment = Printer Drivers path = /var/lib/samba/printers browseable = yes read only = yes guest ok = yes - Regards, Chris -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] windows 7 and printer sharing
On Tue, 05 Jan 2010 12:03:38 +0100 Christophe Baegert c.baegert-lis...@lixium.fr wrote: CB Hi, CB On a linux server with CUPS, I installed Samba to share it with windows CB computers. CB I managed to share it with my Macbook on MacOS 10.4, with this address : | CB smb://login:passw...@name _of_server/name_of_printer| CB So I think my server is well configured. CB BUT I don't even see my network on a Windows 7 computer (I applied the In your case I wouldn't use smb for printing. both OSX and windows (at least recent ones) can print directly to a CUPS server. the main advantage of SMB printing is automatic installation of drivers. this is worth the trouble only if you have many clients. (and to my knowledge it doesn't work with 64bits OS) Use http://your.cups.server/printers/your_printername to connect to your cups server. -- Jean-Jacques Moulis Tel: (013) 281684 ISYFax: (013) 139282 Linköping UniversityE-mail: j...@isy.liu.se 581 83 Linköping -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba as domain member to another samba PDC
Daniel Müller schrieb: Hello, with pdbedit -L on my MemberServer (Samba) I could not list the domain users and groups! With pdbedit -L it is only working on my PDC(Samba) I assume then this is - at least at the moment - normal behaviour of pdbedit. Perhaps someone else on this list can tell me if this is going to change or has already changed e.g. with Samba 4. Try getent passwd and getent group instead. If there show up your users and groups. try example: touch test.txt and then chown yourdomainuser:thisuserdomaingroup. If this function you can test next: Make a share on your SambaMemberServer. Give the rights to a user only known in your SambaDomain (no local user) . Try to connect the share as this user. If this is working you got it. I already did that, and it works. That's not the point I'm asking for. As I wrote in my first post, I want to use a GUI for creating samba shares that relies on the output of pdbedit -L for listing users which are allowed/denied access. If pdbedit -L does not work, I will either have to write my own pdbedit which wil mimic the expected output by calling ldapsearch and formatting the output like pdbedit does. Or I will have to find another suitable GUI. Thank you for your help, Andreas -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] windows 7 and printer sharing
Hi, Le 05/01/2010 13:03, Jean-Jacques Moulis a écrit : In your case I wouldn't use smb for printing. both OSX and windows (at least recent ones) can print directly to a CUPS server. IPP never worked on my Macbook using OS X 10.4, which works well with Samba. But I didn't try it on the Windows 7 computer, I'll try that, if it works, indeed, Samba isn't necessary !!! Thank you for your help. Regards, Chris -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Samba share browseable to certain IP networks
Hello. I have set up a shared samba server for two organisations. Using hosts allow I can permit access to a share from a certain IP network, however, the share is browseable still for everybody. How can I prevent that, is that possible? Regards, Patrik Hall -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Samba with DNS
When the Samba4 for gets released this year, how is DNS to be setup, is there any special requirements, will samba setup dns for you when using active directory? How does that whole part work? I have seen that kerberos will be built in. Also I have to say, I saw the Samba Team Blog 3 and I really like how they will rename the services to be more suited to thier task. It is great. Keep up with the great work. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] windows 7 and printer sharing
On Tue, Jan 05, 2010 at 01:38:18PM +0100, Christophe Baegert wrote: IPP never worked on my Macbook using OS X 10.4, which works well with Samba. Odd, given I remember Mac OS X 10.1 automatically detecting the IPP broadcasts by cups (which cups was set to share printers with the network, which it doesn't by default). Apple is even funding cups these days. As long as your print server with cups is configured to share with the local network, and not firewalling it away it should work. But I didn't try it on the Windows 7 computer, I'll try that, if it works, indeed, Samba isn't necessary !!! Thank you for your help. I have certainly used IPP printing with windows. use the url: http://printerserver:631/printers/print_queue_name And install the right driver of course. Of course cups should be configured to handle unknown job types as raw (which I think is normally the default these days as well). -- Len Sorensen -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] NTLMv2 in Sun's 'official' Samba 3.0.37?
It didn't work for me on Sun with Samba 3.0.37 either.I was under the impression (quite possibly wrong) that for Win 7 support you would need Samba 3.3.x or 3.4.x anyway.I have been testing the sunfreeware.com version of samba 3.4.x (full zfs support seems to be missing) and compiling it from scratch (getting kerberos enabled is a problem.) And hoping that a Sun-provided build of 3.4.x comes out sometime in the next 6 months. 3.0.x line is hitting a dead end. (Dell has made our life easier in 2009 by still shipping us machines with XP.)I have an open ticket with Sun on separate issue with 3.0.37 so I am hoping this will let me find out what their plans are. On 12/27/09 19:29, Jake Carroll wrote: Hi all. Just looking for some guidance as to what works, and what doesn't. Recently I've noticed that no matter what I do, I can't seem to get NTLMv2 to negotiate using Windows Vista, Windows 7 or Mac OS X 10.6.x against Solaris 10 Samba 3.0.37. If I 'tune' the client OS that it only negotiates with NTLMv1, all is well. In my global block, on the Solaris Samba server, I have: [global] client lanman auth=no client ntlmv2 auth=yes ntlm auth = no Now, I'd have thought that this would be enough to make NTLMv2 work along it's merry way - but apparently not. Whenever I attempt to connect and negotiate using NTLMv2, the client OS is given a generic 'incorrect username or password' response. So - the question. Does 3.0.37 actually even support NTLMv2? Am I doing something wrong in trying to turn it 'on'? Sun aren't talking, but I'm sure somebody here would know the history behind this... Thanks all. JC -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] NTLMv2 in Sun's 'official' Samba 3.0.37?
From everything I've read and experienced, version 3.3.4 was the earliest Samba version that was demonstrated to be able to support Windows 7 (with the proper registry entries). Blessings, David On Jan 5, 2010 10:04 AM, Gaiseric Vandal gaiseric.van...@gmail.com wrote: It didn't work for me on Sun with Samba 3.0.37 either.I was under the impression (quite possibly wrong) that for Win 7 support you would need Samba 3.3.x or 3.4.x anyway.I have been testing the sunfreeware.comversion of samba 3.4.x (full zfs support seems to be missing) and compiling it from scratch (getting kerberos enabled is a problem.) And hoping that a Sun-provided build of 3.4.x comes out sometime in the next 6 months. 3.0.x line is hitting a dead end.(Dell has made our life easier in 2009 by still shipping us machines with XP.)I have an open ticket with Sun on separate issue with 3.0.37 so I am hoping this will let me find out what their plans are. On 12/27/09 19:29, Jake Carroll wrote: Hi all. Just looking for some guidance as to w... -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] windows 7 and printer sharing
You may also want to look into setting up avahi to advertise your CUPS printer. Avahi is the Linux implementation of the Bonjour advertising protocol; Bonjour is for Apple what UPnP is for Windows. -Original Message- From: samba-boun...@lists.samba.org [mailto:samba- boun...@lists.samba.org] On Behalf Of Lennart Sorensen Sent: Tuesday, January 05, 2010 7:49 AM To: Christophe Baegert Cc: samba@lists.samba.org Subject: Re: [Samba] windows 7 and printer sharing On Tue, Jan 05, 2010 at 01:38:18PM +0100, Christophe Baegert wrote: IPP never worked on my Macbook using OS X 10.4, which works well with Samba. Odd, given I remember Mac OS X 10.1 automatically detecting the IPP broadcasts by cups (which cups was set to share printers with the network, which it doesn't by default). Apple is even funding cups these days. As long as your print server with cups is configured to share with the local network, and not firewalling it away it should work. But I didn't try it on the Windows 7 computer, I'll try that, if it works, indeed, Samba isn't necessary !!! Thank you for your help. I have certainly used IPP printing with windows. use the url: http://printerserver:631/printers/print_queue_name And install the right driver of course. Of course cups should be configured to handle unknown job types as raw (which I think is normally the default these days as well). -- Len Sorensen -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] upgrade from 3.2.15 fails - winbind problems
Greetings, I have been attempting an existing Samba domain member server that is running Samba 3.2.15 to 3.3.9 (or 3.4.3) but in either case my AD users end up being unknown to the server. I am using the idmap rid on the member server - no changes allowed to AD server, AD server not managed by my group. So far any attempt using 3.3.9 or 3.4.3 fails with AD users not being identified. I am sure I have a broken config file, but have been unable to correct it on my own, nor have I been able to find an up-to-date example of how the smb.conf file for someone using idmap rid *should* look in the current versions of samba. I would *love* to see a working smb.conf file from someone using idmap rid on a AD member server with the tbd backend on a currnet version of samba. I have left and rejoined the domain. Testjoin says I joined okay. wbinfo -g returns a list of groups However, wbinfo -t tells me checking the trust secret via RPC calls failed Could not check secret and is see the following from wbinfo -a 1001362%password plaintext password authentication succeeded could not obtain winbind interface details! could not obtain winbind separator! could not obtain winbind interface details! could not obtain winbind domain name! challenge/response password authentication succeeded finally from my hacked-up smb.conf file. # idmap uid and idmap gid are aliases for # winbind uid and winbid gid, respectively # OLD IDMAP SETTINGS - did not work # idmap backend = idmap_rid:CSUNET=1-2 # idmap uid = 1-2 # idmap gid = 1-2 # 3.2.14 IDMAP settings # idmap domains = CSUNET # idmap config CSUNET: default = yes # idmap config CSUNET: backend = rid # idmap config CSUNET: base_rid = 0 # idmap config CSUNET: range = 1-1 # 3.3.9 IDMAP settings - still not working. # winbind separator = \ winbind use default domain = yes template homedir = /home/%U template shell = /usr/bin/bash # idmap backend = tdb idmap uid = 1-1 idmap gid = 1-1 idmap config CSUNET: default = yes idmap config CSUNET: backend = rid idmap config CSUNET: range = 1-1 Thanks! -Bob -- *** Bob Martel,System Administrator I met someone who looks a lot like you Levin College of Urban Affairs She does the things you do Cleveland State University But she is an IBM (216) 687-2214 r.mar...@csuohio.edu-Jeff Lynne *** -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] NTLMv2 in Sun's 'official' Samba 3.0.37?
On Tue, Jan 5, 2010 at 08:04, Gaiseric Vandal gaiseric.van...@gmail.com wrote: It didn't work for me on Sun with Samba 3.0.37 either. I was under the impression (quite possibly wrong) that for Win 7 support you would need Samba 3.3.x or 3.4.x anyway. I have been testing the sunfreeware.com version of samba 3.4.x (full zfs support seems to be missing) and compiling it from scratch (getting kerberos enabled is a problem.) And hoping that a Sun-provided build of 3.4.x comes out sometime in the next 6 months. 3.0.x line is hitting a dead end. (Dell has made our life easier in 2009 by still shipping us machines with XP.) I have an open ticket with Sun on separate issue with 3.0.37 so I am hoping this will let me find out what their plans are. Their plans are to push 3.4: http://opensolaris.org/jive/thread.jspa?threadID=120279tstart=15 -- It's time to finish going metric. http://gometric.us -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] PDC directory permission fail
Dear Serg and All Сергей wrote: Hello, Bino! I use webmin to do the samba PDC configuration IMHO, insuffisient Agree ... I did some direct edit to conf file [warehouse] comment = Files of warehouse writeable = yes path = /hdd2/samba/groupfiles/warehouse when I create that share via webmin i use option : a. mode : 775 b. Create user : Root c. Create Group : warehouse. 4. From my XP station , I login to that domain with user name wh01, the results is : a. Successfull login b. wh01 can create a file in the home directory (/home/wh01) But, wh01 can not write file to share warehouse Which permission to the new file? May be 644? :) IMHO, user have right to write directory, but have not right to write file. Look man smb.conf for force create mode, force directory mode or http://wiki.samba.org/index.php/Frequently_Asked_Questions#inherit_permissions Thankyou for your enlightment I read that documentation, but I don't want uuser to be able to execute things in directory So I chage the share to : [warehouse] create mode = 660 path = /hdd2/samba/groupfiles/warehouse directory mode = 660 force group = warehouse (and the dircory is auto created with user:group as root:warehouse) Still the user with group warehouse can not access (event just open) the directory so I try to delete the share ... manualy remove the dir , and re create the share (and dir) with : [warehouse] create mode = 760 path = /hdd2/samba/groupfiles/warehouse directory mode = 760 force group = warehouse Still the user with group warehouse can not access (event just open) the directory Again, I try to delete the share ... manualy remove the dir , and re create the share (and dir) with : [warehouse] create mode = 770 path = /hdd2/samba/groupfiles/warehouse directory mode = 770 force group = warehouse And ... voila ... the user can access (read-write) into the shares ... But it'll means that the user can also execute somethings inside directory ... right ? Why we need the execute bit in directory permission just to let the user to read and write only ? Just fyi, my system is based on : ++ Ubuntu Jaunty ++ Samba 3.32 Sincerely -bino- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] PDC directory permission fail
Bino Oetomo wrote: And ... voila ... the user can access (read-write) into the shares ... But it'll means that the user can also execute somethings inside directory ... right ? Why we need the execute bit in directory permission just to let the user to read and write only ? That is how UNIX filesystem permissions work. 'Execute' on a directory allows traversal of (ie access into) the directory. From Wikipedia (http://en.wikipedia.org/wiki/File_system_permissions): There are three specific permissions on Unix-like systems that apply to each class: * The read permission, which grants the ability to read a file. When set for a directory, this permission grants the ability to read the names of files in the directory (but not to find out any further information about them such as contents, file type, size, ownership, permissions, etc.) * The write permission, which grants the ability to modify a file. When set for a directory, this permission grants the ability to modify entries in the directory. This includes creating files, deleting files, and renaming files. * The execute permission, which grants the ability to execute a file. This permission must be set for executable binaries (for example, a compiled c++ program) or shell scripts (for example, a Perl program) in order to allow the operating system to run them. When set for a directory, this permission grants the ability to traverse its tree in order to access files or subdirectories, but not see files inside the directory (unless read is set). Search Google for unix permissions if you need more understanding. -Brian -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] PDC directory permission fail
Dear Brian and all Thankyou for your fast enlightment Brian H. Nelson wrote: Bino Oetomo wrote: And ... voila ... the user can access (read-write) into the shares ... But it'll means that the user can also execute somethings inside directory ... right ? Why we need the execute bit in directory permission just to let the user to read and write only ? That is how UNIX filesystem permissions work. 'Execute' on a directory allows traversal of (ie access into) the directory. Understood. I Knew that for every execute will need read, thats why every allow-execute will consequently allow-read. But how if i need allo-write (consequently will allow-read) + deny-execute ? AFAIK it will 6 or 2 in permission bit, right ? Sincerely -bino- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via da41f23... s3 net: Fix up a share type translation and translate some more strings via 9a9d737... s3 net: Add a few missing gettext calls. from 2a66db8... Fix the merged build. Probably not strictly correct but allows us to make test. Jeremy. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit da41f23bdad1ea3a1a49110217cfde3efcde5075 Author: Kai Blin k...@samba.org Date: Tue Jan 5 09:54:04 2010 +0100 s3 net: Fix up a share type translation and translate some more strings commit 9a9d737070bfde62f2d5a35ad25606da578f9f7e Author: Kai Blin k...@samba.org Date: Tue Jan 5 09:43:34 2010 +0100 s3 net: Add a few missing gettext calls. Many many thanks to Adi Roiban from #ubuntu-translators for helping me find and fix my problems with the translations. --- Summary of changes: source3/locale/net/de.po | 2396 +- source3/utils/net_help.c |4 +- source3/utils/net_util.c |8 +- 3 files changed, 1093 insertions(+), 1315 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/locale/net/de.po b/source3/locale/net/de.po index 0e18172..e1ccb32 100644 --- a/source3/locale/net/de.po +++ b/source3/locale/net/de.po @@ -8,13 +8,13 @@ msgid msgstr Project-Id-Version: @pack...@\n Report-Msgid-Bugs-To: \n -POT-Creation-Date: 2009-08-11 09:01+0200\n +POT-Creation-Date: 2010-01-05 09:23+0100\n PO-Revision-Date: 2009-12-26 19:20+0100\n Last-Translator: André Hentschel n...@dawncrow.de\n +Language-Team: \n MIME-Version: 1.0\n Content-Type: text/plain; charset=UTF-8\n Content-Transfer-Encoding: 8bit\n -Language-Team: \n #: ../../utils/net.c:103 msgid Enter machine password: @@ -35,219 +35,269 @@ msgid This function will change the ADS Domain member machine account password in the secrets.tdb file!\n msgstr -#: ../../utils/net.c:150 -#: ../../utils/net.c:228 +#: ../../utils/net.c:132 +msgid Failed to open secrets.tdb.\n +msgstr + +#: ../../utils/net.c:139 ../../utils/net.c:157 ../../utils/net_conf.c:1136 ../../utils/net_help.c:36 ../../utils/net_rap.c:161 ../../utils/net_rap.c:302 ../../utils/net_rap.c:467 ../../utils/net_rap.c:750 ../../utils/net_rap.c:891 +#: ../../utils/net_rap.c:1002 ../../utils/net_rap.c:1193 ../../utils/net_rpc.c:979 ../../utils/net_rpc.c:2820 ../../utils/net_rpc.c:4923 ../../utils/net_rpc.c:6962 ../../utils/net_rpc.c:7067 ../../utils/net_util.c:586 +msgid Usage:\n +msgstr Verwendung:\n + +#: ../../utils/net.c:141 +#, c-format +msgid +net setauthuser -U user[%%password] \n +Set the auth user account to userpassword. Prompt for password if not specified.\n +msgstr + +#: ../../utils/net.c:146 ../../utils/net.c:164 +msgid +net setauthuser delete\n +Delete the auth user setting.\n +msgstr + +#: ../../utils/net.c:159 +#, c-format +msgid +net setauthuser -U user[%%password]\n +Set the auth user account to userpassword. Prompt for password if not specified.\n +msgstr + +#: ../../utils/net.c:169 +msgid the auth user +msgstr + +#: ../../utils/net.c:171 +msgid Failed to get the auth users password.\n +msgstr + +#: ../../utils/net.c:177 +msgid error storing auth user name\n +msgstr + +#: ../../utils/net.c:183 +msgid error storing auth user domain\n +msgstr + +#: ../../utils/net.c:189 +msgid error storing auth user password\n +msgstr + +#: ../../utils/net.c:213 +msgid No authorised user configured\n +msgstr + +#: ../../utils/net.c:255 ../../utils/net.c:333 #, c-format msgid Unable to open secrets.tdb. Can't fetch domain SID for name: %s\n msgstr -#: ../../utils/net.c:163 -#: ../../utils/net.c:251 +#: ../../utils/net.c:268 ../../utils/net.c:356 #, c-format msgid SID for domain %s is: %s\n msgstr -#: ../../utils/net.c:175 +#: ../../utils/net.c:280 msgid usage: net setlocalsid S-1-5-21-x-y-z\n msgstr -#: ../../utils/net.c:195 +#: ../../utils/net.c:300 msgid usage: net setdomainsid S-1-5-21-x-y-z\n msgstr -#: ../../utils/net.c:213 +#: ../../utils/net.c:318 msgid usage: net getdomainsid\n msgstr -#: ../../utils/net.c:238 +#: ../../utils/net.c:343 msgid Could not fetch local SID\n msgstr -#: ../../utils/net.c:242 +#: ../../utils/net.c:347 #, c-format msgid SID for local machine %s is: %s\n msgstr -#: ../../utils/net.c:246 +#: ../../utils/net.c:351 msgid Could not fetch domain SID\n msgstr -#: ../../utils/net.c:263 +#: ../../utils/net.c:368 #, c-format msgid get_maxrid: Could not search %s\n msgstr -#: ../../utils/net.c:297 +#: ../../utils/net.c:402 msgid usage: net maxrid\n msgstr -#: ../../utils/net.c:302 +#: ../../utils/net.c:407 msgid can't get current maximum rid\n msgstr -#: ../../utils/net.c:306 +#: ../../utils/net.c:411 #, c-format msgid Currently used maximum rid: %d\n
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated via 0272f44... s3 net: Fix up a share type translation and translate some more strings (cherry picked from commit da41f23bdad1ea3a1a49110217cfde3efcde5075) via dda3091... s3 net: Add a few missing gettext calls. via ba2cc29... net: Add some German translation from e743177... VERSION: Raise version number up to 3.5.0rc1. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test - Log - commit 0272f44061fa9205bb744e286b6203e15e157a6e Author: Kai Blin k...@samba.org Date: Tue Jan 5 09:54:04 2010 +0100 s3 net: Fix up a share type translation and translate some more strings (cherry picked from commit da41f23bdad1ea3a1a49110217cfde3efcde5075) commit dda309191e8927ffcea8724db1a65c422f90e6b9 Author: Kai Blin k...@samba.org Date: Tue Jan 5 09:43:34 2010 +0100 s3 net: Add a few missing gettext calls. Many many thanks to Adi Roiban from #ubuntu-translators for helping me find and fix my problems with the translations. (cherry picked from commit 9a9d737070bfde62f2d5a35ad25606da578f9f7e) commit ba2cc29fe0ebd4282ddd19026759bae2c93c Author: André Hentschel n...@dawncrow.de Date: Mon Dec 28 02:58:40 2009 +0100 net: Add some German translation Signed-off-by: Kai Blin k...@samba.org (cherry picked from commit b0dd364cdde107577c74a91f3a65989e97a2c073) --- Summary of changes: source3/locale/net/de.po | 2070 -- source3/utils/net_help.c |4 +- source3/utils/net_util.c |8 +- 3 files changed, 1092 insertions(+), 990 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/locale/net/de.po b/source3/locale/net/de.po index a336936..e1ccb32 100644 --- a/source3/locale/net/de.po +++ b/source3/locale/net/de.po @@ -1,5 +1,6 @@ # net message translation (german). # Copyright (C) 2009 Kai Blin k...@samba.org +# Copyright (C) 2009 André Hentschel n...@dawncrow.de # This file is distributed under the same license as the samba package. # #, fuzzy @@ -7,9 +8,10 @@ msgid msgstr Project-Id-Version: @pack...@\n Report-Msgid-Bugs-To: \n -POT-Creation-Date: 2009-08-11 09:01+0200\n -PO-Revision-Date: 2009-08-06 20:45+0200\n -Last-Translator: Kai Blin k...@samba.org\n +POT-Creation-Date: 2010-01-05 09:23+0100\n +PO-Revision-Date: 2009-12-26 19:20+0100\n +Last-Translator: André Hentschel n...@dawncrow.de\n +Language-Team: \n MIME-Version: 1.0\n Content-Type: text/plain; charset=UTF-8\n Content-Transfer-Encoding: 8bit\n @@ -33,216 +35,269 @@ msgid This function will change the ADS Domain member machine account password in the secrets.tdb file!\n msgstr -#: ../../utils/net.c:150 ../../utils/net.c:228 +#: ../../utils/net.c:132 +msgid Failed to open secrets.tdb.\n +msgstr + +#: ../../utils/net.c:139 ../../utils/net.c:157 ../../utils/net_conf.c:1136 ../../utils/net_help.c:36 ../../utils/net_rap.c:161 ../../utils/net_rap.c:302 ../../utils/net_rap.c:467 ../../utils/net_rap.c:750 ../../utils/net_rap.c:891 +#: ../../utils/net_rap.c:1002 ../../utils/net_rap.c:1193 ../../utils/net_rpc.c:979 ../../utils/net_rpc.c:2820 ../../utils/net_rpc.c:4923 ../../utils/net_rpc.c:6962 ../../utils/net_rpc.c:7067 ../../utils/net_util.c:586 +msgid Usage:\n +msgstr Verwendung:\n + +#: ../../utils/net.c:141 +#, c-format +msgid +net setauthuser -U user[%%password] \n +Set the auth user account to userpassword. Prompt for password if not specified.\n +msgstr + +#: ../../utils/net.c:146 ../../utils/net.c:164 +msgid +net setauthuser delete\n +Delete the auth user setting.\n +msgstr + +#: ../../utils/net.c:159 +#, c-format +msgid +net setauthuser -U user[%%password]\n +Set the auth user account to userpassword. Prompt for password if not specified.\n +msgstr + +#: ../../utils/net.c:169 +msgid the auth user +msgstr + +#: ../../utils/net.c:171 +msgid Failed to get the auth users password.\n +msgstr + +#: ../../utils/net.c:177 +msgid error storing auth user name\n +msgstr + +#: ../../utils/net.c:183 +msgid error storing auth user domain\n +msgstr + +#: ../../utils/net.c:189 +msgid error storing auth user password\n +msgstr + +#: ../../utils/net.c:213 +msgid No authorised user configured\n +msgstr + +#: ../../utils/net.c:255 ../../utils/net.c:333 #, c-format msgid Unable to open secrets.tdb. Can't fetch domain SID for name: %s\n msgstr -#: ../../utils/net.c:163 ../../utils/net.c:251 +#: ../../utils/net.c:268 ../../utils/net.c:356 #, c-format msgid SID for domain %s is: %s\n msgstr -#: ../../utils/net.c:175 +#: ../../utils/net.c:280 msgid usage: net setlocalsid S-1-5-21-x-y-z\n msgstr -#: ../../utils/net.c:195 +#: ../../utils/net.c:300 msgid usage: net setdomainsid S-1-5-21-x-y-z\n msgstr -#: ../../utils/net.c:213 +#: ../../utils/net.c:318 msgid
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via d06fb8e0.. s3: List trusted domains from wcache when domain is offline. via 133638c... s3: Make winbindd_cache.c aware of domain offline to avoid unnecessary backend query. via 36493bf... s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response. from da41f23... s3 net: Fix up a share type translation and translate some more strings http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit d06fb8e02706559e91c6d185427409bb093bb896 Author: Bo Yang boy...@samba.org Date: Wed Jan 6 19:13:59 2010 +0800 s3: List trusted domains from wcache when domain is offline. Signed-off-by: Bo Yang boy...@samba.org commit 133638c8aea7280d01b5a23150428977e9ff0e11 Author: Bo Yang boy...@samba.org Date: Wed Jan 6 15:05:20 2010 +0800 s3: Make winbindd_cache.c aware of domain offline to avoid unnecessary backend query. Signed-off-by: Bo Yang boy...@samba.org commit 36493bf2f6634b84c57107bcb86bcbf3e82e80fc Author: Bo Yang boy...@samba.org Date: Wed Jan 6 12:13:35 2010 +0800 s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response. Signed-off-by: Bo Yang boy...@samba.org --- Summary of changes: source3/include/proto.h |5 + source3/rpc_client/cli_pipe.c | 26 ++- source3/rpc_client/ndr.c| 15 ++ source3/rpc_client/rpc_transport_np.c | 12 + source3/rpc_client/rpc_transport_smbd.c | 10 + source3/rpc_client/rpc_transport_sock.c | 53 + source3/winbindd/winbindd_cache.c | 380 ++- source3/winbindd/winbindd_cm.c |3 +- source3/winbindd/winbindd_rpc.c | 14 +- 9 files changed, 501 insertions(+), 17 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/include/proto.h b/source3/include/proto.h index b3921c4..d956ede 100644 --- a/source3/include/proto.h +++ b/source3/include/proto.h @@ -5396,6 +5396,7 @@ NTSTATUS rpc_transport_np_init(TALLOC_CTX *mem_ctx, struct cli_state *cli, const struct ndr_syntax_id *abstract_syntax, struct rpc_cli_transport **presult); struct cli_state *rpc_pipe_np_smb_conn(struct rpc_pipe_client *p); +void rpccli_close_np_fd(struct rpc_pipe_client *p); /* The following definitions come from rpc_client/rpc_transport_smbd.c */ @@ -5426,11 +5427,15 @@ NTSTATUS rpc_transport_smbd_init(TALLOC_CTX *mem_ctx, struct rpc_cli_smbd_conn *conn, const struct ndr_syntax_id *abstract_syntax, struct rpc_cli_transport **presult); +struct cli_state *rpc_pipe_smbd_smb_conn(struct rpc_pipe_client *p); /* The following definitions come from rpc_client/rpc_transport_sock.c */ NTSTATUS rpc_transport_sock_init(TALLOC_CTX *mem_ctx, int fd, struct rpc_cli_transport **presult); +int rpccli_set_sock_timeout(struct rpc_pipe_client *rpccli, int timeout); +void rpccli_close_sock_fd(struct rpc_pipe_client *rpccli); +bool rpc_pipe_tcp_connection_ok(struct rpc_pipe_client *rpccli); /* The following definitions come from rpc_client/cli_samr.c */ diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c index 9653166..48e2f9e 100644 --- a/source3/rpc_client/cli_pipe.c +++ b/source3/rpc_client/cli_pipe.c @@ -3035,12 +3035,30 @@ NTSTATUS rpc_pipe_bind(struct rpc_pipe_client *cli, unsigned int rpccli_set_timeout(struct rpc_pipe_client *rpc_cli, unsigned int timeout) { - struct cli_state *cli = rpc_pipe_np_smb_conn(rpc_cli); + struct cli_state *cli; - if (cli == NULL) { - return 0; + if (rpc_cli-transport-transport == NCACN_NP) { + cli = rpc_pipe_np_smb_conn(rpc_cli); + if (cli == NULL) { + return 0; + } + return cli_set_timeout(cli, timeout); + } + + if (rpc_cli-transport-transport == NCACN_IP_TCP || + rpc_cli-transport-transport == NCALRPC) { + return rpccli_set_sock_timeout(rpc_cli, timeout); } - return cli_set_timeout(cli, timeout); + + if (rpc_cli-transport-transport == NCACN_INTERNAL) { + cli = rpc_pipe_smbd_smb_conn(rpc_cli); + if (!cli) { + return 0; + } + return cli_set_timeout(cli, timeout); + } + + return 0; } bool
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated via 65003db... s3: List trusted domains from wcache when domain is offline. via 063a2ce... s3: Make winbindd_cache.c aware of domain offline to avoid unnecessary backend query. via b58b359... s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response. from 0272f44... s3 net: Fix up a share type translation and translate some more strings (cherry picked from commit da41f23bdad1ea3a1a49110217cfde3efcde5075) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test - Log - commit 65003db3685098dd3b8370c5a6fc673c9eba5d7a Author: Bo Yang boy...@samba.org Date: Wed Jan 6 19:13:59 2010 +0800 s3: List trusted domains from wcache when domain is offline. Signed-off-by: Bo Yang boy...@samba.org (cherry picked from commit d06fb8e02706559e91c6d185427409bb093bb896) commit 063a2ceb9192a5b1820a7e115decc49357f2b3b6 Author: Bo Yang boy...@samba.org Date: Wed Jan 6 15:05:20 2010 +0800 s3: Make winbindd_cache.c aware of domain offline to avoid unnecessary backend query. Signed-off-by: Bo Yang boy...@samba.org (cherry picked from commit 133638c8aea7280d01b5a23150428977e9ff0e11) commit b58b359881c91ec382cfa1d6ba3007b8354b29cb Author: Bo Yang boy...@samba.org Date: Wed Jan 6 12:13:35 2010 +0800 s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response. Signed-off-by: Bo Yang boy...@samba.org (cherry picked from commit 36493bf2f6634b84c57107bcb86bcbf3e82e80fc) --- Summary of changes: source3/include/proto.h |5 + source3/rpc_client/cli_pipe.c | 26 ++- source3/rpc_client/ndr.c| 15 ++ source3/rpc_client/rpc_transport_np.c | 12 + source3/rpc_client/rpc_transport_smbd.c | 10 + source3/rpc_client/rpc_transport_sock.c | 53 + source3/winbindd/winbindd_cache.c | 380 ++- source3/winbindd/winbindd_cm.c |3 +- source3/winbindd/winbindd_rpc.c | 14 +- 9 files changed, 501 insertions(+), 17 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/include/proto.h b/source3/include/proto.h index d2ebd92..b3512d9 100644 --- a/source3/include/proto.h +++ b/source3/include/proto.h @@ -5377,6 +5377,7 @@ NTSTATUS rpc_transport_np_init(TALLOC_CTX *mem_ctx, struct cli_state *cli, const struct ndr_syntax_id *abstract_syntax, struct rpc_cli_transport **presult); struct cli_state *rpc_pipe_np_smb_conn(struct rpc_pipe_client *p); +void rpccli_close_np_fd(struct rpc_pipe_client *p); /* The following definitions come from rpc_client/rpc_transport_smbd.c */ @@ -5407,11 +5408,15 @@ NTSTATUS rpc_transport_smbd_init(TALLOC_CTX *mem_ctx, struct rpc_cli_smbd_conn *conn, const struct ndr_syntax_id *abstract_syntax, struct rpc_cli_transport **presult); +struct cli_state *rpc_pipe_smbd_smb_conn(struct rpc_pipe_client *p); /* The following definitions come from rpc_client/rpc_transport_sock.c */ NTSTATUS rpc_transport_sock_init(TALLOC_CTX *mem_ctx, int fd, struct rpc_cli_transport **presult); +int rpccli_set_sock_timeout(struct rpc_pipe_client *rpccli, int timeout); +void rpccli_close_sock_fd(struct rpc_pipe_client *rpccli); +bool rpc_pipe_tcp_connection_ok(struct rpc_pipe_client *rpccli); /* The following definitions come from rpc_client/cli_samr.c */ diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c index 23f002c..2f84828 100644 --- a/source3/rpc_client/cli_pipe.c +++ b/source3/rpc_client/cli_pipe.c @@ -3034,12 +3034,30 @@ NTSTATUS rpc_pipe_bind(struct rpc_pipe_client *cli, unsigned int rpccli_set_timeout(struct rpc_pipe_client *rpc_cli, unsigned int timeout) { - struct cli_state *cli = rpc_pipe_np_smb_conn(rpc_cli); + struct cli_state *cli; - if (cli == NULL) { - return 0; + if (rpc_cli-transport-transport == NCACN_NP) { + cli = rpc_pipe_np_smb_conn(rpc_cli); + if (cli == NULL) { + return 0; + } + return cli_set_timeout(cli, timeout); + } + + if (rpc_cli-transport-transport == NCACN_IP_TCP || + rpc_cli-transport-transport == NCALRPC) { + return rpccli_set_sock_timeout(rpc_cli, timeout); } - return cli_set_timeout(cli, timeout);
Re: [SCM] Samba Shared Repository - branch v3-5-test updated
On Tue, Jan 05, 2010 at 05:12:37AM -0600, Bo Yang wrote: commit 063a2ceb9192a5b1820a7e115decc49357f2b3b6 Author: Bo Yang boy...@samba.org Date: Wed Jan 6 15:05:20 2010 +0800 s3: Make winbindd_cache.c aware of domain offline to avoid unnecessary backend query. Signed-off-by: Bo Yang boy...@samba.org (cherry picked from commit 133638c8aea7280d01b5a23150428977e9ff0e11) Are you sure this is the right thing to do? winbindd_cache will be essentially removed in the very near future, at this moment we cache everything twice: Once in the NDR layer in the parent and once in the backends. Unfortunately for 3.5 I did not have enough time to complete this, but I hope you don't mind if I remove your new code very soon again. Volker signature.asc Description: Digital signature
Re: [SCM] Samba Shared Repository - branch v3-5-test updated
Volker Lendecke wrote: On Tue, Jan 05, 2010 at 05:12:37AM -0600, Bo Yang wrote: commit 063a2ceb9192a5b1820a7e115decc49357f2b3b6 Author: Bo Yang boy...@samba.org Date: Wed Jan 6 15:05:20 2010 +0800 s3: Make winbindd_cache.c aware of domain offline to avoid unnecessary backend query. Signed-off-by: Bo Yang boy...@samba.org (cherry picked from commit 133638c8aea7280d01b5a23150428977e9ff0e11) Are you sure this is the right thing to do? winbindd_cache will be essentially removed in the very near future, at this moment we cache everything twice: Once in the NDR layer in the parent and once in the backends. Unfortunately for 3.5 I did not have enough time to complete this, but I hope you don't mind if I remove your new code very soon again. Never mind. :-) pls don't remove the timeout part since s3_loop_once() loops forever without timeout. Volker -- Bo Yang, Software Engineer, Suse Labs GPG-key-ID 538C4C1A Samba Team boy...@samba.orghttp://www.samba.org/ SUSE Linux boy...@suse.de http://www.novell.com/
[SCM] SAMBA-CTDB repository - branch v3-4-ctdb updated - 3.4.2-ctdb-16-1-gb130fa9
The branch, v3-4-ctdb has been updated via b130fa9d595893621c8f5b9088f4e123bc9644c5 (commit) from 19f746178841c579a4db31733524f68924859262 (commit) http://gitweb.samba.org/?p=obnox/samba-ctdb.git;a=shortlog;h=v3-4-ctdb - Log - commit b130fa9d595893621c8f5b9088f4e123bc9644c5 Author: Michael Adam ob...@samba.org Date: Tue Jan 5 16:17:27 2010 +0100 s3:dbwrap_ctdb: fix an uninitialized variable. Michael --- Summary of changes: source3/lib/dbwrap_ctdb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/lib/dbwrap_ctdb.c b/source3/lib/dbwrap_ctdb.c index d70637e..d6fde35 100644 --- a/source3/lib/dbwrap_ctdb.c +++ b/source3/lib/dbwrap_ctdb.c @@ -381,7 +381,7 @@ static bool pull_newest_from_marshall_buffer(struct ctdb_marshall_buffer *buf, { struct ctdb_rec_data *rec = NULL; struct ctdb_ltdb_header h; - bool found; + bool found = false; TDB_DATA data; int i; -- SAMBA-CTDB repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via a08a0ff... s4:SAMLDB LDB module - Fix trailing whitespaces via 77ce33c... s4:SAMLDB LDB module - Rework to allow checks for wrong defaultObjectCategory attributes via c051008... s4:schema_load.c - Typo via bbf9885... s4:ldap_schema.py - add an additional check for validity of defaultObjectCategory via d8ca002... s4:ldap_schema.py - Move generated attributes check from d06fb8e0.. s3: List trusted domains from wcache when domain is offline. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit a08a0ffd37cbf0c87c054a499f549d74598e2db4 Author: Matthias Dieter Wallnöfer mwallnoe...@yahoo.de Date: Sun Jan 3 21:47:36 2010 +0100 s4:SAMLDB LDB module - Fix trailing whitespaces commit 77ce33c419dc000362a2c532e5c7afc1a013c731 Author: Matthias Dieter Wallnöfer mwallnoe...@yahoo.de Date: Sun Jan 3 20:36:09 2010 +0100 s4:SAMLDB LDB module - Rework to allow checks for wrong defaultObjectCategory attributes This allows a stricter check for defaultObjectCategory attributes which is performed when the relax control isn't specified. Additional note: As the added comment points out this isn't complete. And I personally think that moving this at some point to the objectclass module is a better idea to make this fully work (since there we have direct access to the schema). If someone has a good idea how to do this please inform me. Anyway, the SAMLDB module does require some restructure since at the moment it's very overloaded and therefore a bit a mess. In the meantime I started to work on a new approach to realise it in a better way. commit c051008540dd381bb79e39a0c9b6db6aa99a3a6e Author: Matthias Dieter Wallnöfer mwallnoe...@yahoo.de Date: Sun Jan 3 19:54:53 2010 +0100 s4:schema_load.c - Typo commit bbf988501352801f88c714a67e5ab2b9d19a7af1 Author: Matthias Dieter Wallnöfer mwallnoe...@yahoo.de Date: Sun Jan 3 19:53:01 2010 +0100 s4:ldap_schema.py - add an additional check for validity of defaultObjectCategory commit d8ca002a8c7b56712aeaadc19885f70d762ac059 Author: Matthias Dieter Wallnöfer mwallnoe...@yahoo.de Date: Sun Jan 3 19:43:52 2010 +0100 s4:ldap_schema.py - Move generated attributes check Make more clear that they're created before the schemaUpdateNow. --- Summary of changes: source4/dsdb/samdb/ldb_modules/samldb.c | 180 -- source4/dsdb/samdb/ldb_modules/schema_load.c |2 +- source4/lib/ldb/tests/python/ldap_schema.py | 55 ++-- 3 files changed, 154 insertions(+), 83 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/dsdb/samdb/ldb_modules/samldb.c b/source4/dsdb/samdb/ldb_modules/samldb.c index fc286c4..17a99c7 100644 --- a/source4/dsdb/samdb/ldb_modules/samldb.c +++ b/source4/dsdb/samdb/ldb_modules/samldb.c @@ -9,12 +9,12 @@ it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 3 of the License, or (at your option) any later version. - + This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - + You should have received a copy of the GNU General Public License along with this program. If not, see http://www.gnu.org/licenses/. */ @@ -333,37 +333,37 @@ static int samldb_check_samAccountName_callback(struct ldb_request *req, { struct samldb_ctx *ac; int ret; - + ac = talloc_get_type(req-context, struct samldb_ctx); - + if (ares-error != LDB_SUCCESS) { return ldb_module_done(ac-req, ares-controls, ares-response, ares-error); } - + switch (ares-type) { - case LDB_REPLY_ENTRY: + case LDB_REPLY_ENTRY: /* if we get an entry it means this samAccountName * already exists */ return ldb_module_done(ac-req, NULL, NULL, LDB_ERR_ENTRY_ALREADY_EXISTS); - + case LDB_REPLY_REFERRAL: /* this should not happen */ return ldb_module_done(ac-req, NULL, NULL, LDB_ERR_OPERATIONS_ERROR); - + case LDB_REPLY_DONE: /* not found, go on */ talloc_free(ares); ret = samldb_next_step(ac); break; } - + if (ret != LDB_SUCCESS) { return ldb_module_done(ac-req, NULL, NULL, ret); } - + return
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via f6bd654... Fix bug #7020 - smbd using 2G memory. from a08a0ff... s4:SAMLDB LDB module - Fix trailing whitespaces http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit f6bd654a6c878111f0f0f4d07adb644fc3bbf224 Author: Jeremy Allison j...@samba.org Date: Tue Jan 5 14:34:00 2010 -0800 Fix bug #7020 - smbd using 2G memory. When deferring an async pipe writeX and readX transfer the outstanding request struct onto the conn struct. This needs freeing after the packet is finally processed. Jeremy. --- Summary of changes: source3/smbd/pipes.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/smbd/pipes.c b/source3/smbd/pipes.c index bf64c59..9bc3fdf 100644 --- a/source3/smbd/pipes.c +++ b/source3/smbd/pipes.c @@ -353,6 +353,11 @@ static void pipe_write_andx_done(struct tevent_req *subreq) done: chain_reply(req); + /* +* We must free here as the ownership of req was +* moved to the connection struct in reply_pipe_write_and_X(). +*/ + TALLOC_FREE(req); } / @@ -458,4 +463,9 @@ static void pipe_read_andx_done(struct tevent_req *subreq) done: chain_reply(req); + /* +* We must free here as the ownership of req was +* moved to the connection struct in reply_pipe_read_and_X(). +*/ + TALLOC_FREE(req); } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated via b635398... Fix bug #7020 - smbd using 2G memory. from 65003db... s3: List trusted domains from wcache when domain is offline. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test - Log - commit b63539809d022f7012f4899a5a18a835079d6c6f Author: Jeremy Allison j...@samba.org Date: Tue Jan 5 14:34:00 2010 -0800 Fix bug #7020 - smbd using 2G memory. When deferring an async pipe writeX and readX transfer the outstanding request struct onto the conn struct. This needs freeing after the packet is finally processed. Jeremy. (cherry picked from commit f6bd654a6c878111f0f0f4d07adb644fc3bbf224) --- Summary of changes: source3/smbd/pipes.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/smbd/pipes.c b/source3/smbd/pipes.c index bf64c59..9bc3fdf 100644 --- a/source3/smbd/pipes.c +++ b/source3/smbd/pipes.c @@ -353,6 +353,11 @@ static void pipe_write_andx_done(struct tevent_req *subreq) done: chain_reply(req); + /* +* We must free here as the ownership of req was +* moved to the connection struct in reply_pipe_write_and_X(). +*/ + TALLOC_FREE(req); } / @@ -458,4 +463,9 @@ static void pipe_read_andx_done(struct tevent_req *subreq) done: chain_reply(req); + /* +* We must free here as the ownership of req was +* moved to the connection struct in reply_pipe_read_and_X(). +*/ + TALLOC_FREE(req); } -- Samba Shared Repository
Build status as of Wed Jan 6 07:00:03 2010
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2010-01-05 00:00:08.0 -0700 +++ /home/build/master/cache/broken_results.txt 2010-01-06 00:00:04.0 -0700 @@ -1,4 +1,4 @@ -Build status as of Tue Jan 5 07:00:03 2010 +Build status as of Wed Jan 6 07:00:03 2010 Build counts: Tree Total Broken Panic @@ -6,7 +6,7 @@ ccache 1 0 0 distcc 0 0 0 ldb 29 29 0 -libreplace 28 11 0 +libreplace 0 0 0 lorikeet 0 0 0 pidl 0 0 0 ppp 0 0 0 @@ -15,8 +15,8 @@ samba-web0 0 0 samba_3_current 27 26 0 samba_3_master 27 27 5 -samba_3_next 26 26 2 -samba_4_0_test 29 26 2 -talloc 28 10 0 -tdb 26 25 0 +samba_3_next 27 27 2 +samba_4_0_test 29 26 3 +talloc 1 0 0 +tdb 1 0 0