[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 617c647 Fix valgrind errors with memmove and talloc pools. via cbfc3ef Add simple limited pool tests to test_memlimit(). via 3d0f717 Remove talloc_memlimit_update(). No longer used. via 8e2a543 Inside _talloc_realloc(), keep track of size changes over malloc/realloc/free. via 314508d Don't call talloc_memlimit_update() inside _talloc_realloc() when we're just manipulating pool members. via 0fbcfcc Fix a conditional check. (size - tc->size > 0) is always true if size and tc->size are unsigned. via 4386029 In _talloc_steal_internal(), correctly decrement the memory limit in the source, and increment in the destination. via 6bc190d Inside _talloc_free_internal(), always call talloc_memlimit_update_on_free() before we free the real memory. via 4dfde7d Update memory limits when we call free() on a pool. via a4ebbe7 Change __talloc() to only call talloc_memlimit_check()/talloc_memlimit_grow() on actual malloc allocation. via 4159a78 Change _talloc_total_mem_internal() to ignore memory allocated from a pool when calculating limit size. via 7a6beae Remove magic TC_HDR_SIZE handling inside talloc_memlimit_check(). via fe790f6 Start to fix talloc memlimits with talloc pools. from 323cccd smbd: Use #defines in smb2_getinfo_send http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 617c647b8ef562ace589a11a15eb460e6db71f2a Author: Jeremy Allison Date: Tue Aug 27 13:20:43 2013 -0700 Fix valgrind errors with memmove and talloc pools. bin/smbtorture //127.0.0.1 local.talloc now runs with no valgrind errors. Signed-off-by: Jeremy Allison Reviewed-by: "Stefan (metze) Metzmacher" Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Aug 28 02:44:17 CEST 2013 on sn-devel-104 commit cbfc3efbfd4a3a6f3b031ce8ef375d37f2c545f3 Author: Jeremy Allison Date: Tue Aug 27 13:09:03 2013 -0700 Add simple limited pool tests to test_memlimit(). Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce commit 3d0f717d437bb24f430fad788b9eb35e8fe8e0e8 Author: Jeremy Allison Date: Tue Aug 27 13:08:33 2013 -0700 Remove talloc_memlimit_update(). No longer used. Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce commit 8e2a543e088cac36a5b6bbab1a6be961fa00cc4d Author: Jeremy Allison Date: Tue Aug 27 13:07:04 2013 -0700 Inside _talloc_realloc(), keep track of size changes over malloc/realloc/free. Replace the last use of talloc_memlimit_update() with talloc_memlimit_grow()/ talloc_memlimit_shrink(). Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce commit 314508dd73105138d756f4ca3dfb65f1d368a9f7 Author: Jeremy Allison Date: Tue Aug 27 13:03:27 2013 -0700 Don't call talloc_memlimit_update() inside _talloc_realloc() when we're just manipulating pool members. Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce commit 0fbcfcc824e474874c15d7c0b2ea0df408448906 Author: Jeremy Allison Date: Tue Aug 27 12:59:04 2013 -0700 Fix a conditional check. (size - tc->size > 0) is always true if size and tc->size are unsigned. Replace with (size > tc->size). Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce commit 43860293225d14ca2c339277b42f8705322463ab Author: Jeremy Allison Date: Tue Aug 27 12:57:43 2013 -0700 In _talloc_steal_internal(), correctly decrement the memory limit in the source, and increment in the destination. Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce commit 6bc190d6dd7fd0ab028c39c1463477a863f6943a Author: Jeremy Allison Date: Tue Aug 27 12:54:38 2013 -0700 Inside _talloc_free_internal(), always call talloc_memlimit_update_on_free() before we free the real memory. Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce commit 4dfde7d33e7ac6c94833ecc758baff487ab67e4e Author: Jeremy Allison Date: Tue Aug 27 12:51:20 2013 -0700 Update memory limits when we call free() on a pool. Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce commit a4ebbe73b4b8dcab4d344e693ad9796ec8997f87 Author: Jeremy Allison Date: Tue Aug 27 12:49:00 2013 -0700 Change __talloc() to only call talloc_memlimit_check()/talloc_memlimit_grow() on actual malloc allocation. Don't check the memlimit if the allocation was successful from a pool. We already checked the memory limit when we created the pool. Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce commit 4159a78ed7eda340758e22286f16186987a20f2f Author: Jeremy Allison Date: Tue Aug 27 12:46:09 2013 -0700 Change _talloc_total_mem_internal() to ignore memory allocated from a pool when calculating limit size. We must only count normal tallocs
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 323cccd smbd: Use #defines in smb2_getinfo_send from d1593a2 Fix the UNIX extensions CHOWN calls to use FCHOWN if available, else LCHOWN. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 323cccd35d06c7327c19dc5cb891043507624d7d Author: Volker Lendecke Date: Mon Aug 26 08:36:14 2013 + smbd: Use #defines in smb2_getinfo_send Signed-off-by: Volker Lendecke Reviewed-by: David Disseldorp Autobuild-User(master): David Disseldorp Autobuild-Date(master): Tue Aug 27 15:08:08 CEST 2013 on sn-devel-104 --- Summary of changes: source3/smbd/smb2_getinfo.c |8 1 files changed, 4 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/smbd/smb2_getinfo.c b/source3/smbd/smb2_getinfo.c index 7a41b19..4420f94 100644 --- a/source3/smbd/smb2_getinfo.c +++ b/source3/smbd/smb2_getinfo.c @@ -282,7 +282,7 @@ static struct tevent_req *smbd_smb2_getinfo_send(TALLOC_CTX *mem_ctx, } switch (in_info_type) { - case 0x01:/* SMB2_GETINFO_FILE */ + case SMB2_GETINFO_FILE: { uint16_t file_info_level; char *data = NULL; @@ -403,7 +403,7 @@ static struct tevent_req *smbd_smb2_getinfo_send(TALLOC_CTX *mem_ctx, break; } - case 0x02:/* SMB2_GETINFO_FS */ + case SMB2_GETINFO_FS: { uint16_t file_info_level; char *data = NULL; @@ -443,7 +443,7 @@ static struct tevent_req *smbd_smb2_getinfo_send(TALLOC_CTX *mem_ctx, break; } - case 0x03:/* SMB2_GETINFO_SEC */ + case SMB2_GETINFO_SECURITY: { uint8_t *p_marshalled_sd = NULL; size_t sd_size = 0; @@ -489,7 +489,7 @@ static struct tevent_req *smbd_smb2_getinfo_send(TALLOC_CTX *mem_ctx, break; } - case 0x04: /* SMB2_0_INFO_QUOTA */ + case SMB2_GETINFO_QUOTA: tevent_req_nterror(req, NT_STATUS_NOT_SUPPORTED); return tevent_req_post(req, ev); -- Samba Shared Repository
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2013-08-27-1351/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2013-08-27-1351/samba3.stderr http://git.samba.org/autobuild.flakey/2013-08-27-1351/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2013-08-27-1351/samba.stderr http://git.samba.org/autobuild.flakey/2013-08-27-1351/samba.stdout The top commit at the time of the failure was: commit d1593a20f3a5ebf287477dfa8f5ab31dca3dd0c3 Author: Jeremy Allison Date: Wed Aug 21 12:20:48 2013 -0700 Fix the UNIX extensions CHOWN calls to use FCHOWN if available, else LCHOWN. UNIX extensions calls must never deref links. Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Mon Aug 26 20:19:46 CEST 2013 on sn-devel-104
[SCM] Samba Shared Repository - branch v4-0-test updated
The branch, v4-0-test has been updated via 1787174 Fix bug #10063 - source3/lib/util.c:1493 leaking memory w/ pam_winbind.so / winbind from 16e6631 s3-winbindd: fix fallback to ncacn_np in cm_connect_lsat(). http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test - Log - commit 17871748fbf07c545099bdead294694c976d467a Author: Jeremy Allison Date: Fri Aug 2 15:03:39 2013 -0700 Fix bug #10063 - source3/lib/util.c:1493 leaking memory w/ pam_winbind.so / winbind Don't use talloc_tos() in something that can be linked to in pam_winbindd.so Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce Autobuild-User(master): Simo Sorce Autobuild-Date(master): Sat Aug 24 02:28:28 CEST 2013 on sn-devel-104 (cherry picked from commit 9423d5afb71e272298f4858d82f436e19ee2b07f) Autobuild-User(v4-0-test): Karolin Seeger Autobuild-Date(v4-0-test): Tue Aug 27 11:39:07 CEST 2013 on sn-devel-104 --- Summary of changes: source3/lib/util.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/lib/util.c b/source3/lib/util.c index 5ffce58..d543c7f 100644 --- a/source3/lib/util.c +++ b/source3/lib/util.c @@ -1487,10 +1487,12 @@ char *myhostname(void) char *myhostname_upper(void) { - char *name; static char *ret; if (ret == NULL) { - name = get_myname(talloc_tos()); + char *name = get_myname(NULL); + if (name == NULL) { + return NULL; + } ret = strupper_talloc(NULL, name); talloc_free(name); } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v4-1-test updated
The branch, v4-1-test has been updated via 6b6cab7 Fix bug #10063 - source3/lib/util.c:1493 leaking memory w/ pam_winbind.so / winbind from c41ffd5 ntdbtool.8.xml: Bump version up to 4.1. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-1-test - Log - commit 6b6cab72c12ac1bb5fadb31d56ece0e0ef37613c Author: Jeremy Allison Date: Fri Aug 2 15:03:39 2013 -0700 Fix bug #10063 - source3/lib/util.c:1493 leaking memory w/ pam_winbind.so / winbind Don't use talloc_tos() in something that can be linked to in pam_winbindd.so Signed-off-by: Jeremy Allison Reviewed-by: Simo Sorce Autobuild-User(master): Simo Sorce Autobuild-Date(master): Sat Aug 24 02:28:28 CEST 2013 on sn-devel-104 (cherry picked from commit 9423d5afb71e272298f4858d82f436e19ee2b07f) Autobuild-User(v4-1-test): Karolin Seeger Autobuild-Date(v4-1-test): Tue Aug 27 11:36:39 CEST 2013 on sn-devel-104 --- Summary of changes: source3/lib/util.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/lib/util.c b/source3/lib/util.c index 93aab3c..db46ad3 100644 --- a/source3/lib/util.c +++ b/source3/lib/util.c @@ -1487,10 +1487,12 @@ char *myhostname(void) char *myhostname_upper(void) { - char *name; static char *ret; if (ret == NULL) { - name = get_myname(talloc_tos()); + char *name = get_myname(NULL); + if (name == NULL) { + return NULL; + } ret = strupper_talloc(NULL, name); talloc_free(name); } -- Samba Shared Repository