autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-16-0856/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-16-0856/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-16-0856/samba.stdout The top commit at the time of the failure was: commit d9e335872a4072dd2db05a8bdbfa30ceedecdfcf Author: Noel PowerDate: Thu Feb 11 16:02:24 2016 + build: Fix cluster-support option, default was 'None' now 'False' Cluster-support had some auto-detection but no longer does. Prior to commit id(s) e67c4b977a52d1744f4da8296bbcd7c213cbe92a & 69c0c43d55c93b82b2e398d5c61009fd347170bf cluster support was auto detected Signed-off-by: Noel Power Reviewed-by: Martin Schwenke Reviewed-by: Uri Simchoni Reviewed-by: Amitay Isaacs Autobuild-User(master): Amitay Isaacs Autobuild-Date(master): Tue Feb 16 04:03:14 CET 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-16-0613/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-16-0613/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-16-0613/samba.stdout The top commit at the time of the failure was: commit 2267faddfa9863b205dfad580fbd45182916cb32 Author: Stefan MetzmacherDate: Mon Feb 15 11:40:34 2016 +0100 tevent: version 0.9.27 * Fix bug in poll backend - poll_event_loop_poll() exits the for loop on POLLNVAL instead of continuing to find an event that is ready. * Fix ETIME handling for Solaris event ports (bug #11728). Signed-off-by: Stefan Metzmacher Reviewed-by: Michael Adam Autobuild-User(master): Michael Adam Autobuild-Date(master): Tue Feb 16 00:00:51 CET 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via d9e3358 build: Fix cluster-support option, default was 'None' now 'False' via c4cd56c libcli: Fix debug message, print sid string for new_ace trustee. from 2267fad tevent: version 0.9.27 https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit d9e335872a4072dd2db05a8bdbfa30ceedecdfcf Author: Noel PowerDate: Thu Feb 11 16:02:24 2016 + build: Fix cluster-support option, default was 'None' now 'False' Cluster-support had some auto-detection but no longer does. Prior to commit id(s) e67c4b977a52d1744f4da8296bbcd7c213cbe92a & 69c0c43d55c93b82b2e398d5c61009fd347170bf cluster support was auto detected Signed-off-by: Noel Power Reviewed-by: Martin Schwenke Reviewed-by: Uri Simchoni Reviewed-by: Amitay Isaacs Autobuild-User(master): Amitay Isaacs Autobuild-Date(master): Tue Feb 16 04:03:14 CET 2016 on sn-devel-144 commit c4cd56c484c4edd8f271524bdd8e97a9e52116e6 Author: Noel Power Date: Thu Feb 11 16:00:55 2016 + libcli: Fix debug message, print sid string for new_ace trustee. Signed-off-by: Noel Power Reviewed-by: Uri Simchoni Reviewed-by: Amitay Isaacs --- Summary of changes: libcli/security/secdesc.c | 2 +- source3/wscript | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/libcli/security/secdesc.c b/libcli/security/secdesc.c index bbad8a3..6e20e90 100644 --- a/libcli/security/secdesc.c +++ b/libcli/security/secdesc.c @@ -567,7 +567,7 @@ NTSTATUS se_create_child_secdesc(TALLOC_CTX *ctx, " inherited as %s:%d/0x%02x/0x%08x\n", dom_sid_string(frame, >trustee), ace->type, ace->flags, ace->access_mask, - dom_sid_string(frame, >trustee), + dom_sid_string(frame, _ace->trustee), new_ace->type, new_ace->flags, new_ace->access_mask)); diff --git a/source3/wscript b/source3/wscript index 8fe1374..c6fdb1b 100644 --- a/source3/wscript +++ b/source3/wscript @@ -57,7 +57,7 @@ def set_options(opt): opt.SAMBA3_ADD_OPTION('profiling-data', default=False) opt.SAMBA3_ADD_OPTION('libarchive', default=None) -opt.SAMBA3_ADD_OPTION('cluster-support', default=None) +opt.SAMBA3_ADD_OPTION('cluster-support', default=False) opt.SAMBA3_ADD_OPTION('regedit', default=None) -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 2267fad tevent: version 0.9.27 from 279d249 README.Coding: Improve pointer example https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 2267faddfa9863b205dfad580fbd45182916cb32 Author: Stefan MetzmacherDate: Mon Feb 15 11:40:34 2016 +0100 tevent: version 0.9.27 * Fix bug in poll backend - poll_event_loop_poll() exits the for loop on POLLNVAL instead of continuing to find an event that is ready. * Fix ETIME handling for Solaris event ports (bug #11728). Signed-off-by: Stefan Metzmacher Reviewed-by: Michael Adam Autobuild-User(master): Michael Adam Autobuild-Date(master): Tue Feb 16 00:00:51 CET 2016 on sn-devel-144 --- Summary of changes: lib/tevent/ABI/{tevent-0.9.26.sigs => tevent-0.9.27.sigs} | 0 lib/tevent/wscript| 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) copy lib/tevent/ABI/{tevent-0.9.26.sigs => tevent-0.9.27.sigs} (100%) Changeset truncated at 500 lines: diff --git a/lib/tevent/ABI/tevent-0.9.26.sigs b/lib/tevent/ABI/tevent-0.9.27.sigs similarity index 100% copy from lib/tevent/ABI/tevent-0.9.26.sigs copy to lib/tevent/ABI/tevent-0.9.27.sigs diff --git a/lib/tevent/wscript b/lib/tevent/wscript index 103cc06..501de16 100755 --- a/lib/tevent/wscript +++ b/lib/tevent/wscript @@ -1,7 +1,7 @@ #!/usr/bin/env python APPNAME = 'tevent' -VERSION = '0.9.26' +VERSION = '0.9.27' blddir = 'bin' -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 279d249 README.Coding: Improve pointer example via dae1a9f README.Coding: Add a boolean example we use very often from 19fdc7f script/release.sh: generate announce.${tagname}.patch.txt in announcement_samba_rc() https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 279d2499763b5e56fd26faa4d04fe307d713944d Author: Andreas SchneiderDate: Mon Feb 15 15:53:50 2016 +0100 README.Coding: Improve pointer example Signed-off-by: Andreas Schneider Reviewed-by: Ralph Boehme Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Mon Feb 15 20:52:24 CET 2016 on sn-devel-144 commit dae1a9fdb5f85ebb1c72f7990959ffaa3003c769 Author: Andreas Schneider Date: Mon Feb 15 15:51:26 2016 +0100 README.Coding: Add a boolean example we use very often Signed-off-by: Andreas Schneider Reviewed-by: Ralph Boehme --- Summary of changes: README.Coding | 12 1 file changed, 12 insertions(+) Changeset truncated at 500 lines: diff --git a/README.Coding b/README.Coding index 29bad1b..2b011a6 100644 --- a/README.Coding +++ b/README.Coding @@ -312,6 +312,17 @@ lib/replace/, new code should adhere to the following conventions: * Boolean values are "true" and "false" (not True or False) * Exact width integers are of type [u]int[8|16|32|64]_t +Most of the time a good name for a boolean variable is 'ok'. Here is an +example we often use: + + bool ok; + + ok = foo(); + if (!ok) { + /* do something */ + } + +It makes the code more readable and is easy to debug. Typedefs @@ -363,6 +374,7 @@ it's also easier to use the "step" command within gdb. Good Example: char *name = NULL; + int ret; name = get_some_name(); if (name == NULL) { -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 19fdc7f script/release.sh: generate announce.${tagname}.patch.txt in announcement_samba_rc() via d87077a script/release.sh: improve error messages if the tag verification fails from 6968ee4 script/autobuild.py: use --extra-python=/usr/bin/python3 by default https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 19fdc7fd5785498044223874460f0ef13e88f576 Author: Karolin SeegerDate: Wed Jan 27 12:33:21 2016 +0100 script/release.sh: generate announce.${tagname}.patch.txt in announcement_samba_rc() This was only done in announcement_samba_stable() before. Pair-Programmed-With: Stefan Metzmacher Signed-off-by: Karolin Seeger Signed-off-by: Stefan Metzmacher Autobuild-User(master): Karolin Seeger Autobuild-Date(master): Mon Feb 15 17:41:49 CET 2016 on sn-devel-144 commit d87077afb41e3602443bbd79b1466f35e087e457 Author: Karolin Seeger Date: Wed Jan 27 12:29:44 2016 +0100 script/release.sh: improve error messages if the tag verification fails This makes it more obvious if a gpg key is expired. Pair-Programmed-With: Stefan Metzmacher Signed-off-by: Karolin Seeger Signed-off-by: Stefan Metzmacher --- Summary of changes: script/release.sh | 44 ++-- 1 file changed, 42 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/script/release.sh b/script/release.sh index e5d93a7..7db4e53 100755 --- a/script/release.sh +++ b/script/release.sh @@ -216,6 +216,8 @@ verify_samba_stable() { git tag -v "${oldtagname}" >${verify_out} 2>&1 || { echo "failed to verify old tag[${oldtagname}]" + echo "" + cat "${verify_out}" return 1 } @@ -411,7 +413,9 @@ check_nopatch() { echo "Verifying tagname: ${tagname}" git tag -v "${tagname}" >${verify_out} 2>&1 || { - echo "failed to verify old tag[${oldtagname}]" + echo "failed to verify tag[${tagname}]" + echo "" + cat "${verify_out}" return 1 } grep -q "${GPG_KEYID}" "${verify_out}" || { @@ -460,7 +464,9 @@ check_samba_stable() { echo "Verifying tagname: ${tagname}" git tag -v "${tagname}" >${verify_out} 2>&1 || { - echo "failed to verify old tag[${oldtagname}]" + echo "failed to verify tag[${tagname}]" + echo "" + cat "${verify_out}" return 1 } grep -q "${GPG_KEYID}" "${verify_out}" || { @@ -704,6 +710,40 @@ announcement_samba_rc() { echo "" } > announce.${tagname}.body.html + local webrepo="${TMPDIR}/webrepo" + + mkdir "${webrepo}" || { + return 1 + } + git -C "${webrepo}" init || { + return 1 + } + + mkdir -p "$(dirname ${webrepo}/${headlinefile})" || { + return 1 + } + cp -a "announce.${tagname}.headline.html" "${webrepo}/${headlinefile}" || { + return 1 + } + + mkdir -p "$(dirname ${webrepo}/${bodyfile})" || { + return 1 + } + cp -a "announce.${tagname}.body.html" "${webrepo}/${bodyfile}" || { + return 1 + } + + git -C "${webrepo}" add "${headlinefile}" "${bodyfile}" || { + return 1 + } + git -C "${webrepo}" commit --signoff --message "NEWS[${version}]: Samba ${version} Available for Download" || { + return 1 + } + CLEANUP_FILES="${CLEANUP_FILES} announce.${tagname}.patch.txt" + git -C "${webrepo}" format-patch --stdout -1 HEAD > announce.${tagname}.patch.txt || { + return 1 + } + CLEANUP_FILES="${CLEANUP_FILES} announce.${tagname}.todo.txt" { ls -lart announce.${tagname}.* -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v4-3-test updated
The branch, v4-3-test has been updated via 6c1a5f0 param: Fix str_list_v3 to accept ; again via 11b89bd loadparm: Fix memory leak issue. via 4526ba6 s3: smbd: posix_acls: Fix check for setting u:g:o entry on a filesystem with no ACL support. via ebb7d66 s3:smbd:open: Skip redundant call to file_set_dosmode when creating a new file. from f1d0341 docs-xml: fix typo in smbspool_krb5_wrapper manpage. https://git.samba.org/?p=samba.git;a=shortlog;h=v4-3-test - Log - commit 6c1a5f0c230dbb98b60230d169512def09966678 Author: Volker LendeckeDate: Thu Feb 11 13:11:46 2016 +0100 param: Fix str_list_v3 to accept ; again Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Thu Feb 11 19:19:55 CET 2016 on sn-devel-144 https://bugzilla.samba.org/show_bug.cgi?id=11732 Autobuild-User(v4-3-test): Karolin Seeger Autobuild-Date(v4-3-test): Mon Feb 15 14:36:43 CET 2016 on sn-devel-104 commit 11b89bdc2570b670149f7f3bd8d98224b181b75c Author: Hemanth Thummala Date: Tue Feb 2 10:33:20 2016 -0800 loadparm: Fix memory leak issue. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11708 Signed-off-by: Hemanth Thummala Reviewed-by: Alexander Bokovoy Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Thu Feb 4 12:39:14 CET 2016 on sn-devel-144 (cherry picked from commit 8247d93701ed838190fe74044a63a56d63d37bf5) commit 4526ba628ed7ee2bbd6751fb0155efff0b970dba Author: Jeremy Allison Date: Tue Feb 9 12:47:43 2016 -0800 s3: smbd: posix_acls: Fix check for setting u:g:o entry on a filesystem with no ACL support. Since 4.0.x we add 2 additional ACE entries, one SMB_ACL_USER and SMB_ACL_GROUP to match the existing SMB_ACL_USER_OBJ and SMB_ACL_GROUP_OBJ entries. The two additional entries break the simple "must have 3 entries" check done inside convert_canon_ace_to_posix_perms(). Replace this with a more complete test. Problem and initial fix provided by BUG: https://bugzilla.samba.org/show_bug.cgi?id=10489 Signed-off-by: Jeremy Allison Reviewed-by: Uri Simchoni Autobuild-User(master): Uri Simchoni Autobuild-Date(master): Thu Feb 11 11:14:53 CET 2016 on sn-devel-144 (cherry picked from commit 5172bf0c5b0672c1479c2ad776460956aa469bca) commit ebb7d6602bd4c8f86e8d47e0581160f6d900ede9 Author: Jose A. Rivera Date: Wed Feb 3 20:58:19 2016 -0600 s3:smbd:open: Skip redundant call to file_set_dosmode when creating a new file. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11727 Signed-off-by: Jose A. Rivera Pair-programmed-with: Ira Cooper Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Fri Feb 5 04:37:43 CET 2016 on sn-devel-144 (cherry picked from commit aec07b8b60ff9589a3c84eef6adeca464e6c01f6) --- Summary of changes: lib/util/util_strlist.c | 18 +- source3/param/loadparm.c | 2 +- source3/smbd/open.c | 4 ++-- source3/smbd/posix_acls.c | 39 ++- 4 files changed, 58 insertions(+), 5 deletions(-) Changeset truncated at 500 lines: diff --git a/lib/util/util_strlist.c b/lib/util/util_strlist.c index 987fdfb..2c1c2d5 100644 --- a/lib/util/util_strlist.c +++ b/lib/util/util_strlist.c @@ -552,7 +552,23 @@ char **str_list_make_v3(TALLOC_CTX *mem_ctx, const char *string, TALLOC_FREE(list); return NULL; } - if (!sep) sep = LIST_SEP; + + /* +* DON'T REPLACE THIS BY "LIST_SEP". The common version of +* LIST_SEP does not contain the ;, which used to be accepted +* by Samba 4.0 before param merges. It would be the far +* better solution to split the _v3 version again to source3/ +* where it belongs, see the _v3 in its name. +* +* Unfortunately it is referenced in /lib/param/loadparm.c, +* which depends on the version that the AD-DC mandates, +* namely without the ; as part of the list separator. I am +* missing the waf fu to properly work around the wrong +* include paths here for this defect. +*/ + if (sep == NULL) { + sep = " \t,;\n\r"; + } num = 0;
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 6968ee4 script/autobuild.py: use --extra-python=/usr/bin/python3 by default via e86a845 .travis.yml: install python3-{crypto,dev,dnspython} via 312bf41 .travis.yml: install python-crypto via 4132d36 .travis.yml: we don't require python-all-dev via b040cba .travis.yml: we require 'realpath' now via 212468e .travis.yml: do a sort -u on the installed packages via 8adf470 ldb:ABI: add missing pyldb-util.py3-1.1.25.sigs from 8b765ac smbd: fix build with FAM support https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 6968ee4b3a1cf5ef7fef2d94b9278d902c443c7a Author: Stefan MetzmacherDate: Mon Feb 1 12:55:34 2016 +0100 script/autobuild.py: use --extra-python=/usr/bin/python3 by default export AUTOBUILD_NO_EXTRA_PYTHON=1 can overwrite this if required. Signed-off-by: Stefan Metzmacher Reviewed-by: Michael Adam Autobuild-User(master): Stefan Metzmacher Autobuild-Date(master): Mon Feb 15 14:28:27 CET 2016 on sn-devel-144 commit e86a8451ed5be9ac55e95ddadee4825f16ce8945 Author: Stefan Metzmacher Date: Tue Feb 2 11:49:52 2016 +0100 .travis.yml: install python3-{crypto,dev,dnspython} autobuild will use --extra-python=/usr/bin/python3 in future. Signed-off-by: Stefan Metzmacher Reviewed-by: Michael Adam commit 312bf416ad6a6db4f4342556bd6190d56c455660 Author: Stefan Metzmacher Date: Tue Feb 2 11:46:56 2016 +0100 .travis.yml: install python-crypto Signed-off-by: Stefan Metzmacher Reviewed-by: Michael Adam commit 4132d3648f8dc0ed2d4413cb4904330b26886706 Author: Stefan Metzmacher Date: Tue Feb 2 11:46:00 2016 +0100 .travis.yml: we don't require python-all-dev python-dev is enough. Signed-off-by: Stefan Metzmacher Reviewed-by: Michael Adam commit b040cbaf5bc853e2e3edc7917cd9ec72a664ce71 Author: Stefan Metzmacher Date: Tue Feb 2 13:06:06 2016 +0100 .travis.yml: we require 'realpath' now Signed-off-by: Stefan Metzmacher Reviewed-by: Michael Adam commit 212468e96714548ec9d4186033396713632e51cf Author: Stefan Metzmacher Date: Tue Feb 2 11:42:52 2016 +0100 .travis.yml: do a sort -u on the installed packages Signed-off-by: Stefan Metzmacher Reviewed-by: Michael Adam commit 8adf470af231718d334e282594079a67e4da9f05 Author: Stefan Metzmacher Date: Thu Jan 14 03:14:26 2016 +0100 ldb:ABI: add missing pyldb-util.py3-1.1.25.sigs Signed-off-by: Stefan Metzmacher Reviewed-by: Michael Adam --- Summary of changes: .travis.yml| 2 +- ...ldb-util-1.1.10.sigs => pyldb-util.py3-1.1.25.sigs} | 0 script/autobuild.py| 18 -- 3 files changed, 13 insertions(+), 7 deletions(-) copy lib/ldb/ABI/{pyldb-util-1.1.10.sigs => pyldb-util.py3-1.1.25.sigs} (100%) Changeset truncated at 500 lines: diff --git a/.travis.yml b/.travis.yml index 9d12665..b930cfe 100644 --- a/.travis.yml +++ b/.travis.yml @@ -24,7 +24,7 @@ matrix: before_install: - sudo apt-get update -qq - - sudo apt-get install --assume-yes screen git build-essential libacl1-dev libattr1-dev libblkid-dev libgnutls-dev libreadline-dev python-dev libpam0g-dev python-dnspython gdb pkg-config libpopt-dev libldap2-dev dnsutils libbsd-dev attr krb5-user docbook-xsl libcups2-dev acl bison debhelper docbook-xml docbook-xsl flex libaio-dev libbsd-dev libcap-dev libcups2-dev libncurses5-dev libpam0g-dev libpopt-dev libreadline-dev perl perl-modules libparse-yapp-perl pkg-config python-all-dev python-dnspython xsltproc zlib1g-dev autoconf + - sudo apt-get install --assume-yes acl attr autoconf bison build-essential debhelper dnsutils docbook-xml docbook-xsl flex gdb git krb5-user libacl1-dev libaio-dev libattr1-dev libblkid-dev libbsd-dev libcap-dev libcups2-dev libgnutls-dev libldap2-dev libncurses5-dev libpam0g-dev libparse-yapp-perl libpopt-dev libreadline-dev perl perl-modules pkg-config python-crypto python-dev python-dnspython python3-crypto python3-dev python3-dnspython realpath screen xsltproc zlib1g-dev script: - git fetch --unshallow diff --git a/lib/ldb/ABI/pyldb-util-1.1.10.sigs b/lib/ldb/ABI/pyldb-util.py3-1.1.25.sigs similarity index 100% copy from lib/ldb/ABI/pyldb-util-1.1.10.sigs copy to lib/ldb/ABI/pyldb-util.py3-1.1.25.sigs diff --git
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-15-1300/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-15-1300/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-15-1300/samba.stdout The top commit at the time of the failure was: commit 8b765ac01198cebc1806bce95637c667bfd9aa12 Author: Ralph BoehmeDate: Fri Feb 12 17:25:09 2016 +0100 smbd: fix build with FAM support Add missing define of HAVE_FAM when FAM is detected. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11733 Signed-off-by: Ralph Boehme Reviewed-by: Volker Lendecke Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Sun Feb 14 13:50:56 CET 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-02-15-1049/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-02-15-1049/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-02-15-1049/samba.stdout The top commit at the time of the failure was: commit 8b765ac01198cebc1806bce95637c667bfd9aa12 Author: Ralph BoehmeDate: Fri Feb 12 17:25:09 2016 +0100 smbd: fix build with FAM support Add missing define of HAVE_FAM when FAM is detected. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11733 Signed-off-by: Ralph Boehme Reviewed-by: Volker Lendecke Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Sun Feb 14 13:50:56 CET 2016 on sn-devel-144