autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-21-0803/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-21-0803/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-21-0803/samba.stdout The top commit at the time of the failure was: commit e0aae9f0d374cda639371aa3e395e848682e5737 Author: Martin Schwenke Date: Thu Jul 14 12:01:14 2016 +1000 ctdb-tests: Add shellcheck test suite CTDB has a lot of scripts and shellcheck can be useful to find dubious scripting practices. Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs Autobuild-User(master): Amitay Isaacs Autobuild-Date(master): Thu Jul 21 06:06:49 CEST 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via e0aae9f ctdb-tests: Add shellcheck test suite via b51f604 ctdb-tests: Add new test support script for script install paths via 355c49f ctdb-scripts: Avoid shellcheck warning SC2006 (legacy `..`) via dfa2c1d ctdb-scripts: Avoid shellcheck warning SC2124 (string=array) via f19f44e ctdb-scripts: Avoid shellcheck warning SC2155 (declare, assign) via aa51875 ctdb-scripts: Avoid shellcheck warning SC2059 ($ in printf format) via 8bd2c55 ctdb-scripts: Avoid chellcheck warning SC2012 (ls for file list) via 52b43d7 ctdb-scripts: Avoid shellcheck warning SC2012 (ls for file list) via 5e9aa57 ctdb-scripts: Avoid shellcheck warning SC2038 (find without -print0) via d138cb8 ctdb-scripts: Avoid shellcheck warning SC2039 (non-portable ulimit options) via e96c122 ctdb-scripts: Avoid shellcheck warning SC2039 (test -nt operator) via 524eac9 ctdb-scripts: Avoid shellcheck warning SC2094 (read/write same file) via d7f3b19 ctdb-scripts: Avoid shellcheck warning SC2039 (echo -n) via f43df8f ctdb-scripts: Avoid shellcheck warning SC2039 (type command) via b0c1dbf ctdb-scripts: Avoid shellcheck warning SC2015 (A && B || C) via 987fd07 ctdb-scripts: Avoid shellcheck warnings SC2119, SC2120 (function arguments) via 77341f6 ctdb-scripts: Avoid shellcheck warning SC2002 (useless cat) via fc858a1 ctdb-scripts: Avoid shellcheck warning SC2017 (arithmetic precision) via 0ca0026 ctdb-scripts: Avoid shellcheck warning SC1004 (backslash in quotes) via b208ae7 ctdb-scripts: Avoid shellcheck warning SC2154 (unassigned variables) via 9255d64 ctdb-scripts: Avoid shellcheck warnings SC2046, SC2086 (double-quoting) via f6c25a4 ctdb-scripts: Avoid shellcheck warning SC2034 (unused variables) via 13b3c6a ctdb-scripts: Avoid shellcheck warning SC2004 ($ in arithmetic) via efc9af2 ctdb-scripts: Avoid shellcheck warnings SC2030, SC2031 (subshell variables) via 0ea90f6 ctdb-scripts: Avoid shellcheck warning SC2016 ($ in single quotes) via 113529f ctdb-scripts: Drop function ctdb_check_counter() via 770fe1f ctdb-scripts: Drop use of ctdb_check_counter from vsftpd event script via 0825eff ctdb-scripts: Drop use of ctdb_check_counter from reclock event script via 92d0d44 ctdb-scripts: Drop use of ctdb_check_counter from httpd event script via fc53256 ctdb-scripts: Drop use of service_tcp_ports via 09a7a78 ctdb-scripts: Event script indentation and whitespace cleanups via d52409d ctdb-scripts: Drop use of ctdb_standard_event_handler() via 5cf45ed ctdb-tests: New event script test for corrupt TDB checking via 0d60ecf ctdb-tests: Add new httpd event script test via ca28a47 ctdb-tests: Add new vsftpd event script test via c7a730c ctdb-tests: Add reclock event script tests via 91eb421 ctdb-scripts: Fix a bug in counter checking from 5437fdc s4:torture/ndr: add more krb5pac tests with PAC blobs from pkinit https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit e0aae9f0d374cda639371aa3e395e848682e5737 Author: Martin Schwenke Date: Thu Jul 14 12:01:14 2016 +1000 ctdb-tests: Add shellcheck test suite CTDB has a lot of scripts and shellcheck can be useful to find dubious scripting practices. Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs Autobuild-User(master): Amitay Isaacs Autobuild-Date(master): Thu Jul 21 06:06:49 CEST 2016 on sn-devel-144 commit b51f604f753abc094bf0151165173c5a27b5711f Author: Martin Schwenke Date: Thu Jul 14 11:58:51 2016 +1000 ctdb-tests: Add new test support script for script install paths This helps unit tests locate CTDB's scripts. It is being created to support some new shellcheck unit tests. Hopefully, it can also be used to simplify some of the symlink complexity in some other unit tests suites, such as eventscripts. Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs commit 355c49fc7469d7a82e507c87250a60d490d112ac Author: Martin Schwenke Date: Thu Jul 14 12:58:31 2016 +1000 ctdb-scripts: Avoid shellcheck warning SC2006 (legacy `..`) SC2006: Use $(..) instead of legacy `..`. Make the obvious changes to $(...) but convert some to $((...)). Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs commit dfa2c1d5d205d1281060732547996954fd1b1f02 Author: Martin Schwenke Date: Thu Jul 14 12:28:17 2016 +1000 ctdb-scripts: Avoid shellcheck warning SC2124 (string=array) SC2124: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. Signed-off-by: Martin Schwenke Reviewed
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-21-0404/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-21-0404/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-21-0404/samba.stdout The top commit at the time of the failure was: commit 5437fdcffb116d0af279b7a0f45893cc883a8e69 Author: Stefan Metzmacher Date: Tue Jul 19 16:32:06 2016 +0200 s4:torture/ndr: add more krb5pac tests with PAC blobs from pkinit We validate everything except the whole LOGON_INFO structure, we even decrypt the PAC_CREDENTIALS_INFO blob and verify PAC_CREDENTIAL_DATA_NDR and PAC_CREDENTIAL_NTLM_SECPKG. Signed-off-by: Stefan Metzmacher Reviewed-by: Günther Deschner Autobuild-User(master): Stefan Metzmacher Autobuild-Date(master): Thu Jul 21 01:07:28 CEST 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-21-0328/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-21-0328/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-21-0328/samba.stdout The top commit at the time of the failure was: commit a464a897f346a3296e30a5920509922efb4949c1 Author: Garming Sam Date: Fri Jul 15 14:29:02 2016 +1200 samba-tool: Speed up all samba-tool commands This in particular helps the docs.py test halve in time (at least on my machine) NOTE: The removal of enable_null_tracking is required because we are no longer importing join.py in every single samba-tool invocation. Without removing this line, memory would be hanging from both the actual NULL context and the talloc_null_context (causing a segfault at system_exit). Signed-off-by: Garming Sam Reviewed-by: Douglas Bagnall Autobuild-User(master): Garming Sam Autobuild-Date(master): Wed Jul 20 12:47:24 CEST 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 5437fdc s4:torture/ndr: add more krb5pac tests with PAC blobs from pkinit via 4e4cc8e s4:torture/ndr: make use of torture_suite_add_ndr_pull_validate_test() in krb5pac when possible via bb64c55 krb5_wrap: provide CKSUMTYPE_HMAC_SHA1_96_AES_* via 0e201ec krb5pac/netlogon: add a comment regarding PAC_LOGON_INFO unique pointers on push via a6f672d torture: Add another sample of a PAC that broke the old PAC_UPN_DNS_INFO handling via 930dc1a s4-torture: add another krb5pac buffer to the ndr test. via 7741e02 s4-torture: add ndr krb5pac testsuite. via 3852770 krb5pac.idl: implement PAC_UPN_DNS_INFO correct via 8e45836 krb5pac: fix push/pull of subcontexts in PAC_BUFFER via 4f5dde6 krb5pac: no need for a noprint PAC_BUFFER. via 7eab12f s4:torture/ndr: Add supplementalCredentials blob from Win2012R2 via 9e82286 s4:torture/ndr: Add supplementalCredentials blobs from alpha13 and release_4_1_0rc3 via c30dcae s4:torture/ndr: add validation checks for strange supplementalCredentials blobs via 5690bc9 s4-torture: rename torture_suite_add_ndr_pullpush_test to torture_suite_add_ndr_pull_validate_test. via cde8ed2 torture: show the first differing byte and a dump in torture_assert_data_blob_equal(). via 26d2ea3 drsblobs.idl: supplementalCredentialsSubBlob make it possible to parse strange blobs via e9c9615 drsblobs.idl: mark supplementalCredentialsSubBlob as nopull,nopush via f9a4d0d s4:dsdb/password_hash: explicitly set SUPPLEMENTAL_CREDENTIALS_SIGNATURE via 5c1ce0e s3:libnet_dssync_keytab: ignore empty supplementalCredentialsBlob structures via 1be64cb s4:kdc: ignore empty supplementalCredentialsBlob structures via d3c8902 ctdb-tools: Avoid uninitialised memory access via fac60e5 ctdb-client: Fix access after free error via 5f57bcc ctdb-client: Fix incorrect variable reference via 7fdb5d2c WHATSNEW: Add features added for Samba 4.5 from a464a89 samba-tool: Speed up all samba-tool commands https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 5437fdcffb116d0af279b7a0f45893cc883a8e69 Author: Stefan Metzmacher Date: Tue Jul 19 16:32:06 2016 +0200 s4:torture/ndr: add more krb5pac tests with PAC blobs from pkinit We validate everything except the whole LOGON_INFO structure, we even decrypt the PAC_CREDENTIALS_INFO blob and verify PAC_CREDENTIAL_DATA_NDR and PAC_CREDENTIAL_NTLM_SECPKG. Signed-off-by: Stefan Metzmacher Reviewed-by: Günther Deschner Autobuild-User(master): Stefan Metzmacher Autobuild-Date(master): Thu Jul 21 01:07:28 CEST 2016 on sn-devel-144 commit 4e4cc8e91dd67308d6437f98d59059ac557aad4e Author: Stefan Metzmacher Date: Tue Jul 19 16:38:56 2016 +0200 s4:torture/ndr: make use of torture_suite_add_ndr_pull_validate_test() in krb5pac when possible Signed-off-by: Stefan Metzmacher Reviewed-by: Günther Deschner commit bb64c550ae19b08ad4e6d8d26f68c2474cb251e6 Author: Stefan Metzmacher Date: Tue Jul 19 16:31:01 2016 +0200 krb5_wrap: provide CKSUMTYPE_HMAC_SHA1_96_AES_* MIT only defined this as CKSUMTYPE_HMAC_SHA1_96_AES128, while Heimdal has CKSUMTYPE_HMAC_SHA1_96_AES_128. Signed-off-by: Stefan Metzmacher Reviewed-by: Günther Deschner commit 0e201ecdc53b07d66342e453b3710d3d06481b8b Author: Stefan Metzmacher Date: Thu Jul 14 09:34:43 2016 +0200 krb5pac/netlogon: add a comment regarding PAC_LOGON_INFO unique pointers on push This difference is the reason why we can't fully (ndr)validate some PAC blobs. Signed-off-by: Stefan Metzmacher Reviewed-by: Günther Deschner commit a6f672d69f9bb3933181f45bbd51f4014224bdca Author: Andrew Bartlett Date: Tue Jul 19 16:48:18 2016 +1200 torture: Add another sample of a PAC that broke the old PAC_UPN_DNS_INFO handling This is included because this sample helped us addres issues in the previous attempt at handling PAC_UPN_DNS_INFO correctly, and I have Tris's permission to include this in our tests. Signed-off-by: Andrew Bartlett Reviewed-by: Stefan Metzmacher commit 930dc1a12ab2108a3d217aebabd93b31ea85524c Author: Günther Deschner Date: Wed Feb 6 13:10:44 2013 +0100 s4-torture: add another krb5pac buffer to the ndr test. This one nicely demonstrates that the strings are really non-null terminated. Guenther Signed-off-by: Günther Deschner Reviewed-by: Stefan Metzmacher commit 7741e0286781a28c61a135afb143d943c56b6a8a Author: Günther Deschner Date: Thu Dec 13 12:28:19 2012 +0100 s4-torture: add ndr krb5pac testsuite. Someone changed the PAC buffer union without adding proper tests, now we sometimes fail
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-21-0003/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-21-0003/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-21-0003/samba.stdout The top commit at the time of the failure was: commit a464a897f346a3296e30a5920509922efb4949c1 Author: Garming Sam Date: Fri Jul 15 14:29:02 2016 +1200 samba-tool: Speed up all samba-tool commands This in particular helps the docs.py test halve in time (at least on my machine) NOTE: The removal of enable_null_tracking is required because we are no longer importing join.py in every single samba-tool invocation. Without removing this line, memory would be hanging from both the actual NULL context and the talloc_null_context (causing a segfault at system_exit). Signed-off-by: Garming Sam Reviewed-by: Douglas Bagnall Autobuild-User(master): Garming Sam Autobuild-Date(master): Wed Jul 20 12:47:24 CEST 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-20-2003/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-20-2003/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-20-2003/samba.stdout The top commit at the time of the failure was: commit a464a897f346a3296e30a5920509922efb4949c1 Author: Garming Sam Date: Fri Jul 15 14:29:02 2016 +1200 samba-tool: Speed up all samba-tool commands This in particular helps the docs.py test halve in time (at least on my machine) NOTE: The removal of enable_null_tracking is required because we are no longer importing join.py in every single samba-tool invocation. Without removing this line, memory would be hanging from both the actual NULL context and the talloc_null_context (causing a segfault at system_exit). Signed-off-by: Garming Sam Reviewed-by: Douglas Bagnall Autobuild-User(master): Garming Sam Autobuild-Date(master): Wed Jul 20 12:47:24 CEST 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-20-1922/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-20-1922/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-20-1922/samba.stdout The top commit at the time of the failure was: commit a464a897f346a3296e30a5920509922efb4949c1 Author: Garming Sam Date: Fri Jul 15 14:29:02 2016 +1200 samba-tool: Speed up all samba-tool commands This in particular helps the docs.py test halve in time (at least on my machine) NOTE: The removal of enable_null_tracking is required because we are no longer importing join.py in every single samba-tool invocation. Without removing this line, memory would be hanging from both the actual NULL context and the talloc_null_context (causing a segfault at system_exit). Signed-off-by: Garming Sam Reviewed-by: Douglas Bagnall Autobuild-User(master): Garming Sam Autobuild-Date(master): Wed Jul 20 12:47:24 CEST 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-20-1603/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-20-1603/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-20-1603/samba.stdout The top commit at the time of the failure was: commit a464a897f346a3296e30a5920509922efb4949c1 Author: Garming Sam Date: Fri Jul 15 14:29:02 2016 +1200 samba-tool: Speed up all samba-tool commands This in particular helps the docs.py test halve in time (at least on my machine) NOTE: The removal of enable_null_tracking is required because we are no longer importing join.py in every single samba-tool invocation. Without removing this line, memory would be hanging from both the actual NULL context and the talloc_null_context (causing a segfault at system_exit). Signed-off-by: Garming Sam Reviewed-by: Douglas Bagnall Autobuild-User(master): Garming Sam Autobuild-Date(master): Wed Jul 20 12:47:24 CEST 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via a464a89 samba-tool: Speed up all samba-tool commands from 698f651 notifyd: Move BlockSignals calls to server.c https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit a464a897f346a3296e30a5920509922efb4949c1 Author: Garming Sam Date: Fri Jul 15 14:29:02 2016 +1200 samba-tool: Speed up all samba-tool commands This in particular helps the docs.py test halve in time (at least on my machine) NOTE: The removal of enable_null_tracking is required because we are no longer importing join.py in every single samba-tool invocation. Without removing this line, memory would be hanging from both the actual NULL context and the talloc_null_context (causing a segfault at system_exit). Signed-off-by: Garming Sam Reviewed-by: Douglas Bagnall Autobuild-User(master): Garming Sam Autobuild-Date(master): Wed Jul 20 12:47:24 CEST 2016 on sn-devel-144 --- Summary of changes: python/samba/netcmd/main.py | 78 - 1 file changed, 41 insertions(+), 37 deletions(-) Changeset truncated at 500 lines: diff --git a/python/samba/netcmd/main.py b/python/samba/netcmd/main.py index 498702c..ba90748 100644 --- a/python/samba/netcmd/main.py +++ b/python/samba/netcmd/main.py @@ -20,25 +20,28 @@ from samba import getopt as options from samba.netcmd import SuperCommand -from samba.netcmd.dbcheck import cmd_dbcheck -from samba.netcmd.delegation import cmd_delegation -from samba.netcmd.dns import cmd_dns -from samba.netcmd.domain import cmd_domain -from samba.netcmd.drs import cmd_drs -from samba.netcmd.dsacl import cmd_dsacl -from samba.netcmd.fsmo import cmd_fsmo -from samba.netcmd.gpo import cmd_gpo -from samba.netcmd.group import cmd_group -from samba.netcmd.ldapcmp import cmd_ldapcmp -from samba.netcmd.ntacl import cmd_ntacl -from samba.netcmd.rodc import cmd_rodc -from samba.netcmd.sites import cmd_sites -from samba.netcmd.spn import cmd_spn -from samba.netcmd.testparm import cmd_testparm -from samba.netcmd.nettime import cmd_time -from samba.netcmd.user import cmd_user -from samba.netcmd.processes import cmd_processes +class cache_loader(dict): +""" +We only load subcommand tools if they are actually used. +This significantly reduces the amount of time spent starting up +samba-tool +""" +def __getitem__(self, attr): +item = dict.__getitem__(self, attr) +if item is None: +package = 'nettime' if attr == 'time' else attr +self[attr] = getattr(__import__('samba.netcmd.%s' % package, +fromlist=['cmd_%s' % attr]), + 'cmd_%s' % attr)() +return dict.__getitem__(self, attr) + +def iteritems(self): +for key in self: +yield (key, self[key]) + +def items(self): +return list(self.iteritems()) class cmd_sambatool(SuperCommand): """Main samba administration tool.""" @@ -47,22 +50,23 @@ class cmd_sambatool(SuperCommand): "versionopts": options.VersionOptions, } -subcommands = {} -subcommands["dbcheck"] = cmd_dbcheck() -subcommands["delegation"] = cmd_delegation() -subcommands["dns"] = cmd_dns() -subcommands["domain"] = cmd_domain() -subcommands["drs"] = cmd_drs() -subcommands["dsacl"] = cmd_dsacl() -subcommands["fsmo"] = cmd_fsmo() -subcommands["gpo"] = cmd_gpo() -subcommands["group"] = cmd_group() -subcommands["ldapcmp"] = cmd_ldapcmp() -subcommands["ntacl"] = cmd_ntacl() -subcommands["rodc"] = cmd_rodc() -subcommands["sites"] = cmd_sites() -subcommands["spn"] = cmd_spn() -subcommands["testparm"] = cmd_testparm() -subcommands["time"] = cmd_time() -subcommands["user"] = cmd_user() -subcommands["processes"] = cmd_processes() +subcommands = cache_loader() + +subcommands["dbcheck"] = None +subcommands["delegation"] = None +subcommands["dns"] = None +subcommands["domain"] = None +subcommands["drs"] = None +subcommands["dsacl"] = None +subcommands["fsmo"] = None +subcommands["gpo"] = None +subcommands["group"] = None +subcommands["ldapcmp"] = None +subcommands["ntacl"] = None +subcommands["rodc"] = None +subcommands["sites"] = None +subcommands["spn"] = None +subcommands["testparm"] = None +subcommands["time"] = None +subcommands["user"] = None +subcommands["processes"] = None -- Samba Shared Repository
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-20-1204/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-20-1204/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-20-1204/samba.stdout The top commit at the time of the failure was: commit 698f6517866f567e999baf5b63ec7e6f5e9452a8 Author: Volker Lendecke Date: Tue Jul 19 14:36:07 2016 +0200 notifyd: Move BlockSignals calls to server.c notifyd_send() is called as part of smbd initialization both in normal daemon mode after a fork, but also in interactive mode. In interactive mode, notifyd should not modify the global signal state with BlockSignals(). This patch moves the signal blocking to the place where we know that notifyd is a child daemon. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Jul 20 09:04:00 CEST 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-20-1120/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-20-1120/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-20-1120/samba.stdout The top commit at the time of the failure was: commit 99b8acaa809b8de70ff6b16eb2511bb7d6e904e8 Author: Jeremy Allison Date: Tue Jul 19 09:24:38 2016 -0700 s3: torture: Regression test case to specify exactly how UNIX extensions should act on files with streams. If a stream is open, refuse the unlink. Ensure UNIX unlink request can remove a file containing streams. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12021 Signed-off-by: Jeremy Allison Reviewed-by: Ralph Boehme Autobuild-User(master): Ralph Böhme Autobuild-Date(master): Wed Jul 20 05:20:29 CEST 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 698f651 notifyd: Move BlockSignals calls to server.c via fa96452 smbd: Re-register notify requests via fef0c3d smbd: Restart notifyd via cf7fea2 smbd: Store notify filters in fsp->notify via 0136141 smbd: Log which notifyd was found via 5371d2b smbd: Remember notifyd's serverid via 7404fef notify_msg: Deregister handler upon talloc_free via 16a1418 smbd: Remove "listel" from notify_msg via 99b9f57 smbd: Protect notify_callback from stray pointers via 3caa8a1 smbd: Pass "sconn" via notify to notify_callback() via d446e40 smbd: There's only one notify_callback via 2779cae smbd: Make notify_callback() public via 60fe61b smbd: "path" is no longer needed in notify_list via 229c910 smbd: Add "path" to notify_remove via ed26f4b smbd: Avoid a talloc_asprintf via ea47abc smbd: Add fsp_fullbasepath via 2c7bfdc smbd: Factor out notify_init via 8e27c19 smbd: sconn->sys_notify_ctx is not used via 2bd3451 smbd: Don't stop sending to children when one send fails from 99b8aca s3: torture: Regression test case to specify exactly how UNIX extensions should act on files with streams. https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 698f6517866f567e999baf5b63ec7e6f5e9452a8 Author: Volker Lendecke Date: Tue Jul 19 14:36:07 2016 +0200 notifyd: Move BlockSignals calls to server.c notifyd_send() is called as part of smbd initialization both in normal daemon mode after a fork, but also in interactive mode. In interactive mode, notifyd should not modify the global signal state with BlockSignals(). This patch moves the signal blocking to the place where we know that notifyd is a child daemon. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Jul 20 09:04:00 CEST 2016 on sn-devel-144 commit fa96452f9cde535f3cfe31afe8c54199a940f027 Author: Volker Lendecke Date: Tue Jun 21 16:23:19 2016 +0200 smbd: Re-register notify requests When notifyd is restarted, the parent will broadcast that fact to all workers. They will then re-register their notify requests. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit fef0c3d271847313f118160e57a853f89985 Author: Volker Lendecke Date: Fri Jun 24 16:29:28 2016 +0200 smbd: Restart notifyd Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit cf7fea2312c159764402f1bcb966f97904fb2132 Author: Volker Lendecke Date: Fri Jun 24 16:27:34 2016 +0200 smbd: Store notify filters in fsp->notify When notifyd crashes, it will be restarted. We need to restore the filters with notifyd Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit 01361418abd9b33cd0719188a88952566d99ff68 Author: Volker Lendecke Date: Thu Jun 23 14:24:32 2016 +0200 smbd: Log which notifyd was found Just a debugging aid Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit 5371d2b86077a0624e3ee58d4f554d64ce5cfbe9 Author: Volker Lendecke Date: Tue Jun 21 14:13:06 2016 +0200 smbd: Remember notifyd's serverid Similarly to cleanupd, this is necessary to restart notifyd Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit 7404feffd7130ce389be3a1f65a7ae8c7cc2d156 Author: Volker Lendecke Date: Tue Jun 21 13:04:25 2016 +0200 notify_msg: Deregister handler upon talloc_free So far, we haven't TALLOC_FREE'ed the notify context. This will change. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit 16a1418f3aa08b1fd5c971481592bfddc250abf0 Author: Volker Lendecke Date: Tue Jun 14 15:03:35 2016 +0200 smbd: Remove "listel" from notify_msg We have all information that was kept in "notify_list" in other parts of smbd as well. The only possible downside of this patch is that we possibly have a lot more fsp's than fsp's with notifies, so notify_callback() might be a bit slower in this situation. If this turns out to be a problem, I'd rather put some more smarts into the notifyd protocol to enable a better indexed notify_callback(). For now, this avoids data to be kept in two places. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit 99b9f5729a32f1b60bac150abe267da4daa1e7e2 Author: Volker Lendecke Date: Tue Jun 14 15:00:29 2016 +0200 smbd: Protect notify_callback from stray pointers This protection right now lives in notify_msg.c with the notify_list, but that will go. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit 3caa8a1bf1e55d09399c4d54c69b638955ed