autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-19-0618/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-19-0618/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-19-0618/samba.stdout
  
The top commit at the time of the failure was:

commit 23b4fb681aa7c02450d0ebb06af87943163b959b
Author: Amitay Isaacs 
Date:   Fri Aug 19 01:26:38 2016 +1000

s3-libnet: Add missing format element

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12163

Signed-off-by: Amitay Isaacs 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Aug 18 23:49:42 CEST 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-19-0220/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-19-0220/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-19-0220/samba.stdout
  
The top commit at the time of the failure was:

commit 23b4fb681aa7c02450d0ebb06af87943163b959b
Author: Amitay Isaacs 
Date:   Fri Aug 19 01:26:38 2016 +1000

s3-libnet: Add missing format element

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12163

Signed-off-by: Amitay Isaacs 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Aug 18 23:49:42 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Volker Lendecke]

The branch, master has been updated
   via  23b4fb6 s3-libnet: Add missing format element
   via  a37048f s3-lib: Pass missing argument for format string
  from  a6073e6 smbd: allow reading files based on FILE_EXECUTE access right

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 23b4fb681aa7c02450d0ebb06af87943163b959b
Author: Amitay Isaacs 
Date:   Fri Aug 19 01:26:38 2016 +1000

s3-libnet: Add missing format element

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12163

Signed-off-by: Amitay Isaacs 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Aug 18 23:49:42 CEST 2016 on sn-devel-144

commit a37048f8d49eb72ea89a8708032d4d04dac59f3d
Author: Amitay Isaacs 
Date:   Sun Aug 7 18:17:19 2016 +1000

s3-lib: Pass missing argument for format string

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12163

Signed-off-by: Amitay Isaacs 
Reviewed-by: Volker Lendecke 

---

Summary of changes:
 source3/lib/util_tdb.c   | 2 +-
 source3/libnet/libnet_join.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/util_tdb.c b/source3/lib/util_tdb.c
index d7a8a47..7db7111 100644
--- a/source3/lib/util_tdb.c
+++ b/source3/lib/util_tdb.c
@@ -431,7 +431,7 @@ char *tdb_data_string(TALLOC_CTX *mem_ctx, TDB_DATA d)
return NULL;
}
 
-   len = cbuf_printf(ost, "%d:");
+   len = cbuf_printf(ost, "%zu:", d.dsize);
if (len == -1) {
goto done;
}
diff --git a/source3/libnet/libnet_join.c b/source3/libnet/libnet_join.c
index a3946a3..96a4c59 100644
--- a/source3/libnet/libnet_join.c
+++ b/source3/libnet/libnet_join.c
@@ -2448,7 +2448,7 @@ static WERROR libnet_DomainJoin(TALLOC_CTX *mem_ctx,
 );
if (!NT_STATUS_IS_OK(status)) {
libnet_join_set_error_string(mem_ctx, r,
-   "failed to find DC for domain %s",
+   "failed to find DC for domain %s - %s",
r->in.domain_name,
get_friendly_nt_error_msg(status));
return WERR_DCNOTFOUND;
@@ -2712,7 +2712,7 @@ static WERROR libnet_DomainUnjoin(TALLOC_CTX *mem_ctx,
 );
if (!NT_STATUS_IS_OK(status)) {
libnet_unjoin_set_error_string(mem_ctx, r,
-   "failed to find DC for domain %s",
+   "failed to find DC for domain %s - %s",
r->in.domain_name,
get_friendly_nt_error_msg(status));
return WERR_DCNOTFOUND;


-- 
Samba Shared Repository

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-/samba.stdout
  
The top commit at the time of the failure was:

commit a6073e6130d39dac58f1e6ea9f41ec4ab34c3e29
Author: Uri Simchoni 
Date:   Thu Aug 4 14:59:23 2016 +0300

smbd: allow reading files based on FILE_EXECUTE access right

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12149

Signed-off-by: Uri Simchoni 
Reviewed-by: David Disseldorp 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Thu Aug 18 18:58:22 CEST 2016 on sn-devel-144

autobuild[sn-devel-144]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2016-08-18-2022/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-08-18-2022/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-08-18-2022/samba.stdout
  
The top commit at the time of the failure was:

commit a6073e6130d39dac58f1e6ea9f41ec4ab34c3e29
Author: Uri Simchoni 
Date:   Thu Aug 4 14:59:23 2016 +0300

smbd: allow reading files based on FILE_EXECUTE access right

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12149

Signed-off-by: Uri Simchoni 
Reviewed-by: David Disseldorp 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Thu Aug 18 18:58:22 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[David Disseldorp]

The branch, master has been updated
   via  a6073e6 smbd: allow reading files based on FILE_EXECUTE access right
  from  626dcc9 ctdb-ipalloc: Fix cumulative takeover timeout

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit a6073e6130d39dac58f1e6ea9f41ec4ab34c3e29
Author: Uri Simchoni 
Date:   Thu Aug 4 14:59:23 2016 +0300

smbd: allow reading files based on FILE_EXECUTE access right

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12149

Signed-off-by: Uri Simchoni 
Reviewed-by: David Disseldorp 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Thu Aug 18 18:58:22 CEST 2016 on sn-devel-144

---

Summary of changes:
 selftest/knownfail   |  7 ++-
 source3/smbd/smb2_glue.c | 16 
 2 files changed, 18 insertions(+), 5 deletions(-)


Changeset truncated at 500 lines:

diff --git a/selftest/knownfail b/selftest/knownfail
index 41cad44..ffcaf06 100644
--- a/selftest/knownfail
+++ b/selftest/knownfail
@@ -286,10 +286,7 @@
 ^samba4.krb5.kdc.*as-req-aes.*fl2000dc
 # nt4_member and ad_member don't support ntlmv1
 
^samba3.blackbox.smbclient_auth.plain.*_member.*option=clientntlmv2auth=no.member.creds.*as.user
-#new read tests fail
+#nt-vfs server blocks read with execute access
 ^samba4.smb2.read.access
-^samba3.smb2.read.access
-#new copychunk tests fail
+#ntvfs server blocks copychunk with execute access on read handle
 ^samba4.smb2.ioctl.copy_chunk_bad_access
-^samba3.smb2.ioctl.copy_chunk_bad_access
-^samba3.smb2.ioctl fs_specific.copy_chunk_bad_access
diff --git a/source3/smbd/smb2_glue.c b/source3/smbd/smb2_glue.c
index b41775d..0bb34be 100644
--- a/source3/smbd/smb2_glue.c
+++ b/source3/smbd/smb2_glue.c
@@ -48,6 +48,22 @@ struct smb_request *smbd_smb2_fake_smb_request(struct 
smbd_smb2_request *req)
 FLAGS2_32_BIT_ERROR_CODES |
 FLAGS2_LONG_PATH_COMPONENTS |
 FLAGS2_IS_LONG_NAME;
+
+   /* This is not documented in revision 49 of [MS-SMB2] but should be
+* added in a later revision (and torture test smb2.read.access
+* as well as smb2.ioctl_copy_chunk_bad_access against
+* Server 2012R2 confirms this)
+*
+* If FILE_EXECUTE is granted to a handle then the SMB2 server
+* acts as if FILE_READ_DATA has also been granted. We must still
+* keep the original granted mask, because with ioctl requests,
+* access checks are made on the file handle, "below" the SMB2
+* server, and the object store below the SMB layer is not aware
+* of this arrangement (see smb2.ioctl.copy_chunk_bad_access
+* torture test).
+*/
+   smbreq->flags2 |= FLAGS2_READ_PERMIT_EXECUTE;
+
if (IVAL(inhdr, SMB2_HDR_FLAGS) & SMB2_HDR_FLAG_DFS) {
smbreq->flags2 |= FLAGS2_DFS_PATHNAMES;
}


-- 
Samba Shared Repository

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-1818/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-1818/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-1818/samba.stdout
  
The top commit at the time of the failure was:

commit 626dcc9e493e2ac4fd502f75c7cb4d29f686f017
Author: Martin Schwenke 
Date:   Thu Aug 18 12:57:33 2016 +1000

ctdb-ipalloc: Fix cumulative takeover timeout

Commit c40fc62642ff5ac49b75e9af49c299e33dbc9073 runs the IP allocation
algorithm after calculating the timeout offset.  If the algorithm
takes a long time then there may be no attempt to release or take over
IPs.

Instead, reset the timeout just before the RELEASE_IP stage if an
early jump to IPREALLOCATED was not taken.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12161

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Thu Aug 18 12:36:37 CEST 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-1420/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-1420/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-1420/samba.stdout
  
The top commit at the time of the failure was:

commit b21308252eb409bad6089cc0f09fada0229d33e8
Author: Jeremy Allison 
Date:   Wed Aug 17 10:57:10 2016 -0700

s3: vfs: snapper: Fix snapper_gmt_strip_snapshot() function to strip @GMT 
token identically to shadow_copy2.c:shadow_copy2_strip_snapshot()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12150

Signed-off-by: Jeremy Allison 
Reviewed-by: Christof Schmitt 
Reviewed-by: David Disseldorp 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Thu Aug 18 06:43:02 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Amitay Isaacs]

The branch, master has been updated
   via  626dcc9 ctdb-ipalloc: Fix cumulative takeover timeout
  from  b213082 s3: vfs: snapper: Fix snapper_gmt_strip_snapshot() function 
to strip @GMT token identically to shadow_copy2.c:shadow_copy2_strip_snapshot()

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 626dcc9e493e2ac4fd502f75c7cb4d29f686f017
Author: Martin Schwenke 
Date:   Thu Aug 18 12:57:33 2016 +1000

ctdb-ipalloc: Fix cumulative takeover timeout

Commit c40fc62642ff5ac49b75e9af49c299e33dbc9073 runs the IP allocation
algorithm after calculating the timeout offset.  If the algorithm
takes a long time then there may be no attempt to release or take over
IPs.

Instead, reset the timeout just before the RELEASE_IP stage if an
early jump to IPREALLOCATED was not taken.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12161

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Thu Aug 18 12:36:37 CEST 2016 on sn-devel-144

---

Summary of changes:
 ctdb/server/ctdb_takeover.c | 27 +--
 1 file changed, 17 insertions(+), 10 deletions(-)


Changeset truncated at 500 lines:

diff --git a/ctdb/server/ctdb_takeover.c b/ctdb/server/ctdb_takeover.c
index a02076d..ee4dbe1 100644
--- a/ctdb/server/ctdb_takeover.c
+++ b/ctdb/server/ctdb_takeover.c
@@ -1539,16 +1539,9 @@ int ctdb_takeover_run(struct ctdb_context *ctdb, struct 
ctdb_node_map_old *nodem
return -1;
}
 
-   /* Each of the later stages (RELEASE_IP, TAKEOVER_IP,
-* IPREALLOCATED) notionally has a timeout of TakeoverTimeout
-* seconds.  However, RELEASE_IP can take longer due to TCP
-* connection killing, so sometimes needs more time.
-* Therefore, use a cumulative timeout of TakeoverTimeout * 3
-* seconds across all 3 stages.  No explicit expiry checks are
-* needed before each stage because tevent is smart enough to
-* fire the timeouts even if they are in the past.  Initialise
-* this here to cope with early jumps to IPREALLOCATED. */
-   timeout = timeval_current_ofs(3 * ctdb->tunable.takeover_timeout,0);
+   /* Default timeout for early jump to IPREALLOCATED.  See below
+* for explanation of 3 times... */
+   timeout = timeval_current_ofs(3 * ctdb->tunable.takeover_timeout, 0);
 
/*
 * ip failover is completely disabled, just send out the 
@@ -1622,6 +1615,20 @@ int ctdb_takeover_run(struct ctdb_context *ctdb, struct 
ctdb_node_map_old *nodem
 
ZERO_STRUCT(ip); /* Avoid valgrind warnings for union */
 
+   /* Each of the following stages (RELEASE_IP, TAKEOVER_IP,
+* IPREALLOCATED) notionally has a timeout of TakeoverTimeout
+* seconds.  However, RELEASE_IP can take longer due to TCP
+* connection killing, so sometimes needs more time.
+* Therefore, use a cumulative timeout of TakeoverTimeout * 3
+* seconds across all 3 stages.  No explicit expiry checks are
+* needed before each stage because tevent is smart enough to
+* fire the timeouts even if they are in the past.  Initialise
+* this here so it explicitly covers the stages we're
+* interested in but, in particular, not the time taken by the
+* ipalloc().
+*/
+   timeout = timeval_current_ofs(3 * ctdb->tunable.takeover_timeout, 0);
+
/* Send a RELEASE_IP to all nodes that should not be hosting
 * each IP.  For each IP, all but one of these will be
 * redundant.  However, the redundant ones are used to tell


-- 
Samba Shared Repository

autobuild[sn-devel-144]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2016-08-18-1125/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-08-18-1125/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-08-18-1125/samba.stdout
  
The top commit at the time of the failure was:

commit b21308252eb409bad6089cc0f09fada0229d33e8
Author: Jeremy Allison 
Date:   Wed Aug 17 10:57:10 2016 -0700

s3: vfs: snapper: Fix snapper_gmt_strip_snapshot() function to strip @GMT 
token identically to shadow_copy2.c:shadow_copy2_strip_snapshot()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12150

Signed-off-by: Jeremy Allison 
Reviewed-by: Christof Schmitt 
Reviewed-by: David Disseldorp 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Thu Aug 18 06:43:02 CEST 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-1019/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-1019/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-18-1019/samba.stdout
  
The top commit at the time of the failure was:

commit b21308252eb409bad6089cc0f09fada0229d33e8
Author: Jeremy Allison 
Date:   Wed Aug 17 10:57:10 2016 -0700

s3: vfs: snapper: Fix snapper_gmt_strip_snapshot() function to strip @GMT 
token identically to shadow_copy2.c:shadow_copy2_strip_snapshot()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12150

Signed-off-by: Jeremy Allison 
Reviewed-by: Christof Schmitt 
Reviewed-by: David Disseldorp 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Thu Aug 18 06:43:02 CEST 2016 on sn-devel-144