Re: [SeaBIOS] new tag request for seabios
> Can you confirm the patch below on top of rel-1.7.5.1 fixes the issue for you? Yes, it works. I applied this patch on latest seabios-1.7.5.1 sources and it compile successfully with Intel Compiler as well as with GCC4.9.1. -Original Message- From: Kevin O'Connor [mailto:ke...@koconnor.net] Sent: Friday, November 21, 2014 12:29 PM To: Pandey, Sunil K Cc: 'seabios@seabios.org'; Gerd Hoffmann Subject: Re: [SeaBIOS] new tag request for seabios On Fri, Nov 21, 2014 at 08:03:29PM +, Pandey, Sunil K wrote: > > Is this the only thing preventing compilation on the Intel compiler? > Yes, this is the only problem for Intel compiler. > > I can directly use from git checkout but issue is, SeaBios is > indirectly included in many other open source applications which is > based on SeaBios release tag. Anytime, when I try to compile other > open source applications (i.e. Xen), indirectly it try to compile > SeaBios and Intel Compiler fail because of this issue. Okay. We're likely a couple of months out from the next major release. It may be a candidate for the stable branch, which Gerd maintains. Can you confirm the patch below on top of rel-1.7.5.1 fixes the issue for you? -Kevin --- a/scripts/layoutrom.py +++ b/scripts/layoutrom.py @@ -175,10 +175,7 @@ def doLayout(sections, config, genreloc): # Determine 16bit positions li.sections16 = getSectionsCategory(sections, '16') textsections = getSectionsPrefix(li.sections16, '.text.') -rodatasections = ( -getSectionsPrefix(li.sections16, '.rodata.str1.1') -+ getSectionsPrefix(li.sections16, '.rodata.__func__.') -+ getSectionsPrefix(li.sections16, '.rodata.__PRETTY_FUNCTION__.')) +rodatasections = getSectionsPrefix(li.sections16, '.rodata') datasections = getSectionsPrefix(li.sections16, '.data16.') fixedsections = getSectionsPrefix(li.sections16, '.fixedaddr.') @@ -191,10 +188,7 @@ def doLayout(sections, config, genreloc): # Determine 32seg positions li.sections32seg = getSectionsCategory(sections, '32seg') textsections = getSectionsPrefix(li.sections32seg, '.text.') -rodatasections = ( -getSectionsPrefix(li.sections32seg, '.rodata.str1.1') -+ getSectionsPrefix(li.sections32seg, '.rodata.__func__.') -+ getSectionsPrefix(li.sections32seg, '.rodata.__PRETTY_FUNCTION__.')) +rodatasections = getSectionsPrefix(li.sections32seg, '.rodata') datasections = getSectionsPrefix(li.sections32seg, '.data32seg.') li.sec32seg_start, li.sec32seg_align = setSectionsStart( ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] new tag request for seabios
On Fri, Nov 21, 2014 at 08:03:29PM +, Pandey, Sunil K wrote: > > Is this the only thing preventing compilation on the Intel compiler? > Yes, this is the only problem for Intel compiler. > > I can directly use from git checkout but issue is, SeaBios is > indirectly included in many other open source applications which is > based on SeaBios release tag. Anytime, when I try to compile other > open source applications (i.e. Xen), indirectly it try to compile > SeaBios and Intel Compiler fail because of this issue. Okay. We're likely a couple of months out from the next major release. It may be a candidate for the stable branch, which Gerd maintains. Can you confirm the patch below on top of rel-1.7.5.1 fixes the issue for you? -Kevin --- a/scripts/layoutrom.py +++ b/scripts/layoutrom.py @@ -175,10 +175,7 @@ def doLayout(sections, config, genreloc): # Determine 16bit positions li.sections16 = getSectionsCategory(sections, '16') textsections = getSectionsPrefix(li.sections16, '.text.') -rodatasections = ( -getSectionsPrefix(li.sections16, '.rodata.str1.1') -+ getSectionsPrefix(li.sections16, '.rodata.__func__.') -+ getSectionsPrefix(li.sections16, '.rodata.__PRETTY_FUNCTION__.')) +rodatasections = getSectionsPrefix(li.sections16, '.rodata') datasections = getSectionsPrefix(li.sections16, '.data16.') fixedsections = getSectionsPrefix(li.sections16, '.fixedaddr.') @@ -191,10 +188,7 @@ def doLayout(sections, config, genreloc): # Determine 32seg positions li.sections32seg = getSectionsCategory(sections, '32seg') textsections = getSectionsPrefix(li.sections32seg, '.text.') -rodatasections = ( -getSectionsPrefix(li.sections32seg, '.rodata.str1.1') -+ getSectionsPrefix(li.sections32seg, '.rodata.__func__.') -+ getSectionsPrefix(li.sections32seg, '.rodata.__PRETTY_FUNCTION__.')) +rodatasections = getSectionsPrefix(li.sections32seg, '.rodata') datasections = getSectionsPrefix(li.sections32seg, '.data32seg.') li.sec32seg_start, li.sec32seg_align = setSectionsStart( ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] new tag request for seabios
> Is this the only thing preventing compilation on the Intel compiler? Yes, this is the only problem for Intel compiler. I can directly use from git checkout but issue is, SeaBios is indirectly included in many other open source applications which is based on SeaBios release tag. Anytime, when I try to compile other open source applications (i.e. Xen), indirectly it try to compile SeaBios and Intel Compiler fail because of this issue. -Original Message- From: Kevin O'Connor [mailto:ke...@koconnor.net] Sent: Friday, November 21, 2014 11:30 AM To: Pandey, Sunil K Cc: 'seabios@seabios.org' Subject: Re: [SeaBIOS] new tag request for seabios On Fri, Nov 21, 2014 at 07:04:47PM +, Pandey, Sunil K wrote: > Hi Kevin, > > Thanks for response. Following are specific change I'm talking about. > Compilers are not expected to create .rodata.str1.1, .rodata.__func__ > and .rodata.__PRETTY_FUNCTION__. If compiler decide to use some other > .rodata__ suffix name in place of __func__, __PRETTY_FUNCTION__ or > str1.1, it breaks the compilation. > > As you can see someone already taken out that check from SeaBios > mainline, but 1.7.5.1 still has. As a result of this assumption, > whenever I try to build SeaBios with Intel Compiler it Fail because > Intel compiler uses some other character in place of > __PRETTY_FUNCTION__ and __func__. It will be great if you can > incorporate this fix in released version. I made that change as part of commit e5749978. The change was part of a feature enhancement (compiling with -fno-merge-constants). Is this the only thing preventing compilation on the Intel compiler? Typically a feature enhancement such as e5749978 would go into the next release, and we're likely a month or so out from the next release. As Peter mentioned in another email, it should be possible to checkout a git version using the hash instead of a tag name in the interim (eg, "git checkout 9f505f71"). -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] new tag request for seabios
On Fri, Nov 21, 2014 at 07:04:47PM +, Pandey, Sunil K wrote: > Hi Kevin, > > Thanks for response. Following are specific change I'm talking > about. Compilers are not expected to create .rodata.str1.1, > .rodata.__func__ and .rodata.__PRETTY_FUNCTION__. If compiler > decide to use some other .rodata__ suffix name in place of __func__, > __PRETTY_FUNCTION__ or str1.1, it breaks the compilation. > > As you can see someone already taken out that check from SeaBios > mainline, but 1.7.5.1 still has. As a result of this assumption, > whenever I try to build SeaBios with Intel Compiler it Fail because > Intel compiler uses some other character in place of > __PRETTY_FUNCTION__ and __func__. It will be great if you can > incorporate this fix in released version. I made that change as part of commit e5749978. The change was part of a feature enhancement (compiling with -fno-merge-constants). Is this the only thing preventing compilation on the Intel compiler? Typically a feature enhancement such as e5749978 would go into the next release, and we're likely a month or so out from the next release. As Peter mentioned in another email, it should be possible to checkout a git version using the hash instead of a tag name in the interim (eg, "git checkout 9f505f71"). -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] new tag request for seabios
Hi Kevin, Thanks for response. Following are specific change I'm talking about. Compilers are not expected to create .rodata.str1.1, .rodata.__func__ and .rodata.__PRETTY_FUNCTION__. If compiler decide to use some other .rodata__ suffix name in place of __func__, __PRETTY_FUNCTION__ or str1.1, it breaks the compilation. As you can see someone already taken out that check from SeaBios mainline, but 1.7.5.1 still has. As a result of this assumption, whenever I try to build SeaBios with Intel Compiler it Fail because Intel compiler uses some other character in place of __PRETTY_FUNCTION__ and __func__. It will be great if you can incorporate this fix in released version. Layoutrom.py file check for From SeaBios mainline (layoutrom.py): = 180 rodatasections = getSectionsPrefix(sections16, '.rodata') 193 rodatasections = getSectionsPrefix(sections32seg, '.rodata') From 1.7.5.1 (layoutrom.py): == 178 rodatasections = ( 179 getSectionsPrefix(li.sections16, '.rodata.str1.1')␊ 180 + getSectionsPrefix(li.sections16, '.rodata.__func__.') 181 + getSectionsPrefix(li.sections16, '.rodata.__PRETTY_FUNCTION__.')) 194 rodatasections = ( 195 getSectionsPrefix(li.sections32seg, '.rodata.str1.1') 196 + getSectionsPrefix(li.sections32seg, '.rodata.__func__.') 197 + getSectionsPrefix(li.sections32seg, '.rodata.__PRETTY_FUNCTION__.')) Thanks, Sunil -Original Message- From: Kevin O'Connor [mailto:ke...@koconnor.net] Sent: Friday, November 21, 2014 10:42 AM To: Pandey, Sunil K Cc: 'seabios@seabios.org' Subject: Re: [SeaBIOS] new tag request for seabios On Wed, Nov 12, 2014 at 09:20:22PM +, Pandey, Sunil K wrote: > Hello, > > I'm looking for a fix in > http://code.coreboot.org/p/seabios/source/tree/master/scripts/layoutro > m.py file. Apparently the fix is already in the master, but it's hard > for me to use directly from master. Currently all existing tags are > old and doesn't reflect latest layoutrom.py changes. > > Can you please create a new tag from master so that I can use it in my > project? I'm trying to compile seabios code with Intel compiler, but > it keep failing because of layoutrom.py file __func__ check. Can you post the error that you are seeing? We just tagged rel-1.7.5.1 and it included all the build bug fixes that I know of. There are changes to scripts/layoutrom.py between rel-1.7.5.1 and the current master branch, but none of those changes were thought to be bug fixes. -Kevin PS - please post in just plain text (no html) in the future. ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] new tag request for seabios
Pandey, Sunil K wrote: > the fix is already in the master, but it's hard for me to use > directly from master. Currently all existing tags are old and > doesn't reflect latest layoutrom.py changes. Wherever you use a tag with git you can also provide a commit hash. It should work well to simply change your code to reference the commit with the fix instead of the tag you are currently using. Unrelated to using a commit id maybe someone will add a tag. //Peter ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] new tag request for seabios
On Wed, Nov 12, 2014 at 09:20:22PM +, Pandey, Sunil K wrote: > Hello, > > I'm looking for a fix in > http://code.coreboot.org/p/seabios/source/tree/master/scripts/layoutrom.py > file. Apparently the fix is already in the master, but it's hard for > me to use directly from master. Currently all existing tags are old > and doesn't reflect latest layoutrom.py changes. > > Can you please create a new tag from master so that I can use it in > my project? I'm trying to compile seabios code with Intel compiler, > but it keep failing because of layoutrom.py file __func__ check. Can you post the error that you are seeing? We just tagged rel-1.7.5.1 and it included all the build bug fixes that I know of. There are changes to scripts/layoutrom.py between rel-1.7.5.1 and the current master branch, but none of those changes were thought to be bug fixes. -Kevin PS - please post in just plain text (no html) in the future. ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
[SeaBIOS] new tag request for seabios
Hello, I'm looking for a fix in http://code.coreboot.org/p/seabios/source/tree/master/scripts/layoutrom.py file. Apparently the fix is already in the master, but it's hard for me to use directly from master. Currently all existing tags are old and doesn't reflect latest layoutrom.py changes. Can you please create a new tag from master so that I can use it in my project? I'm trying to compile seabios code with Intel compiler, but it keep failing because of layoutrom.py file __func__ check. Thanks, Sunil Pandey ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
