RFR JDK 8 doclint fixes in javax.net.ssl

2013-08-23 Thread Joe Darcy

Hello,

Please review the patch below which resolves several doclint issues in 
javax.net.ssl.


Thanks,

-Joe

diff -r 4ef82445ea20 src/share/classes/javax/net/ssl/SNIHostName.java
--- a/src/share/classes/javax/net/ssl/SNIHostName.javaFri Aug 23 
20:59:34 2013 +0200
+++ b/src/share/classes/javax/net/ssl/SNIHostName.javaFri Aug 23 
14:33:44 2013 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -293,6 +293,7 @@
  * the a href={@docRoot}/java/util/regex/Pattern.html#sum
  * regular expression pattern/a
  * representing the hostname(s) to match
+ * @return a {@code SNIMatcher} object for {@code SNIHostName}s
  * @throws NullPointerException if {@code regex} is
  * {@code null}
  * @throws java.util.regex.PatternSyntaxException if the regular 
expression's

diff -r 4ef82445ea20 src/share/classes/javax/net/ssl/X509KeyManager.java
--- a/src/share/classes/javax/net/ssl/X509KeyManager.javaFri Aug 23 
20:59:34 2013 +0200
+++ b/src/share/classes/javax/net/ssl/X509KeyManager.javaFri Aug 23 
14:33:44 2013 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1999, 2004, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -40,7 +40,7 @@
  * UL
  * LI determine the set of aliases that are available for negotiations
  *  based on the criteria presented,
- * LI select the ITALIC best alias /ITALIC based on
+ * LI select the i best alias/i based on
  *  the criteria presented, and
  * LI obtain the corresponding key material for given aliases.
  * /UL



Re: RFR JDK 8 doclint fixes in javax.net.ssl

2013-08-23 Thread Bradford Wetmore

Looks good to me, but Xuelei (owner) might want to have a quick look.

Brad



On 8/23/2013 2:34 PM, Joe Darcy wrote:

Hello,

Please review the patch below which resolves several doclint issues in
javax.net.ssl.

Thanks,

-Joe

diff -r 4ef82445ea20 src/share/classes/javax/net/ssl/SNIHostName.java
--- a/src/share/classes/javax/net/ssl/SNIHostName.javaFri Aug 23
20:59:34 2013 +0200
+++ b/src/share/classes/javax/net/ssl/SNIHostName.javaFri Aug 23
14:33:44 2013 -0700
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights
reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -293,6 +293,7 @@
   * the a href={@docRoot}/java/util/regex/Pattern.html#sum
   * regular expression pattern/a
   * representing the hostname(s) to match
+ * @return a {@code SNIMatcher} object for {@code SNIHostName}s
   * @throws NullPointerException if {@code regex} is
   * {@code null}
   * @throws java.util.regex.PatternSyntaxException if the regular
expression's
diff -r 4ef82445ea20 src/share/classes/javax/net/ssl/X509KeyManager.java
--- a/src/share/classes/javax/net/ssl/X509KeyManager.javaFri Aug 23
20:59:34 2013 +0200
+++ b/src/share/classes/javax/net/ssl/X509KeyManager.javaFri Aug 23
14:33:44 2013 -0700
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 1999, 2004, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights
reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -40,7 +40,7 @@
   * UL
   * LI determine the set of aliases that are available for negotiations
   *  based on the criteria presented,
- * LI select the ITALIC best alias /ITALIC based on
+ * LI select the i best alias/i based on
   *  the criteria presented, and
   * LI obtain the corresponding key material for given aliases.
   * /UL



Re: RFR JDK 8 doclint fixes in javax.net.ssl

2013-08-23 Thread Xuelei Fan
Looks fine to me, too. Thanks for the update.

xuelei


On Aug 24, 2013, at 6:09, Bradford Wetmore bradford.wetm...@oracle.com wrote:

 Looks good to me, but Xuelei (owner) might want to have a quick look.
 
 Brad
 
 
 
 On 8/23/2013 2:34 PM, Joe Darcy wrote:
 Hello,
 
 Please review the patch below which resolves several doclint issues in
 javax.net.ssl.
 
 Thanks,
 
 -Joe
 
 diff -r 4ef82445ea20 src/share/classes/javax/net/ssl/SNIHostName.java
 --- a/src/share/classes/javax/net/ssl/SNIHostName.javaFri Aug 23
 20:59:34 2013 +0200
 +++ b/src/share/classes/javax/net/ssl/SNIHostName.javaFri Aug 23
 14:33:44 2013 -0700
 @@ -1,5 +1,5 @@
  /*
 - * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
 + * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights
 reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
 @@ -293,6 +293,7 @@
   * the a href={@docRoot}/java/util/regex/Pattern.html#sum
   * regular expression pattern/a
   * representing the hostname(s) to match
 + * @return a {@code SNIMatcher} object for {@code SNIHostName}s
   * @throws NullPointerException if {@code regex} is
   * {@code null}
   * @throws java.util.regex.PatternSyntaxException if the regular
 expression's
 diff -r 4ef82445ea20 src/share/classes/javax/net/ssl/X509KeyManager.java
 --- a/src/share/classes/javax/net/ssl/X509KeyManager.javaFri Aug 23
 20:59:34 2013 +0200
 +++ b/src/share/classes/javax/net/ssl/X509KeyManager.javaFri Aug 23
 14:33:44 2013 -0700
 @@ -1,5 +1,5 @@
  /*
 - * Copyright (c) 1999, 2004, Oracle and/or its affiliates. All rights
 reserved.
 + * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights
 reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
 @@ -40,7 +40,7 @@
   * UL
   * LI determine the set of aliases that are available for negotiations
   *  based on the criteria presented,
 - * LI select the ITALIC best alias /ITALIC based on
 + * LI select the i best alias/i based on
   *  the criteria presented, and
   * LI obtain the corresponding key material for given aliases.
   * /UL