Re: RFR: 8306028: separate ThreadStart/ThreadEnd events posting code in JVMTI VTMS transitions [v8]
On Thu, 8 Jun 2023 19:05:54 GMT, Doug Simon wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update copyright comments > > src/hotspot/share/runtime/sharedRuntime.cpp line 641: > >> 639: JRT_ENTRY(void, SharedRuntime::notify_jvmti_vthread_start(oopDesc* vt, >> jboolean hide, JavaThread* current)) >> 640: assert(hide == JNI_FALSE, "must be VTMS transition finish"); >> 641: jobject vthread = JNIHandles::make_local(const_cast(vt)); > > Since the current thread is in the `current` arg, it could be used here when > creating the local handle. That's right. Thanks. - PR Review Comment: https://git.openjdk.org/jdk/pull/13484#discussion_r1223851214
Re: RFR: 8306028: separate ThreadStart/ThreadEnd events posting code in JVMTI VTMS transitions [v8]
On Tue, 2 May 2023 02:01:44 GMT, Serguei Spitsyn wrote: >> This refactoring to separate ThreadStart/ThreadEnd events posting code in >> the JVMTI VTMS transitions is needed for future work on JVMTI scalability >> and performance improvements. It is to easier put this code on slow path. >> >> Testing: mach5 tiers 1-6 were successful. > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > update copyright comments src/hotspot/share/runtime/sharedRuntime.cpp line 641: > 639: JRT_ENTRY(void, SharedRuntime::notify_jvmti_vthread_start(oopDesc* vt, > jboolean hide, JavaThread* current)) > 640: assert(hide == JNI_FALSE, "must be VTMS transition finish"); > 641: jobject vthread = JNIHandles::make_local(const_cast(vt)); Since the current thread is in the `current` arg, it could be used here when creating the local handle. - PR Review Comment: https://git.openjdk.org/jdk/pull/13484#discussion_r1223444559
Re: RFR: 8306028: separate ThreadStart/ThreadEnd events posting code in JVMTI VTMS transitions [v8]
> This refactoring to separate ThreadStart/ThreadEnd events posting code in the > JVMTI VTMS transitions is needed for future work on JVMTI scalability and > performance improvements. It is to easier put this code on slow path. > > Testing: mach5 tiers 1-6 were successful. Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision: update copyright comments - Changes: - all: https://git.openjdk.org/jdk/pull/13484/files - new: https://git.openjdk.org/jdk/pull/13484/files/02b27601..f4227c7a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=13484=07 - incr: https://webrevs.openjdk.org/?repo=jdk=13484=06-07 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/13484.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13484/head:pull/13484 PR: https://git.openjdk.org/jdk/pull/13484