Re: CVS commit: src/sys/ufs/ufs
On Sun Sep 20 2009 at 14:00:24 +, Manuel Bouyer wrote: Module Name: src Committed By: bouyer Date: Sun Sep 20 14:00:24 UTC 2009 Modified Files: src/sys/ufs/ufs: ufs_ihash.c Log Message: PR kern/41147: race between nfsd and local rm Note that the race also exists between 2 nfs client, one of them doing the rm. In ufs_ihashget(), vget() can return a vnode that has been vclean'ed because vget() can sleep. After vget returns, check that vp is still connected with ip, and that ip still points to the inode we want. This fix the NULL pointer dereference in ufs_fhtovp() I've been seeing on a NFS server. Um, hold the phone. The whole point of vget() is to provide race-free access to the weak vnode reference held by the file system. Are you saying this does not hold anymore?
Re: CVS commit: src/distrib
On Sat, Sep 19, 2009 at 09:05:27PM +, Christos Zoulas wrote: if [ -n $1 ]; then awk -f .../list2sh.awk $@ fi Since $@ is being substituted, wouldn't a check against $# be more appropriate? and that X$1 idiom needs to die It is necessary to guarantee the way the expression is evaluated if/when $1 (in the above example) is, say, -o or some other string that might be deemed to be an operator. Although posix defines strict rules for expressions with small numbers of arguments, netbsd'd parser doesn't obey them! as well as using unquoted variables which will break for strings with whitespace. Sometimes I empty IFS David -- David Laight: da...@l8s.co.uk
Re: CVS commit: src/distrib
Module Name: src Committed By: abs Date: Sun Sep 20 23:19:56 UTC 2009 : Added Files: src/distrib/common: termcap Removed Files: : src/distrib/common: termcap.mini : Log Message: 34 different termcap subsets, plus a couple of ports still using the full termcap distfile. In an attempt to reduce the madness switch everyone (except the i386 cd install which does its own thing) to the same (under 8K) termcap subset: Can't it use src/distrib/common/mktermcap script? --- Izumi Tsutsui
