Re: CVS commit: [cherry-xenmp] src/sys/arch/xen/x86

2011-06-27 Thread Cherry G. Mathew
On 27 June 2011 12:23, Cherry G. Mathew che...@netbsd.org wrote:
 Module Name:    src
 Committed By:   cherry
 Date:           Mon Jun 27 10:23:21 UTC 2011

 Modified Files:
        src/sys/arch/xen/x86 [cherry-xenmp]: x86_xpmap.c

 Log Message:
 Add xpq locking around xpq-QUEUE_TLB_FLUSH()


sorry, that was meant to be:
Add xpq locking around xpq_queue_tlb_flush()

cvs surgery done.

Thanks,

-- 
~Cherry


Re: CVS commit: src/sys/uvm

2011-06-27 Thread YAMAMOTO Takashi
hi,

 Module Name:  src
 Committed By: hannken
 Date: Mon Jun 27 15:56:37 UTC 2011
 
 Modified Files:
   src/sys/uvm: uvm_amap.c
 
 Log Message:
 amap_copy(): Keep the source amap locked until its lock has been copied.

btw, this code seems to assume that uvm_anfree does not release the lock
even temporarily while the comment on uvm_anfree1 says the opposite.

YAMAMOTO Takashi

 
 Kernel assertion anon-an_lock == amap-am_lock no longer fails.
 
 Ok: Mindaugas Rasiukevicius rm...@netbsd.org
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.99 -r1.100 src/sys/uvm/uvm_amap.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


Re: CVS commit: src/sys/uvm

2011-06-27 Thread Masao Uebayashi
On Tue, Jun 28, 2011 at 9:39 AM, YAMAMOTO Takashi
y...@mwd.biglobe.ne.jp wrote:
 hi,

 Module Name:  src
 Committed By: hannken
 Date:         Mon Jun 27 15:56:37 UTC 2011

 Modified Files:
       src/sys/uvm: uvm_amap.c

 Log Message:
 amap_copy(): Keep the source amap locked until its lock has been copied.

 btw, this code seems to assume that uvm_anfree does not release the lock
 even temporarily while the comment on uvm_anfree1 says the opposite.

This locking protocol looks odd to me.  Mutex obj is alloc'ed in amap,
why not free'ed in amap too?  uobj is doing so.


 YAMAMOTO Takashi


 Kernel assertion anon-an_lock == amap-am_lock no longer fails.

 Ok: Mindaugas Rasiukevicius rm...@netbsd.org


 To generate a diff of this commit:
 cvs rdiff -u -r1.99 -r1.100 src/sys/uvm/uvm_amap.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.



Re: CVS commit: src

2011-06-27 Thread Matt Thomas
Please do MKDEBUG=yes builds.

You missed adding:

./usr/libdata/debug/sbin/fsck_v7fs.debug
./usr/libdata/debug/sbin/mount_v7fs.debug
./usr/libdata/debug/sbin/newfs_v7fs.debug

On Jun 27, 2011, at 4:52 AM, UCHIYAMA Yasushi wrote:

 Module Name:  src
 Committed By: uch
 Date: Mon Jun 27 11:52:58 UTC 2011
 
 Modified Files:
   src/distrib/sets/lists/base: mi
   src/distrib/sets/lists/comp: mi
   src/distrib/sets/lists/man: mi
   src/sbin: Makefile
   src/sys/conf: files
   src/sys/fs: Makefile
   src/sys/sys: disklabel.h mount.h vnode.h
 Added Files:
   src/sbin/fsck_v7fs: Makefile datablock.c freeblock.c fsck_v7fs.8
   fsck_v7fs.c fsck_v7fs.h inode.c main.c pathname.c
   src/sbin/mount_v7fs: Makefile mount_v7fs.8 mount_v7fs.c mount_v7fs.h
   src/sbin/newfs_v7fs: Makefile main.c newfs_v7fs.8 newfs_v7fs.c
   newfs_v7fs.h
   src/sys/fs/v7fs: Makefile files.v7fs v7fs.h v7fs_args.h
   v7fs_datablock.c v7fs_datablock.h v7fs_dirent.c v7fs_dirent.h
   v7fs_endian.c v7fs_endian.h v7fs_extern.c v7fs_extern.h v7fs_file.c
   v7fs_file.h v7fs_file_util.c v7fs_impl.h v7fs_inode.c v7fs_inode.h
   v7fs_inode_util.c v7fs_io.c v7fs_io_kern.c v7fs_io_user.c
   v7fs_superblock.c v7fs_superblock.h v7fs_superblock_util.c
   v7fs_vfsops.c v7fs_vnops.c
 
 Log Message:
 7th Edition(V7) File System support. and NetBSD symbolic-link, socket, FIFO 
 extension. see newfs_v7fs(8).
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.939 -r1.940 src/distrib/sets/lists/base/mi
 cvs rdiff -u -r1.1632 -r1.1633 src/distrib/sets/lists/comp/mi
 cvs rdiff -u -r1.1321 -r1.1322 src/distrib/sets/lists/man/mi
 cvs rdiff -u -r1.119 -r1.120 src/sbin/Makefile
 cvs rdiff -u -r0 -r1.1 src/sbin/fsck_v7fs/Makefile \
src/sbin/fsck_v7fs/datablock.c src/sbin/fsck_v7fs/freeblock.c \
src/sbin/fsck_v7fs/fsck_v7fs.8 src/sbin/fsck_v7fs/fsck_v7fs.c \
src/sbin/fsck_v7fs/fsck_v7fs.h src/sbin/fsck_v7fs/inode.c \
src/sbin/fsck_v7fs/main.c src/sbin/fsck_v7fs/pathname.c
 cvs rdiff -u -r0 -r1.1 src/sbin/mount_v7fs/Makefile \
src/sbin/mount_v7fs/mount_v7fs.8 src/sbin/mount_v7fs/mount_v7fs.c \
src/sbin/mount_v7fs/mount_v7fs.h
 cvs rdiff -u -r0 -r1.1 src/sbin/newfs_v7fs/Makefile \
src/sbin/newfs_v7fs/main.c src/sbin/newfs_v7fs/newfs_v7fs.8 \
src/sbin/newfs_v7fs/newfs_v7fs.c src/sbin/newfs_v7fs/newfs_v7fs.h
 cvs rdiff -u -r1.1017 -r1.1018 src/sys/conf/files
 cvs rdiff -u -r1.19 -r1.20 src/sys/fs/Makefile
 cvs rdiff -u -r0 -r1.1 src/sys/fs/v7fs/Makefile src/sys/fs/v7fs/files.v7fs \
src/sys/fs/v7fs/v7fs.h src/sys/fs/v7fs/v7fs_args.h \
src/sys/fs/v7fs/v7fs_datablock.c src/sys/fs/v7fs/v7fs_datablock.h \
src/sys/fs/v7fs/v7fs_dirent.c src/sys/fs/v7fs/v7fs_dirent.h \
src/sys/fs/v7fs/v7fs_endian.c src/sys/fs/v7fs/v7fs_endian.h \
src/sys/fs/v7fs/v7fs_extern.c src/sys/fs/v7fs/v7fs_extern.h \
src/sys/fs/v7fs/v7fs_file.c src/sys/fs/v7fs/v7fs_file.h \
src/sys/fs/v7fs/v7fs_file_util.c src/sys/fs/v7fs/v7fs_impl.h \
src/sys/fs/v7fs/v7fs_inode.c src/sys/fs/v7fs/v7fs_inode.h \
src/sys/fs/v7fs/v7fs_inode_util.c src/sys/fs/v7fs/v7fs_io.c \
src/sys/fs/v7fs/v7fs_io_kern.c src/sys/fs/v7fs/v7fs_io_user.c \
src/sys/fs/v7fs/v7fs_superblock.c src/sys/fs/v7fs/v7fs_superblock.h \
src/sys/fs/v7fs/v7fs_superblock_util.c src/sys/fs/v7fs/v7fs_vfsops.c \
src/sys/fs/v7fs/v7fs_vnops.c
 cvs rdiff -u -r1.108 -r1.109 src/sys/sys/disklabel.h
 cvs rdiff -u -r1.199 -r1.200 src/sys/sys/mount.h
 cvs rdiff -u -r1.232 -r1.233 src/sys/sys/vnode.h
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.