Re: CVS commit: src

2011-07-05 Thread Christos Zoulas 
In article <1k3w077.dr9oh1asic2om%m...@netbsd.org>,
Emmanuel Dreyfus  wrote:
>matthew green  wrote:
>
>> > /usr/src3/lib/libc/rpc/xdr_sizeof.c:112:12: error: 
>> > cast from pointer to integer of different size
>> > /usr/src3/lib/libc/rpc/xdr_sizeof.c:124:18: error: 
>> > cast to pointer from integer of different size
>
>Does that fix it at yours?
>
>--- xdr_sizeof.c.orig   2011-07-04 15:16:46.0 +0200
>+++ xdr_sizeof.c2011-07-04 15:17:01.0 +0200
>@@ -110,5 +110,5 @@
>return (NULL);
>}
>-   if (len < (u_int)xdrs->x_base) {
>+   if (len < (u_int)(u_long)xdrs->x_base) {
>/* x_private was already allocated */
>xdrs->x_handy += len;
>@@ -122,5 +122,5 @@
>return (NULL);
>}
>-   xdrs->x_base = (caddr_t) len;
>+   xdrs->x_base = (caddr_t)(u_long) len;
>xdrs->x_handy += len;
>return ((int32_t *) xdrs->x_private);
>

intptr_t please.

christos

Re: CVS commit: src/sys/uvm

2011-07-05 Thread YAMAMOTO Takashi 
hi,

> y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
>> > Module Name:   src
>> > Committed By:  hannken
>> > Date:  Mon Jun 27 15:56:37 UTC 2011
>> > 
>> > Modified Files:
>> >src/sys/uvm: uvm_amap.c
>> > 
>> > Log Message:
>> > amap_copy(): Keep the source amap locked until its lock has been copied.
>> 
>> btw, this code seems to assume that uvm_anfree does not release the lock
>> even temporarily while the comment on uvm_anfree1 says the opposite.
> 
> http://www.netbsd.org/~rmind/uvm_anon_freelst.diff
> 
> Looks good?

i don't understand what it solves.  can you explain a little?

YAMAMOTO Takashi

> 
>> 
>> YAMAMOTO Takashi
> 
> -- 
> Mindaugas

Re: CVS commit: src/sys/sys

2011-07-05 Thread Joerg Sonnenberger 
On Tue, Jul 05, 2011 at 07:32:34AM +, David A. Holland wrote:
> Log Message:
> The manipulation macros for struct dirent are also used by the ufs/ffs
> code to manipulate the similar but not identical struct direct. For
> this reason they must remain type-polymorphic. Rev 1.25 broke that
> property, so put it back by using typeof. Fixes PR 45119.

Please revert this and give UFS/FFS a custom copy. Using very GCC
specific C extensions is not appropiate here.

Joerg

Re: CVS commit: src

2011-07-05 Thread Izumi Tsutsui 
> > For (1) I think "OBJDUMP_ARM_AOUT_FLAGS" like this:
> > ---
> > OBJDUMP_ARM_AOUT_FLAGS= \
> > -O a.out-arm-netbsd \
> > -R .ident   \
 :
> > For (2), not sure which is better bsd.own.mk or bsd.sys.mk etc.
> > 
> > Note:
> > - sgimips has similar flags to generate ecoff bootloaders
> > - I'm not sure if we can use elf2aout(1) for old ARM firmware
> 
> I think OBJDYMP_AOUT_FLAGS inside a if ${MACINE_ARCH} == "arm" ...
> block is a better choice.

I'll add OBJDUMP_ELF2AOUT_FLAGS?= wrapped with if ${MACHINE_ARCH} == "foo"
in bsd.own.mk as an alternative of elf2aout (or elf2ecoff).

---
Izumi Tsutsui