Re: CVS commit: src/tools/compat

2012-06-03 Thread Alan Barrett

On Sun, 03 Jun 2012, Joerg Sonnenberger wrote:

Log Message:
Add __predict_true / __predict_false definitions.



+#undef __predict_false
+#define __predict_false(x) x
+#undef __predict_true
+#define __predict_true(x) x


Please parenthesise the definitions.

I don't know whether it's worth defining them in a 
compiler-dependent way, or using #ifndef to pick up any definition 
provided by the host system.


--apb (Alan Barrett)


Re: CVS commit: src/sys

2012-06-03 Thread Izumi Tsutsui
> > Can't we have an option for autoloading rootfs modules,
> > like console settings configurable via installboot?
> 
> You can request it from the boot.cfg file,
> there is no need for a second way - it only confuses things.

How can we make bootloader to select file system type where kernel
is loaded from?

---
Izumi Tsutsui


Re: CVS commit: src/sys

2012-06-03 Thread David Laight
On Sun, Jun 03, 2012 at 10:10:40AM +0900, Izumi Tsutsui wrote:
> dsl@ wrote:
...
> > > } Log Message:
> > > } Remove the code that tries to load the "ffs" kernel module during boot.
> > > } This is in line with the core decision than even modular kernels should
> > > }   contain the ffs code.
> > > } I've left in the code that tries to load "nfs" and "ext2fs", but it
> > > }   isn't clear that is necessary.
> > > } Removes a warning message that (usually) flashes past to fast to read.
> > > } AFAICT all the relevant kernels contain ffs (and nfs for that matter).
...
> Can't we have an option for autoloading rootfs modules,
> like console settings configurable via installboot?

You can request it from the boot.cfg file,
there is no need for a second way - it only confuses things.

David

-- 
David Laight: da...@l8s.co.uk