Re: CVS commit: src/usr.bin/sed

2015-03-01 Thread Warner Losh

> On Mar 1, 2015, at 8:45 AM, Aleksej Saushev  wrote:
> 
> chris...@astron.com (Christos Zoulas) writes:
> 
>> In article <20150228215653.f2f0...@cvs.netbsd.org>,
>> Aleksej Saushev  wrote:
>>> -=-=-=-=-=-
>>> 
>>> Module Name:src
>>> Committed By:   asau
>>> Date:   Sat Feb 28 21:56:53 UTC 2015
>>> 
>>> Modified Files:
>>> src/usr.bin/sed: compile.c extern.h main.c process.c
>>> 
>>> Log Message:
>>> Improve modularity of "sed" source:
>>> - move program source input subroutines into compiler part;
>>> - move data I/O subroutines into processor part.
>> 
>> It there a good reason for that? We try to keep it synced with FreeBSD..
> 
> It makes code a lot cleaner and allows embedding it.
> 
> If that's problem, I'll submit changes to FreeBSD.

Sounds like a good idea to me…

Warner


signature.asc
Description: Message signed with OpenPGP using GPGMail


Re: CVS commit: src/usr.bin/sed

2015-03-01 Thread Christos Zoulas
In article <87d24szpq8@inbox.ru>, Aleksej Saushev   wrote:
>
>It makes code a lot cleaner and allows embedding it.
>
>If that's problem, I'll submit changes to FreeBSD.

It is not a problem and communicating the changes with FreeBSD
would be great. This is just FYI :-)

christos



Re: CVS commit: src/usr.bin/sed

2015-03-01 Thread Aleksej Saushev
chris...@astron.com (Christos Zoulas) writes:

> In article <20150228215653.f2f0...@cvs.netbsd.org>,
> Aleksej Saushev  wrote:
>>-=-=-=-=-=-
>>
>>Module Name:  src
>>Committed By: asau
>>Date: Sat Feb 28 21:56:53 UTC 2015
>>
>>Modified Files:
>>  src/usr.bin/sed: compile.c extern.h main.c process.c
>>
>>Log Message:
>>Improve modularity of "sed" source:
>>- move program source input subroutines into compiler part;
>>- move data I/O subroutines into processor part.
>
> It there a good reason for that? We try to keep it synced with FreeBSD..

It makes code a lot cleaner and allows embedding it.

If that's problem, I'll submit changes to FreeBSD.


-- 
HE CE3OH...