re: CVS commit: src/external/mit/xorg/bin/xauth
On Apr 6, 9:31am, m...@eterna.com.au (matthew green) wrote:
-- Subject: re: CVS commit: src/external/mit/xorg/bin/xauth
| it shows xauth doing this:
|
| unlink("/home/foo/.Xauthority");
| link("/home/foo/.Xauthority", "/home/foo/.Xauthority");
|
| which is where it fails.
|
| the code itself clearly can't be responsible for this, it is
| using a -c or -n additional postfix on the filename for the
| 'src' link above, which isn't present.
|
| at least, that appears to be the intent ;)
Someone pointed out the bug to me. Our stpcpy_chk() was off by one.
gcc-4.8 changes:
strcpy(dst, ...); l = strlen(dst);
to
x = stpcpy(dst, ...); l = x - dst;
if you update and rebuild libc, xauth should work again.
christos
re: CVS commit: src/external/mit/xorg/bin/xauth
Christos Zoulas writes:
> In article <20140405170155.aca4...@cvs.netbsd.org>,
> Matthias Scheler wrote:
> >-=-=-=-=-=-
> >
> >Module Name: src
> >Committed By:tron
> >Date:Sat Apr 5 17:01:55 UTC 2014
> >
> >Modified Files:
> > src/external/mit/xorg/bin/xauth: Makefile
> >
> >Log Message:
> >Force "USE_SSP" to "no" when compiling xauth(1) for now. This avoid the
> >program to fail with error messages like this one:
> >
> >/usr/X11R7/bin/xauth: file /home/tron/.Xauthority does not exist
> >/usr/X11R7/bin/xauth: unable to link authority file
> >/home/tron/.Xauthority, use /home/tron/.Xauthority
> >
> >This seems to be some weird compiler bug. If you add a debug printf(3) call
> >before the line in "xsrc/external/mit/xauth/dist/process.c" that calls
> >link(2) the target and source filename have the correct value and
> >the call works. Without the printf(3) call it fails.
>
> What does ktracing show?
it shows xauth doing this:
unlink("/home/foo/.Xauthority");
link("/home/foo/.Xauthority", "/home/foo/.Xauthority");
which is where it fails.
the code itself clearly can't be responsible for this, it is
using a -c or -n additional postfix on the filename for the
'src' link above, which isn't present.
at least, that appears to be the intent ;)
.mrg.
Re: CVS commit: src/external/mit/xorg/bin/xauth
In article <20140405170155.aca4...@cvs.netbsd.org>, Matthias Scheler wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: tron >Date: Sat Apr 5 17:01:55 UTC 2014 > >Modified Files: > src/external/mit/xorg/bin/xauth: Makefile > >Log Message: >Force "USE_SSP" to "no" when compiling xauth(1) for now. This avoid the >program to fail with error messages like this one: > >/usr/X11R7/bin/xauth: file /home/tron/.Xauthority does not exist >/usr/X11R7/bin/xauth: unable to link authority file >/home/tron/.Xauthority, use /home/tron/.Xauthority > >This seems to be some weird compiler bug. If you add a debug printf(3) call >before the line in "xsrc/external/mit/xauth/dist/process.c" that calls >link(2) the target and source filename have the correct value and >the call works. Without the printf(3) call it fails. What does ktracing show? christos
Re: CVS commit: src/external/mit/xorg/bin/xauth
On Sat, Apr 05, 2014 at 05:01:55PM +, Matthias Scheler wrote: > Module Name: src > Committed By: tron > Date: Sat Apr 5 17:01:55 UTC 2014 > > Modified Files: > src/external/mit/xorg/bin/xauth: Makefile > > Log Message: > Force "USE_SSP" to "no" when compiling xauth(1) for now. This avoid the > program to fail with error messages like this one: So this is this applied to all compilers on all architectures? Joerg
