Re: tree.h: returning void, legal but weird

[Mark Kettenis]

> Date: Sat, 10 Oct 2020 18:37:50 +0200
> From: Otto Moerbeek 
> 
> OK?

ok kettenis@

> Index: tree.h
> ===
> RCS file: /cvs/src/sys/sys/tree.h,v
> retrieving revision 1.29
> diff -u -p -r1.29 tree.h
> --- tree.h30 Jul 2017 19:27:20 -  1.29
> +++ tree.h10 Oct 2020 16:36:15 -
> @@ -910,25 +910,25 @@ _name##_RBT_PARENT(struct _type *elm)   
>  __unused static inline void  \
>  _name##_RBT_SET_LEFT(struct _type *elm, struct _type *left)  \
>  {\
> - return _rb_set_left(_name##_RBT_TYPE, elm, left);   \
> + _rb_set_left(_name##_RBT_TYPE, elm, left);  \
>  }\
>   \
>  __unused static inline void  \
>  _name##_RBT_SET_RIGHT(struct _type *elm, struct _type *right)
> \
>  {\
> - return _rb_set_right(_name##_RBT_TYPE, elm, right); \
> + _rb_set_right(_name##_RBT_TYPE, elm, right);\
>  }\
>   \
>  __unused static inline void  \
>  _name##_RBT_SET_PARENT(struct _type *elm, struct _type *parent)  
> \
>  {\
> - return _rb_set_parent(_name##_RBT_TYPE, elm, parent);   \
> + _rb_set_parent(_name##_RBT_TYPE, elm, parent);  \
>  }\
>   \
>  __unused static inline void  \
>  _name##_RBT_POISON(struct _type *elm, unsigned long poison)  \
>  {\
> - return _rb_poison(_name##_RBT_TYPE, elm, poison);   \
> + _rb_poison(_name##_RBT_TYPE, elm, poison);  \
>  }\
>   \
>  __unused static inline int   \
> 
> 

tree.h: returning void, legal but weird

[Otto Moerbeek]

OK?

-Otto

Index: tree.h
===
RCS file: /cvs/src/sys/sys/tree.h,v
retrieving revision 1.29
diff -u -p -r1.29 tree.h
--- tree.h  30 Jul 2017 19:27:20 -  1.29
+++ tree.h  10 Oct 2020 16:36:15 -
@@ -910,25 +910,25 @@ _name##_RBT_PARENT(struct _type *elm) 
 __unused static inline void\
 _name##_RBT_SET_LEFT(struct _type *elm, struct _type *left)\
 {  \
-   return _rb_set_left(_name##_RBT_TYPE, elm, left);   \
+   _rb_set_left(_name##_RBT_TYPE, elm, left);  \
 }  \
\
 __unused static inline void\
 _name##_RBT_SET_RIGHT(struct _type *elm, struct _type *right)  \
 {  \
-   return _rb_set_right(_name##_RBT_TYPE, elm, right); \
+   _rb_set_right(_name##_RBT_TYPE, elm, right);\
 }  \
\
 __unused static inline void\
 _name##_RBT_SET_PARENT(struct _type *elm, struct _type *parent)
\
 {  \
-   return _rb_set_parent(_name##_RBT_TYPE, elm, parent);   \
+   _rb_set_parent(_name##_RBT_TYPE, elm, parent);  \
 }  \
\
 __unused static inline void\
 _name##_RBT_POISON(struct _type *elm, unsigned long poison)\
 {  \
-   return _rb_poison(_name##_RBT_TYPE, elm, poison);   \
+   _rb_poison(_name##_RBT_TYPE, elm, poison);  \
 }  \
\
 __unused static inline int \