Re: [Tigervnc-devel] GNU TLS

2010-05-03 Thread Adam Tkac
On Wed, Apr 28, 2010 at 06:25:51PM -0500, DRC wrote:
 Additional fuel for this discussion-- the Windows build now fails as
 well unless you specify configure --disable-gnutls.

Thanks for report. Should be fixed in r4051.

 On 4/28/10 2:53 PM, DRC wrote:
  There are a couple of problems with this, as I see it:
  
  1) GNU TLS support is enabled by default, so if GNU TLS isn't installed
  on the system (which is the case for non-Linux systems, generally), then
  configure fails.  Our build should not require GNU TLS, nor should it
  require that the user explicitly specify --disable-gnutls.
  
  2) The PKG_CHECK_MODULES macro isn't generally available on all systems.
   Not just OS X, as it turns out.  A Google search of several forums
  seems to indicate that it isn't present on FreeBSD as well.
  
  3) The PKG_CHECK_MODULES macro always generates a fatal condition if GNU
  TLS isn't available.
  
  
  I believe that the behavior should be as follows:
  
  -- A mechanism other than PKG_CHECK_MODULES should be used to detect the
  presence of GNU TLS (AC_CHECK_LIB or AC_CHECK_HEADER, probably.)
  
  -- If GNU TLS is present, then it should be enabled by default.  If it
  is not present, then it should be disabled by default.
  
  -- If GNU TLS is present, then the user can specify --disable-gnutls to
  disable it.
  
  
  An alternative solution:
  
  -- PKG_CHECK_MODULES should be made non-fatal, if possible, or ...
  -- Enabling GNU TLS support should not be the default.
  
  -- A local version of PKG_CHECK_MODULES should be included in our build
  for use on systems that do not provide it.
  
  
  How to go about doing any of the above is left as an exercise for the
  reader.
  
  DRC
 
 --
 ___
 Tigervnc-devel mailing list
 Tigervnc-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/tigervnc-devel

-- 
Adam Tkac, Red Hat, Inc.

--
___
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel


Re: [Tigervnc-devel] building with MinGW

2010-05-03 Thread Antoine Martin

 There is also /usr/bin/mingw32-configure script which I use on Fedora.
 Simply call it instead of ./configure in the tigervnc/trunk directory :)

Thx, re-re-cap (for others):

yum install mingw32-gcc-c++ mingw32-w32api mingw32-gcc mingw32-binutils
cd tigervnc/trunk
autoreconf -fi
/usr/bin/mingw32-configure


 Then I found your post:
 http://www.mail-archive.com/tigervnc-devel@lists.sourceforge.net/msg00434.html
 Which points to this patch:
 http://sourceforge.net/tracker/?func=detailatid=302435aid=2877129group_id=2435
 Which has already been merged into Fedora 12's version of mingw.
  
 You are incorrect, that patch isn't available in Fedora 12. You have
 to apply it manually and then rerun configure.
We are talking about this patch, right?
http://atkac.fedorapeople.org/w32api-tigervnc.patch

I must have applied parts of it before and forgotten about it.
Anyway, it applies except for the last part: mingw32/lib/shell32.c is 
nowhere to be found.
I even did a full yum install mingw32* to be sure.
In fact, doing a google search turns up nothing at all (except this patch!):
http://www.google.com/search?hl=enq=mingw32/lib/shell32.c;

Please advise. Do I need to pull mingw from source? How is that going to 
play with my yum installed copies...

Thanks
Antoine


   You should see
 following line when you run configure with Windows host:

 ...
 checking whether CLSID_ActiveDesktop is declared... yes
 ...


 So then I added:
 #includeshlguid.h
 To CleanDesktop.cxx
 and:
 include ./$(DEPDIR)/librfb_win32_la-CleanDesktop.Plo
 to the Makefile (although it seemed to build without this line - it
 seems correct to have it)
 And rfb_win32 built successfully at last with the CleanDesktop stuff.
  
 winvnc4 should be compilable without modifications.

 Regards, Adam




--
___
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel


Re: [Tigervnc-devel] building with MinGW

2010-05-03 Thread Adam Tkac
On Mon, May 03, 2010 at 06:58:15PM +0700, Antoine Martin wrote:
 Then I found your post:
 http://www.mail-archive.com/tigervnc-devel@lists.sourceforge.net/msg00434.html
 Which points to this patch:
 http://sourceforge.net/tracker/?func=detailatid=302435aid=2877129group_id=2435
 Which has already been merged into Fedora 12's version of mingw.
 You are incorrect, that patch isn't available in Fedora 12. You have
 to apply it manually and then rerun configure.
 We are talking about this patch, right?
 http://atkac.fedorapeople.org/w32api-tigervnc.patch
 
 I must have applied parts of it before and forgotten about it.
 Anyway, it applies except for the last part: mingw32/lib/shell32.c
 is nowhere to be found.
 I even did a full yum install mingw32* to be sure.
 In fact, doing a google search turns up nothing at all (except this patch!):
 http://www.google.com/search?hl=enq=mingw32/lib/shell32.c;
 
 Please advise. Do I need to pull mingw from source? How is that
 going to play with my yum installed copies...

You must rebuild the mingw32-w32api package with that patch. And you
will have to do it every time when mingw32-w32api is updated.
To be honest it might be better to include the patch in the Fedora
distribution but I generally prefer to go things to the upstream
first.

You can read how to rebuild rpm on
http://www.linuxweblog.com/patch-rebuild-rpm, for example. Note that
%_topdir macro is not /usr/src/redhat/ but ~/rpmbuild/. Simply put the
patch to ~/rpmbuild/SOURCES directory and apply it as written in
chapter 6. Adding the patch to the package.

You can get the latest source rpm from
http://kojipkgs.fedoraproject.org/packages/mingw32-w32api/3.13/5.fc13/src/mingw32-w32api-3.13-5.fc13.src.rpm.

Feel free to ask me if you hit any problem.

Regards, Adam

-- 
Adam Tkac, Red Hat, Inc.

--
___
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel


Re: [Tigervnc-devel] building with MinGW

2010-05-03 Thread Antoine Martin
On 05/03/2010 07:22 PM, Adam Tkac wrote:
 On Mon, May 03, 2010 at 06:58:15PM +0700, Antoine Martin wrote:

 Then I found your post:
 http://www.mail-archive.com/tigervnc-devel@lists.sourceforge.net/msg00434.html
 Which points to this patch:
 http://sourceforge.net/tracker/?func=detailatid=302435aid=2877129group_id=2435
 Which has already been merged into Fedora 12's version of mingw.
  
 You are incorrect, that patch isn't available in Fedora 12. You have
 to apply it manually and then rerun configure.

 We are talking about this patch, right?
 http://atkac.fedorapeople.org/w32api-tigervnc.patch

 I must have applied parts of it before and forgotten about it.
 Anyway, it applies except for the last part: mingw32/lib/shell32.c
 is nowhere to be found.
 I even did a full yum install mingw32* to be sure.
 In fact, doing a google search turns up nothing at all (except this patch!):
 http://www.google.com/search?hl=enq=mingw32/lib/shell32.c;

 Please advise. Do I need to pull mingw from source? How is that
 going to play with my yum installed copies...
  
 You must rebuild the mingw32-w32api package with that patch. And you
 will have to do it every time when mingw32-w32api is updated.
 To be honest it might be better to include the patch in the Fedora
 distribution but I generally prefer to go things to the upstream
 first.

Fair enough.
 You can read how to rebuild rpm on
 http://www.linuxweblog.com/patch-rebuild-rpm, for example. Note that
 %_topdir macro is not /usr/src/redhat/ but ~/rpmbuild/. Simply put the
 patch to ~/rpmbuild/SOURCES directory and apply it as written in
 chapter 6. Adding the patch to the package.

 You can get the latest source rpm from
 http://kojipkgs.fedoraproject.org/packages/mingw32-w32api/3.13/5.fc13/src/mingw32-w32api-3.13-5.fc13.src.rpm.

 Feel free to ask me if you hit any problem.

Thanks, that worked. Got the:
checking whether CLSID_ActiveDesktop is declared... yes
And the .exe built fine.

Is there a make install somewhere I've missed? I had to select the DLL 
set by hand.
(the tigervnc.iss seems to be based on the VS build?)

The resulting binary will display the help text when run via wine:
wine winvnc4.exe -h
But will not display anything when running native.
It seems to run though, listening on :5900 at least - but the tray icon 
is missing and I can't seem to connect.. (No password configured..)
And if I specify *any* command line arguments, it dies (sometimes 
popping up Dr Watson)
Probably still missing something..

Thanks
Antoine
 Regards, Adam




--
___
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel