Re: [5][PATCH] BUILDING.txt and build.properties.default refer to old JTA version

2002-08-12 Thread Steve Downey

On Monday 12 August 2002 03:22 pm, you wrote:

> After this patch, the build is slightly broken if Tyrex isn't available. It
> appears that compilation of  org/apache/naming/factory/TyrexFactory.java
> and TyrexResourceFactory are conditioned only on JTA. Patch to follow.

Patch is NOT to have full.dist=on in ~/build.properties. 

~/build.properties is nice when you're only building a group of related 
projects with the same environment. With unrelated projects, it's a source of 
much strangeness.

I worked with one guy who argued for an /etc/build.properties. Fortunately 
coworkers kept me for strangling him.




--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [5][PATCH] BUILDING.txt and build.properties.default refer to old JTA version

2002-08-12 Thread Steve Downey

With patch actually attached ...

On Monday 12 August 2002 03:22 pm, you wrote:
> BUILDING.txt and the default build properties refer to an older version of
> the Java Transaction API. The current version is 1.0.1a, where the old
> version was 1.0.1. The are semantically the same, just documentation
> changes. The current version of the jta jar file is named jta.jar, rather
> than
> jta-spec1_0_1.jar
>
> I'm trying to get the Tomcat 5 build to be as smooth as possible out of the
> box. 'ant download' makes most of it very straightforward. For optional
> components, it's a little tougher, as many of them are behind license
> screens.
>
> Several of the APIs that Sun provides also don't define a directory for
> themselves, such as JNDI and JTA. For these I've always placed them in a
> directory with the same name as the zip file, sans .zip.
>
> After this patch, the build is slightly broken if Tyrex isn't available. It
> appears that compilation of  org/apache/naming/factory/TyrexFactory.java
> and TyrexResourceFactory are conditioned only on JTA. Patch to follow.


Index: BUILDING.txt
===
RCS file: /home/cvspublic/jakarta-tomcat-5/BUILDING.txt,v
retrieving revision 1.14
diff -u -r1.14 BUILDING.txt
--- BUILDING.txt	7 Aug 2002 14:14:03 -	1.14
+++ BUILDING.txt	12 Aug 2002 19:11:06 -
@@ -337,12 +337,13 @@
 
 (18) Download and Install the Java Transaction APIs
 
-* Download the Java Transaction API (JTA) package (version 1.0.1) from:
+* Download the Java Transaction API (JTA) package (version 1.0.1a) from:
 
 http://java.sun.com/products/jta/
 
 * Unpack the package into a convenient location so that it resides in its
-  own subdirectory.
+  own subdirectory. By default, the Tomcat build expects this to be
+  {base.path}/jta-1_0_1a/
 
 
 (19) Download and Install the Struts Binary Distribution
Index: build.properties.default
===
RCS file: /home/cvspublic/jakarta-tomcat-5/build.properties.default,v
retrieving revision 1.18
diff -u -r1.18 build.properties.default
--- build.properties.default	8 Aug 2002 05:47:01 -	1.18
+++ build.properties.default	12 Aug 2002 19:11:06 -
@@ -197,9 +197,9 @@
 
 
 # - Java Transaction API (JTA), version 1.0.1 or later -
-jta.home=${base.path}/jta-spec1_0_1
+jta.home=${base.path}/jta-1_0_1a
 jta.lib=${jta.home}
-jta.jar=${jta.lib}/jta-spec1_0_1.jar
+jta.jar=${jta.lib}/jta.jar
 
 
 # - JUnit Unit Test Suite, version 3.7 or later -



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 


[5][PATCH] BUILDING.txt and build.properties.default refer to old JTA version

2002-08-12 Thread Steve Downey

BUILDING.txt and the default build properties refer to an older version of the 
Java Transaction API. The current version is 1.0.1a, where the old version 
was 1.0.1. The are semantically the same, just documentation changes. The 
current version of the jta jar file is named jta.jar, rather than 
jta-spec1_0_1.jar 

I'm trying to get the Tomcat 5 build to be as smooth as possible out of the 
box. 'ant download' makes most of it very straightforward. For optional 
components, it's a little tougher, as many of them are behind license 
screens.

Several of the APIs that Sun provides also don't define a directory for 
themselves, such as JNDI and JTA. For these I've always placed them in a 
directory with the same name as the zip file, sans .zip.

After this patch, the build is slightly broken if Tyrex isn't available. It 
appears that compilation of  org/apache/naming/factory/TyrexFactory.java and 
TyrexResourceFactory are conditioned only on JTA. Patch to follow. 





--
To unsubscribe, e-mail:   
For additional commands, e-mail: