Re: [tor-bugs] #11331 [Core Tor/Tor]: rewrite tor in rust-lang

[Tor Bug Tracker & Wiki]

#11331: rewrite tor in rust-lang
--+-
 Reporter:  cypherpunks   |  Owner:
 Type:  project   | Status:  new
 Priority:  Medium|  Milestone:  Tor: very long term
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by Sebastian):

 * cc: Sebastian (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #11331 [Core Tor/Tor]: rewrite tor in rust-lang

[Tor Bug Tracker & Wiki]

#11331: rewrite tor in rust-lang
--+-
 Reporter:  cypherpunks   |  Owner:
 Type:  project   | Status:  new
 Priority:  Medium|  Milestone:  Tor: very long term
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by frewsxcv):

 Update from Sebastian Hahn:

 https://lists.torproject.org/pipermail/tor-dev/2017-March/012088.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21845 [- Select a component]: Active Reader view

[Tor Bug Tracker & Wiki]

#21845: Active Reader view
--+-
 Reporter:  rick17|  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 Firefox has an add-on called Active Reader View. It partially works on
 Tor. I can get the reader to come up and show two elements on the left
 hand side tool bar: Close, and Control (font), then it re-directs back to
 the original article in Pocket. I searched about this and saw a bunch of
 developer pages about this and that, but I was confused.

 Is this supported? If so, how can I get my Tor browser to read
 (auditorily) to me?

 Thanks,
 Rick.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21625 [Applications/Tor Browser]: Review networking code for Firefox 52

[Tor Bug Tracker & Wiki]

#21625: Review networking code for Firefox 52
-+-
 Reporter:  gk   |  Owner:
 |  mikeperry
 Type:  task | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201703, ff52-esr,  |  Actual Points:
  tbb-7.0-must   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mikeperry):

 Stuff we should patch/disable:
  * FlyWeb (dom/flyweb/FlyWebService.cpp) - This is a mechanism for
 contacting local devices and interacting with them. It may not be fully
 implemented, but networking code is definitely here. Disable it.
  * dom/presentation/* and nsNetworkInfoService::ListNetworkAddresses - the
 Presentation API (for remote displays - https://developer.mozilla.org/en-
 US/docs/Web/API/Presentation_API). This needs to be disabled even if
 proxied, because it does ICE-style IP address discovery and advertisement.
  * ./dom/presentation/provider/MulticastDNSDeviceProvider.cpp - used by
 the Presentation API to announce itself (and maybe other stuff?). Make
 sure it gets disabled.
  * The Rust URL parser (third_party/rust/url/src/host.rs) has a
 to_socket_addrs and ToSocketAddrs methods. These should be patched out for
 safety and to remind us later, I think.
  * netwerk/dns/mdns/libmdns/fallback/MulticastDNS.jsm - more mDNS stuff
 that should be disabled.

 Android stuff that definitely leaks that we should fix (missing proxy
 params to HttpUrlConnection - these need to use the buildHttpConnection
 helper to get a proxy):
  * mobile/android/base/java/org/mozilla/gecko/feeds/FeedFetcher.java
  *
 mobile/android/base/java/org/mozilla/gecko/media/GeckoMediaDrmBridgeV21.java
  *
 mobile/android/base/java/org/mozilla/gecko/search/SearchEngineManager.java
  * mobile/android/thirdparty/com/keepsafe/switchboard/SwitchBoard.java

 That's it for the stuff that definitely needs patching. I'll post the
 other sets as soon as I can.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21625 [Applications/Tor Browser]: Review networking code for Firefox 52

[Tor Bug Tracker & Wiki]

#21625: Review networking code for Firefox 52
-+-
 Reporter:  gk   |  Owner:
 |  mikeperry
 Type:  task | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201703, ff52-esr,  |  Actual Points:
  tbb-7.0-must   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mikeperry):

 Ok, I'm done with the review. I conducted it a little different this time.
 I just did a 'git diff -U10 esr45 esr52' and focused primarily on the new
 lines, looking for various types of socket usage. (Things like the PR_
 calls, UDPSockets, SOCK_, etc). My review notes will be posted in the
 repo.

 I'm going to break the writeup down into categories on this ticket. First
 I'll list stuff that really needs to be patched. Then I'll list some stuff
 that we already patched that changed a bit (which may cause our patches to
 fail) that we should look at closely after patch application. Then I'll
 list stuff that it would be nice to have a second set of eyes confirm.

 We may also want someone to go over the android stuff again in more
 detail, as well.

 Will be posting the above mentioned sections one per comment here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21844 [Applications/Tor Browser]: Additional packages needed

[Tor Bug Tracker & Wiki]

#21844: Additional packages needed
--+--
 Reporter:  tom   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 I needed to add the following packages to get the build to work.

 `apt-get install python-cheetah kpartx`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21843 [Applications/Tor Browser]: Switching from `make alpha` to `make nightly` doesn't work

[Tor Bug Tracker & Wiki]

#21843: Switching from `make alpha` to `make nightly` doesn't work
--+--
 Reporter:  tom   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Switching from make alpha to make nightly gives this error:
 {{{
 updating: mac-langpacks/pt-BR.xpi (deflated 10%)
 You are not currently on a branch.
 Please specify which branch you want to merge with.
 See git-pull(1) for details.

 git pull  

 Makefile:97: recipe for target 'prep-nightly' failed
 make: *** [prep-nightly] Error 1
 }}}

 This can be traced to this:
 https://gitweb.torproject.org/builders/tor-browser-bundle.git/tree/gitian
 /fetch-inputs.sh#n258

 Because `make alpha` checked out a tag, `git pull` fails. We can detect a
 checkout tag with something like `git status | grep "HEAD detached"` and
 behave more intelligently.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17619 [Applications/Tor Messenger]: Tor Messenger timezone in chats

[Tor Bug Tracker & Wiki]

#17619: Tor Messenger timezone in chats
+---
 Reporter:  sukhbir |  Owner:
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Messenger  |Version:
 Severity:  Normal  | Resolution:  duplicate
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+---
Changes (by arlolra):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 This is being resolved in #21736

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21736 [Applications/Tor Messenger]: Do not keep account/timestamp when copy-pasting message containing an URL

[Tor Bug Tracker & Wiki]

#21736: Do not keep account/timestamp when copy-pasting message containing an 
URL
+--
 Reporter:  dgoulet |  Owner:  huyvq
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Messenger  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by arlolra):

 * owner:   => huyvq
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed whle trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed whle trying to
download a file
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  tbb-7.0-must, ff52-esr,  |  Actual Points:
  TorBrowserTeam201703, tbb-7.0-must-nightly |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Kathy and I tried to debug this problem. The main thing we learned is that
 we are not yet good at understanding e10s-related problems :)

 What we do know is that the main (chrome) process is killing the content
 process (which is associated with the tab where the download is
 initiated). Code inside the KillProcess() function within
 ipc/chromium/src/base/process_util_posix.cc sends a SIGTERM to the content
 process . But why? The key hint seems to be this log message:

  ###!!! [Parent][DispatchAsyncMessage] Error:
 PExternalHelperApp::Msg_DivertToParentUsing Route error: message sent to
 unknown actor ID

 I will attach a call stack that shows how the code gets there, but Kathy
 and I don't know the answer to the really important question: "Why?". Our
 best guess is that we should not be trying to use the prompt service from
 the chrome process at all, but that seems surprising.

 Does anyone know how we can learn more about what APIs can safely be used
 from which kind of process? Or maybe we should just ask some Mozilla
 engineers?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18291 [Applications/Tor Browser]: Don't use libfaketime anymore for building the Firefox part of Tor Browser

[Tor Bug Tracker & Wiki]

#18291: Don't use libfaketime anymore for building the Firefox part of Tor 
Browser
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-gitian, ff45-esr,|  Actual Points:
  TorBrowserTeam201605, GeorgKoppen201605|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Even though
 {{{
 +  # Those files are however not part of the files we ship.
 }}}
 maybe, it's better instead of adding comments like
 {{{
 +  # Since we stopped using libfaketime, the gcc, gmp, zlib, openssl,
 +  # libevent, mingw-w64 archives are no longer reproducible. The main
 +  # reason is that they include some .a archives which include
 timestamps.
 }}}
 start to use deterministic mode of binutils?
 https://wiki.debian.org/ReproducibleBuilds/TimestampsInStaticLibraries

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21748 [Obfuscation/Snowflake]: Snowflake breaks nightly builds as of March 15

[Tor Bug Tracker & Wiki]

#21748: Snowflake breaks nightly builds as of March 15
-+-
 Reporter:  gk   |  Owner:  arlolra
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Obfuscation/Snowflake|Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-7.0-must-nightly, tbb-gitian,|  Actual Points:
  TorBrowserTeam201703R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Okay, I applied the changes to `master` (commit
 38689af2a845dfa85765bf52e535c89476863378 and
 121de1ca7cbee29f34f99753a7948c7447e38965) and `hardened-builds` (commit
 45f6ab2698d447441095e8d388fba3a3aa855f57 and
 58801dcbb5d927d6eb35a328cb63d1912434a397). Thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21838 [Applications/Tor Browser]: Gitian VM creation fails on Ubuntu 16.x machines in the unmount step

[Tor Bug Tracker & Wiki]

#21838: Gitian VM creation fails on Ubuntu 16.x machines in the unmount step
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-gitian|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 As a temporary workaround, I uploaded VM images that you can be copied to
 the `gitian-builder` directory:
 https://people.torproject.org/~boklm/tmp/bug_21838/
 https://people.torproject.org/~boklm/tmp/bug_21838/sha256sums.txt
 https://people.torproject.org/~boklm/tmp/bug_21838/sha256sums.txt.asc

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21748 [Obfuscation/Snowflake]: Snowflake breaks nightly builds as of March 15

[Tor Bug Tracker & Wiki]

#21748: Snowflake breaks nightly builds as of March 15
-+-
 Reporter:  gk   |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Obfuscation/Snowflake|Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-7.0-must-nightly, tbb-gitian,|  Actual Points:
  TorBrowserTeam201703R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arlolra):

 > Do we still need export JAVA_HOME=/usr/lib/jvm/default-java in fetch-
 inputs.sh?

 I believe so.  It's needed for the calls to `gclient` there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21748 [Obfuscation/Snowflake]: Snowflake breaks nightly builds as of March 15

[Tor Bug Tracker & Wiki]

#21748: Snowflake breaks nightly builds as of March 15
-+-
 Reporter:  gk   |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Obfuscation/Snowflake|Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-7.0-must-nightly, tbb-gitian,|  Actual Points:
  TorBrowserTeam201703R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 There is a bunch of Java stuff going away. Do we still need `export
 JAVA_HOME=/usr/lib/jvm/default-java` in `fetch-inputs.sh`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17670 [Applications/Tor Browser]: Mac OSX mistakes Tor as Firefox default browser

[Tor Bug Tracker & Wiki]

#17670: Mac OSX mistakes Tor as Firefox default browser
--+--
 Reporter:  patrickbateman|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Immediate |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by SpH6308):

 same thing if default *exe for Tor set to Browser\Tor Browser\Tor\tor.exe?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21328 [Applications/Tor Browser]: Move to clang 3.8.0 for Tor Browser's clang-based macOS toolchain

[Tor Bug Tracker & Wiki]

#21328: Move to clang 3.8.0 for Tor Browser's clang-based macOS toolchain
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201703R, GeorgKoppen201703,  |
  tbb-7.0-must-nightly   |
Parent ID:  #21147   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * status:  new => needs_review
 * keywords:
 tbb-gitian, ff52-esr, tbb-7.0-must, TorBrowserTeam201703,
 GeorgKoppen201703, tbb-7.0-must-nightly
 =>
 tbb-gitian, ff52-esr, tbb-7.0-must, TorBrowserTeam201703R,
 GeorgKoppen201703, tbb-7.0-must-nightly


Comment:

 This makes sense, thanks. I just pushed `bug_21328_v4` (the new commit
 https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_21328_v4=b9ee73abc959b930186138ea203152d1773b24f8)
 with small changes and the one mentioned in comment:17.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21774 [Core Tor/Stem]: Fix CONN_BW event listening

[Tor Bug Tracker & Wiki]

#21774: Fix CONN_BW event listening
---+
 Reporter:  timonh |  Owner:  atagar
 Type:  defect | Status:  closed
 Priority:  Low|  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by atagar):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Sorry about the long delay! Fix merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21753 [Applications/Tor Browser]: Get rid of old GCC toolchain in pluggable transports macOS descriptor

[Tor Bug Tracker & Wiki]

#21753: Get rid of old GCC toolchain in pluggable transports macOS descriptor
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam21703R,|  Actual Points:
  GeorgKoppen201703, tbb-gitian  |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:2 gk]:
 > `bug_21753_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_21753_v3=d0465e4ce9e9fa13a46faae8c7401b5fb78582f8)
 in my public tor-browser-bundle repo has a fix for this bug.

 This patch looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13790 [Core Tor/Tor]: Refactor and add comments to new_route_len()

[Tor Bug Tracker & Wiki]

#13790: Refactor and add comments to new_route_len()
-+-
 Reporter:  dgoulet  |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  026-deferrable,  |  Actual Points:
  tor-03-unspecified-201612  |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21842 [Core Tor/Tor]: Remove tor-checkkey

[Tor Bug Tracker & Wiki]

#21842: Remove tor-checkkey
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  0
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * type:  defect => enhancement


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21842 [Core Tor/Tor]: Remove tor-checkkey

[Tor Bug Tracker & Wiki]

#21842: Remove tor-checkkey
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  0
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => 0


Comment:

 See branch `ticket21842` in my public repository.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21842 [Core Tor/Tor]: Remove tor-checkkey

[Tor Bug Tracker & Wiki]

#21842: Remove tor-checkkey
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21842 [Core Tor/Tor]: Remove tor-checkkey

[Tor Bug Tracker & Wiki]

#21842: Remove tor-checkkey
--+
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 We currently build a tor-checkkey binary in src/tools.  It extracts and
 prints the modulus from a PEM-encoded RSA public key.

 Long ago, we added it on order to help detect and clean up the effects of
 the Debian OpenSSL RNG bug (CVE-2008-0166).  But that's nearly a decade
 ago; maybe we can let this code get removed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21834 [Applications/Tor Browser]: ExcludeExitNodes settings ignored

[Tor Bug Tracker & Wiki]

#21834: ExcludeExitNodes settings ignored
--+--
 Reporter:  JoeDiFostar   |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by JoeDiFostar):

 Replying to [comment:7 gk]:
 > This might be the same as #13051. I wonder if that is Windows specific.
 JoeDiFostar: Do you have the option to test your setup on a non-Windows
 machine and report back if there are similar issues?

 Absolutely,  will test on  Debian Jessie and report.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #9145 [Applications/Tor Browser]: TBB 3.0a1 crashes on startup on Win7

[Tor Bug Tracker & Wiki]

#9145: TBB 3.0a1 crashes on startup on Win7
-+-
 Reporter:  dope457  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-crash, Windows, Hardware-|  Actual Points:
  acceleration, fuck-mingw   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 To add some explicit instructions here as this gets referenced often. For
 a built browser suffering from the problem, on Windows:

 1. Copy browser/omni.ja twice, once to omni.ja-backup and once to omni.zip
 2. Unzip the zip file using Windows built-in Zip Extractor. ([0] Indicates
 that other zip programs will not work correctly)
 3. In the extracted omni/ folder, edit default/preferences/firefox.js and
 add ``pref("gfx.direct2d.disabled",true);``
 4. Repackage the folder by running (in the extracted omni/ folder) ``zip
 -qr9XD omni.ja *`` - I used the cygwin zip package to do this. [0]
 indicates that other packaging methods will not work.
 5. move the repackages omni.ja over top the original (you have the back up
 right?!) and test!

 I was able to get it running with only gfx.direct2d.disabled - maybe one
 might need the layers.acceleration.disabled set to true too?

 [0] https://developer.mozilla.org/en-
 US/docs/Mozilla/About_omni.ja_%28formerly_omni.jar%29

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20680 [Applications/Tor Browser]: Rebase Tor Browser patches to 52 ESR

[Tor Bug Tracker & Wiki]

#20680: Rebase Tor Browser patches to 52 ESR
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201703, tbb-7.0-must-nightly |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Here is the next batch:

 `43d4fc730a6216433c059345111c5fe9d11deae6`: looks good to me. mcs/brade
 could you have a second look?
 `2b52030695f445b2f924a4442efeb6d49ee9fde2`: good
 `8faf75d71705cdf891e6bedfc10ef8e93429d7fa`: good
 `88e6c45cd16afdc26c1ec0ed7c887e5844c0374e`: good
 `7ba9b10dab17c534933ec3441ff646b236445fbf`: good
 `e8503c86d6ce4c286f54488b95f63447f9184c97`: good

 `1f1afb99079173c4ceff978cdb17ec74e8c39af4`:

 1) the last bit in setLoginSavingEnabled() seems to be missing?

 `facd4d52edcbe48478f4b27f8f59b6579b02cc67`:

 1) Why do we have:

 {{{
 +nsCOMPtr profile;
 +rv = aProfileSvc->GetProfileByName(nsDependentCString(arg),
 +   getter_AddRefs(profile));
 +if (NS_SUCCEEDED(rv)) {
 +  ProfileStatus status = CheckProfileWriteAccess(profile);
 +  if (PROFILE_STATUS_OK != status)
 +return ProfileErrorDialog(profile, status, nullptr, aNative,
 aResult);
 +}
 }}}

 now? It seems the relevant code around it does not have changed enough
 that this is self-explaining to me.

 `800a82cf4133635e6b709013bbb95ccc3ae1a5e7`:

 1) Why is MOZ_UTF16() not good enough anymore? Does the code not build
 with it anymore?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16426 [Metrics/Onionoo]: Add parse history for tarballs in archive directory

[Tor Bug Tracker & Wiki]

#16426: Add parse history for tarballs in archive directory
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 PS:  I assume we decided at some point to not add tests for the history
 tracking functionality?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16426 [Metrics/Onionoo]: Add parse history for tarballs in archive directory

[Tor Bug Tracker & Wiki]

#16426: Add parse history for tarballs in archive directory
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 Looks fine passes tests and checks.  Merge ready.

 I added some quick tweaks to things I noticed in the reviewed classes.
 Please review three more commits in
 [https://gitweb.torproject.org/user/iwakeh/onionoo.git?h=task-16426 my
 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21841 [Core Tor/Tor]: Refactor: include openssl headers from fewer modules

[Tor Bug Tracker & Wiki]

#21841: Refactor: include openssl headers from fewer modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:| Points:  .3
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 (Note that there are still openssl includes in some of the donna headers,
 but that they are no longer actually used.  Also note that tor-gencert and
 tor-checkkey in src/tool/ still use openssl APIs directly.  I'm not
 changing those right now.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21841 [Core Tor/Tor]: Refactor: include openssl headers from fewer modules

[Tor Bug Tracker & Wiki]

#21841: Refactor: include openssl headers from fewer modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:| Points:  .3
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => .3


Comment:

 See branch 'isolate_openssl' in my public repo.  I think it improves our
 code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21841 [Core Tor/Tor]: Refactor: include openssl headers from fewer modules

[Tor Bug Tracker & Wiki]

#21841: Refactor: include openssl headers from fewer modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  .3
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21841 [Core Tor/Tor]: Refactor: include openssl headers from fewer modules

[Tor Bug Tracker & Wiki]

#21841: Refactor: include openssl headers from fewer modules
--+
 Reporter:  nickm |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:  .3|   Reviewer:
  Sponsor:|
--+
 When possible, we should make it so that no part of our code other than
 crypto*.c and tortls*.c actually depend on openssl APIs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21328 [Applications/Tor Browser]: Move to clang 3.8.0 for Tor Browser's clang-based macOS toolchain

[Tor Bug Tracker & Wiki]

#21328: Move to clang 3.8.0 for Tor Browser's clang-based macOS toolchain
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201703, GeorgKoppen201703,   |
  tbb-7.0-must-nightly   |
Parent ID:  #21147   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by boklm):

 The reason for this diff seems to be that the path to `libfaketime.so.1`
 changed between wheezy and jessie.

 Debian wheezy: /usr/lib/faketime/libfaketime.so.1
 Debian jessie: /usr/lib/x86_64-linux-gnu/faketime/libfaketime.so.1

 So we need to fix the libfaketime path there:
 https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/tree/gitian/descriptors/mac/gitian-tor.yml?h=bug_21328_v3#n73

 Fixing this path removed the diff in my test with rbm (although I did not
 try with the other changes yet).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21840 [Internal Services/Tor Sysadmin Team]: subdomain for test gitlab machine

[Tor Bug Tracker & Wiki]

#21840: subdomain for test gitlab machine
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by hiro):

 @dgoulet, I didn't update the gitlab original ticket since I was under the
 assumption that Greenhost was our test run and that we would need to get
 back to that ticket to do the proper tpo implementation. This is also why
 I suggested this machine to get a tp.net domain.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21748 [Obfuscation/Snowflake]: Snowflake breaks nightly builds as of March 15

[Tor Bug Tracker & Wiki]

#21748: Snowflake breaks nightly builds as of March 15
-+-
 Reporter:  gk   |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Obfuscation/Snowflake|Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-7.0-must-nightly, tbb-gitian,|  Actual Points:
  TorBrowserTeam201703R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-7.0-must-nightly => tbb-7.0-must-nightly, tbb-gitian,
 TorBrowserTeam201703R
 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16426 [Metrics/Onionoo]: Add parse history for tarballs in archive directory

[Tor Bug Tracker & Wiki]

#16426: Add parse history for tarballs in archive directory
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16426 [Metrics/Onionoo]: Add parse history for tarballs in archive directory

[Tor Bug Tracker & Wiki]

#16426: Add parse history for tarballs in archive directory
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  assigned
 Priority:  Low  |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * owner:   => metrics-team
 * status:  needs_review => assigned
 * severity:   => Normal


Comment:

 Please find
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-16426
 my task-16426 branch] with an amended patch and another commit that fixes
 a bug that I found while testing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21328 [Applications/Tor Browser]: Move to clang 3.8.0 for Tor Browser's clang-based macOS toolchain

[Tor Bug Tracker & Wiki]

#21328: Move to clang 3.8.0 for Tor Browser's clang-based macOS toolchain
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201703, GeorgKoppen201703,   |
  tbb-7.0-must-nightly   |
Parent ID:  #21147   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by boklm):

 It looks like the update to jessie is causing the diff.

 I did some test rebuilds of tor, openssl and libevent using rbm (the
 current master branch is reproducible on OSX).

 I used the following patch to update to jessie:
 {{{
 diff --git a/rbm.conf b/rbm.conf
 index e206193..0ffdb22 100644
 --- a/rbm.conf
 +++ b/rbm.conf
 @@ -166,7 +166,7 @@ targets:
torbrowser-osx-x86_64:
  - osx-x86_64
osx-x86_64:
 -distribution: Debian-7.11
 +distribution: Debian-8.7
  arch: x86_64
  var:
osx: 1
 }}}

 And I built the tor compenent using this command:
 {{{
 ./rbm/rbm build tor --target alpha --target torbrowser-osx-x86_64
 }}}

 After doing two builds, cleaning tor, openssl and libevent between the two
 builds, I get a non-matching tor binary:
 https://people.torproject.org/~boklm/tmp/bug_21328/move-jessie/build1/
 https://people.torproject.org/~boklm/tmp/bug_21328/move-jessie/build2/

 In build3 and build4, I did two builds of the tor component only (without
 cleaning openssl and libevent between them), and still get a non-matching
 tor binary:
 https://people.torproject.org/~boklm/tmp/bug_21328/move-jessie/build3/
 https://people.torproject.org/~boklm/tmp/bug_21328/move-jessie/build4/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21840 [Internal Services/Tor Sysadmin Team]: subdomain for test gitlab machine

[Tor Bug Tracker & Wiki]

#21840: subdomain for test gitlab machine
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by dgoulet):

 +1 for now.

 `gitlab.torproject.org` seems the right way to do this for now since this
 machine would be our "trial run" (for network team) and then if we like
 it, we can always change it after if we want something more "broad" in the
 name.

 @hiro, did we explain to weasel and qbi what we want to do with that
 Gitlab after the network team meeting in Amsterdam?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21748 [Obfuscation/Snowflake]: Snowflake breaks nightly builds as of March 15

[Tor Bug Tracker & Wiki]

#21748: Snowflake breaks nightly builds as of March 15
---+--
 Reporter:  gk |  Owner:  arlolra
 Type:  defect | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Major  | Resolution:
 Keywords:  tbb-7.0-must-nightly   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by arlolra):

 > Do you feel this is ready for review now?

 Yes, I do.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21748 [Obfuscation/Snowflake]: Snowflake breaks nightly builds as of March 15

[Tor Bug Tracker & Wiki]

#21748: Snowflake breaks nightly builds as of March 15
---+--
 Reporter:  gk |  Owner:  arlolra
 Type:  defect | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Major  | Resolution:
 Keywords:  tbb-7.0-must-nightly   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by gk):

 Replying to [comment:14 arlolra]:
 > Yup, matches.
 >
 > {{{
 > $ shasum -a 256 tor-browser-linux32-7.0a2_ar.mar
 > 6385850447978cde1264fe10fd18dfd5c335ea20fac3f6c874aa969bd9511aad  tor-
 browser-linux32-7.0a2_ar.mar
 > $ shasum -a 256 tor-browser-linux32-7.0a2_en-US.tar.xz
 > e48d4cd91cf0e64721e44e2c35835cd794e07095cf251e77f5bc21ad29f6af30  tor-
 browser-linux32-7.0a2_en-US.tar.xz
 > }}}

 Good. Do you feel this is ready for review yet?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21328 [Applications/Tor Browser]: Move to clang 3.8.0 for Tor Browser's clang-based macOS toolchain

[Tor Bug Tracker & Wiki]

#21328: Move to clang 3.8.0 for Tor Browser's clang-based macOS toolchain
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201703, GeorgKoppen201703,   |
  tbb-7.0-must-nightly   |
Parent ID:  #21147   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Replying to [comment:14 boklm]:
 > Replying to [comment:12 gk]:
 > >
 > > boklm: Can you take that one from here?
 > Ok, I'm currently doing some test builds to find which change is causing
 the diff.
 >
 > In your tests, was the tor binary the only file that was not
 reproducible, or did it affect other parts too (such as firefox)?

 Just the tor binary.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21748 [Obfuscation/Snowflake]: Snowflake breaks nightly builds as of March 15

[Tor Bug Tracker & Wiki]

#21748: Snowflake breaks nightly builds as of March 15
---+--
 Reporter:  gk |  Owner:  arlolra
 Type:  defect | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Major  | Resolution:
 Keywords:  tbb-7.0-must-nightly   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by arlolra):

 Yup, matches.

 {{{
 $ shasum -a 256 tor-browser-linux32-7.0a2_ar.mar
 6385850447978cde1264fe10fd18dfd5c335ea20fac3f6c874aa969bd9511aad  tor-
 browser-linux32-7.0a2_ar.mar
 $ shasum -a 256 tor-browser-linux32-7.0a2_en-US.tar.xz
 e48d4cd91cf0e64721e44e2c35835cd794e07095cf251e77f5bc21ad29f6af30  tor-
 browser-linux32-7.0a2_en-US.tar.xz
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21840 [Internal Services/Tor Sysadmin Team]: subdomain for test gitlab machine

[Tor Bug Tracker & Wiki]

#21840: subdomain for test gitlab machine
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Hi,
 I think it would be a good idea if we could have a tp.net subdomain for
 our testing gitlab machine.
 IP: 37.218.242.159
 Suggested domain gitlab.torproject.net
 What do you think?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21272 [Metrics]: Onionperf deployment

[Tor Bug Tracker & Wiki]

#21272: Onionperf deployment
-+--
 Reporter:  hiro |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by hiro):

 Here is an example:

 @type torperf 1.0
 CONNECT=1490960319.10 DATACOMPLETE=1490960321.08 DATAPERC0=1490960319.56
 DATAPERC10=1490960319.98 DATAPERC100=1490960321.08
 DATAPERC20=1490960320.19 DATAPERC30=1490960320.36 DATAPERC40=1490960320.46
 DATAPERC50=1490960320.56 DATAPERC60=1490960320.68 DATAPERC70=1490960320.80
 DATAPERC80=1490960320.92 DATAPERC90=1490960321.04
 DATAREQUEST=1490960319.31 DATARESPONSE=1490960319.52 DIDTIMEOUT=0
 ENDPOINTLOCAL=localhost:127.0.0.1:46700
 ENDPOINTPROXY=localhost:127.0.0.1:33806
 ENDPOINTREMOTE=37.218.247.40:37.218.247.40:80 FILESIZE=1048576
 HOSTNAMELOCAL=op-nl HOSTNAMEREMOTE=op-nl LAUNCH=0.0
 NEGOTIATE=1490960319.10 READBYTES=1048642 REQUEST=1490960319.10
 RESPONSE=1490960319.31 SOCKET=1490960319.10 SOURCE=op-nl
 START=1490960319.10 WRITEBYTES=53

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21328 [Applications/Tor Browser]: Move to clang 3.8.0 for Tor Browser's clang-based macOS toolchain

[Tor Bug Tracker & Wiki]

#21328: Move to clang 3.8.0 for Tor Browser's clang-based macOS toolchain
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201703, GeorgKoppen201703,   |
  tbb-7.0-must-nightly   |
Parent ID:  #21147   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by boklm):

 Replying to [comment:12 gk]:
 >
 > boklm: Can you take that one from here?
 Ok, I'm currently doing some test builds to find which change is causing
 the diff.

 In your tests, was the tor binary the only file that was not reproducible,
 or did it affect other parts too (such as firefox)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21272 [Metrics]: Onionperf deployment

[Tor Bug Tracker & Wiki]

#21272: Onionperf deployment
-+--
 Reporter:  hiro |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Can you trigger generation of .tpf files without having to wait for the
 daily cronjob to do that?  Then we could check if it's really using port
 80 and telling us about it.

 Removing old data once we're sure it's buggy is probably a good idea.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21839 [HTTPS Everywhere/EFF-HTTPS Everywhere]: "Amazon.in (partial)" is partially broken

[Tor Bug Tracker & Wiki]

#21839: "Amazon.in (partial)" is partially broken
---+--
 Reporter:  cypherpunks|  Owner:  jsha
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  HTTPS Everywhere/EFF-HTTPS Everywhere  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+--
 Example page:-
 http://www.amazon.in/dp/B00W0VBOH0/ref=twister_dp_update?_encoding=UTF8=1

 When trying to select sizes or colors, the page fails to update with https
 everywhere enabled on firefox.

 This is due to this xhr request being clobbered by jquery/cors.

 For some reason the request method switches to OPTIONS instead of GET when
 the below xhr request is upgraded from http to https.

 https://www.amazon.in/gp/twister/ajaxv2?sid=

 The amazon server responds with a 405 for an OPTIONS request.

 Need to add this exclusion pattern.

 

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21272 [Metrics]: Onionperf deployment

[Tor Bug Tracker & Wiki]

#21272: Onionperf deployment
-+--
 Reporter:  hiro |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by hiro):

 This is now implemented after changing the supported kernel in all 3
 instances. I am seeing successful transfers. It is probably a good idea to
 clean up old logs with no transfers and wrong ports in the measurements.
 I'll do this starting from tomorrow. Please let me know if you prefer
 otherwise.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20451 [Obfuscation/meek]: The communication stream of managed proxy '/usr/bin/meek-client' is 'closed'

[Tor Bug Tracker & Wiki]

#20451: The communication stream of managed proxy '/usr/bin/meek-client' is
'closed'
--+--
 Reporter:  tagener-noisu |  Owner:  dcf
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Obfuscation/meek  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dcf):

 * status:  reopened => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20451 [Obfuscation/meek]: The communication stream of managed proxy '/usr/bin/meek-client' is 'closed'

[Tor Bug Tracker & Wiki]

#20451: The communication stream of managed proxy '/usr/bin/meek-client' is
'closed'
--+--
 Reporter:  tagener-noisu |  Owner:  dcf
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:
Component:  Obfuscation/meek  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dcf):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:7 tnoisu]:
 > Hi, I can't login into my old account ''tagener-noisu'', so I have
 created another one. The problem was that meek wasn't able to create a log
 file in the working directory. I've changed the log path like this `--log
 /tmp/meek-client.log` to fix it. I think that meek should just work
 without logging if it couldn't create a log file. Should I report this
 issue to developer's github?

 I'm the developer so this is the right place to report it. Sorry for the
 delay.

 I don't like the idea of silently continuing if the log file fails to
 open. The way it fails now is pretty bad though, because it leaves no
 trace of an error message.

 It would be good if an error message appeared in tor's log, even if the
 pluggable transport can't write its own log file. Unfortunately, the
 [https://spec.torproject.org/pt-spec pluggable transports spec] doesn't
 really give us a way to report general errors. We could abuse the
 `CMETHOD-ERROR` or `PROXY-ERROR` messages; those appear in tor's log.
 `CMETHOD-ERROR` appears like this:
 {{{
 [warn] Client managed proxy encountered a method error. (meek error
 opening log file: open meek-client.log: permission denied)
 [warn] Managed proxy at './meek-client' failed the configuration protocol
 and will be destroyed.
 }}}
 `PROXY-ERROR` appears like this:
 {{{
 [warn] Managed proxy failed to configure the pluggable transport's
 outgoing proxy. (error opening log file: open meek-client.log: permission
 denied)
 [warn] Managed proxy at './meek-client' failed the configuration protocol
 and will be destroyed.
 }}}

 Of these two options, `CMETHOD-ERROR` seems better than `PROXY-ERROR`
 because it won't add a misleading message about a proxy in the log. It's
 not totally correct because we're not supposed to emit a `CMETHOD-ERROR`
 unless we're asked for a specific client method, and we would be emitting
 this error very early, before even looking at the list of client methods.
 However, I don't think it will be a problem in practice.

 attachment:0001-Emit-a-CMETHOD-ERROR-or-SMETHOD-ERROR-when-failing-t.patch
 is an example patch for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21834 [Applications/Tor Browser]: ExcludeExitNodes settings ignored

[Tor Bug Tracker & Wiki]

#21834: ExcludeExitNodes settings ignored
--+--
 Reporter:  JoeDiFostar   |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  needs_information => assigned
 * owner:   => tbb-team


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21834 [Applications/Tor Browser]: ExcludeExitNodes settings ignored

[Tor Bug Tracker & Wiki]

#21834: ExcludeExitNodes settings ignored
--+---
 Reporter:  JoeDiFostar   |  Owner:
 Type:  defect| Status:  needs_information
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * version:  Tor: 0.2.9.10 =>


Comment:

 This might be the same as #13051. I wonder if that is Windows specific.
 JoeDiFostar: Do you have the option to test your setup on a non-Windows
 machine and report back if there are similar issues?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21748 [Obfuscation/Snowflake]: Snowflake breaks nightly builds as of March 15

[Tor Bug Tracker & Wiki]

#21748: Snowflake breaks nightly builds as of March 15
---+--
 Reporter:  gk |  Owner:  arlolra
 Type:  defect | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Major  | Resolution:
 Keywords:  tbb-7.0-must-nightly   |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by gk):

 Replying to [comment:12 arlolra]:
 > That seemed to work.  Let's see if you have some matching,
 >
 > {{{
 > ...
 > d34b4d98accb38c0f9e50178c6f1b473128e8cb51d10199b1afdc0a03041cd50  tor-
 browser-linux64-7.0a2_ar.mar
 > 4f922462983456bbeca4187d56c04a239e8a65a00e4d6762010bcfa26dc48af1  tor-
 browser-linux64-7.0a2_ar.tar.xz
 > 93ab3c2b9cf7ba23090a39a6679aeecd923c31714747c8e1ed4cebed101b70fb  tor-
 browser-linux64-7.0a2_de.mar
 > 752ef758e23970aeff7011269064e07e4921bb4d8e2a19f68ff3b36723abbdda  tor-
 browser-linux64-7.0a2_de.tar.xz
 > 0bf42106f2ec9d4c2cee689b5c8293449fbb2915c6e52c47e564f8cd7da26c3d  tor-
 browser-linux64-7.0a2_en-US.mar
 > 1d673966ab4561ac75fde485b0481c0cb128bbda882f284b638949df995412e0  tor-
 browser-linux64-7.0a2_en-US.tar.xz
 > ...
 > }}}

 Looks good. Do you have by chance some 32bit SHA256 sums as well? I have
 {{{
 ...
 6385850447978cde1264fe10fd18dfd5c335ea20fac3f6c874aa969bd9511aad  tor-
 browser-linux32-7.0a2_ar.mar
 50c23f7f628de2849ee52471f8cb9069b32c4238264e95757f28f844abf9f717  tor-
 browser-linux32-7.0a2_ar.tar.xz
 edcbf82362931dfd3a950ff9c6d564ca74c2c0929293551e3124366b2c5dd831  tor-
 browser-linux32-7.0a2_de.mar
 6fdfd3cea6a39c9003ee66900696244ceaa51f64984cb1f67016637c3560d6e6  tor-
 browser-linux32-7.0a2_de.tar.xz
 526f6c81e8c552cecbbb2a00ec7e3adbec2e365773c08ba30b98a7118fdd996a  tor-
 browser-linux32-7.0a2_en-US.mar
 e48d4cd91cf0e64721e44e2c35835cd794e07095cf251e77f5bc21ad29f6af30  tor-
 browser-linux32-7.0a2_en-US.tar.xz
 ...
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs