Re: [tor-bugs] #23444 [- Select a component]: test1

2017-09-08 Thread Tor Bug Tracker & Wiki
#23444: test1
--+-
 Reporter:  gerry33ge |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal| Resolution:  invalid
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by Dbryrtfbcbhgf):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 test1? reopen if this is a official test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23444 [- Select a component]: test1

2017-09-08 Thread Tor Bug Tracker & Wiki
#23444: test1
--+
 Reporter:  gerry33ge |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by gerry33ge):

 kein kommi

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23444 [- Select a component]: test1

2017-09-08 Thread Tor Bug Tracker & Wiki
#23444: test1
--+
 Reporter:  gerry33ge |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 test1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23443 [- Select a component]: TOR si blocca all'avvio

2017-09-08 Thread Tor Bug Tracker & Wiki
#23443: TOR si blocca all'avvio
--+
 Reporter:  kalikalikali  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by kalikalikali):

 * Attachment "LOG.rtf" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23443 [- Select a component]: TOR si blocca all'avvio

2017-09-08 Thread Tor Bug Tracker & Wiki
#23443: TOR si blocca all'avvio
--+
 Reporter:  kalikalikali  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Ciao come da oggetto, quando avvio tor  e clicco su connetti, la sbarra di
 avanzamento arriva quasi alla fine,poi si ferma per un bel po' di minuti
 finchè non esce questo errore

 Tor failed to establish a Tor network connection.

 Connecting to the Tor network failed (no route to host -
 171.25.193.131:443).

 Tra l'altro con questo mac avevo già installato e utilizzato Tor tempo fa
 Ho un MacBook pro con El capitan, connessione Vodafone fibra

 Io mi scuso se non è il posto giusto per chiedere supporto, ma spero di
 aver indovinato
 Grazie

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22952 [Applications/Tor Browser]: Tor Browser Arabic Fonts Issue !

2017-09-08 Thread Tor Bug Tracker & Wiki
#22952: Tor Browser Arabic Fonts Issue !
--+---
 Reporter:  sigma4111 |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-fingerprinting-fonts  |  Actual Points:
Parent ID:  #18097| Points:
 Reviewer:|Sponsor:
--+---

Comment (by arthuredelstein):

 Replying to [comment:11 sigma4111]:
 > Also, the convenent Arabic fonts that can make display of site O.K are
 the following:
 >
 > - Arial (default fonts used by site itself = it's real font)

 On Windows, Arial is whitelisted because it is a system font available by
 default on all Windows versions. Furthermore, there is no additional
 bundled Arabic font on the Windows version of Tor Browser. That means Tor
 Browser will display Arabic text with Arial on Windows. I checked the
 website and confirmed that the Arial is being used to display the Arabic
 text.

 I then compared Firefox and Tor Browser on Windows and the rendering of
 the site looks identical to me on both browsers. Arial is used in both
 cases.

 Finally I looked at Linux: the Arabic text looks like it is rendered in a
 very similar font size to the size used on the site in Windows. So I'm not
 sure I understand what the concern is here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22089 [Applications/Tor Browser]: Add Decentraleyes to slighten off a bit exit traffic and work around some CDNs blocking of Tor (was: Add Decentraleyes to stop tracking by large CDNs

2017-09-08 Thread Tor Bug Tracker & Wiki
#22089: Add Decentraleyes to slighten off a bit exit traffic and work around 
some
CDNs blocking of Tor
+--
 Reporter:  imageverif  |  Owner:  tbb-team
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-usability, tbb-performance  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

2017-09-08 Thread Tor Bug Tracker & Wiki
#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by asn):

 Pushed some improvements to the #23387 tests in my `bug23310_hsdir_sync`
 branch.
 Let's include those too when we make the final branch here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16596 [Metrics/ExoneraTor]: Change database queries towards making only a single query per request

2017-09-08 Thread Tor Bug Tracker & Wiki
#16596: Change database queries towards making only a single query per request
+-
 Reporter:  karsten |  Owner:  karsten
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+-
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Ok, I also took the time to make some changes, some of which I also found
 necessary for the reviewing itself.
 More inline ...

 Replying to [comment:9 karsten]:
 > ...
 > > Hmm, right. My idea was that we'll later copy over this servlet to
 metrics-web where it would make a little more sense to make the host name
 configurable. But on second thought that's not really the case. I'll just
 hard-code it.

 Fine.

 >
 > ...
 > > > In 'step 3' I see some problems with `null` values, for example,
 `"".equals(null)` would evaluate to false (line 147 following).
 > >
 > > Note that we're using `null` for invalid parameter values and `""` for
 empty parameter values. Do you see actual problems or potential problems
 there?
 > >
 > > In the latter case (potential problems), maybe we can resolve them by
 documenting things a bit better, or by making things clearer in subsequent
 commits.

 Maybe, think about a clearer way of documenting.  There is not actual
 problem considering the checks before the call to `writeForm`.

 > > ...
 > > > For most exceptions caught the error message should be logged; and,
 it might be time to switch to slf4j-api and logback, now.
 > >
 > > Yes, we can switch to slf4j, though we should do that in a separate
 commit on top of these, probably in a new ticket.

 Please find a commit on my task branch for that (link below).

 > ...
 >
 > > > QueryServlet: Helper methods ` private String
 parseTimestampParameter` and `private String parseIpParameter` should be
 `public static` and tests should be added.  Similarly, `private String
 convertIpV*ToHex`, which could be combined by simply adding another
 argument, i.e., `public static String convertIpV4ToHex(String relayIp,
 boolean isIpV4)`.
 > >
 > > Agreed, though let's save that for another ticket and not overload
 this ticket with too many improvements all at once. I know it's tempting.
 Stay strong, we'll eventually fix these things.

 Ok, new ticket.

 > >
 > > > A `MILLISEC_IN_DAY = 24L * 60L * 60L * 1000L` constant would be
 useful.
 >
 > Fixed.

 Fine.

 >
 > >
 > > > Other: Using the object `Boolean exit` for a triplet state is a bit
 too much of a hack.  There could be a simple enum, as simple as, for
 example, `public enum Exit { U, Y, N; }`.
 > >
 > > Ugh, that would turn the JSON field into a string, which doesn't seem
 very intuitive for "is an exit". And whoever processes this JSON will need
 to check for `null` anyway, regardless of boolean or string. In fact, I
 think that we're using the boolean field exactly in the way it's supposed
 to be used: `true` means "is an exit", `false` means "is not an exit", and
 `null` means "we don't know". I think I'd like to leave this one
 unchanged. It's not a hack.

 This is what I added to the third commit in my branch.  The U,N,Y
 abbreviations are handy and more readable.
 In addition, setting a value to `null` will make the default Gson omit the
 field from the json output.  That is not that intuitive.

 > >
 > > > Regarding SQL:
 > > > Order-by statement should be using names not numbers.
 > >
 > > Hmm, now that you mention that, I wonder if we even need results to be
 sorted at all. I'll try to take that out. Otherwise I'd change numbers to
 names in a subsequent commit, because it's not directly related to this
 ticket.
 >
 > Fixed.

 Fine, not ordering should also save some query time.

 >
 > > > Couldn't the exit-information be part of the query already?
 > >
 > > Yes, but I'd like to save database changes for a later ticket. There's
 so, so much more we can do to make the database schema more efficient.
 (I'd have to look at my notes from last year, but I believe that we're
 storing exit information directly in the database rather than the entire
 raw status entry.)
 > >
 > > > (I could also look into providing some patches, if we agree on the
 changes and you don't have the time?)
 > >

 The changes I added in
 [https://gitweb.torproject.org/user/iwakeh/exonerator.git/log/?h=task-16596
 this branch] start adding some tests also for the JSON/Gson related code.
 The tests document what JSON format to expect.  I moved all Gson related
 into QueryResponse.  If we ever switch to some other JSON generator/parser
 it will be easier to accomplish.
 The version information is also all moved 

[tor-bugs] #23442 [Applications/Tor Browser]: Error building firefox for Windows 64 in security/pkix/lib/pkixnames.cpp

2017-09-08 Thread Tor Bug Tracker & Wiki
#23442: Error building firefox for Windows 64 in security/pkix/lib/pkixnames.cpp
--+
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam201709
Actual Points:|  Parent ID:  #23229
   Points:|   Reviewer:
  Sponsor:|
--+
 We are getting the following error when trying to build firefox for
 Windows 64:
 {{{
 /var/tmp/dist/mingw-w64/helpers/x86_64-w64-mingw32-g++ -std=gnu++11
 -mwindows -o pkixnames.o -c   -DNDEBUG=1 -DTRIMMED=1
 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API
 -DIMPL_LIBXUL -I/var/tmp/build/firefox-89417fed09e5/security/pkix
 -I/var/tmp/build/firefox-89417fed09e5/obj-mingw/security/pkix
 -I/var/tmp/build/firefox-89417fed09e5/security/pkix/include
 -I/var/tmp/build/firefox-89417fed09e5/obj-mingw/dist/include
 -I/var/tmp/build/firefox-89417fed09e5/obj-mingw/dist/include/nspr
 -I/var/tmp/build/firefox-89417fed09e5/obj-mingw/dist/include/nss
 -DMOZILLA_CLIENT -include /var/tmp/build/firefox-89417fed09e5/obj-mingw
 /mozilla-config.h -MD -MP -MF .deps/pkixnames.o.pp  -Wall -Wc++11-compat
 -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith
 -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-
 invalid-offsetof -Wc++14-compat -Wno-error=maybe-uninitialized -Wno-error
 =deprecated-declarations -Wno-error=array-bounds -Wno-format -fno-
 lifetime-dse -fno-exceptions -fno-strict-aliasing -mms-bitfields -fno-rtti
 -fno-exceptions -fno-math-errno -pipe  -g -O -fomit-frame-pointer  -Wall
 -Wextra -pedantic-errors -Wno-error=shadow  /var/tmp/build/firefox-
 89417fed09e5/security/pkix/lib/pkixnames.cpp
 /var/tmp/build/firefox-89417fed09e5/security/pkix/lib/pkixnames.cpp: In
 function 'bool mozilla::pkix::{anonymous}::FinishIPv6Address(uint8_t
 (&)[16], int, int)':
 /var/tmp/build/firefox-
 89417fed09e5/security/pkix/lib/pkixnames.cpp:1712:32: error: 'memmove' was
 not declared in this scope
componentsToMove * 2u);
 ^
 make[5]: *** [pkixnames.o] Error 1
 make[5]: Leaving directory `/var/tmp/build/firefox-89417fed09e5/obj-
 mingw/security/pkix'
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23436 [Applications/Tor Browser]: Error building firefox for Windows 64 in js/src/vm/TraceLogging.cpp

2017-09-08 Thread Tor Bug Tracker & Wiki
#23436: Error building firefox for Windows 64 in js/src/vm/TraceLogging.cpp
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201709R |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * status:  new => needs_review
 * keywords:  TorBrowserTeam201709 => TorBrowserTeam201709R


Comment:

 This build issue is fixed when using this patch: https://hg.mozilla.org
 /mozilla-central/rev/6909c7487def

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22952 [Applications/Tor Browser]: Tor Browser Arabic Fonts Issue !

2017-09-08 Thread Tor Bug Tracker & Wiki
#22952: Tor Browser Arabic Fonts Issue !
--+---
 Reporter:  sigma4111 |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-fingerprinting-fonts  |  Actual Points:
Parent ID:  #18097| Points:
 Reviewer:|Sponsor:
--+---
Changes (by arthuredelstein):

 * cc: arthuredelstein (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23441 [- Select a component]: make test: fgets_eagain FAILED

2017-09-08 Thread Tor Bug Tracker & Wiki
#23441: make test: fgets_eagain FAILED
--+---
 Reporter:  svengo|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:  Tor: 0.3.0.10
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+---
 I've compiled tor-0.3.0.10 in an alpine:3.6 docker container, the complete
 source is available from https://raw.githubusercontent.com/svengo/docker-
 tor/master/Dockerfile. Everything is fine but make test failed:

 {{{
 # make test
 [...]
 util/fgets_eagain:
   FAIL src/test/test_util.c:3970: assert(retptr OP_EQ buf): 0 vs
 0x7ffc7aa12174
   [fgets_eagain FAILED]
 [...]
 1/868 TESTS FAILED. (30 skipped)
 make: *** [Makefile:9727: test] Error 1
 }}}

 I don't know if that is the same bug as #20988 and #21416.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23440 [Core Tor/Tor]: Enhancement: Replace CookieAuthFileGroupReadable option with flag for CookieAuthFile

2017-09-08 Thread Tor Bug Tracker & Wiki
#23440: Enhancement: Replace CookieAuthFileGroupReadable option with flag for
CookieAuthFile
--+---
 Reporter:  Ralph |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.3.0.10
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+---
 Making Tor's cookie auth file group-readable currently requires the use of
 two separate options:
 {{{
 # (1) Current (as of Tor 0.3.0.10) and unwieldy
 CookieAuthFile /path/to/file
 CookieAuthFileGroupReadable 1
 }}}
 I suggest to replace the option CookieAuthFileGroupReadable with a flag
 GroupReadable for the CookieAuthFile option:
 {{{
 # (2) Feature request: GroupReadable flag, replaces (1)
 CookieAuthFile /path/to/file GroupReadable
 }}}
 This enhancement would feel more "natural" and is consistent with a
 similar flag for the ControlPort option:
 {{{
 # (3) Current (as of Tor 0.3.0.10) and natural:
 ControlPort unix:/path/to/socket GroupWritable
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23439 [Applications/Tor Browser]: Exempt .onion domains from mixed content warnings

2017-09-08 Thread Tor Bug Tracker & Wiki
#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201709,|  Actual Points:
  GeorgKoppen201709  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * component:  - Select a component => Applications/Tor Browser


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23439 [- Select a component]: Exempt .onion domains from mixed content warnings

2017-09-08 Thread Tor Bug Tracker & Wiki
#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  - Select a component |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201709,|  Actual Points:
  GeorgKoppen201709  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * owner:  (none) => gk
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23439 [- Select a component]: Exempt .onion domains from mixed content warnings

2017-09-08 Thread Tor Bug Tracker & Wiki
#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  - Select a   |Version:
  component  |   Keywords:  TorBrowserTeam201709,
 Severity:  Normal   |  GeorgKoppen201709
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Part one of getting .onions exempted for the HTTPS requirement for secure
 contexts was done in #21321. Now we want to extend that to mixed content
 settings as well. See:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1382359 for the Mozilla bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22651 [Applications/Tor Browser]: Remove redirects for torbrowser-launcher

2017-09-08 Thread Tor Bug Tracker & Wiki
#22651: Remove redirects for torbrowser-launcher
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201709  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 The redirect has been removed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23368 [Core Tor/Tor]: Add design and coding guidelines for using floating point

2017-09-08 Thread Tor Bug Tracker & Wiki
#23368: Add design and coding guidelines for using floating point
--+
 Reporter:  teor  |  Owner:  catalyst
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
  |  implemented
 Keywords:  doc, tor-safety, review-group-23  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Looks like a good, comprehensive start to me.  I've merged it to master.
 We can add more here as we go along.  Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23383 [Metrics/Metrics website]: Apply Tor style guide to redesigned Tor Metrics website

2017-09-08 Thread Tor Bug Tracker & Wiki
#23383: Apply Tor style guide to redesigned Tor Metrics website
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Metrics website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by antonela):

 Karsten,
 I made 2 versions, with a purple background and with a white one.
 Let me know if you need something else!

 https://share.riseup.net/#HpFui8JIkPIJJu5rusOQYg

 Thanks

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23368 [Core Tor/Tor]: Add design and coding guidelines for using floating point

2017-09-08 Thread Tor Bug Tracker & Wiki
#23368: Add design and coding guidelines for using floating point
--+
 Reporter:  teor  |  Owner:  catalyst
 Type:  enhancement   | Status:
  |  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  doc, tor-safety, review-group-23  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by catalyst):

 * status:  needs_revision => needs_review


Comment:

 Pushed an update to oniongit that incorporates these suggestions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18660 [Core Tor/Stem]: OSX's man command lacks '--encoding' argument

2017-09-08 Thread Tor Bug Tracker & Wiki
#18660: OSX's man command lacks '--encoding' argument
---+
 Reporter:  Sebastian  |  Owner:  atagar
 Type:  defect | Status:  closed
 Priority:  Low|  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  utils  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by atagar):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Thanks ewong! Pushed your branch with some little tweaks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22407 [Core Tor/Tor]: Support HTTP CONNECT tunnels as an alternative to SOCKS

2017-09-08 Thread Tor Bug Tracker & Wiki
#22407: Support HTTP CONNECT tunnels as an alternative to SOCKS
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, pt-v2, application-  |  implemented
  support, http-connect, needs-design, prop229   |  Actual Points:
Parent ID:   | Points:  5
 Reviewer:  isis |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Opened #23438; closing this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23438 [Core Tor/Tor]: Use better status codes for HTTP CONNECT proxy errors

2017-09-08 Thread Tor Bug Tracker & Wiki
#23438: Use better status codes for HTTP CONNECT proxy errors
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core |Version:
  Tor/Tor|   Keywords:  http-connect tor-client needs-rfc-
 Severity:  Normal   |  knowledge
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 The current list of status codes was gathered by combining the RFCs with
 guesswork; many things are 404/403/502.  Perhaps there is a better list?
 (See end_reason_to_http_connect_response_line().)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23372 [Core Tor/Tor]: test: stack-use-after-scope in hs_service/build_update_descriptors

2017-09-08 Thread Tor Bug Tracker & Wiki
#23372: test: stack-use-after-scope in hs_service/build_update_descriptors
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Blocker   | Resolution:  fixed
 Keywords:  tor-test, tor-hs prop224  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by asn):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Fixed with f2c93f9 as part of #23387.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22173 [Core Tor/Tor]: Support looking up node by ed25519 identity (backend)

2017-09-08 Thread Tor Bug Tracker & Wiki
#22173: Support looking up node by ed25519 identity (backend)
-+
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  review-group-23  |  Actual Points:  2
Parent ID:   | Points:  1
 Reviewer:  catalyst |Sponsor:
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 thanks! Merging this to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23355 [Core Tor/Tor]: prop224: Implement a client purge state for NEWNYM

2017-09-08 Thread Tor Bug Tracker & Wiki
#23355: prop224: Implement a client purge state for NEWNYM
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  closed
 Priority:  High  |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
  |  implemented
 Keywords:  prop224, tor-hs, review-group-23  |  Actual Points:
Parent ID:  #23300| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 confirmed with asn, and merging

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23387 [Core Tor/Tor]: prop224: HSdir index desynch between client and service

2017-09-08 Thread Tor Bug Tracker & Wiki
#23387: prop224: HSdir index desynch between client and service
--+
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  prop224, tor-hs, review-group-23  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merging!  Please close the other tickets that are fixed by this branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23368 [Core Tor/Tor]: Add design and coding guidelines for using floating point

2017-09-08 Thread Tor Bug Tracker & Wiki
#23368: Add design and coding guidelines for using floating point
--+
 Reporter:  teor  |  Owner:  catalyst
 Type:  enhancement   | Status:
  |  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  doc, tor-safety, review-group-23  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by catalyst):

 These are all good suggestions!  I'm trying to figure out how to include
 them without making the section too long.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23387 [Core Tor/Tor]: prop224: HSdir index desynch between client and service

2017-09-08 Thread Tor Bug Tracker & Wiki
#23387: prop224: HSdir index desynch between client and service
--+
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:
  |  merge_ready
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  prop224, tor-hs, review-group-23  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by asn):

 OK. Pushed another commit which tests that upload_descriptor_to_all()
 is in synch with pick_hsdir_v3() for various scenarios. This should give
 some more confidence and also unittest `pick_hsdir_v3()`.

 I think this is good to merge now!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18101 [Applications/Tor Browser]: IP leak from Windows UI dialog with URI

2017-09-08 Thread Tor Bug Tracker & Wiki
#18101: IP leak from Windows UI dialog with URI
-+-
 Reporter:  uileak   |  Owner:
 |  arthuredelstein
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-disk-leak, tbb-proxy-bypass, |  Actual Points:
  TorBrowserTeam201709R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: mcs, brade (added)
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:49 arthuredelstein]:
 > Replying to [comment:48 gk]:
 >
 > Answering questions in reverse order:
 >
 > > And could you verify that other Tor Browser platforms are unaffected?
 comment:7 seems to point this out for Linux. See comment:9 for macOS.
 >
 > Here's a patch that covers all platforms:
 > https://github.com/arthuredelstein/tor-browser/commit/18101+2
 >
 > Unfortunately, I haven't yet been able to test these on old Linux and
 macOS platforms. The current platforms on desktops I tested (XFCE, KDE,
 macOS) do not show a text box in the Open Dialog. Once I have builds
 ready, I will post them on this ticket so that people can test on old
 Mac/Linux platforms if they have them.

 I built own bundles and this was a PITA to test. I can confirm that the
 patch for Linux fixes the problem and it looks good to me. After trying to
 reproduce the problem for quite a while I wrote custom extension code
 using the example on https://developer.mozilla.org/en-
 US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIFilePicker but with
 `modSave` (this is important, I could not find a way to reproduce the
 issue and test the fix with `modOpen`) and, obviously,
 `nsIFilePicker.filterAllowURLs` added to the filters.

 Arthur/Mark/Kathy: that might be a way to test the fix on a Mac as well
 (which I don't have atm).

 With the patch for Windows I still see DNS leaks. Here is what I did:

 1) Open the patched Tor Browser
 2) Go to https://bugs.torproject.org/18101
 3) Copy the URL of the Tor logo
 4) Open https://bug711654.bmoattachments.org/attachment.cgi?id=582460 in a
 new tab
 5) Start Wireshark
 6) Click on the "Browse" button and paste the URL for the Tor log and
 click on "Open"
 7) Wait a while and a DNS query for trac.torproject.org will be in the
 Wireshark log.

 Marking this as `needs_revision` for this problem. Arthur, let me know
 whether you can reproduce that. This happens on a Windows 7 machine (in
 case that matters).

 > > Arthur: What do we want to do for XP (see comment:10)?
 >
 > I am inclined to treat this problem as wontfix, because XP is deprecated
 by Microsoft and is expected to be deprecated in September by Mozilla as
 well. I did spend a little time looking into the problem but I don't see a
 quick solution.

 Well, we certainly would take a patch if someone came up with one. So,
 let's open a follow-up ticket for that case and set `ff59-esr-will-have`
 as keyword once we are done here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18101 [Applications/Tor Browser]: IP leak from Windows UI dialog with URI

2017-09-08 Thread Tor Bug Tracker & Wiki
#18101: IP leak from Windows UI dialog with URI
-+-
 Reporter:  uileak   |  Owner:
 |  arthuredelstein
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-disk-leak, tbb-proxy-bypass, |  Actual Points:
  TorBrowserTeam201709R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:51 cypherpunks]:
 > Is this ticket about protection for noobs who can't distinguish between
 shell and browser? If so, shouldn't we make this feature obey TBB's design
 requirements? Something like "Firefox should handle URLs (instead of
 system shell)".

 I am fine opening a follow-up ticket for that idea - after we plugged that
 hole in this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22173 [Core Tor/Tor]: Support looking up node by ed25519 identity (backend)

2017-09-08 Thread Tor Bug Tracker & Wiki
#22173: Support looking up node by ed25519 identity (backend)
-+
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  enhancement  | Status:  merge_ready
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:  2
Parent ID:   | Points:  1
 Reviewer:  catalyst |Sponsor:
-+
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 OK, thanks! I responded on oniongit -- I was mistaken. Looks good now!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23437 [Webpages/Webtools]: newsletter archive, subscribe and unsubscribed pages

2017-09-08 Thread Tor Bug Tracker & Wiki
#23437: newsletter archive, subscribe and unsubscribed pages
---+--
 Reporter:  isabela|  Owner:  hiro
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Webpages/Webtools  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team|  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by isabela):

 * Attachment "newsletter-signup-archive.png" added.

 Steph mock

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23437 [Webpages/Webtools]: newsletter archive, subscribe and unsubscribed pages

2017-09-08 Thread Tor Bug Tracker & Wiki
#23437: newsletter archive, subscribe and unsubscribed pages
---+-
 Reporter:  isabela|  Owner:  hiro
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Webpages/Webtools  |Version:
 Severity:  Normal |   Keywords:  ux-team
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+-
 Comms team is working on a newsletter for Tor Project. This ticket is not
 about the mailing part of it, but about the pages people will see if they:

  1. Want to subscribe to the newsletter.
  1. Unsubscribe action is successful - page you see when you click on the
 link to unsubscribe.
  1. Newsletters permanent page
  1. Archive of previous newsletters

 Example of a newsletter permanent
 page:[http://37.218.240.202/archive/2017-09-01-first-newsletter
 http://37.218.240.202/archive/2017-09-01-first-newsletter]This is useful
 for us to have people referring to our newsletter on social media, blogs,
 articles.Attached is a mock done by Steph which we would like UX team to
 review:Archive will be just a table with one column for newsletter title
 and one column for the date it was sent/published.Here is an example of
 the archive (is not using the design from Steph's mock
 yet):http://37.218.240.202/archive

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22785 [Applications/Tor Browser]: Show an alternative icon for features that are blocked and not broken.

2017-09-08 Thread Tor Bug Tracker & Wiki
#22785: Show an alternative icon for features that are blocked and not broken.
--+--
 Reporter:  linda |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ux-team,  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by linda):

 Replying to [comment:10 gk]:
 > FWIW: We should consider the case where websites can't get rendered at
 all due to some slider setting (see: #23324 where disabling SVG is causing
 this). Those might be cases where no blocking icon on the page can be
 shown (I have not looked closer at that). And having such cases + plus
 cases where we *would show* an icon is pretty confusing.

 This is a good point. Hmm...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22407 [Core Tor/Tor]: Support HTTP CONNECT tunnels as an alternative to SOCKS

2017-09-08 Thread Tor Bug Tracker & Wiki
#22407: Support HTTP CONNECT tunnels as an alternative to SOCKS
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, pt-v2, application-  |  Actual Points:
  support, http-connect, needs-design, prop229   |
Parent ID:   | Points:  5
 Reviewer:  isis |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 tor-client, pt-v2, application-support, http-connect, needs-design,
 prop229, review-group-22, review-group-23
 =>
 tor-client, pt-v2, application-support, http-connect, needs-design,
 prop229


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23429 [Core Tor/Tor]: hs: assert on rend_data when pruning the v2 service list

2017-09-08 Thread Tor Bug Tracker & Wiki
#23429: hs: assert on rend_data when pruning the v2 service list
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  closed
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-hs, prop224, review-group-23  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 merged to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23304 [Core Tor/Tor]: prop224: Dump a malformed descriptor in a file and log_warn about it

2017-09-08 Thread Tor Bug Tracker & Wiki
#23304: prop224: Dump a malformed descriptor in a file and log_warn about it
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-23  |  Actual Points:
Parent ID:  #23300| Points:
 Reviewer:|Sponsor:  SponsorR-
  |  can
--+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 looks good, but let's use escaped() here, in case there are tricky
 characters in the descriptor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23304 [Core Tor/Tor]: prop224: Dump a malformed descriptor in a file and log_warn about it

2017-09-08 Thread Tor Bug Tracker & Wiki
#23304: prop224: Dump a malformed descriptor in a file and log_warn about it
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-23  |  Actual Points:
Parent ID:  #23300| Points:
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  can
--+
Changes (by nickm):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20119 [Core Tor/Tor]: Tor should exit if it fails to write its PidFile, under principle of least confusion. Also, maybe Tor should create the directory that the PidFile points to

2017-09-08 Thread Tor Bug Tracker & Wiki
#20119: Tor should exit if it fails to write its PidFile, under principle of 
least
confusion. Also, maybe Tor should create the directory that the PidFile
points to
-+-
 Reporter:  yurivict271  |  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.7
 Severity:  Normal   | Resolution:  fixed
 Keywords:  easy, fs, tor-relay, usability,  |  Actual Points:  0
  startup, review-group-23   |
Parent ID:   | Points:  .5
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merging!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22215 [Core Tor/Tor]: networkstatus_nickname_is_unnamed() can get ripped out

2017-09-08 Thread Tor Bug Tracker & Wiki
#22215: networkstatus_nickname_is_unnamed() can get ripped out
-+
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:
Parent ID:  #12898   | Points:
 Reviewer:  nickm|Sponsor:
-+
Changes (by nickm):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22215 [Core Tor/Tor]: networkstatus_nickname_is_unnamed() can get ripped out

2017-09-08 Thread Tor Bug Tracker & Wiki
#22215: networkstatus_nickname_is_unnamed() can get ripped out
-+
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:
Parent ID:  #12898   | Points:
 Reviewer:  nickm|Sponsor:
-+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 The first two parts of this commit are fine, but the changes in dirvote.c
 need to become conditional, and only happen when a new consensus method is
 provided.

 The problem is that the consensus-generation code in dirvote.c needs to be
 run in exactly the same way on all the authorities for all inputs, or else
 they can produce different outputs, which will make them not agree on the
 consensus.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22215 [Core Tor/Tor]: networkstatus_nickname_is_unnamed() can get ripped out

2017-09-08 Thread Tor Bug Tracker & Wiki
#22215: networkstatus_nickname_is_unnamed() can get ripped out
-+
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:
Parent ID:  #12898   | Points:
 Reviewer:  nickm|Sponsor:
-+
Changes (by nickm):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23383 [Metrics/Metrics website]: Apply Tor style guide to redesigned Tor Metrics website

2017-09-08 Thread Tor Bug Tracker & Wiki
#23383: Apply Tor style guide to redesigned Tor Metrics website
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Metrics website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 antonela, do you think you could put together new `*tile.png` files like
 the one mentioned in
 [https://trac.torproject.org/projects/tor/ticket/23383#comment:3 comment 3
 above]? I think we'll need the following five resolutions:
  - 310 x 310
  - 196 x 196
  - 152 x 152
  - 150 x 150
  - 70 x 70

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22173 [Core Tor/Tor]: Support looking up node by ed25519 identity (backend)

2017-09-08 Thread Tor Bug Tracker & Wiki
#22173: Support looking up node by ed25519 identity (backend)
-+
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:  2
Parent ID:   | Points:  1
 Reviewer:  catalyst |Sponsor:
-+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Thanks, catalyst! I just asked a question about your question on the
 oniongit ticket.

 I also tried to apply the patch from #22215 on top of this, and it worked
 okay with "git am -3".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23387 [Core Tor/Tor]: prop224: HSdir index desynch between client and service

2017-09-08 Thread Tor Bug Tracker & Wiki
#23387: prop224: HSdir index desynch between client and service
--+
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:
  |  merge_ready
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  prop224, tor-hs, review-group-23  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22644 [Core Tor/Tor]: Assert crash with HSPOST and POSTDESCRIPTOR control port commands

2017-09-08 Thread Tor Bug Tracker & Wiki
#22644: Assert crash with HSPOST and POSTDESCRIPTOR control port commands
-+-
 Reporter:  donncha  |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-control, crash, 029-backport,|  Actual Points:  .1
  030-backport, 031-backport, review-group-23|
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged to 029 and forward!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22281 [Core Tor/Tor]: Prevent pattern of bugs caused by calling get_options() within options_validate() etc

2017-09-08 Thread Tor Bug Tracker & Wiki
#22281: Prevent pattern of bugs caused by calling get_options() within
options_validate() etc
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by nickm):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22281 [Core Tor/Tor]: Prevent pattern of bugs caused by calling get_options() within options_validate() etc

2017-09-08 Thread Tor Bug Tracker & Wiki
#22281: Prevent pattern of bugs caused by calling get_options() within
options_validate() etc
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+

Comment (by nickm):

 I think you're right.  I added a fixup commit for this. Better now?

 (I also ran it through the chutney tests to see if they would complain.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23433 [Core Tor/Tor]: Windows relay: 85% of CPU power is wasted inside select() call

2017-09-08 Thread Tor Bug Tracker & Wiki
#23433: Windows relay: 85% of CPU power is wasted inside select() call
---+
 Reporter:  Vort   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor   |Version:  Tor: 0.3.1.5-alpha
 Severity:  Normal | Resolution:
 Keywords:  tor-relay windows  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by Vort):

 > Try to increment TokenBucketRefillInterval option, any difference?

 Most likely, no.
 With `TokenBucketRefillInterval 300` I see same kernel/total proportions
 (~85%) and same CPU load (~15%, ~1MiB/s, ~3500 connections).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23426 [Core Tor/Tor]: Remove AllowDotExit

2017-09-08 Thread Tor Bug Tracker & Wiki
#23426: Remove AllowDotExit
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:  0
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Pushed a fixup commit; better?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

2017-09-08 Thread Tor Bug Tracker & Wiki
#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
-+
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merging!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23237 [Core Tor/Tor]: Add 'GETINFO ip-to-country/available'

2017-09-08 Thread Tor Bug Tracker & Wiki
#23237: Add 'GETINFO ip-to-country/available'
+--
 Reporter:  atagar  |  Owner:  nickm
 Type:  enhancement | Status:  closed
 Priority:  Low |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
|  implemented
 Keywords:  easy, tor-control, review-group-23  |  Actual Points:  .1
Parent ID:  | Points:
 Reviewer:  dgoulet |Sponsor:
+--
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22377 [Core Tor/Tor]: Rip out AUTHDIR_NEWDESCS event?

2017-09-08 Thread Tor Bug Tracker & Wiki
#22377: Rip out AUTHDIR_NEWDESCS event?
-+
 Reporter:  arma |  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  review-group-23  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by nickm):

 * status:  needs_information => closed
 * resolution:   => implemented


Comment:

 changed, merged. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22377 [Core Tor/Tor]: Rip out AUTHDIR_NEWDESCS event?

2017-09-08 Thread Tor Bug Tracker & Wiki
#22377: Rip out AUTHDIR_NEWDESCS event?
-+
 Reporter:  arma |  Owner:  nickm
 Type:  enhancement  | Status:  needs_information
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+

Comment (by nickm):

 oh, good point. will make that change then merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23436 [Applications/Tor Browser]: Error building firefox for Windows 64 in js/src/vm/TraceLogging.cpp

2017-09-08 Thread Tor Bug Tracker & Wiki
#23436: Error building firefox for Windows 64 in js/src/vm/TraceLogging.cpp
--+
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam201709
Actual Points:|  Parent ID:  #23229
   Points:|   Reviewer:
  Sponsor:|
--+
 We are getting the following error when trying to build firefox for
 Windows 64:
 {{{
 /var/tmp/dist/mingw-w64/helpers/x86_64-w64-mingw32-g++ -std=gnu++11
 -mwindows -o TraceLogging.o -c   -DNDEBUG=1 -DTRIMMED=1 -D_CRT_RAND_S
 -DENABLE_SHARED_ARRAY_BUFFER -DEXPORT_JS_API -DJS_HAS_CTYPES
 '-DDLL_PREFIX=""' '-DDLL_SUFFIX=".dll"' -DFFI_BUILDING -DMOZ_HAS_MOZGLUE
 -I/var/tmp/build/firefox-89417fed09e5/js/src -I/var/tmp/build/firefox-
 89417fed09e5/obj-mingw/js/src -I/var/tmp/build/firefox-89417fed09e5/obj-
 mingw/js/src/ctypes/libffi/include -I/var/tmp/build/firefox-
 89417fed09e5/js/src/ctypes/libffi/src/x86 -I/var/tmp/build/firefox-
 89417fed09e5/obj-mingw/dist/include  -I/var/tmp/build/firefox-89417fed09e5
 /obj-mingw/dist/include/nspr  -DMOZILLA_CLIENT -include
 /var/tmp/build/firefox-89417fed09e5/obj-mingw/js/src/js-confdefs.h -MD -MP
 -MF .deps/TraceLogging.o.pp  -Wall -Wc++11-compat -Wempty-body -Wignored-
 qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-
 limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof
 -Wc++14-compat -Wno-error=maybe-uninitialized -Wno-error=deprecated-
 declarations -Wno-error=array-bounds -Wno-format -fno-lifetime-dse -mms-
 bitfields -fno-rtti -fno-exceptions -fno-math-errno -pipe  -g -O -fomit-
 frame-pointer  -Wno-shadow -Werror=format  /var/tmp/build/firefox-
 89417fed09e5/js/src/vm/TraceLogging.cpp
 /var/tmp/build/firefox-89417fed09e5/js/src/vm/TraceLogging.cpp: In member
 function 'js::TraceLoggerEventPayload*
 js::TraceLoggerThread::getOrCreateEventPayload(TraceLoggerTextId, const
 char*, size_t, size_t, const void*)':
 /var/tmp/build/firefox-89417fed09e5/js/src/vm/TraceLogging.cpp:461:93:
 error: format '%u' expects argument of type 'unsigned int', but argument 5
 has type 'size_t {aka long long unsigned int}' [-Werror=format=]
  snprintf(str, len + 1, "script %s:%" PRIuSIZE ":%" PRIuSIZE,
 filename, lineno, colno);
 ^
 /var/tmp/build/firefox-89417fed09e5/js/src/vm/TraceLogging.cpp:461:93:
 error: format '%u' expects argument of type 'unsigned int', but argument 6
 has type 'size_t {aka long long unsigned int}' [-Werror=format=]
 cc1plus: some warnings being treated as errors
 make[5]: *** [TraceLogging.o] Error 1
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23433 [Core Tor/Tor]: Windows relay: 85% of CPU power is wasted inside select() call

2017-09-08 Thread Tor Bug Tracker & Wiki
#23433: Windows relay: 85% of CPU power is wasted inside select() call
---+
 Reporter:  Vort   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor   |Version:  Tor: 0.3.1.5-alpha
 Severity:  Normal | Resolution:
 Keywords:  tor-relay windows  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by cypherpunks):

 `WS2_32.dll!select` is a final destination of code, in top, always.

 > And, most likely, it can be fixed by using the different approaches for
 network API interaction.

 Good luck with implementing it.


 Try to increment `TokenBucketRefillInterval` option, any difference?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23289 [Core Tor/Tor]: Improving HS reachability for Orbot/Android users

2017-09-08 Thread Tor Bug Tracker & Wiki
#23289: Improving HS reachability for Orbot/Android users
+
 Reporter:  n8fr8   |  Owner:  n8fr8
 Type:  enhancement | Status:  new
 Priority:  High|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  orbot, mobile, android  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  Sponsor8-can
+
Changes (by goapunk):

 * cc: goapunk@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23435 [Internal Services/Service - git]: New git repository in Infrastructure and Administration /project for newsletter microsite

2017-09-08 Thread Tor Bug Tracker & Wiki
#23435: New git repository in Infrastructure and Administration /project for
newsletter microsite
-+
 Reporter:  hiro |  Owner:  tor-gitadm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+
 Hello,

 Can I have a git repo to store the code for the tor newsletter microsite?

 Thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

2017-09-08 Thread Tor Bug Tracker & Wiki
#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201709  |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:  Sponsor4
--+--

Comment (by boklm):

 I tried a build with this, however it didn't fix the build issue:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_23231_v2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23387 [Core Tor/Tor]: prop224: HSdir index desynch between client and service

2017-09-08 Thread Tor Bug Tracker & Wiki
#23387: prop224: HSdir index desynch between client and service
--+
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:
  |  merge_ready
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  prop224, tor-hs, review-group-23  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by asn):

 Addressed Nick's review! Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation

2017-09-08 Thread Tor Bug Tracker & Wiki
#23094: prop224: Optimize hsdir_index calculation
+--
 Reporter:  asn |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--

Comment (by asn):

 After our #23387 refactoring of hsdir index logic Nick suggested that we
 don't need to keep all 3 around in memory, since two of them are always
 identical:
 https://oniongit.eu/asn/tor/merge_requests/6#note_1201

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation (was: prop224: Include hsdir_index in node_t instead of pointer)

2017-09-08 Thread Tor Bug Tracker & Wiki
#23094: prop224: Optimize hsdir_index calculation
+--
 Reporter:  asn |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23434 [Core Tor/Tor]: Review bridgeauth glue/admin scripts and make as much public as possible

2017-09-08 Thread Tor Bug Tracker & Wiki
#23434: Review bridgeauth glue/admin scripts and make as much public as possible
--+
 Reporter:  isis  |  Owner:  isis
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  bridgeauth
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 These have never been public; I inherited them via Lucky Green. They are
 primarily ssh and rsync in shell scripts and cronjobs, but in order for
 others to understand how things get from one place to another in the
 network, they should be public where possible (I think this should be all
 of it, but I'll need to give it a careful once-over to be sure).

 Putting in "Core Tor/Tor" since it's either that or "Obfuscation/BridgeDB"
 and neither really fits.  (There maybe should be a component for DirAuth
 administration??)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22137 [Applications/Tor Browser]: Provide the same scrollbar size across different platforms

2017-09-08 Thread Tor Bug Tracker & Wiki
#22137: Provide the same scrollbar size across different platforms
---+--
 Reporter:  gk |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-fingerprinting-resolution  |  Actual Points:
Parent ID:  #18283 | Points:
 Reviewer: |Sponsor:
---+--

Comment (by gk):

 FWIW: https://bugzilla.mozilla.org/show_bug.cgi?id=1397996 is the Mozilla
 bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23403 [Applications/Tor Browser]: Use tor-browser-build/tmp rather than /tmp as default tmp directory

2017-09-08 Thread Tor Bug Tracker & Wiki
#23403: Use tor-browser-build/tmp rather than /tmp as default tmp directory
+
 Reporter:  boklm   |  Owner:  boklm
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201709R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by boklm):

 In commit 84881888708f4fd163b1867193fed6471d0c53a9 I added this `tmp`
 directory to the .gitignore file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23433 [Core Tor/Tor]: Windows relay: 85% of CPU power is wasted inside select() call

2017-09-08 Thread Tor Bug Tracker & Wiki
#23433: Windows relay: 85% of CPU power is wasted inside select() call
--+
 Reporter:  Vort  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: 0.3.1.5-alpha
 Severity:  Normal|   Keywords:  tor-relay windows
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Since I have eliminated the network slowdown with patch from #22798, I
 have started to face another problem:
 As connection count began to grow, CPU resources consumption start growing
 too.
 Now, with 3700 connections and 1 MiB/s of Tor traffic, CPU is
 [[attachment:tor_cpu.png|loaded at 15%]].
 With 3 MiB/s of traffic, CPU load goes up to maximum 25% (full load of 1
 CPU core).
 It is possible to think that Tor uses much cryptography and that thing is
 overloading my PC. But no.
 Much of the time (88 hours of total 102 hours) tor.exe process spends in
 kernel mode. Most probably, inside `WS2_32.dll!select` function (called
 from libevent library).
 This specificity limits maximum speeds, which can be achieved using Tor
 relay with Windows.
 And, most likely, it can be fixed by using the different approaches for
 network API interaction.

 CPU: Intel Core i5-4690
 OS: Windows 7 SP1 x64

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23433 [Core Tor/Tor]: Windows relay: 85% of CPU power is wasted inside select() call

2017-09-08 Thread Tor Bug Tracker & Wiki
#23433: Windows relay: 85% of CPU power is wasted inside select() call
---+
 Reporter:  Vort   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor   |Version:  Tor: 0.3.1.5-alpha
 Severity:  Normal | Resolution:
 Keywords:  tor-relay windows  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by Vort):

 * Attachment "tor_cpu.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23425 [Applications/Tor Browser]: Build fails when running without a terminal

2017-09-08 Thread Tor Bug Tracker & Wiki
#23425: Build fails when running without a terminal
+
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201709R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good, merged to `master` (commit
 e21581e108a44915c0bd0f2acd346b02288a52a0).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22692 [Applications/Tor Browser]: Backport Linux content sandboxing from Firefox 54

2017-09-08 Thread Tor Bug Tracker & Wiki
#22692: Backport Linux content sandboxing from Firefox 54
-+-
 Reporter:  jld  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  GeorgKoppen201709,   |  Actual Points:
  TorBrowserTeam201709R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Thanks, I updated `bug_22692_v3` with the two patches (they applied
 cleanly) and will do a rebuild and further test while waiting on review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23104 [Applications/Tor Browser]: CSS line-height reveals the platform Tor Browser is running on

2017-09-08 Thread Tor Bug Tracker & Wiki
#23104: CSS line-height reveals the platform Tor Browser is running on
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-fingerprinting-os |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 FWIW: this is https://bugzilla.mozilla.org/show_bug.cgi?id=1397994 on
 Mozilla's side.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs