Re: [tor-bugs] #31637 [Core Tor/Tor]: Make sure we have test coverage for Option, +Option and /Option across defaults, torrc, command line

[Tor Bug Tracker & Wiki]

#31637: Make sure we have test coverage for Option, +Option and /Option across
defaults, torrc, command line
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  1.5
Parent ID:  #29211   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  new => needs_review
 * actualpoints:   => 1.5


Comment:

 CI has passed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31637 [Core Tor/Tor]: Make sure we have test coverage for Option, +Option and /Option across defaults, torrc, command line

[Tor Bug Tracker & Wiki]

#31637: Make sure we have test coverage for Option, +Option and /Option across
defaults, torrc, command line
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by nickm):

 I've opened a new branch, `ticket31637`, which squashes all of the work
 above.  PR at https://github.com/torproject/tor/pull/1324 .  I expect that
 the CI will still pass, but you never know.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31703 [Internal Services/Service - dist]: Downloading Tor Browser from 2620:0:6b0:b:225:dada:19:1 is painfully slow

[Tor Bug Tracker & Wiki]

#31703: Downloading Tor Browser from 2620:0:6b0:b:225:dada:19:1 is painfully 
slow
--+--
 Reporter:  pospeselr |  Owner:  anarcat
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - dist  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by anarcat):

 it seems this fixed itself, maybe by cymru:

 {{{
 14:12:30  [412201.561239] igb :01:00.0 eth0: igb: eth0 NIC
 Link is Up 1000 Mbps Full Duplex, Flow Control: RX
 }}}

 Local time (UTC-4). Traffic now flows freely on moly and you should have
 better performance now:

 {{{
 anarcat@angela:~(master)$ curl --resolve 'www.torproject.org:443:web-
 cymru-01.torproject.org' -o /dev/null
 https://dist.torproject.org/torbrowser/8.5.5/tor-browser-linux64-8.5.5_en-
 US.tar.xz
   % Total% Received % Xferd  Average Speed   TimeTime Time
 Current
  Dload  Upload   Total   SpentLeft
 Speed
 100 72.3M  100 72.3M0 0  2490k  0  0:00:29  0:00:29 --:--:--
 2513k
 }}}

 Thanks for the report!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31475 [Core Tor/Tor]: config: stop using atof()

[Tor Bug Tracker & Wiki]

#31475: config: stop using atof()
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  asn-merge |  Actual Points:  .2
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:   => asn-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31475 [Core Tor/Tor]: config: stop using atof()

[Tor Bug Tracker & Wiki]

#31475: config: stop using atof()
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .2
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 lgtm thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29646 [Applications/Tor Browser]: NoScript XSS user choices are persisted

[Tor Bug Tracker & Wiki]

#29646: NoScript XSS user choices are persisted
-+-
 Reporter:  atac |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-disk-leak xss noscript tbb-  |  Actual Points:
  newnym ux-team |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:8 antonela]:
 > Maybe regular users want persistent NoScript options because setting
 those each time you open the browser, is annoying.
 But disk-avoidance is a MUST.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31739 [Applications/Tor Browser]: TBB 9.0a6 Issues with Cloudflare

[Tor Bug Tracker & Wiki]

#31739: TBB 9.0a6 Issues with Cloudflare
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  tbb-must-alpha, ff68-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 Mozilla's release schedule is well known, so why isn't this process more
 automatic? Not dramatic? Was it for the body politic? eastdakota is a
 lunatic? dailystormer aren't realpolitik?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31740 [Applications/Tor Browser]: Review RemoteSettings usages in esr68

[Tor Bug Tracker & Wiki]

#31740: Review RemoteSettings usages in esr68
-+-
 Reporter:  acat |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff68-esr
 Severity:  Normal   |  TorBrowserTeam201909
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 `RemoteSettings` (https://firefox-source-
 docs.mozilla.org/main/68.0/services/common/services/RemoteSettings.html)
 is now used for several features as a way to synchronize some local state
 (collections, sets of records) with some remote state that Mozilla
 controls. I did not review the protocol, but the way I understand it is
 that there are periodical polls to the server with an etag header
 (last_timestamp, returned by the server in a previous poll) which return
 the list of changes since that timestamp. I think this etag may be quite
 close to a user identifier, so Mozilla's servers could probably link
 together all the RemoteSettings request can get is the sequence of all
 'RemoteSettings polls' for a user. Not sure how much you can guess about
 the user with that, though.

 In any case, opening this to decide/review which ones of the usages of
 RemoteSettings we need or not. The `RemoteSettings` one is probably a
 subset of the requests happening in background, but I guess it's a start.
 I'm listing files where `RemoteSettings` are used. My understanding is
 that just calling `RemoteSettings('acollectionname')` will start the
 syncing mechanism, meaning that there will be requests polling in
 background 'from time to time'.


 * `browser/components/newtab/{lib/ASRouter.jsm, lib/FaviconFeed.jsm,
 lib/PersonalityProvider.jsm, lib/SiteClassifier.jsm}`
   * These should not be run if we disable Activity Stream (#31575).

 * `toolkit/components/normandy/lib/RecipeRunner.jsm`
   * I think this will not be run, since the `RemoteSettings` is created
 lazily when `gRemoteSettingsClient` is accessed, and that should not
 happen since we have `datareporting.healthreport.uploadEnabled = false`.

 * `toolkit/components/search/SearchService.jsm`
   * Used to update the "ignore list settings" which can be used to
 remotely "ignore" search engines? I think we can remove this one.

 * `browser/components/preferences/browserLanguages.js`
   * There is a dump for this one in `services/settings/dumps/main
 /language-dictionaries.json`. It seems to be a mapping of locale to
 dictionary ids. We probably have to keep this one if we want to allow
 changing UI language in `about:preferences`, via Mozilla's language packs.

 * `netwerk/url-classifier/UrlClassifierSkipListService.jsm`
   * If I understand it correctly, this is used for content blocking, to be
 able to skip some steps ("features") for specific urls. I guess to be able
 to fix antitracking breakage remotely? We should not need this one if we
 don't plan to make it possible to enable content blocking/mozilla's
 antitracking.

 * `security/manager/ssl/RemoteSecuritySettings.jsm`
   * Intermediate certificate preloading. There is #30682 to decide what to
 do with this.

 Finally some blocklists, I think some of them we already have in esr60,
 but not all? Not completely sure, but I would say it's better to keep
 these?

 * `services/common/blocklist-clients.js`
   * onecrl (already in esr60).
   * pinning blocklist (related to HPKP? not sure if it's in esr60).

 * `toolkit/mozapps/extensions/Blocklist.jsm` (these were already in esr60)
   * extensions blocklist
   * plugins blocklist
   * gfx blocklist

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-+-
 Reporter:  mcs  |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R, tbb-update  |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 https://devblogs.microsoft.com/oldnewthing/20190830-00/?p=102823
 Coincidence?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31685 [Circumvention/Snowflake]: Snowflake : ON/OFF switch

[Tor Bug Tracker & Wiki]

#31685: Snowflake : ON/OFF switch
-+
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Trivial  | Resolution:
 Keywords:  snowflake-ux |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by cypherpunks):

 "Status" is good but what about accessibility ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31538 [Applications/Tor Browser]: Windows bundles based on ESR 68 are not built reproducibly

[Tor Bug Tracker & Wiki]

#31538: Windows bundles based on ESR 68 are not built reproducibly
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must- |  Actual Points:
  alpha, TorBrowserTeam201909R,  |
  GeorgKoppen201909  |
Parent ID:  #30322   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Linux 64bit builds are still matching. So, we are good, woo!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs