Re: [U-Boot] [PATCH] ARMV7: OMAP3: BeagleBoard: add more expansionboard IDs

2010-11-05 Thread Premi, Sanjeev 
> -Original Message-
> From: u-boot-boun...@lists.denx.de 
> [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Jason Kridner
> Sent: Friday, November 05, 2010 11:17 AM
> To: u-boot@lists.denx.de
> Cc: Koen Kooi
> Subject: [U-Boot] [PATCH] ARMV7: OMAP3: BeagleBoard: add more 
> expansionboard IDs

[sp] Is it really necessary to mention ARMV7 in the subject line?
 OMAP3 & BeagbeBoard seem sufficient.

> 
> From: Koen Kooi 
> 
> Signed-off-by: Koen Kooi 
> Signed-off-by: Jason Kridner 
> ---
>  board/ti/beagle/beagle.c |   16 
>  1 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c
> index d9b6f01..520e57d 100644
> --- a/board/ti/beagle/beagle.c
> +++ b/board/ti/beagle/beagle.c
> @@ -48,6 +48,10 @@
>  #define TINCANTOOLS_TRAINER  0x04000100
>  #define TINCANTOOLS_SHOWDOG  0x03000100
>  #define KBADC_BEAGLEFPGA 0x01000600
> +#define LW_BEAGLETOUCH   0x01000700
> +#define LCDOG_BRAINMUX   0x01000800
> +#define LCDOG_BRAINMUXTOUCH  0x02000800

[sp] Don't see any mechanism to read these values. Assuming the
 detection mechanism is consistent i.e. no difference due
 to different eeprom etc. etc.

> +#define SF_HARDHAT   0x01000900

[sp] Don't see this used below

>  
>  #define BEAGLE_NO_EEPROM 0x
>  
> @@ -223,6 +227,18 @@ int misc_init_r(void)
>   MUX_KBADC_BEAGLEFPGA();
>   setenv("buddy", "beaglefpga");
>   break;
> + case LW_BEAGLETOUCH:
> + printf("Recognized Liquidware Beagletouch board\n");
> + setenv("buddy", "beagletouch");
> + break;
> + case LCDOG_BRAINMUX:
> + printf("Recognized Brainmux LCDog board\n");
> + setenv("buddy", "lcdog");
> + break;
> + case LCDOG_BRAINMUXTOUCH:
> + printf("Recognized Brainmux LCDog Touch board\n");
> + setenv("buddy", "lcdogtouch");
> + break;
>   case BEAGLE_NO_EEPROM:
>   printf("No EEPROM on expansion board\n");
>   setenv("buddy", "none");
> -- 
> 1.5.6.4
> 
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] ARMV7: OMAP3: BeagleBoard: add more expansionboard IDs

2010-11-04 Thread Wolfgang Denk 
Dear Jason Kridner,

In message <1288936010-30462-1-git-send-email-jkrid...@beagleboard.org> you 
wrote:
> From: Koen Kooi 
> 
> Signed-off-by: Koen Kooi 
> Signed-off-by: Jason Kridner 
> ---
>  board/ti/beagle/beagle.c |   16 
>  1 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c
> index d9b6f01..520e57d 100644
> --- a/board/ti/beagle/beagle.c
> +++ b/board/ti/beagle/beagle.c
> @@ -48,6 +48,10 @@
>  #define TINCANTOOLS_TRAINER  0x04000100
>  #define TINCANTOOLS_SHOWDOG  0x03000100
>  #define KBADC_BEAGLEFPGA 0x01000600
> +#define LW_BEAGLETOUCH   0x01000700
> +#define LCDOG_BRAINMUX   0x01000800
> +#define LCDOG_BRAINMUXTOUCH  0x02000800
> +#define SF_HARDHAT   0x01000900
^^

Where is this being used?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Respect is a rational process
-- McCoy, "The Galileo Seven", stardate 2822.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] ARMV7: OMAP3: BeagleBoard: add more expansionboard IDs

2010-11-04 Thread Jason Kridner 
From: Koen Kooi 

Signed-off-by: Koen Kooi 
Signed-off-by: Jason Kridner 
---
 board/ti/beagle/beagle.c |   16 
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c
index d9b6f01..520e57d 100644
--- a/board/ti/beagle/beagle.c
+++ b/board/ti/beagle/beagle.c
@@ -48,6 +48,10 @@
 #define TINCANTOOLS_TRAINER0x04000100
 #define TINCANTOOLS_SHOWDOG0x03000100
 #define KBADC_BEAGLEFPGA   0x01000600
+#define LW_BEAGLETOUCH 0x01000700
+#define LCDOG_BRAINMUX 0x01000800
+#define LCDOG_BRAINMUXTOUCH0x02000800
+#define SF_HARDHAT 0x01000900
 
 #define BEAGLE_NO_EEPROM   0x
 
@@ -223,6 +227,18 @@ int misc_init_r(void)
MUX_KBADC_BEAGLEFPGA();
setenv("buddy", "beaglefpga");
break;
+   case LW_BEAGLETOUCH:
+   printf("Recognized Liquidware Beagletouch board\n");
+   setenv("buddy", "beagletouch");
+   break;
+   case LCDOG_BRAINMUX:
+   printf("Recognized Brainmux LCDog board\n");
+   setenv("buddy", "lcdog");
+   break;
+   case LCDOG_BRAINMUXTOUCH:
+   printf("Recognized Brainmux LCDog Touch board\n");
+   setenv("buddy", "lcdogtouch");
+   break;
case BEAGLE_NO_EEPROM:
printf("No EEPROM on expansion board\n");
setenv("buddy", "none");
-- 
1.5.6.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot