Re: [U-Boot] [PATCH 07/14][v2] drivers: fsl-mc: Return error for major version mismatch

[Joe Hershberger]

Hi Prabhakar,

On Thu, Jun 11, 2015 at 4:03 AM, Prabhakar Kushwaha
prabha...@freescale.com wrote:
 Management complex major version should match to the firmware present in 
 flash.

 Return error during mismatch of major version.

 Signed-off-by: Prabhakar Kushwaha prabha...@freescale.com
 ---
 Changes for v2: Sending as it is for patchset

  drivers/net/fsl-mc/mc.c | 7 ++-
  1 file changed, 6 insertions(+), 1 deletion(-)

 diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
 index 2094595..c4406c6 100644
 --- a/drivers/net/fsl-mc/mc.c
 +++ b/drivers/net/fsl-mc/mc.c
 @@ -518,9 +518,14 @@ int mc_init(void)
 goto out;
 }

 -   if (MC_VER_MAJOR != mc_ver_info.major)
 +   if (MC_VER_MAJOR != mc_ver_info.major) {
 printf(fsl-mc: ERROR: Firmware major version mismatch 
 (found: %d, expected: %d)\n,
mc_ver_info.major, MC_VER_MAJOR);
 +   printf(fsl-mc: Update the Management Complex firmware\n);
 +
 +   error = 1;

Please use:
+   error = -ENODEV;

 +   goto out;
 +   }

 if (MC_VER_MINOR != mc_ver_info.minor)
 printf(fsl-mc: WARNING: Firmware minor version mismatch 
 (found: %d, expected: %d)\n,
 --
 1.9.1


 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 07/14][v2] drivers: fsl-mc: Return error for major version mismatch

[Prabhakar Kushwaha]

Management complex major version should match to the firmware present in flash.

Return error during mismatch of major version.

Signed-off-by: Prabhakar Kushwaha prabha...@freescale.com
---
Changes for v2: Sending as it is for patchset

 drivers/net/fsl-mc/mc.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
index 2094595..c4406c6 100644
--- a/drivers/net/fsl-mc/mc.c
+++ b/drivers/net/fsl-mc/mc.c
@@ -518,9 +518,14 @@ int mc_init(void)
goto out;
}
 
-   if (MC_VER_MAJOR != mc_ver_info.major)
+   if (MC_VER_MAJOR != mc_ver_info.major) {
printf(fsl-mc: ERROR: Firmware major version mismatch (found: 
%d, expected: %d)\n,
   mc_ver_info.major, MC_VER_MAJOR);
+   printf(fsl-mc: Update the Management Complex firmware\n);
+
+   error = 1;
+   goto out;
+   }
 
if (MC_VER_MINOR != mc_ver_info.minor)
printf(fsl-mc: WARNING: Firmware minor version mismatch 
(found: %d, expected: %d)\n,
-- 
1.9.1


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot