Re: [U-Boot] [PATCH 2/4] udoo: Add SATA disk support.

[Giuseppe Pagano]

On Thu, 2013-11-07 at 09:40 +0100, Stefano Babic wrote:
> Hi Giuseppe,
> 
> On 06/11/2013 21:37, Giuseppe Pagano wrote:
> > Add Sata support on uDoo Board.
> > 
> > Signed-off-by: Giuseppe Pagano 
> > Cc: sba...@denx.de
> > 
> > ---

> > +#ifdef CONFIG_CMD_SATA
> > +int setup_sata(void)
> > +{
> > +   struct iomuxc_base_regs *const iomuxc_regs
> > +   = (struct iomuxc_base_regs *)IOMUXC_BASE_ADDR;
> > +
> > +   int ret = enable_sata_clock();
> > +   if (ret)
> > +   return ret;
> > +
> > +   clrsetbits_le32(&iomuxc_regs->gpr[13],
> > +   IOMUXC_GPR13_SATA_MASK,
> > +   IOMUXC_GPR13_SATA_PHY_8_RXEQ_3P0DB
> > +   |IOMUXC_GPR13_SATA_PHY_7_SATA2M
> > +   |IOMUXC_GPR13_SATA_SPEED_3G
> > +   |(3< > +   |IOMUXC_GPR13_SATA_SATA_PHY_5_SS_DISABLED
> > +   |IOMUXC_GPR13_SATA_SATA_PHY_4_ATTEN_9_16
> > +   |IOMUXC_GPR13_SATA_PHY_3_TXBOOST_0P00_DB
> > +   |IOMUXC_GPR13_SATA_PHY_2_TX_1P104V
> > +   |IOMUXC_GPR13_SATA_PHY_1_SLOW);
> > +
> > +   return 0;
> > +}
> > +#endif
> 
> Do not copy code ! If you want to reuse functions from nitrogen, please
> factorize the function and put it into imx-common, thanks.

Ok, I'll do. 
I'm going to produce a new udoo patch with git send-patch and I'll
submit as v2 of this one. 

> Best regards,
> Stefano Babic

Best regards,
Giuseppe Pagano


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/4] udoo: Add SATA disk support.

[Stefano Babic]

Hi Giuseppe,

On 06/11/2013 21:37, Giuseppe Pagano wrote:
> Add Sata support on uDoo Board.
> 
> Signed-off-by: Giuseppe Pagano 
> Cc: sba...@denx.de
> 
> ---
> 
> diff -uNr a/board/udoo/udoo.c b/board/udoo/udoo.c
> --- a/board/udoo/udoo.c   2013-11-06 18:45:22.0 +0100
> +++ b/board/udoo/udoo.c   2013-11-06 18:46:00.0 +0100
> @@ -208,6 +208,32 @@
>   return 0;
>  }
>  
> +#ifdef CONFIG_CMD_SATA
> +int setup_sata(void)
> +{
> + struct iomuxc_base_regs *const iomuxc_regs
> + = (struct iomuxc_base_regs *)IOMUXC_BASE_ADDR;
> +
> + int ret = enable_sata_clock();
> + if (ret)
> + return ret;
> +
> + clrsetbits_le32(&iomuxc_regs->gpr[13],
> + IOMUXC_GPR13_SATA_MASK,
> + IOMUXC_GPR13_SATA_PHY_8_RXEQ_3P0DB
> + |IOMUXC_GPR13_SATA_PHY_7_SATA2M
> + |IOMUXC_GPR13_SATA_SPEED_3G
> + |(3< + |IOMUXC_GPR13_SATA_SATA_PHY_5_SS_DISABLED
> + |IOMUXC_GPR13_SATA_SATA_PHY_4_ATTEN_9_16
> + |IOMUXC_GPR13_SATA_PHY_3_TXBOOST_0P00_DB
> + |IOMUXC_GPR13_SATA_PHY_2_TX_1P104V
> + |IOMUXC_GPR13_SATA_PHY_1_SLOW);
> +
> + return 0;
> +}
> +#endif

Do not copy code ! If you want to reuse functions from nitrogen, please
factorize the function and put it into imx-common, thanks.

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 2/4] udoo: Add SATA disk support.

[Giuseppe Pagano]

Add Sata support on uDoo Board.

Signed-off-by: Giuseppe Pagano 
Cc: sba...@denx.de

---

diff -uNr a/board/udoo/udoo.c b/board/udoo/udoo.c
--- a/board/udoo/udoo.c 2013-11-06 18:45:22.0 +0100
+++ b/board/udoo/udoo.c 2013-11-06 18:46:00.0 +0100
@@ -208,6 +208,32 @@
return 0;
 }
 
+#ifdef CONFIG_CMD_SATA
+int setup_sata(void)
+{
+   struct iomuxc_base_regs *const iomuxc_regs
+   = (struct iomuxc_base_regs *)IOMUXC_BASE_ADDR;
+
+   int ret = enable_sata_clock();
+   if (ret)
+   return ret;
+
+   clrsetbits_le32(&iomuxc_regs->gpr[13],
+   IOMUXC_GPR13_SATA_MASK,
+   IOMUXC_GPR13_SATA_PHY_8_RXEQ_3P0DB
+   |IOMUXC_GPR13_SATA_PHY_7_SATA2M
+   |IOMUXC_GPR13_SATA_SPEED_3G
+   |(3bi_boot_params = PHYS_SDRAM + 0x100;
 
+#ifdef CONFIG_CMD_SATA
+   setup_sata();
+#endif
return 0;
 }
 
diff -uNr a/include/configs/udoo.h b/include/configs/udoo.h
--- a/include/configs/udoo.h2013-11-06 18:45:22.0 +0100
+++ b/include/configs/udoo.h2013-11-06 18:46:27.0 +0100
@@ -34,6 +34,19 @@
 #define CONFIG_MXC_UART
 #define CONFIG_MXC_UART_BASE   UART2_BASE
 
+#define CONFIG_CMD_SATA
+/*
+ * SATA Configs
+ */
+#ifdef CONFIG_CMD_SATA
+#define CONFIG_DWC_AHSATA
+#define CONFIG_SYS_SATA_MAX_DEVICE 1
+#define CONFIG_DWC_AHSATA_PORT_ID  0
+#define CONFIG_DWC_AHSATA_BASE_ADDRSATA_ARB_BASE_ADDR
+#define CONFIG_LBA48
+#define CONFIG_LIBATA
+#endif
+
 /* Network support */
 
 #define CONFIG_CMD_PING


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot