Re: [U-Boot] [PATCH v2] universal_c210: check the NULL pointer when get the PMIC

[Minkyu Kang]

On 11/12/12 16:57, Lukasz Majewski wrote:
> Hi Minkyu,
> 
>> PMIC 2.0 require to test return pointer from pmic_get()
>>
>> Signed-off-by: Minkyu Kang 
>> Cc: Lukasz Majewski 
>> Cc: Wolfgang Denk 
>> ---
>> Changes in V2:
>>  - Since functions are void type, remove the return value.
>>
>>  board/samsung/universal_c210/universal.c |6 ++
>>  1 file changed, 6 insertions(+)
>>

applied to u-boot-samsung/resolve.

Thanks.
Minkyu Kang.

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] universal_c210: check the NULL pointer when get the PMIC

[Lukasz Majewski]

Hi Minkyu,

> PMIC 2.0 require to test return pointer from pmic_get()
> 
> Signed-off-by: Minkyu Kang 
> Cc: Lukasz Majewski 
> Cc: Wolfgang Denk 
> ---
> Changes in V2:
>   - Since functions are void type, remove the return value.
> 
>  board/samsung/universal_c210/universal.c |6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/board/samsung/universal_c210/universal.c
> b/board/samsung/universal_c210/universal.c index 4869798..e742707
> 100644 --- a/board/samsung/universal_c210/universal.c
> +++ b/board/samsung/universal_c210/universal.c
> @@ -343,6 +343,9 @@ static void init_pmic_lcd(void)
>  
>   struct pmic *p = pmic_get("MAX8998_PMIC");
>  
> + if (!p)
> + return;
> +
>   if (pmic_probe(p))
>   return;
>  
> @@ -434,6 +437,9 @@ static void lcd_power_on(void)
>  {
>   struct pmic *p = pmic_get("MAX8998_PMIC");
>  
> + if (!p)
> + return;
> +
>   if (pmic_probe(p))
>   return;
>  

Acked-by: Lukasz Majewski 


-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2] universal_c210: check the NULL pointer when get the PMIC

[Minkyu Kang]

PMIC 2.0 require to test return pointer from pmic_get()

Signed-off-by: Minkyu Kang 
Cc: Lukasz Majewski 
Cc: Wolfgang Denk 
---
Changes in V2:
- Since functions are void type, remove the return value.

 board/samsung/universal_c210/universal.c |6 ++
 1 file changed, 6 insertions(+)

diff --git a/board/samsung/universal_c210/universal.c 
b/board/samsung/universal_c210/universal.c
index 4869798..e742707 100644
--- a/board/samsung/universal_c210/universal.c
+++ b/board/samsung/universal_c210/universal.c
@@ -343,6 +343,9 @@ static void init_pmic_lcd(void)
 
struct pmic *p = pmic_get("MAX8998_PMIC");
 
+   if (!p)
+   return;
+
if (pmic_probe(p))
return;
 
@@ -434,6 +437,9 @@ static void lcd_power_on(void)
 {
struct pmic *p = pmic_get("MAX8998_PMIC");
 
+   if (!p)
+   return;
+
if (pmic_probe(p))
return;
 
-- 
1.7.9.5
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot