Re: [U-Boot] [PATCH v4] Program net device MAC addresses after initializing

2010-04-27 Thread Thomas Chou 
On 04/27/2010 02:23 AM, Ben Warren wrote:
 Add a new function to the eth_device struct for programming a network
 controller's hardware address.

 After all network devices have been initialized and the proper MAC address
 for each has been determined, make a device driver call to program the
 address into the device.  Only device instances with valid unicast addresses
 will be programmed.

 Signed-off-by: Ben Warrenbiggerbadder...@gmail.com
 Acked-by: Heiko Schocherh...@denx.de
 Acked-by: Detlev Zundeld...@denx.de
 Tested-by: Prafulla Wadaskarprafu...@marvell.com

Tested using ethoc and altera_tse driver on nios2 NEEK and EP3C120 boards.

Tested-by: Thomas Chou tho...@wytron.com.tw

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4] Program net device MAC addresses after initializing

2010-04-27 Thread Ben Warren 
On 4/26/2010 11:23 AM, Ben Warren wrote:
 Add a new function to the eth_device struct for programming a network
 controller's hardware address.

 After all network devices have been initialized and the proper MAC address
 for each has been determined, make a device driver call to program the
 address into the device.  Only device instances with valid unicast addresses
 will be programmed.

 Signed-off-by: Ben Warrenbiggerbadder...@gmail.com
 Acked-by: Heiko Schocherh...@denx.de
 Acked-by: Detlev Zundeld...@denx.de
 Tested-by: Prafulla Wadaskarprafu...@marvell.com
 ---

Numerous positive test reports, no NAKs.  Adding to net repo.

regards,
Ben
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4] Program net device MAC addresses after initializing

2010-04-26 Thread Heiko Schocher 
Hello Ben,

Ben Warren wrote:
 Add a new function to the eth_device struct for programming a network
 controller's hardware address.
 
 After all network devices have been initialized and the proper MAC address
 for each has been determined, make a device driver call to program the
 address into the device.  Only device instances with valid unicast addresses
 will be programmed.
 
 Signed-off-by: Ben Warren biggerbadder...@gmail.com
 Acked-by: Heiko Schocher h...@denx.de
 Acked-by: Detlev Zundel d...@denx.de
 Tested-by: Prafulla Wadaskar prafu...@marvell.com
 ---
 v4-v3 First controller uses 'ethmacskip' instead of 'eth0macskip'
 v2-v3 Made the sprintf in new function actually work :(
 v1-v2 Add documentation  environment variable for overriding new behavior
 ACKs mentioned above are for v1
 
  README |5 +
  doc/README.drivers.eth |7 ++-
  doc/README.enetaddr|   10 ++
  include/net.h  |1 +
  net/eth.c  |   13 +
  5 files changed, 31 insertions(+), 5 deletions(-)

Tested on the magnesium board, patch for adapting fec_mxc
driver follow, so:

Tested-by: Heiko Schocher h...@denx.de

bye
Heiko
-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot