Re: [PATCH] nvme: Correct the prps per page calculation method
On Wed, Jun 23, 2021 at 4:53 PM Bin Meng wrote: > > On Tue, Jun 22, 2021 at 11:34 AM Wesley Sheng wrote: > > > > From: Wesley Sheng > > > > Each prp is 8 bytes, calculate the number of prps > > per page should just divide page size by 8 > > there is no need to minus 1 > > > > Signed-off-by: Wesley Sheng > > --- > > drivers/nvme/nvme.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Bin Meng applied to u-boot-x86, thanks!
Re: [PATCH] nvme: Correct the prps per page calculation method
On Tue, Jun 22, 2021 at 11:34 AM Wesley Sheng wrote: > > From: Wesley Sheng > > Each prp is 8 bytes, calculate the number of prps > per page should just divide page size by 8 > there is no need to minus 1 > > Signed-off-by: Wesley Sheng > --- > drivers/nvme/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng
[PATCH] nvme: Correct the prps per page calculation method
From: Wesley Sheng Each prp is 8 bytes, calculate the number of prps per page should just divide page size by 8 there is no need to minus 1 Signed-off-by: Wesley Sheng --- drivers/nvme/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index fc64d93ab8..622bb378c0 100644 --- a/drivers/nvme/nvme.c +++ b/drivers/nvme/nvme.c @@ -79,7 +79,7 @@ static int nvme_setup_prps(struct nvme_dev *dev, u64 *prp2, u64 *prp_pool; int length = total_len; int i, nprps; - u32 prps_per_page = (page_size >> 3) - 1; + u32 prps_per_page = page_size >> 3; u32 num_pages; length -= (page_size - offset); -- 2.25.1
Re: [PATCH] nvme: Correct the prps per page calculation method
On Wed, Jun 16, 2021 at 12:09 PM Wesley Sheng wrote: > > From: wesleywesley nits: are you sure this name is correct? Should it be "Wesley Sheng"? > > Each prp is 8 bytes, calculate the number of prps > per page should just divide page size by 8 > there is no need to minus 1 > > Signed-off-by: wesleywesley > --- > drivers/nvme/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng
[PATCH] nvme: Correct the prps per page calculation method
From: wesleywesley Each prp is 8 bytes, calculate the number of prps per page should just divide page size by 8 there is no need to minus 1 Signed-off-by: wesleywesley --- drivers/nvme/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index fc64d93ab8..622bb378c0 100644 --- a/drivers/nvme/nvme.c +++ b/drivers/nvme/nvme.c @@ -79,7 +79,7 @@ static int nvme_setup_prps(struct nvme_dev *dev, u64 *prp2, u64 *prp_pool; int length = total_len; int i, nprps; - u32 prps_per_page = (page_size >> 3) - 1; + u32 prps_per_page = page_size >> 3; u32 num_pages; length -= (page_size - offset); -- 2.25.1
