Re: [PATCH v5 08/10] mtd: spi-nor-core: Add Cypress manufacturer ID in set_4byte
On 2/24/2021 9:11 PM, Pratyush Yadav wrote: > On 19/02/21 10:56AM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> Cypress chips support SPINOR_OP_EN4B(B7h)/SPINOR_OP_EX4B(E9h) to > > The datasheet says the EN4B command is indeed B7h but EX4B is listed as > B8h. The command E9h is for "Password Unlock". So exiting 4 byte mode > will do something completely different. > How stupid of me! Thank you for thorough review.
Re: [PATCH v5 08/10] mtd: spi-nor-core: Add Cypress manufacturer ID in set_4byte
On 19/02/21 10:56AM, tkuw584...@gmail.com wrote: > From: Takahiro Kuwano > > Cypress chips support SPINOR_OP_EN4B(B7h)/SPINOR_OP_EX4B(E9h) to The datasheet says the EN4B command is indeed B7h but EX4B is listed as B8h. The command E9h is for "Password Unlock". So exiting 4 byte mode will do something completely different. > enable/disable 4-byte addressing mode. > > Signed-off-by: Takahiro Kuwano > --- > drivers/mtd/spi/spi-nor-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c > index 46948ed41b..8d63681cb3 100644 > --- a/drivers/mtd/spi/spi-nor-core.c > +++ b/drivers/mtd/spi/spi-nor-core.c > @@ -492,6 +492,7 @@ static int set_4byte(struct spi_nor *nor, const struct > flash_info *info, > case SNOR_MFR_ISSI: > case SNOR_MFR_MACRONIX: > case SNOR_MFR_WINBOND: > + case SNOR_MFR_CYPRESS: > if (need_wren) > write_enable(nor); > > -- > 2.25.1 > -- Regards, Pratyush Yadav Texas Instruments Inc.
[PATCH v5 08/10] mtd: spi-nor-core: Add Cypress manufacturer ID in set_4byte
From: Takahiro Kuwano Cypress chips support SPINOR_OP_EN4B(B7h)/SPINOR_OP_EX4B(E9h) to enable/disable 4-byte addressing mode. Signed-off-by: Takahiro Kuwano --- drivers/mtd/spi/spi-nor-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c index 46948ed41b..8d63681cb3 100644 --- a/drivers/mtd/spi/spi-nor-core.c +++ b/drivers/mtd/spi/spi-nor-core.c @@ -492,6 +492,7 @@ static int set_4byte(struct spi_nor *nor, const struct flash_info *info, case SNOR_MFR_ISSI: case SNOR_MFR_MACRONIX: case SNOR_MFR_WINBOND: + case SNOR_MFR_CYPRESS: if (need_wren) write_enable(nor); -- 2.25.1
