Re: [U-Boot] [PATCH] arm: socfpga: Add samtec VIN|ING board

2016-04-28 Thread Dinh Nguyen 


On 04/27/2016 06:49 PM, Marek Vasut wrote:

>>
>> With my patch[1], you don't need all of those common configs, all you
>> need is:
>>
>> #define CONFIG_CMD_DFU
>> #define CONFIG_CMD_USB
>> #define CONFIG_CMD_USB_MASS_STORAGE
> 
> Well since there are changes in that, are you fine if I pick this board
> as-is for next ?
> 

Yes.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] arm: socfpga: Add samtec VIN|ING board

2016-04-27 Thread Marek Vasut 
On 04/28/2016 02:57 AM, Tom Rini wrote:
> On Thu, Apr 28, 2016 at 01:49:38AM +0200, Marek Vasut wrote:
>> On 04/13/2016 11:53 PM, Dinh Nguyen wrote:
>>> On 04/13/2016 07:24 AM, Marek Vasut wrote:
 Add support for board based on the popular Altera Cyclone V SoC.
 This board has the following properties:
  - 1 GiB of DRAM
  - 1 Gigabit ethernet
  - 1 USB gadget port
  - 1 USB host port with an on-board hub
  - 2 QSPI NORs connected to the Cadence QSPI core
  - Multiple I2C EEPROMs and one I2C temperature sensor

 Signed-off-by: Marek Vasut 
 Cc: Dinh Nguyen 
 Cc: Chin Liang See 
 ---
>>>
>>> [snip]
>>>
 --- /dev/null
 +++ b/include/configs/socfpga_vining_fpga.h
 @@ -0,0 +1,246 @@
 +/*
 + * Copyright (C) 2015 Marek Vasut 
 + *
 + * SPDX-License-Identifier:   GPL-2.0+
 + */
 +#ifndef __CONFIG_SAMTEC_VINING_FPGA_H__
 +#define __CONFIG_SAMTEC_VINING_FPGA_H__
 +
 +#include 
 +
 +/* U-Boot Commands */
 +#define CONFIG_SYS_NO_FLASH
 +#define CONFIG_DOS_PARTITION
 +#define CONFIG_FAT_WRITE
 +#define CONFIG_HW_WATCHDOG
 +
 +#define CONFIG_CMD_ASKENV
 +#define CONFIG_CMD_BOOTZ
 +#define CONFIG_CMD_CACHE
 +#define CONFIG_CMD_DFU
 +#define CONFIG_CMD_DHCP
 +#define CONFIG_CMD_EEPROM
 +#define CONFIG_CMD_EXT4
 +#define CONFIG_CMD_EXT4_WRITE
 +#define CONFIG_CMD_FAT
 +#define CONFIG_CMD_FS_GENERIC
 +#define CONFIG_CMD_GREPENV
 +#define CONFIG_CMD_LED
 +#define CONFIG_CMD_MII
 +#define CONFIG_CMD_MMC
 +#define CONFIG_CMD_PING
 +#define CONFIG_CMD_USB
 +#define CONFIG_CMD_USB_MASS_STORAGE
 +
>>>
>>> With my patch[1], you don't need all of those common configs, all you
>>> need is:
>>>
>>> #define CONFIG_CMD_DFU
>>> #define CONFIG_CMD_USB
>>> #define CONFIG_CMD_USB_MASS_STORAGE
>>
>> Well since there are changes in that, are you fine if I pick this board
>> as-is for next ?
> 
> You, or anyone else, picking up "old" board ports

This is a new board port, about two weeks old. Technology is moving fast
nowadays ;-)

> to apply now need to
> either ask people to re-spin the series or run moveconfig yourself to
> make sure that everything (except CMD_NAND) in cmd/Kconfig is done in
> the defconfig and not the config.h file.  For example, those last 3
> Kconfig'd right now.

CMD_EEPROM and CMD_LED are not I believe. Do you have any example of the
moveconfig , so I can try it ?


-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] arm: socfpga: Add samtec VIN|ING board

2016-04-27 Thread Tom Rini 
On Thu, Apr 28, 2016 at 01:49:38AM +0200, Marek Vasut wrote:
> On 04/13/2016 11:53 PM, Dinh Nguyen wrote:
> > On 04/13/2016 07:24 AM, Marek Vasut wrote:
> >> Add support for board based on the popular Altera Cyclone V SoC.
> >> This board has the following properties:
> >>  - 1 GiB of DRAM
> >>  - 1 Gigabit ethernet
> >>  - 1 USB gadget port
> >>  - 1 USB host port with an on-board hub
> >>  - 2 QSPI NORs connected to the Cadence QSPI core
> >>  - Multiple I2C EEPROMs and one I2C temperature sensor
> >>
> >> Signed-off-by: Marek Vasut 
> >> Cc: Dinh Nguyen 
> >> Cc: Chin Liang See 
> >> ---
> > 
> > [snip]
> > 
> >> --- /dev/null
> >> +++ b/include/configs/socfpga_vining_fpga.h
> >> @@ -0,0 +1,246 @@
> >> +/*
> >> + * Copyright (C) 2015 Marek Vasut 
> >> + *
> >> + * SPDX-License-Identifier:   GPL-2.0+
> >> + */
> >> +#ifndef __CONFIG_SAMTEC_VINING_FPGA_H__
> >> +#define __CONFIG_SAMTEC_VINING_FPGA_H__
> >> +
> >> +#include 
> >> +
> >> +/* U-Boot Commands */
> >> +#define CONFIG_SYS_NO_FLASH
> >> +#define CONFIG_DOS_PARTITION
> >> +#define CONFIG_FAT_WRITE
> >> +#define CONFIG_HW_WATCHDOG
> >> +
> >> +#define CONFIG_CMD_ASKENV
> >> +#define CONFIG_CMD_BOOTZ
> >> +#define CONFIG_CMD_CACHE
> >> +#define CONFIG_CMD_DFU
> >> +#define CONFIG_CMD_DHCP
> >> +#define CONFIG_CMD_EEPROM
> >> +#define CONFIG_CMD_EXT4
> >> +#define CONFIG_CMD_EXT4_WRITE
> >> +#define CONFIG_CMD_FAT
> >> +#define CONFIG_CMD_FS_GENERIC
> >> +#define CONFIG_CMD_GREPENV
> >> +#define CONFIG_CMD_LED
> >> +#define CONFIG_CMD_MII
> >> +#define CONFIG_CMD_MMC
> >> +#define CONFIG_CMD_PING
> >> +#define CONFIG_CMD_USB
> >> +#define CONFIG_CMD_USB_MASS_STORAGE
> >> +
> > 
> > With my patch[1], you don't need all of those common configs, all you
> > need is:
> > 
> > #define CONFIG_CMD_DFU
> > #define CONFIG_CMD_USB
> > #define CONFIG_CMD_USB_MASS_STORAGE
> 
> Well since there are changes in that, are you fine if I pick this board
> as-is for next ?

You, or anyone else, picking up "old" board ports to apply now need to
either ask people to re-spin the series or run moveconfig yourself to
make sure that everything (except CMD_NAND) in cmd/Kconfig is done in
the defconfig and not the config.h file.  For example, those last 3
Kconfig'd right now.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] arm: socfpga: Add samtec VIN|ING board

2016-04-27 Thread Marek Vasut 
On 04/13/2016 11:53 PM, Dinh Nguyen wrote:
> On 04/13/2016 07:24 AM, Marek Vasut wrote:
>> Add support for board based on the popular Altera Cyclone V SoC.
>> This board has the following properties:
>>  - 1 GiB of DRAM
>>  - 1 Gigabit ethernet
>>  - 1 USB gadget port
>>  - 1 USB host port with an on-board hub
>>  - 2 QSPI NORs connected to the Cadence QSPI core
>>  - Multiple I2C EEPROMs and one I2C temperature sensor
>>
>> Signed-off-by: Marek Vasut 
>> Cc: Dinh Nguyen 
>> Cc: Chin Liang See 
>> ---
> 
> [snip]
> 
>> --- /dev/null
>> +++ b/include/configs/socfpga_vining_fpga.h
>> @@ -0,0 +1,246 @@
>> +/*
>> + * Copyright (C) 2015 Marek Vasut 
>> + *
>> + * SPDX-License-Identifier: GPL-2.0+
>> + */
>> +#ifndef __CONFIG_SAMTEC_VINING_FPGA_H__
>> +#define __CONFIG_SAMTEC_VINING_FPGA_H__
>> +
>> +#include 
>> +
>> +/* U-Boot Commands */
>> +#define CONFIG_SYS_NO_FLASH
>> +#define CONFIG_DOS_PARTITION
>> +#define CONFIG_FAT_WRITE
>> +#define CONFIG_HW_WATCHDOG
>> +
>> +#define CONFIG_CMD_ASKENV
>> +#define CONFIG_CMD_BOOTZ
>> +#define CONFIG_CMD_CACHE
>> +#define CONFIG_CMD_DFU
>> +#define CONFIG_CMD_DHCP
>> +#define CONFIG_CMD_EEPROM
>> +#define CONFIG_CMD_EXT4
>> +#define CONFIG_CMD_EXT4_WRITE
>> +#define CONFIG_CMD_FAT
>> +#define CONFIG_CMD_FS_GENERIC
>> +#define CONFIG_CMD_GREPENV
>> +#define CONFIG_CMD_LED
>> +#define CONFIG_CMD_MII
>> +#define CONFIG_CMD_MMC
>> +#define CONFIG_CMD_PING
>> +#define CONFIG_CMD_USB
>> +#define CONFIG_CMD_USB_MASS_STORAGE
>> +
> 
> With my patch[1], you don't need all of those common configs, all you
> need is:
> 
> #define CONFIG_CMD_DFU
> #define CONFIG_CMD_USB
> #define CONFIG_CMD_USB_MASS_STORAGE

Well since there are changes in that, are you fine if I pick this board
as-is for next ?

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] arm: socfpga: Add samtec VIN|ING board

2016-04-13 Thread Marek Vasut 
On 04/13/2016 11:53 PM, Dinh Nguyen wrote:
> On 04/13/2016 07:24 AM, Marek Vasut wrote:
>> Add support for board based on the popular Altera Cyclone V SoC.
>> This board has the following properties:
>>  - 1 GiB of DRAM
>>  - 1 Gigabit ethernet
>>  - 1 USB gadget port
>>  - 1 USB host port with an on-board hub
>>  - 2 QSPI NORs connected to the Cadence QSPI core
>>  - Multiple I2C EEPROMs and one I2C temperature sensor
>>
>> Signed-off-by: Marek Vasut 
>> Cc: Dinh Nguyen 
>> Cc: Chin Liang See 
>> ---
> 
> [snip]
> 
>> --- /dev/null
>> +++ b/include/configs/socfpga_vining_fpga.h
>> @@ -0,0 +1,246 @@
>> +/*
>> + * Copyright (C) 2015 Marek Vasut 
>> + *
>> + * SPDX-License-Identifier: GPL-2.0+
>> + */
>> +#ifndef __CONFIG_SAMTEC_VINING_FPGA_H__
>> +#define __CONFIG_SAMTEC_VINING_FPGA_H__
>> +
>> +#include 
>> +
>> +/* U-Boot Commands */
>> +#define CONFIG_SYS_NO_FLASH
>> +#define CONFIG_DOS_PARTITION
>> +#define CONFIG_FAT_WRITE
>> +#define CONFIG_HW_WATCHDOG
>> +
>> +#define CONFIG_CMD_ASKENV
>> +#define CONFIG_CMD_BOOTZ
>> +#define CONFIG_CMD_CACHE
>> +#define CONFIG_CMD_DFU
>> +#define CONFIG_CMD_DHCP
>> +#define CONFIG_CMD_EEPROM
>> +#define CONFIG_CMD_EXT4
>> +#define CONFIG_CMD_EXT4_WRITE
>> +#define CONFIG_CMD_FAT
>> +#define CONFIG_CMD_FS_GENERIC
>> +#define CONFIG_CMD_GREPENV
>> +#define CONFIG_CMD_LED
>> +#define CONFIG_CMD_MII
>> +#define CONFIG_CMD_MMC
>> +#define CONFIG_CMD_PING
>> +#define CONFIG_CMD_USB
>> +#define CONFIG_CMD_USB_MASS_STORAGE
>> +
> 
> With my patch[1], you don't need all of those common configs, all you
> need is:
> 
> #define CONFIG_CMD_DFU
> #define CONFIG_CMD_USB
> #define CONFIG_CMD_USB_MASS_STORAGE

You're right, I also commented on your patch :) Let's see how the
discussion goes and I'll ev. send a V2 here.

> Thanks,
> Dinh
> 
> [1] http://lists.denx.de/pipermail/u-boot/2016-April/251654.html
> 


-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] arm: socfpga: Add samtec VIN|ING board

2016-04-13 Thread Dinh Nguyen 
On 04/13/2016 07:24 AM, Marek Vasut wrote:
> Add support for board based on the popular Altera Cyclone V SoC.
> This board has the following properties:
>  - 1 GiB of DRAM
>  - 1 Gigabit ethernet
>  - 1 USB gadget port
>  - 1 USB host port with an on-board hub
>  - 2 QSPI NORs connected to the Cadence QSPI core
>  - Multiple I2C EEPROMs and one I2C temperature sensor
> 
> Signed-off-by: Marek Vasut 
> Cc: Dinh Nguyen 
> Cc: Chin Liang See 
> ---

[snip]

> --- /dev/null
> +++ b/include/configs/socfpga_vining_fpga.h
> @@ -0,0 +1,246 @@
> +/*
> + * Copyright (C) 2015 Marek Vasut 
> + *
> + * SPDX-License-Identifier:  GPL-2.0+
> + */
> +#ifndef __CONFIG_SAMTEC_VINING_FPGA_H__
> +#define __CONFIG_SAMTEC_VINING_FPGA_H__
> +
> +#include 
> +
> +/* U-Boot Commands */
> +#define CONFIG_SYS_NO_FLASH
> +#define CONFIG_DOS_PARTITION
> +#define CONFIG_FAT_WRITE
> +#define CONFIG_HW_WATCHDOG
> +
> +#define CONFIG_CMD_ASKENV
> +#define CONFIG_CMD_BOOTZ
> +#define CONFIG_CMD_CACHE
> +#define CONFIG_CMD_DFU
> +#define CONFIG_CMD_DHCP
> +#define CONFIG_CMD_EEPROM
> +#define CONFIG_CMD_EXT4
> +#define CONFIG_CMD_EXT4_WRITE
> +#define CONFIG_CMD_FAT
> +#define CONFIG_CMD_FS_GENERIC
> +#define CONFIG_CMD_GREPENV
> +#define CONFIG_CMD_LED
> +#define CONFIG_CMD_MII
> +#define CONFIG_CMD_MMC
> +#define CONFIG_CMD_PING
> +#define CONFIG_CMD_USB
> +#define CONFIG_CMD_USB_MASS_STORAGE
> +

With my patch[1], you don't need all of those common configs, all you
need is:

#define CONFIG_CMD_DFU
#define CONFIG_CMD_USB
#define CONFIG_CMD_USB_MASS_STORAGE


Thanks,
Dinh

[1] http://lists.denx.de/pipermail/u-boot/2016-April/251654.html

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] arm: socfpga: Add samtec VIN|ING board

2016-04-13 Thread Marek Vasut 
Add support for board based on the popular Altera Cyclone V SoC.
This board has the following properties:
 - 1 GiB of DRAM
 - 1 Gigabit ethernet
 - 1 USB gadget port
 - 1 USB host port with an on-board hub
 - 2 QSPI NORs connected to the Cadence QSPI core
 - Multiple I2C EEPROMs and one I2C temperature sensor

Signed-off-by: Marek Vasut 
Cc: Dinh Nguyen 
Cc: Chin Liang See 
---
 arch/arm/dts/Makefile |   3 +-
 arch/arm/dts/socfpga_cyclone5_vining_fpga.dts | 113 +
 arch/arm/mach-socfpga/Kconfig |   7 +
 board/samtec/vining_fpga/MAINTAINERS  |   5 +
 board/samtec/vining_fpga/Makefile |   9 +
 board/samtec/vining_fpga/qts/iocsr_config.h   | 660 ++
 board/samtec/vining_fpga/qts/pinmux_config.h  | 219 +
 board/samtec/vining_fpga/qts/pll_config.h |  91 
 board/samtec/vining_fpga/qts/sdram_config.h   | 341 +
 board/samtec/vining_fpga/socfpga.c| 100 
 configs/socfpga_vining_fpga_defconfig |  31 ++
 include/configs/socfpga_vining_fpga.h | 246 ++
 12 files changed, 1824 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/socfpga_cyclone5_vining_fpga.dts
 create mode 100644 board/samtec/vining_fpga/MAINTAINERS
 create mode 100644 board/samtec/vining_fpga/Makefile
 create mode 100644 board/samtec/vining_fpga/qts/iocsr_config.h
 create mode 100644 board/samtec/vining_fpga/qts/pinmux_config.h
 create mode 100644 board/samtec/vining_fpga/qts/pll_config.h
 create mode 100644 board/samtec/vining_fpga/qts/sdram_config.h
 create mode 100644 board/samtec/vining_fpga/socfpga.c
 create mode 100644 configs/socfpga_vining_fpga_defconfig
 create mode 100644 include/configs/socfpga_vining_fpga.h

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 01cf030..f6ab820 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -93,7 +93,8 @@ dtb-$(CONFIG_ARCH_SOCFPGA) += \
socfpga_cyclone5_de0_nano_soc.dtb   \
socfpga_cyclone5_sockit.dtb \
socfpga_cyclone5_socrates.dtb   \
-   socfpga_cyclone5_sr1500.dtb
+   socfpga_cyclone5_sr1500.dtb \
+   socfpga_cyclone5_vining_fpga.dtb
 
 dtb-$(CONFIG_TARGET_DRA7XX_EVM) += dra72-evm.dtb dra7-evm.dtb
 dtb-$(CONFIG_TARGET_BEAGLE_X15) += am57xx-beagle-x15.dtb
diff --git a/arch/arm/dts/socfpga_cyclone5_vining_fpga.dts 
b/arch/arm/dts/socfpga_cyclone5_vining_fpga.dts
new file mode 100644
index 000..f168e4f
--- /dev/null
+++ b/arch/arm/dts/socfpga_cyclone5_vining_fpga.dts
@@ -0,0 +1,113 @@
+/*
+ * Copyright (C) 2015 Marek Vasut 
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+#include "socfpga_cyclone5.dtsi"
+
+/ {
+   model = "samtec VIN|ING FPGA";
+   compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+
+   chosen {
+   bootargs = "console=ttyS0,115200";
+   };
+
+   aliases {
+   ethernet0 = 
+   udc0 = 
+   };
+
+   memory {
+   name = "memory";
+   device_type = "memory";
+   reg = <0x0 0x4000>; /* 1GB */
+   };
+
+   soc {
+   u-boot,dm-pre-reloc;
+   };
+};
+
+ {
+   status = "okay";
+   phy-mode = "rgmii";
+
+   rxd0-skew-ps = <0>;
+   rxd1-skew-ps = <0>;
+   rxd2-skew-ps = <0>;
+   rxd3-skew-ps = <0>;
+   txen-skew-ps = <0>;
+   txc-skew-ps = <2600>;
+   rxdv-skew-ps = <0>;
+   rxc-skew-ps = <2000>;
+};
+
+ {
+   status = "okay";
+};
+
+ {
+   status = "okay";
+};
+
+ {
+   status = "okay";
+};
+
+ {
+   status = "okay";
+
+   rtc: rtc@68 {
+   compatible = "stm,m41t82";
+   reg = <0x68>;
+   };
+};
+
+ {
+   status = "okay";
+   u-boot,dm-pre-reloc;
+
+   flash0: n25q128@0 {
+   u-boot,dm-pre-reloc;
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "n25q128", "spi-flash";
+   reg = <0>;  /* chip select */
+   spi-max-frequency = <5000>;
+   m25p,fast-read;
+   page-size = <256>;
+   block-size = <16>; /* 2^16, 64KB */
+   read-delay = <4>;  /* delay value in read data capture register 
*/
+   tshsl-ns = <50>;
+   tsd2d-ns = <50>;
+   tchsh-ns = <4>;
+   tslch-ns = <4>;
+   };
+
+   flash1: n25q00@1 {
+   u-boot,dm-pre-reloc;
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "n25q00", "spi-flash";
+   reg = <1>;  /* chip select */
+   spi-max-frequency = <5000>;
+   m25p,fast-read;
+   page-size = <256>;
+   block-size = <16>; /* 2^16,