Re: [U-Boot] [PATCH] net: smsc95xx: Use correct get_unaligned functions

[Joe Hershberger]

Hi Mark,

On Mon, Jun 13, 2016 at 3:59 PM, Chris Packham  wrote:
> On Mon, Jun 13, 2016 at 8:01 PM, Chris Packham  
> wrote:
>> Hi Mark,
>>
>> On Mon, Jun 13, 2016 at 5:00 PM, Mark Tomlinson
>>  wrote:
>>> The __get_unaligned_le* functions may not be declared on all platforms.
>>> Instead, get_unaligned_le* should be used. On many platforms both of
>>> these are the same function.
>>>
>>> Change-Id: If28222615e85a6f34f3fde42eb21c6f56a2cb988
>>
>> We shouldn't let these leak out of $work. This doesn't really mean
>> anything to anyone without access to our internal review system.
>>
>>> Reviewed-by: Chris Packham 
>>
>> For what it's worth - this is me I usually post with my gmail account
>> because it's better for managing high volume mailing lists.
>
> Also your signed-off line is missing.

Can I expect a v2?

Thanks,
-Joe
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net: smsc95xx: Use correct get_unaligned functions

[Chris Packham]

On Mon, Jun 13, 2016 at 8:01 PM, Chris Packham  wrote:
> Hi Mark,
>
> On Mon, Jun 13, 2016 at 5:00 PM, Mark Tomlinson
>  wrote:
>> The __get_unaligned_le* functions may not be declared on all platforms.
>> Instead, get_unaligned_le* should be used. On many platforms both of
>> these are the same function.
>>
>> Change-Id: If28222615e85a6f34f3fde42eb21c6f56a2cb988
>
> We shouldn't let these leak out of $work. This doesn't really mean
> anything to anyone without access to our internal review system.
>
>> Reviewed-by: Chris Packham 
>
> For what it's worth - this is me I usually post with my gmail account
> because it's better for managing high volume mailing lists.

Also your signed-off line is missing.

>
>> ---
>>  drivers/usb/eth/smsc95xx.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
>> index 08eaed5..7d9abfd 100644
>> --- a/drivers/usb/eth/smsc95xx.c
>> +++ b/drivers/usb/eth/smsc95xx.c
>> @@ -391,8 +391,8 @@ static int smsc95xx_write_hwaddr_common(struct 
>> usb_device *udev,
>> struct smsc95xx_private *priv,
>> unsigned char *enetaddr)
>>  {
>> -   u32 addr_lo = __get_unaligned_le32([0]);
>> -   u32 addr_hi = __get_unaligned_le16([4]);
>> +   u32 addr_lo = get_unaligned_le32([0]);
>> +   u32 addr_hi = get_unaligned_le16([4]);
>> int ret;
>>
>> /* set hardware address */
>> --
>> 2.8.4
>>
>> ___
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net: smsc95xx: Use correct get_unaligned functions

[Chris Packham]

Hi Mark,

On Mon, Jun 13, 2016 at 5:00 PM, Mark Tomlinson
 wrote:
> The __get_unaligned_le* functions may not be declared on all platforms.
> Instead, get_unaligned_le* should be used. On many platforms both of
> these are the same function.
>
> Change-Id: If28222615e85a6f34f3fde42eb21c6f56a2cb988

We shouldn't let these leak out of $work. This doesn't really mean
anything to anyone without access to our internal review system.

> Reviewed-by: Chris Packham 

For what it's worth - this is me I usually post with my gmail account
because it's better for managing high volume mailing lists.

> ---
>  drivers/usb/eth/smsc95xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
> index 08eaed5..7d9abfd 100644
> --- a/drivers/usb/eth/smsc95xx.c
> +++ b/drivers/usb/eth/smsc95xx.c
> @@ -391,8 +391,8 @@ static int smsc95xx_write_hwaddr_common(struct usb_device 
> *udev,
> struct smsc95xx_private *priv,
> unsigned char *enetaddr)
>  {
> -   u32 addr_lo = __get_unaligned_le32([0]);
> -   u32 addr_hi = __get_unaligned_le16([4]);
> +   u32 addr_lo = get_unaligned_le32([0]);
> +   u32 addr_hi = get_unaligned_le16([4]);
> int ret;
>
> /* set hardware address */
> --
> 2.8.4
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] net: smsc95xx: Use correct get_unaligned functions

[Mark Tomlinson]

The __get_unaligned_le* functions may not be declared on all platforms.
Instead, get_unaligned_le* should be used. On many platforms both of
these are the same function.

Change-Id: If28222615e85a6f34f3fde42eb21c6f56a2cb988
Reviewed-by: Chris Packham 
---
 drivers/usb/eth/smsc95xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
index 08eaed5..7d9abfd 100644
--- a/drivers/usb/eth/smsc95xx.c
+++ b/drivers/usb/eth/smsc95xx.c
@@ -391,8 +391,8 @@ static int smsc95xx_write_hwaddr_common(struct usb_device 
*udev,
struct smsc95xx_private *priv,
unsigned char *enetaddr)
 {
-   u32 addr_lo = __get_unaligned_le32([0]);
-   u32 addr_hi = __get_unaligned_le16([4]);
+   u32 addr_lo = get_unaligned_le32([0]);
+   u32 addr_hi = get_unaligned_le16([4]);
int ret;
 
/* set hardware address */
-- 
2.8.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot