Re: [U-Boot] [PATCH 2/4] dm: usb: host: xhci-dwc3: add missing #ifdef CONFIG_DM_USB

[Simon Glass]

Hi Marek,

On 6 August 2017 at 13:17, Marek Vasut  wrote:
> On 08/06/2017 07:15 AM, Simon Glass wrote:
>> On 24 July 2017 at 09:07,   wrote:
>>> From: Patrice Chotard 
>>>
>>> Add CONFIG_DM_USB flag to avoid following compilation errors
>>> detected by buildman :
>>> +drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
>>> +drivers/usb/host/xhci-dwc3.c:168: undefined reference to `xhci_deregister'
>>> +drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
>>> +drivers/usb/host/xhci-dwc3.c:145: undefined reference to `usb_get_dr_mode'
>>> +drivers/usb/host/xhci-dwc3.c:152: undefined reference to `xhci_register'
>>>
>>> introduced by patch d5c3f014da3 "usb: host: xhci-dwc3: Convert driver to DM"
>>>
>>> Signed-off-by: Patrice Chotard 
>>> Reported-by: Ran Wang 
>>> ---
>>>  drivers/usb/host/xhci-dwc3.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>
>> Reviewed-by: Simon Glass 
>>
> Um, this patch was applied like two weeks ago. Is this some automated
> botmail ... reviewman ? :)

There is no mention of it being applied on this thread, so it looked
like an open patch to me.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/4] dm: usb: host: xhci-dwc3: add missing #ifdef CONFIG_DM_USB

[Marek Vasut]

On 08/06/2017 07:15 AM, Simon Glass wrote:
> On 24 July 2017 at 09:07,   wrote:
>> From: Patrice Chotard 
>>
>> Add CONFIG_DM_USB flag to avoid following compilation errors
>> detected by buildman :
>> +drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
>> +drivers/usb/host/xhci-dwc3.c:168: undefined reference to `xhci_deregister'
>> +drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
>> +drivers/usb/host/xhci-dwc3.c:145: undefined reference to `usb_get_dr_mode'
>> +drivers/usb/host/xhci-dwc3.c:152: undefined reference to `xhci_register'
>>
>> introduced by patch d5c3f014da3 "usb: host: xhci-dwc3: Convert driver to DM"
>>
>> Signed-off-by: Patrice Chotard 
>> Reported-by: Ran Wang 
>> ---
>>  drivers/usb/host/xhci-dwc3.c | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Reviewed-by: Simon Glass 
> 
Um, this patch was applied like two weeks ago. Is this some automated
botmail ... reviewman ? :)

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/4] dm: usb: host: xhci-dwc3: add missing #ifdef CONFIG_DM_USB

[Simon Glass]

On 24 July 2017 at 09:07,   wrote:
> From: Patrice Chotard 
>
> Add CONFIG_DM_USB flag to avoid following compilation errors
> detected by buildman :
> +drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
> +drivers/usb/host/xhci-dwc3.c:168: undefined reference to `xhci_deregister'
> +drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
> +drivers/usb/host/xhci-dwc3.c:145: undefined reference to `usb_get_dr_mode'
> +drivers/usb/host/xhci-dwc3.c:152: undefined reference to `xhci_register'
>
> introduced by patch d5c3f014da3 "usb: host: xhci-dwc3: Convert driver to DM"
>
> Signed-off-by: Patrice Chotard 
> Reported-by: Ran Wang 
> ---
>  drivers/usb/host/xhci-dwc3.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/4] dm: usb: host: xhci-dwc3: add missing #ifdef CONFIG_DM_USB

[patrice.chotard]

From: Patrice Chotard 

Add CONFIG_DM_USB flag to avoid following compilation errors
detected by buildman :
+drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
+drivers/usb/host/xhci-dwc3.c:168: undefined reference to `xhci_deregister'
+drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
+drivers/usb/host/xhci-dwc3.c:145: undefined reference to `usb_get_dr_mode'
+drivers/usb/host/xhci-dwc3.c:152: undefined reference to `xhci_register'

introduced by patch d5c3f014da3 "usb: host: xhci-dwc3: Convert driver to DM"

Signed-off-by: Patrice Chotard 
Reported-by: Ran Wang 
---
 drivers/usb/host/xhci-dwc3.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/host/xhci-dwc3.c b/drivers/usb/host/xhci-dwc3.c
index 374fe74..541a785 100644
--- a/drivers/usb/host/xhci-dwc3.c
+++ b/drivers/usb/host/xhci-dwc3.c
@@ -111,6 +111,7 @@ void dwc3_set_fladj(struct dwc3 *dwc3_reg, u32 val)
GFLADJ_30MHZ(val));
 }
 
+#ifdef CONFIG_DM_USB
 static int xhci_dwc3_probe(struct udevice *dev)
 {
struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
@@ -184,3 +185,4 @@ U_BOOT_DRIVER(xhci_dwc3) = {
.platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata),
.flags = DM_FLAG_ALLOC_PRIV_DMA,
 };
+#endif
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot