Re: [U-Boot] [PATCH v2] powerpc: mpc5xxx: remove redundant CONFIG_MPC5xxx definition

2014-01-15 Thread Gerhard Sittig 
On Tue, Jan 14, 2014 at 17:26 +0900, Masahiro Yamada wrote:
 
 diff --git a/include/configs/BC3450.h b/include/configs/BC3450.h
 index 377db7b..ad69d33 100644
 --- a/include/configs/BC3450.h
 +++ b/include/configs/BC3450.h
 @@ -22,7 +22,6 @@
  /*
   * High Level Configuration Options
   */
 -#define CONFIG_MPC5xxx   1   /* This is an MPC5xxx CPU   
 */
  #define CONFIG_MPC5200   1   /* (more precisely a MPC5200 
 CPU)   */
  #define CONFIG_TQM5200   1   /* ... on a TQM5200 module  
 */
  

Haven't checked all of the patch, just by coincidence spotted
this one.  The removal of one of the preprocessor lines loses
information in the right hand side comment.  After the patch the
remaining text looks odd.


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: off...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] powerpc: mpc5xxx: remove redundant CONFIG_MPC5xxx definition

2014-01-15 Thread Masahiro Yamada 
Hello Gerhard,


* High Level Configuration Options
*/
  -#define CONFIG_MPC5xxx 1   /* This is an MPC5xxx CPU   
  */
   #define CONFIG_MPC5200 1   /* (more precisely a MPC5200 
  CPU)   */
   #define CONFIG_TQM5200 1   /* ... on a TQM5200 module  
  */
   
 
 Haven't checked all of the patch, just by coincidence spotted
 this one.  The removal of one of the preprocessor lines loses
 information in the right hand side comment.  After the patch the
 remaining text looks odd.

Good find!

I posted v3.

I also checked the others and I think this is the only one to be fixed.

Best Regards
Masahiro Yamada

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2] powerpc: mpc5xxx: remove redundant CONFIG_MPC5xxx definition

2014-01-14 Thread Masahiro Yamada 
We do not have to define CONFIG_MPC5xxx in board config headers
(and start.S) because it is defined in arch/powerpc/cpu/mpc5xxx/config.mk.

Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com
---

Changes in v2:
  - Fix a typo in the subject:  s/redandant/redundant/

 arch/powerpc/cpu/mpc5xxx/start.S   | 2 --
 include/configs/BC3450.h   | 1 -
 include/configs/IceCube.h  | 1 -
 include/configs/MVBC_P.h   | 1 -
 include/configs/MVSMR.h| 1 -
 include/configs/PM520.h| 1 -
 include/configs/TB5200.h   | 1 -
 include/configs/TOP5200.h  | 1 -
 include/configs/TQM5200.h  | 1 -
 include/configs/Total5200.h| 1 -
 include/configs/a3m071.h   | 1 -
 include/configs/a4m072.h   | 1 -
 include/configs/aev.h  | 1 -
 include/configs/canmb.h| 1 -
 include/configs/cm5200.h   | 1 -
 include/configs/cpci5200.h | 1 -
 include/configs/digsy_mtc.h| 1 -
 include/configs/galaxy5200.h   | 1 -
 include/configs/hmi1001.h  | 1 -
 include/configs/inka4x0.h  | 1 -
 include/configs/ipek01.h   | 1 -
 include/configs/jupiter.h  | 1 -
 include/configs/manroland/mpc5200-common.h | 1 -
 include/configs/mcc200.h   | 1 -
 include/configs/mecp5200.h | 1 -
 include/configs/motionpro.h| 1 -
 include/configs/munices.h  | 1 -
 include/configs/o2dnt-common.h | 1 -
 include/configs/pcm030.h   | 1 -
 include/configs/pf5200.h   | 1 -
 include/configs/v38b.h | 1 -
 31 files changed, 32 deletions(-)

diff --git a/arch/powerpc/cpu/mpc5xxx/start.S b/arch/powerpc/cpu/mpc5xxx/start.S
index 84ab41e..02c706e 100644
--- a/arch/powerpc/cpu/mpc5xxx/start.S
+++ b/arch/powerpc/cpu/mpc5xxx/start.S
@@ -14,8 +14,6 @@
 #include mpc5xxx.h
 #include version.h
 
-#define CONFIG_MPC5xxx 1   /* needed for Linux kernel header files */
-
 #include ppc_asm.tmpl
 #include ppc_defs.h
 
diff --git a/include/configs/BC3450.h b/include/configs/BC3450.h
index 377db7b..ad69d33 100644
--- a/include/configs/BC3450.h
+++ b/include/configs/BC3450.h
@@ -22,7 +22,6 @@
 /*
  * High Level Configuration Options
  */
-#define CONFIG_MPC5xxx 1   /* This is an MPC5xxx CPU   */
 #define CONFIG_MPC5200 1   /* (more precisely a MPC5200 CPU)   */
 #define CONFIG_TQM5200 1   /* ... on a TQM5200 module  */
 
diff --git a/include/configs/IceCube.h b/include/configs/IceCube.h
index 52368f8..ca49a99 100644
--- a/include/configs/IceCube.h
+++ b/include/configs/IceCube.h
@@ -13,7 +13,6 @@
  * (easy to change)
  */
 
-#define CONFIG_MPC5xxx 1   /* This is an MPC5xxx CPU */
 #define CONFIG_MPC5200 1   /* (more precisely a MPC5200 CPU) */
 #define CONFIG_ICECUBE 1   /* ... on IceCube board */
 
diff --git a/include/configs/MVBC_P.h b/include/configs/MVBC_P.h
index 9d49de7..99e4e90 100644
--- a/include/configs/MVBC_P.h
+++ b/include/configs/MVBC_P.h
@@ -13,7 +13,6 @@
 
 #include version.h
 
-#define CONFIG_MPC5xxx 1
 #define CONFIG_MPC5200 1
 
 #ifndef CONFIG_SYS_TEXT_BASE
diff --git a/include/configs/MVSMR.h b/include/configs/MVSMR.h
index f69b9a8..bb565b6 100644
--- a/include/configs/MVSMR.h
+++ b/include/configs/MVSMR.h
@@ -13,7 +13,6 @@
 
 #include version.h
 
-#define CONFIG_MPC5xxx 1
 #define CONFIG_MPC5200 1
 
 #ifndef CONFIG_SYS_TEXT_BASE
diff --git a/include/configs/PM520.h b/include/configs/PM520.h
index 557a8ba..767ffdc 100644
--- a/include/configs/PM520.h
+++ b/include/configs/PM520.h
@@ -14,7 +14,6 @@
  */
 
 #define CONFIG_MPC5200
-#define CONFIG_MPC5xxx 1   /* This is an MPC5xxx CPU */
 #define CONFIG_PM520   1   /* ... on PM520 board */
 
 #defineCONFIG_SYS_TEXT_BASE0xfff0
diff --git a/include/configs/TB5200.h b/include/configs/TB5200.h
index 90f7fc4..af550aa 100644
--- a/include/configs/TB5200.h
+++ b/include/configs/TB5200.h
@@ -16,7 +16,6 @@
  * (easy to change)
  */
 
-#define CONFIG_MPC5xxx 1   /* This is an MPC5xxx CPU */
 #define CONFIG_MPC5200 1   /* (more precisely an MPC5200 CPU) */
 #define CONFIG_TQM5200 1   /* ... on TQM5200 module */
 #define CONFIG_TB5200  1   /* ... on a TB5200 base board */
diff --git a/include/configs/TOP5200.h b/include/configs/TOP5200.h
index 7aba009..e19201f 100644
--- a/include/configs/TOP5200.h
+++ b/include/configs/TOP5200.h
@@ -25,7 +25,6 @@
  * (easy to change)
  */
 
-#define CONFIG_MPC5xxx 1   /* This is an MPC5xxx CPU */
 #define CONFIG_MPC5200 1   /* More exactly a MPC5200 */
 #define CONFIG_TOP5200 1   /* ... on TOP5200 board - we need this