Re: [PATCH] i2c: stm32f7: SYSCFG Fast Mode Plus support for I2C STM32F7

2020-07-09 Thread Heiko Schocher

Hello Patrick,

Am 06.07.2020 um 13:31 schrieb Patrick Delaunay:

Read SYSCFG bindings to set Fast Mode Plus bits if Fast Mode Plus
speed is selected.

Handle the stm32mp15 specific compatible to handle FastMode+
registers handling which is different on the stm32mp15 compared
to the stm32f7 or stm32h7.
Indeed, on the stm32mp15, the FastMode+ set and clear registers
are separated while on the other platforms (F7 or H7) the control
is done in a unique register.

Signed-off-by: Patrick Delaunay 
---

  drivers/i2c/stm32f7_i2c.c | 74 ++-
  1 file changed, 73 insertions(+), 1 deletion(-)


Applied to u-boot-i2c.git master

Thanks!

bye,
Heiko
--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de


RE: [PATCH] i2c: stm32f7: SYSCFG Fast Mode Plus support for I2C STM32F7

2020-07-08 Thread Patrick DELAUNAY
Hi Heiko

> From: Heiko Schocher 
> Sent: mardi 7 juillet 2020 07:21
> 
> Hello Patrick,
> 
> Am 06.07.2020 um 13:31 schrieb Patrick Delaunay:
> > Read SYSCFG bindings to set Fast Mode Plus bits if Fast Mode Plus
> > speed is selected.
> >
> > Handle the stm32mp15 specific compatible to handle FastMode+ registers
> > handling which is different on the stm32mp15 compared to the stm32f7
> > or stm32h7.
> > Indeed, on the stm32mp15, the FastMode+ set and clear registers are
> > separated while on the other platforms (F7 or H7) the control is done
> > in a unique register.
> >
> > Signed-off-by: Patrick Delaunay 
> > ---
> >
> >   drivers/i2c/stm32f7_i2c.c | 74
> ++-
> >   1 file changed, 73 insertions(+), 1 deletion(-)
> 
> Just tried to apply your patch on current mainline, but this fails for me, 
> reason is
> missing patch:
> 
> http://patchwork.ozlabs.org/project/uboot/patch/20200706112653.18951-2-
> patrick.delau...@st.com/
> 
> So I add this patch also to my repo, if nobody has objections.

No objection for me (as u-boot stm32 custodians / shared with Patrice Chotard),
You can take the in tiny patch in your repo.

I delegate the serie to Patrice only to have a review before merge this serie 
in stm32 tree.
But he is in holiday... and I wait him for my next pull request (including this 
serie).
 
> Beside of this:
> 
> Reviewed-by: Heiko Schocher 

Thanks.
 
> Thanks!
> 
> bye,
> Heiko

Regards,
Patrick

> --
> DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de


Re: [PATCH] i2c: stm32f7: SYSCFG Fast Mode Plus support for I2C STM32F7

2020-07-06 Thread Heiko Schocher

Hello Patrick,

Am 06.07.2020 um 13:31 schrieb Patrick Delaunay:

Read SYSCFG bindings to set Fast Mode Plus bits if Fast Mode Plus
speed is selected.

Handle the stm32mp15 specific compatible to handle FastMode+
registers handling which is different on the stm32mp15 compared
to the stm32f7 or stm32h7.
Indeed, on the stm32mp15, the FastMode+ set and clear registers
are separated while on the other platforms (F7 or H7) the control
is done in a unique register.

Signed-off-by: Patrick Delaunay 
---

  drivers/i2c/stm32f7_i2c.c | 74 ++-
  1 file changed, 73 insertions(+), 1 deletion(-)


Just tried to apply your patch on current mainline, but this fails
for me, reason is missing patch:

http://patchwork.ozlabs.org/project/uboot/patch/20200706112653.18951-2-patrick.delau...@st.com/

So I add this patch also to my repo, if nobody has objections.

Beside of this:

Reviewed-by: Heiko Schocher 

Thanks!

bye,
Heiko
--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de