Re: [U-Boot] [PATCH 7/7] Tegra114: Add/enable Dalmore build (T114 reference board)

2013-01-16 Thread Stephen Warren
On 01/16/2013 02:14 PM, Tom Warren wrote:
> This build is stripped down. It boots to the command prompt.
> GPIO is the only peripheral supported. Others TBD.

> diff --git a/board/nvidia/dalmore/dalmore.c b/board/nvidia/dalmore/dalmore.c

> +void pinmux_init(void)
> +{
> + pinmux_config_table(tegra3_pinmux_common,
> + ARRAY_SIZE(tegra3_pinmux_common));

I assume that should say "tegra114" not "tegra3"?

> diff --git a/include/configs/dalmore.h b/include/configs/dalmore.h

> +/* Must be off for Dalmore to boot !?!? FIXME */
> +#define CONFIG_SYS_DCACHE_OFF

Who knows if there is any A15 core/cache controller support in U-Boot yet?

Aside from any comments I've made, the series, briefly,
Reviewed-by: Stephen Warren 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 7/7] Tegra114: Add/enable Dalmore build (T114 reference board)

2013-01-17 Thread Tom Warren
Stephen,

On Wed, Jan 16, 2013 at 3:51 PM, Stephen Warren  wrote:
> On 01/16/2013 02:14 PM, Tom Warren wrote:
>> This build is stripped down. It boots to the command prompt.
>> GPIO is the only peripheral supported. Others TBD.
>
>> diff --git a/board/nvidia/dalmore/dalmore.c b/board/nvidia/dalmore/dalmore.c
>
>> +void pinmux_init(void)
>> +{
>> + pinmux_config_table(tegra3_pinmux_common,
>> + ARRAY_SIZE(tegra3_pinmux_common));
>
> I assume that should say "tegra114" not "tegra3"?
>

Yep, good catch. Fixed in V2.

>> diff --git a/include/configs/dalmore.h b/include/configs/dalmore.h
>
>> +/* Must be off for Dalmore to boot !?!? FIXME */
>> +#define CONFIG_SYS_DCACHE_OFF
>
> Who knows if there is any A15 core/cache controller support in U-Boot yet?
>

None that I can see, but A15 is a hard keyword to grep for in U-Boot.

Albert?

> Aside from any comments I've made, the series, briefly,
> Reviewed-by: Stephen Warren 
Thanks
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 7/7] Tegra114: Add/enable Dalmore build (T114 reference board)

2013-01-21 Thread Simon Glass
Hi Stephen,

On Wed, Jan 16, 2013 at 2:51 PM, Stephen Warren  wrote:
> On 01/16/2013 02:14 PM, Tom Warren wrote:
>> This build is stripped down. It boots to the command prompt.
>> GPIO is the only peripheral supported. Others TBD.
>
>> diff --git a/board/nvidia/dalmore/dalmore.c b/board/nvidia/dalmore/dalmore.c
>
>> +void pinmux_init(void)
>> +{
>> + pinmux_config_table(tegra3_pinmux_common,
>> + ARRAY_SIZE(tegra3_pinmux_common));
>
> I assume that should say "tegra114" not "tegra3"?
>
>> diff --git a/include/configs/dalmore.h b/include/configs/dalmore.h
>
>> +/* Must be off for Dalmore to boot !?!? FIXME */
>> +#define CONFIG_SYS_DCACHE_OFF
>
> Who knows if there is any A15 core/cache controller support in U-Boot yet?

Sort-of. It works ok for me on snow, so long as you have a patch to
enable L2 support.

Regards,
Simon

>
> Aside from any comments I've made, the series, briefly,
> Reviewed-by: Stephen Warren 
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 7/7] Tegra114: Add/enable Dalmore build (T114 reference board)

2013-01-22 Thread Tom Warren
Simon,

On Mon, Jan 21, 2013 at 4:07 PM, Simon Glass  wrote:
> Hi Stephen,
>
> On Wed, Jan 16, 2013 at 2:51 PM, Stephen Warren  wrote:
>> On 01/16/2013 02:14 PM, Tom Warren wrote:
>>> This build is stripped down. It boots to the command prompt.
>>> GPIO is the only peripheral supported. Others TBD.
>>
>>> diff --git a/board/nvidia/dalmore/dalmore.c b/board/nvidia/dalmore/dalmore.c
>>
>>> +void pinmux_init(void)
>>> +{
>>> + pinmux_config_table(tegra3_pinmux_common,
>>> + ARRAY_SIZE(tegra3_pinmux_common));
>>
>> I assume that should say "tegra114" not "tegra3"?
>>
>>> diff --git a/include/configs/dalmore.h b/include/configs/dalmore.h
>>
>>> +/* Must be off for Dalmore to boot !?!? FIXME */
>>> +#define CONFIG_SYS_DCACHE_OFF
>>
>> Who knows if there is any A15 core/cache controller support in U-Boot yet?
>
> Sort-of. It works ok for me on snow, so long as you have a patch to
> enable L2 support.

Which patch, exactly, to enable L2 support? I'd like to test it on T114.

Thanks
>
> Regards,
> Simon
>
>>
>> Aside from any comments I've made, the series, briefly,
>> Reviewed-by: Stephen Warren 
>> ___
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 7/7] Tegra114: Add/enable Dalmore build (T114 reference board)

2013-01-22 Thread Simon Glass
Hi Tom,

On Tue, Jan 22, 2013 at 12:47 PM, Tom Warren  wrote:
> Simon,
>
> On Mon, Jan 21, 2013 at 4:07 PM, Simon Glass  wrote:
>> Hi Stephen,
>>
>> On Wed, Jan 16, 2013 at 2:51 PM, Stephen Warren  
>> wrote:
>>> On 01/16/2013 02:14 PM, Tom Warren wrote:
 This build is stripped down. It boots to the command prompt.
 GPIO is the only peripheral supported. Others TBD.
>>>
 diff --git a/board/nvidia/dalmore/dalmore.c 
 b/board/nvidia/dalmore/dalmore.c
>>>
 +void pinmux_init(void)
 +{
 + pinmux_config_table(tegra3_pinmux_common,
 + ARRAY_SIZE(tegra3_pinmux_common));
>>>
>>> I assume that should say "tegra114" not "tegra3"?
>>>
 diff --git a/include/configs/dalmore.h b/include/configs/dalmore.h
>>>
 +/* Must be off for Dalmore to boot !?!? FIXME */
 +#define CONFIG_SYS_DCACHE_OFF
>>>
>>> Who knows if there is any A15 core/cache controller support in U-Boot yet?
>>
>> Sort-of. It works ok for me on snow, so long as you have a patch to
>> enable L2 support.
>
> Which patch, exactly, to enable L2 support? I'd like to test it on T114.

I was thinking about this one (it will need porting and perhaps can
become partly common?)

http://patchwork.ozlabs.org/patch/202874/

Regards,
Simon

>
> Thanks
>>
>> Regards,
>> Simon
>>
>>>
>>> Aside from any comments I've made, the series, briefly,
>>> Reviewed-by: Stephen Warren 
>>> ___
>>> U-Boot mailing list
>>> U-Boot@lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot