Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Simon Glass]

Hi Tom,

On 16 February 2016 at 13:13, Tom Warren  wrote:
> Simon,
>
> 
>
>> >>
>> >> I think it was the follow-up patches to add the environment
>> >> work-around that was applied.
>> >>
>> >> 6c88b51 video: tegra: Enable the 'lcd' env variable work-around
>> >> a2931b3 dm: video: Add a temporary work-around for old stdout var
>> >>
>> >> I see the original v2 series here:
>> >>
>> >> http://patchwork.ozlabs.org/project/uboot/list/?delegate=4839
>> >>
>> >> so that is what needs to be applied I think. Then the Tegra config
>> >> issue should be fixed.
>> > I've applied the 23 v2 DM video patches to u-boot-tegra/master, then
>> rebased against current u-boot/master.
>> >
>> > I see the 'warning: (TEGRA_COMMON) selects VIDCONSOLE_AS_LCD which
>> has unmet direct dependencies (DM_VIDEO)' spew for almost every board
>> (w/MAKEALL -s tegra).
>> >
>> > Am I missing some patches?
>>
>> I'll make some time to look but I am tied up most of the day so it will be 
>> later,
>> sorry.
>>
>> The original series is at u-boot-dm/rke-working if that helps.
> I pulled down rke-working. The two commits you list above are *not* in that 
> repo/branch. They _are_ in my u-boot-tegra/next branch (just pushed it to 
> Denx).
> So building rke-working for tegra doesn't result in the DM_VIDEO warning, 
> since the commits aren't there.
>
> Back to you.
>
> Tom

I found that tegra boards without the display enabled generate this
warning. I've sent a patch.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Tom Warren]

Simon,



> >>
> >> I think it was the follow-up patches to add the environment
> >> work-around that was applied.
> >>
> >> 6c88b51 video: tegra: Enable the 'lcd' env variable work-around
> >> a2931b3 dm: video: Add a temporary work-around for old stdout var
> >>
> >> I see the original v2 series here:
> >>
> >> http://patchwork.ozlabs.org/project/uboot/list/?delegate=4839
> >>
> >> so that is what needs to be applied I think. Then the Tegra config
> >> issue should be fixed.
> > I've applied the 23 v2 DM video patches to u-boot-tegra/master, then
> rebased against current u-boot/master.
> >
> > I see the 'warning: (TEGRA_COMMON) selects VIDCONSOLE_AS_LCD which
> has unmet direct dependencies (DM_VIDEO)' spew for almost every board
> (w/MAKEALL -s tegra).
> >
> > Am I missing some patches?
> 
> I'll make some time to look but I am tied up most of the day so it will be 
> later,
> sorry.
> 
> The original series is at u-boot-dm/rke-working if that helps.
I pulled down rke-working. The two commits you list above are *not* in that 
repo/branch. They _are_ in my u-boot-tegra/next branch (just pushed it to Denx).
So building rke-working for tegra doesn't result in the DM_VIDEO warning, since 
the commits aren't there.

Back to you.

Tom
--
nvpublic

> 
> Regards,
> Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Simon Glass]

Hi Tom,

On 16 February 2016 at 09:23, Tom Warren  wrote:
> Simon,
>
>> -Original Message-
>> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass
>> Sent: Tuesday, February 16, 2016 9:03 AM
>> To: Tom Warren 
>> Cc: Stephen Warren ; U-Boot Mailing List > b...@lists.denx.de>; Marcel Ziswiler ; Stephen
>> Warren ; Pantelis Antoniou > consulting.com>; Marek Vasut ; Pavel Herrmann
>> ; Anatolij Gustschin 
>> Subject: Re: [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video
>> drivers to driver model
>>
>> Hi Tom,
>>
>> On 16 February 2016 at 08:47, Tom Warren  wrote:
>> >
>> > Simon
>> >
>> > > -Original Message-
>> > > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon
>> > > Glass
>> > > Sent: Sunday, February 14, 2016 6:19 PM
>> > > To: Stephen Warren 
>> > > Cc: U-Boot Mailing List ; Marcel Ziswiler
>> > > ; Tom Warren ;
>> > > Stephen Warren ; Pantelis Antoniou
>> > > ; Marek Vasut
>> > > ; Pavel Herrmann ;
>> > > Anatolij Gustschin 
>> > > Subject: Re: [PATCH v2 00/23] dm: tegra: Convert tegra20 and
>> > > tegra124 video drivers to driver model
>> > >
>> > > Hi,
>> > >
>> > > On 1 February 2016 at 17:00, Stephen Warren 
>> > > wrote:
>> > > >
>> > > > On 01/30/2016 04:37 PM, Simon Glass wrote:
>> > > >>
>> > > >> This series moves these two drivers over to use driver model for 
>> > > >> video.
>> > > >>
>> > > >> This involves the following steps:
>> > > >> - Sync up some device tree files with Linux
>> > > >> - Implement a proper PWM driver
>> > > >> - Clean up and unify the driver code
>> > > >> - Modify the existing drivers to work with driver model
>> > > >>
>> > > >> The tegra20 display driver uses device tree bindings invented in
>> > > >> 2011 before Linux had this or anyone was able to agree a
>> > > >> standard. It seems possible to move it to the new bindings (like
>> > > >> tegra124) except for the issue of time delays between stages. It
>> > > >> isn't clear how this should work, and Linux implements this by
>> > > >> including all LCD definitions in the kernel source code, and not
>> > > >> using any delays. This causes strange display artifacts on the
>> > > >> display when starting up, but perhaps is harmless to the display.
>> > > >> Future work will sync up the device tree more for seaboard, and thus
>> tidy this up for nvidia boards.
>> > > >>
>> > > >> A bug in the keyboard driver is also fixed by this series. The
>> > > >> series is tested on seaboard and nyan-big, the two boards I have
>> > > >> which support a display.
>> > > >>
>> > > >> This series is available at u-boot-dm/tegra-working.
>> > > >
>> > > >
>> > > > This changes the name of the output device from "lcd" to "vidconsole".
>> > > Anyone who doesn't reset their environment to default when switching
>> > > to this new U-Boot will lose their display output because of this.
>> > > Is there any way to maintain compatibility?
>> > > >
>> > > > Aside from that, I don't see any issues on Springbank (Seaboard),
>> > > > Harmony, Ventana, Paz00, or p2371-2180, so the series,
>> > > > Tested-by: Stephen Warren 
>> > >
>> > > It looks like some of the patches have been applied and all Tegra
>> > > boards are now giving Kconfig warnings.
>> > >
>> > > Tom Warren, are you able to pick up the rest of the series?
>> > I had thought these had already gone in via the dm repo. If not, please 
>> > list
>> those that still need to be picked up and I'll take them in via tegra. Best 
>> to
>> assign the appropriate ones to me in patchwork. Currently it seems they're 
>> all
>> assigned to me. Which patches have already been applied?
>>
>> I think it was the follow-up patches to add the environment work-around that
>> was applied.
>>
>> 6c88b51 video: tegra: Enable the 'lcd' env variable work-around
>> a2931b3 dm: video: Add a temporary work-around for old stdout var
>>
>> I see the original v2 series here:
>>
>> http://patchwork.ozlabs.org/project/uboot/list/?delegate=4839
>>
>> so that is what needs to be applied I think. Then the Tegra config issue 
>> should
>> be fixed.
> I've applied the 23 v2 DM video patches to u-boot-tegra/master, then rebased 
> against current u-boot/master.
>
> I see the 'warning: (TEGRA_COMMON) selects VIDCONSOLE_AS_LCD which has unmet 
> direct dependencies (DM_VIDEO)' spew for almost every board (w/MAKEALL -s 
> tegra).
>
> Am I missing some patches?

I'll make some time to look but I am tied up most of the day so it
will be later, sorry.

The original series is at u-boot-dm/rke-working if 

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Tom Warren]

Simon,

> -Original Message-
> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass
> Sent: Tuesday, February 16, 2016 9:03 AM
> To: Tom Warren 
> Cc: Stephen Warren ; U-Boot Mailing List  b...@lists.denx.de>; Marcel Ziswiler ; Stephen
> Warren ; Pantelis Antoniou  consulting.com>; Marek Vasut ; Pavel Herrmann
> ; Anatolij Gustschin 
> Subject: Re: [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video
> drivers to driver model
> 
> Hi Tom,
> 
> On 16 February 2016 at 08:47, Tom Warren  wrote:
> >
> > Simon
> >
> > > -Original Message-
> > > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon
> > > Glass
> > > Sent: Sunday, February 14, 2016 6:19 PM
> > > To: Stephen Warren 
> > > Cc: U-Boot Mailing List ; Marcel Ziswiler
> > > ; Tom Warren ;
> > > Stephen Warren ; Pantelis Antoniou
> > > ; Marek Vasut
> > > ; Pavel Herrmann ;
> > > Anatolij Gustschin 
> > > Subject: Re: [PATCH v2 00/23] dm: tegra: Convert tegra20 and
> > > tegra124 video drivers to driver model
> > >
> > > Hi,
> > >
> > > On 1 February 2016 at 17:00, Stephen Warren 
> > > wrote:
> > > >
> > > > On 01/30/2016 04:37 PM, Simon Glass wrote:
> > > >>
> > > >> This series moves these two drivers over to use driver model for video.
> > > >>
> > > >> This involves the following steps:
> > > >> - Sync up some device tree files with Linux
> > > >> - Implement a proper PWM driver
> > > >> - Clean up and unify the driver code
> > > >> - Modify the existing drivers to work with driver model
> > > >>
> > > >> The tegra20 display driver uses device tree bindings invented in
> > > >> 2011 before Linux had this or anyone was able to agree a
> > > >> standard. It seems possible to move it to the new bindings (like
> > > >> tegra124) except for the issue of time delays between stages. It
> > > >> isn't clear how this should work, and Linux implements this by
> > > >> including all LCD definitions in the kernel source code, and not
> > > >> using any delays. This causes strange display artifacts on the
> > > >> display when starting up, but perhaps is harmless to the display.
> > > >> Future work will sync up the device tree more for seaboard, and thus
> tidy this up for nvidia boards.
> > > >>
> > > >> A bug in the keyboard driver is also fixed by this series. The
> > > >> series is tested on seaboard and nyan-big, the two boards I have
> > > >> which support a display.
> > > >>
> > > >> This series is available at u-boot-dm/tegra-working.
> > > >
> > > >
> > > > This changes the name of the output device from "lcd" to "vidconsole".
> > > Anyone who doesn't reset their environment to default when switching
> > > to this new U-Boot will lose their display output because of this.
> > > Is there any way to maintain compatibility?
> > > >
> > > > Aside from that, I don't see any issues on Springbank (Seaboard),
> > > > Harmony, Ventana, Paz00, or p2371-2180, so the series,
> > > > Tested-by: Stephen Warren 
> > >
> > > It looks like some of the patches have been applied and all Tegra
> > > boards are now giving Kconfig warnings.
> > >
> > > Tom Warren, are you able to pick up the rest of the series?
> > I had thought these had already gone in via the dm repo. If not, please list
> those that still need to be picked up and I'll take them in via tegra. Best to
> assign the appropriate ones to me in patchwork. Currently it seems they're all
> assigned to me. Which patches have already been applied?
> 
> I think it was the follow-up patches to add the environment work-around that
> was applied.
> 
> 6c88b51 video: tegra: Enable the 'lcd' env variable work-around
> a2931b3 dm: video: Add a temporary work-around for old stdout var
> 
> I see the original v2 series here:
> 
> http://patchwork.ozlabs.org/project/uboot/list/?delegate=4839
> 
> so that is what needs to be applied I think. Then the Tegra config issue 
> should
> be fixed.
I've applied the 23 v2 DM video patches to u-boot-tegra/master, then rebased 
against current u-boot/master.

I see the 'warning: (TEGRA_COMMON) selects VIDCONSOLE_AS_LCD which has unmet 
direct dependencies (DM_VIDEO)' spew for almost every board (w/MAKEALL -s 
tegra).

Am I missing some patches? 
--
nvpublic
> 
> Regards,
> Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Simon Glass]

Hi Tom,

On 16 February 2016 at 08:47, Tom Warren  wrote:
>
> Simon
>
> > -Original Message-
> > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass
> > Sent: Sunday, February 14, 2016 6:19 PM
> > To: Stephen Warren 
> > Cc: U-Boot Mailing List ; Marcel Ziswiler
> > ; Tom Warren ;
> > Stephen Warren ; Pantelis Antoniou  > consulting.com>; Marek Vasut ; Pavel Herrmann
> > ; Anatolij Gustschin 
> > Subject: Re: [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video
> > drivers to driver model
> >
> > Hi,
> >
> > On 1 February 2016 at 17:00, Stephen Warren 
> > wrote:
> > >
> > > On 01/30/2016 04:37 PM, Simon Glass wrote:
> > >>
> > >> This series moves these two drivers over to use driver model for video.
> > >>
> > >> This involves the following steps:
> > >> - Sync up some device tree files with Linux
> > >> - Implement a proper PWM driver
> > >> - Clean up and unify the driver code
> > >> - Modify the existing drivers to work with driver model
> > >>
> > >> The tegra20 display driver uses device tree bindings invented in 2011
> > >> before Linux had this or anyone was able to agree a standard. It
> > >> seems possible to move it to the new bindings (like tegra124) except
> > >> for the issue of time delays between stages. It isn't clear how this
> > >> should work, and Linux implements this by including all LCD
> > >> definitions in the kernel source code, and not using any delays. This
> > >> causes strange display artifacts on the display when starting up, but
> > >> perhaps is harmless to the display. Future work will sync up the
> > >> device tree more for seaboard, and thus tidy this up for nvidia boards.
> > >>
> > >> A bug in the keyboard driver is also fixed by this series. The series
> > >> is tested on seaboard and nyan-big, the two boards I have which
> > >> support a display.
> > >>
> > >> This series is available at u-boot-dm/tegra-working.
> > >
> > >
> > > This changes the name of the output device from "lcd" to "vidconsole".
> > Anyone who doesn't reset their environment to default when switching to this
> > new U-Boot will lose their display output because of this. Is there any way 
> > to
> > maintain compatibility?
> > >
> > > Aside from that, I don't see any issues on Springbank (Seaboard),
> > > Harmony, Ventana, Paz00, or p2371-2180, so the series,
> > > Tested-by: Stephen Warren 
> >
> > It looks like some of the patches have been applied and all Tegra boards are
> > now giving Kconfig warnings.
> >
> > Tom Warren, are you able to pick up the rest of the series?
> I had thought these had already gone in via the dm repo. If not, please list 
> those that still need to be picked up and I'll take them in via tegra. Best 
> to assign the appropriate ones to me in patchwork. Currently it seems they're 
> all assigned to me. Which patches have already been applied?

I think it was the follow-up patches to add the environment
work-around that was applied.

6c88b51 video: tegra: Enable the 'lcd' env variable work-around
a2931b3 dm: video: Add a temporary work-around for old stdout var

I see the original v2 series here:

http://patchwork.ozlabs.org/project/uboot/list/?delegate=4839

so that is what needs to be applied I think. Then the Tegra config
issue should be fixed.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Tom Warren]

Simon

> -Original Message-
> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass
> Sent: Sunday, February 14, 2016 6:19 PM
> To: Stephen Warren 
> Cc: U-Boot Mailing List ; Marcel Ziswiler
> ; Tom Warren ;
> Stephen Warren ; Pantelis Antoniou  consulting.com>; Marek Vasut ; Pavel Herrmann
> ; Anatolij Gustschin 
> Subject: Re: [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video
> drivers to driver model
> 
> Hi,
> 
> On 1 February 2016 at 17:00, Stephen Warren 
> wrote:
> >
> > On 01/30/2016 04:37 PM, Simon Glass wrote:
> >>
> >> This series moves these two drivers over to use driver model for video.
> >>
> >> This involves the following steps:
> >> - Sync up some device tree files with Linux
> >> - Implement a proper PWM driver
> >> - Clean up and unify the driver code
> >> - Modify the existing drivers to work with driver model
> >>
> >> The tegra20 display driver uses device tree bindings invented in 2011
> >> before Linux had this or anyone was able to agree a standard. It
> >> seems possible to move it to the new bindings (like tegra124) except
> >> for the issue of time delays between stages. It isn't clear how this
> >> should work, and Linux implements this by including all LCD
> >> definitions in the kernel source code, and not using any delays. This
> >> causes strange display artifacts on the display when starting up, but
> >> perhaps is harmless to the display. Future work will sync up the
> >> device tree more for seaboard, and thus tidy this up for nvidia boards.
> >>
> >> A bug in the keyboard driver is also fixed by this series. The series
> >> is tested on seaboard and nyan-big, the two boards I have which
> >> support a display.
> >>
> >> This series is available at u-boot-dm/tegra-working.
> >
> >
> > This changes the name of the output device from "lcd" to "vidconsole".
> Anyone who doesn't reset their environment to default when switching to this
> new U-Boot will lose their display output because of this. Is there any way to
> maintain compatibility?
> >
> > Aside from that, I don't see any issues on Springbank (Seaboard),
> > Harmony, Ventana, Paz00, or p2371-2180, so the series,
> > Tested-by: Stephen Warren 
> 
> It looks like some of the patches have been applied and all Tegra boards are
> now giving Kconfig warnings.
> 
> Tom Warren, are you able to pick up the rest of the series?
I had thought these had already gone in via the dm repo. If not, please list 
those that still need to be picked up and I'll take them in via tegra. Best to 
assign the appropriate ones to me in patchwork. Currently it seems they're all 
assigned to me. Which patches have already been applied?

Tom

--
nvpublic
> 
> Regards,
> Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Simon Glass]

Hi,

On 1 February 2016 at 17:00, Stephen Warren  wrote:
>
> On 01/30/2016 04:37 PM, Simon Glass wrote:
>>
>> This series moves these two drivers over to use driver model for video.
>>
>> This involves the following steps:
>> - Sync up some device tree files with Linux
>> - Implement a proper PWM driver
>> - Clean up and unify the driver code
>> - Modify the existing drivers to work with driver model
>>
>> The tegra20 display driver uses device tree bindings invented in 2011 before
>> Linux had this or anyone was able to agree a standard. It seems possible to
>> move it to the new bindings (like tegra124) except for the issue of time
>> delays between stages. It isn't clear how this should work, and Linux
>> implements this by including all LCD definitions in the kernel source code,
>> and not using any delays. This causes strange display artifacts on the
>> display when starting up, but perhaps is harmless to the display. Future
>> work will sync up the device tree more for seaboard, and thus tidy this up
>> for nvidia boards.
>>
>> A bug in the keyboard driver is also fixed by this series. The series is
>> tested on seaboard and nyan-big, the two boards I have which support a
>> display.
>>
>> This series is available at u-boot-dm/tegra-working.
>
>
> This changes the name of the output device from "lcd" to "vidconsole". Anyone 
> who doesn't reset their environment to default when switching to this new 
> U-Boot will lose their display output because of this. Is there any way to 
> maintain compatibility?
>
> Aside from that, I don't see any issues on Springbank (Seaboard), Harmony, 
> Ventana, Paz00, or p2371-2180, so the series,
> Tested-by: Stephen Warren 

It looks like some of the patches have been applied and all Tegra
boards are now giving Kconfig warnings.

Tom Warren, are you able to pick up the rest of the series?

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Simon Glass]

Hi Stephen,

On 1 February 2016 at 17:36, Stephen Warren  wrote:
> On 02/01/2016 05:28 PM, Simon Glass wrote:
>>
>> Hi Stephen,
>>
>> On 1 February 2016 at 17:17, Stephen Warren  wrote:
>>>
>>> On 02/01/2016 05:05 PM, Simon Glass wrote:


 Hi Stephen,

 On 1 February 2016 at 17:00, Stephen Warren 
 wrote:
>
>
> On 01/30/2016 04:37 PM, Simon Glass wrote:
>>
>>
>>
>> This series moves these two drivers over to use driver model for
>> video.
>>
>> This involves the following steps:
>> - Sync up some device tree files with Linux
>> - Implement a proper PWM driver
>> - Clean up and unify the driver code
>> - Modify the existing drivers to work with driver model
>>
>> The tegra20 display driver uses device tree bindings invented in 2011
>> before
>> Linux had this or anyone was able to agree a standard. It seems
>> possible
>> to
>> move it to the new bindings (like tegra124) except for the issue of
>> time
>> delays between stages. It isn't clear how this should work, and Linux
>> implements this by including all LCD definitions in the kernel source
>> code,
>> and not using any delays. This causes strange display artifacts on the
>> display when starting up, but perhaps is harmless to the display.
>> Future
>> work will sync up the device tree more for seaboard, and thus tidy
>> this
>> up
>> for nvidia boards.
>>
>> A bug in the keyboard driver is also fixed by this series. The series
>> is
>> tested on seaboard and nyan-big, the two boards I have which support a
>> display.
>>
>> This series is available at u-boot-dm/tegra-working.
>
>
>
>
> This changes the name of the output device from "lcd" to "vidconsole".
> Anyone who doesn't reset their environment to default when switching to
> this
> new U-Boot will lose their display output because of this. Is there any
> way
> to maintain compatibility?



 I could not think of one other than an egregious hack. It will
 certainly bite someone. Perhaps a hack that detects 'lcd' in the
 stdout env variable and prints a warning would be useful?
>>>
>>>
>>>
>>> Can't the two drivers just respond to the same device name. Presumably a
>>> build would only have one or the other compiled in?
>>
>>
>> I don't want to use 'lcd' for 'vidconsole' since 'vidconsole' is
>> supposed to work for both LCD and video devices. The idea is to merge
>> them. The only way I could think of to make it work was hack in
>> stdio.c to automatically change 'lcd' to vidconsole. I was not brave
>> enough to attempt that, but it might work. What do you think?
>
>
> That sounds like it should work. Isn't that simply:
>
> #if SOMETHING
> if (!strcmp(foo, "lcd"))
> foo = "vidconsole";
> #endif

I've sent a patch for this. Hopefully it will not offend too many people.

>
>>> Or perhaps we can add a hook in the board-specific initialization code
>>> which
>>> re-writes the environment after loading it?
>>>
>>> Printing a message would be useful if the user has a serial console
>>> plugged
>>> in, which will not always be the case. It is not possible on Paz00
>>> (likely
>>> the most widely used T20 device) for example without taking the case
>>> apart
>>> and soldering to a very tiny connector; I expect almost nobody has done
>>> that.
>>
>>
>> Is that the shield thing? I'd really like to attempt that solder if
>> there are instructions somewhere.
>
>
> It's the Toshiba AC100 laptop. There's some information at
> https://ac100.grandou.net/doku.php (and numerous other places if you search
> Google for the model number.)

Ah OK I had forgotten about that, thanks.

Regards,
Smion
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Stephen Warren]

On 02/01/2016 05:05 PM, Simon Glass wrote:

Hi Stephen,

On 1 February 2016 at 17:00, Stephen Warren  wrote:

On 01/30/2016 04:37 PM, Simon Glass wrote:


This series moves these two drivers over to use driver model for video.

This involves the following steps:
- Sync up some device tree files with Linux
- Implement a proper PWM driver
- Clean up and unify the driver code
- Modify the existing drivers to work with driver model

The tegra20 display driver uses device tree bindings invented in 2011
before
Linux had this or anyone was able to agree a standard. It seems possible
to
move it to the new bindings (like tegra124) except for the issue of time
delays between stages. It isn't clear how this should work, and Linux
implements this by including all LCD definitions in the kernel source
code,
and not using any delays. This causes strange display artifacts on the
display when starting up, but perhaps is harmless to the display. Future
work will sync up the device tree more for seaboard, and thus tidy this up
for nvidia boards.

A bug in the keyboard driver is also fixed by this series. The series is
tested on seaboard and nyan-big, the two boards I have which support a
display.

This series is available at u-boot-dm/tegra-working.



This changes the name of the output device from "lcd" to "vidconsole".
Anyone who doesn't reset their environment to default when switching to this
new U-Boot will lose their display output because of this. Is there any way
to maintain compatibility?


I could not think of one other than an egregious hack. It will
certainly bite someone. Perhaps a hack that detects 'lcd' in the
stdout env variable and prints a warning would be useful?


Can't the two drivers just respond to the same device name. Presumably a 
build would only have one or the other compiled in?


Or perhaps we can add a hook in the board-specific initialization code 
which re-writes the environment after loading it?


Printing a message would be useful if the user has a serial console 
plugged in, which will not always be the case. It is not possible on 
Paz00 (likely the most widely used T20 device) for example without 
taking the case apart and soldering to a very tiny connector; I expect 
almost nobody has done that.

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Stephen Warren]

On 02/01/2016 05:28 PM, Simon Glass wrote:

Hi Stephen,

On 1 February 2016 at 17:17, Stephen Warren  wrote:

On 02/01/2016 05:05 PM, Simon Glass wrote:


Hi Stephen,

On 1 February 2016 at 17:00, Stephen Warren  wrote:


On 01/30/2016 04:37 PM, Simon Glass wrote:



This series moves these two drivers over to use driver model for video.

This involves the following steps:
- Sync up some device tree files with Linux
- Implement a proper PWM driver
- Clean up and unify the driver code
- Modify the existing drivers to work with driver model

The tegra20 display driver uses device tree bindings invented in 2011
before
Linux had this or anyone was able to agree a standard. It seems possible
to
move it to the new bindings (like tegra124) except for the issue of time
delays between stages. It isn't clear how this should work, and Linux
implements this by including all LCD definitions in the kernel source
code,
and not using any delays. This causes strange display artifacts on the
display when starting up, but perhaps is harmless to the display. Future
work will sync up the device tree more for seaboard, and thus tidy this
up
for nvidia boards.

A bug in the keyboard driver is also fixed by this series. The series is
tested on seaboard and nyan-big, the two boards I have which support a
display.

This series is available at u-boot-dm/tegra-working.




This changes the name of the output device from "lcd" to "vidconsole".
Anyone who doesn't reset their environment to default when switching to
this
new U-Boot will lose their display output because of this. Is there any
way
to maintain compatibility?



I could not think of one other than an egregious hack. It will
certainly bite someone. Perhaps a hack that detects 'lcd' in the
stdout env variable and prints a warning would be useful?



Can't the two drivers just respond to the same device name. Presumably a
build would only have one or the other compiled in?


I don't want to use 'lcd' for 'vidconsole' since 'vidconsole' is
supposed to work for both LCD and video devices. The idea is to merge
them. The only way I could think of to make it work was hack in
stdio.c to automatically change 'lcd' to vidconsole. I was not brave
enough to attempt that, but it might work. What do you think?


That sounds like it should work. Isn't that simply:

#if SOMETHING
if (!strcmp(foo, "lcd"))
foo = "vidconsole";
#endif


Or perhaps we can add a hook in the board-specific initialization code which
re-writes the environment after loading it?

Printing a message would be useful if the user has a serial console plugged
in, which will not always be the case. It is not possible on Paz00 (likely
the most widely used T20 device) for example without taking the case apart
and soldering to a very tiny connector; I expect almost nobody has done
that.


Is that the shield thing? I'd really like to attempt that solder if
there are instructions somewhere.


It's the Toshiba AC100 laptop. There's some information at 
https://ac100.grandou.net/doku.php (and numerous other places if you 
search Google for the model number.)

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Stephen Warren]

On 01/30/2016 04:37 PM, Simon Glass wrote:

This series moves these two drivers over to use driver model for video.

This involves the following steps:
- Sync up some device tree files with Linux
- Implement a proper PWM driver
- Clean up and unify the driver code
- Modify the existing drivers to work with driver model

The tegra20 display driver uses device tree bindings invented in 2011 before
Linux had this or anyone was able to agree a standard. It seems possible to
move it to the new bindings (like tegra124) except for the issue of time
delays between stages. It isn't clear how this should work, and Linux
implements this by including all LCD definitions in the kernel source code,
and not using any delays. This causes strange display artifacts on the
display when starting up, but perhaps is harmless to the display. Future
work will sync up the device tree more for seaboard, and thus tidy this up
for nvidia boards.

A bug in the keyboard driver is also fixed by this series. The series is
tested on seaboard and nyan-big, the two boards I have which support a
display.

This series is available at u-boot-dm/tegra-working.


This changes the name of the output device from "lcd" to "vidconsole". 
Anyone who doesn't reset their environment to default when switching to 
this new U-Boot will lose their display output because of this. Is there 
any way to maintain compatibility?


Aside from that, I don't see any issues on Springbank (Seaboard), 
Harmony, Ventana, Paz00, or p2371-2180, so the series,

Tested-by: Stephen Warren 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Simon Glass]

Hi Stephen,

On 1 February 2016 at 17:00, Stephen Warren  wrote:
> On 01/30/2016 04:37 PM, Simon Glass wrote:
>>
>> This series moves these two drivers over to use driver model for video.
>>
>> This involves the following steps:
>> - Sync up some device tree files with Linux
>> - Implement a proper PWM driver
>> - Clean up and unify the driver code
>> - Modify the existing drivers to work with driver model
>>
>> The tegra20 display driver uses device tree bindings invented in 2011
>> before
>> Linux had this or anyone was able to agree a standard. It seems possible
>> to
>> move it to the new bindings (like tegra124) except for the issue of time
>> delays between stages. It isn't clear how this should work, and Linux
>> implements this by including all LCD definitions in the kernel source
>> code,
>> and not using any delays. This causes strange display artifacts on the
>> display when starting up, but perhaps is harmless to the display. Future
>> work will sync up the device tree more for seaboard, and thus tidy this up
>> for nvidia boards.
>>
>> A bug in the keyboard driver is also fixed by this series. The series is
>> tested on seaboard and nyan-big, the two boards I have which support a
>> display.
>>
>> This series is available at u-boot-dm/tegra-working.
>
>
> This changes the name of the output device from "lcd" to "vidconsole".
> Anyone who doesn't reset their environment to default when switching to this
> new U-Boot will lose their display output because of this. Is there any way
> to maintain compatibility?

I could not think of one other than an egregious hack. It will
certainly bite someone. Perhaps a hack that detects 'lcd' in the
stdout env variable and prints a warning would be useful?

>
> Aside from that, I don't see any issues on Springbank (Seaboard), Harmony,
> Ventana, Paz00, or p2371-2180, so the series,
> Tested-by: Stephen Warren 

Thanks very much for testing all those,.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

[Simon Glass]

Hi Stephen,

On 1 February 2016 at 17:17, Stephen Warren  wrote:
> On 02/01/2016 05:05 PM, Simon Glass wrote:
>>
>> Hi Stephen,
>>
>> On 1 February 2016 at 17:00, Stephen Warren  wrote:
>>>
>>> On 01/30/2016 04:37 PM, Simon Glass wrote:


 This series moves these two drivers over to use driver model for video.

 This involves the following steps:
 - Sync up some device tree files with Linux
 - Implement a proper PWM driver
 - Clean up and unify the driver code
 - Modify the existing drivers to work with driver model

 The tegra20 display driver uses device tree bindings invented in 2011
 before
 Linux had this or anyone was able to agree a standard. It seems possible
 to
 move it to the new bindings (like tegra124) except for the issue of time
 delays between stages. It isn't clear how this should work, and Linux
 implements this by including all LCD definitions in the kernel source
 code,
 and not using any delays. This causes strange display artifacts on the
 display when starting up, but perhaps is harmless to the display. Future
 work will sync up the device tree more for seaboard, and thus tidy this
 up
 for nvidia boards.

 A bug in the keyboard driver is also fixed by this series. The series is
 tested on seaboard and nyan-big, the two boards I have which support a
 display.

 This series is available at u-boot-dm/tegra-working.
>>>
>>>
>>>
>>> This changes the name of the output device from "lcd" to "vidconsole".
>>> Anyone who doesn't reset their environment to default when switching to
>>> this
>>> new U-Boot will lose their display output because of this. Is there any
>>> way
>>> to maintain compatibility?
>>
>>
>> I could not think of one other than an egregious hack. It will
>> certainly bite someone. Perhaps a hack that detects 'lcd' in the
>> stdout env variable and prints a warning would be useful?
>
>
> Can't the two drivers just respond to the same device name. Presumably a
> build would only have one or the other compiled in?

I don't want to use 'lcd' for 'vidconsole' since 'vidconsole' is
supposed to work for both LCD and video devices. The idea is to merge
them. The only way I could think of to make it work was hack in
stdio.c to automatically change 'lcd' to vidconsole. I was not brave
enough to attempt that, but it might work. What do you think?

>
> Or perhaps we can add a hook in the board-specific initialization code which
> re-writes the environment after loading it?
>
> Printing a message would be useful if the user has a serial console plugged
> in, which will not always be the case. It is not possible on Paz00 (likely
> the most widely used T20 device) for example without taking the case apart
> and soldering to a very tiny connector; I expect almost nobody has done
> that.

Is that the shield thing? I'd really like to attempt that solder if
there are instructions somewhere.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot