Re: [U-Boot] [v2 PATCH 13/14] cmd: qfw: rename QEMU_FW_CFG to CMD_QFW
2016-05-20 10:30 GMT+08:00 Bin Meng: > Hi Miao, > > On Fri, May 20, 2016 at 10:07 AM, Miao Yan wrote: >> Hi Bin, >> >> 2016-05-19 17:08 GMT+08:00 Bin Meng : >>> Hi Miao, >>> >>> the title should say: CMD_QEMU_FW_CFG >>> >>> I can fix this when applying. >>> >>> On Wed, May 18, 2016 at 5:39 PM, Miao Yan wrote: Align macro names with the rest of qfw code >>> >>> and I believe it's better to squash this commit into patch#8 in this >>> series, as they both rename QEMU_FW_CFG to QFW. >> >> Thanks. Do I need a v3 ? >> > > If you have time, let's do a v3 which saves my time. Sorry :( OK, no problem. Miao > > Regards, > Bin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [v2 PATCH 13/14] cmd: qfw: rename QEMU_FW_CFG to CMD_QFW
Hi Miao, On Fri, May 20, 2016 at 10:07 AM, Miao Yanwrote: > Hi Bin, > > 2016-05-19 17:08 GMT+08:00 Bin Meng : >> Hi Miao, >> >> the title should say: CMD_QEMU_FW_CFG >> >> I can fix this when applying. >> >> On Wed, May 18, 2016 at 5:39 PM, Miao Yan wrote: >>> Align macro names with the rest of qfw code >>> >> >> and I believe it's better to squash this commit into patch#8 in this >> series, as they both rename QEMU_FW_CFG to QFW. > > Thanks. Do I need a v3 ? > If you have time, let's do a v3 which saves my time. Sorry :( Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [v2 PATCH 13/14] cmd: qfw: rename QEMU_FW_CFG to CMD_QFW
Hi Bin, 2016-05-19 17:08 GMT+08:00 Bin Meng: > Hi Miao, > > the title should say: CMD_QEMU_FW_CFG > > I can fix this when applying. > > On Wed, May 18, 2016 at 5:39 PM, Miao Yan wrote: >> Align macro names with the rest of qfw code >> > > and I believe it's better to squash this commit into patch#8 in this > series, as they both rename QEMU_FW_CFG to QFW. Thanks. Do I need a v3 ? Thanks, Miao > >> Signed-off-by: Miao Yan >> --- >> cmd/Kconfig| 2 +- >> cmd/Makefile | 2 +- >> configs/qemu-x86_defconfig | 2 +- >> drivers/misc/Kconfig | 2 +- >> 4 files changed, 4 insertions(+), 4 deletions(-) >> > > Reviewed-by: Bin Meng > > [snip] > > Regards, > Bin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [v2 PATCH 13/14] cmd: qfw: rename QEMU_FW_CFG to CMD_QFW
Hi Miao, the title should say: CMD_QEMU_FW_CFG I can fix this when applying. On Wed, May 18, 2016 at 5:39 PM, Miao Yanwrote: > Align macro names with the rest of qfw code > and I believe it's better to squash this commit into patch#8 in this series, as they both rename QEMU_FW_CFG to QFW. > Signed-off-by: Miao Yan > --- > cmd/Kconfig| 2 +- > cmd/Makefile | 2 +- > configs/qemu-x86_defconfig | 2 +- > drivers/misc/Kconfig | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Bin Meng [snip] Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot