[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
This has been applied in Jammy via stable update process: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1959376 ** Changed in: linux (Ubuntu) Status: In Progress => Fix Released ** Changed in: linux (Ubuntu Jammy) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
This bug was fixed in the package linux - 5.13.0-30.33 --- linux (5.13.0-30.33) impish; urgency=medium * impish/linux: 5.13.0-30.33 -proposed tracker (LP: #1960055) * systemd/248.3-1ubuntu8.2 ADT test failure with linux/5.13.0-29.32 (LP: #1960034) - Revert "block: avoid to quiesce queue in elevator_init_mq" - Revert "blk-mq: cancel blk-mq dispatch work in both blk_cleanup_queue and disk_release()" linux (5.13.0-29.32) impish; urgency=medium * impish/linux: 5.13.0-29.32 -proposed tracker (LP: #1959238) * Packaging resync (LP: #1786013) - debian/dkms-versions -- update from kernel-versions (main/2022.01.31) * CVE-2022-22942 - SAUCE: drm/vmwgfx: Fix stale file descriptors on failed usercopy * CVE-2022-0330 - drm/i915: Flush TLBs before releasing backing store * Impish update: upstream stable patchset 2022-01-05 (LP: #1956508) - ACPI: Get acpi_device's parent from the parent field - USB: serial: option: add Telit LE910S1 0x9200 composition - USB: serial: option: add Fibocom FM101-GL variants - usb: dwc2: gadget: Fix ISOC flow for elapsed frames - usb: dwc2: hcd_queue: Fix use of floating point literal - usb: dwc3: gadget: Ignore NoStream after End Transfer - usb: dwc3: gadget: Check for L1/L2/U3 for Start Transfer - usb: dwc3: gadget: Fix null pointer exception - net: nexthop: fix null pointer dereference when IPv6 is not enabled - usb: chipidea: ci_hdrc_imx: fix potential error pointer dereference in probe - usb: typec: fusb302: Fix masking of comparator and bc_lvl interrupts - usb: hub: Fix usb enumeration issue due to address0 race - usb: hub: Fix locking issues with address0_mutex - binder: fix test regression due to sender_euid change - ALSA: ctxfi: Fix out-of-range access - ALSA: hda/realtek: Add quirk for ASRock NUC Box 1100 - ALSA: hda/realtek: Fix LED on HP ProBook 435 G7 - media: cec: copy sequence field for the reply - Revert "parisc: Fix backtrace to always include init funtion names" - HID: wacom: Use "Confidence" flag to prevent reporting invalid contacts - staging/fbtft: Fix backlight - staging: greybus: Add missing rwsem around snd_ctl_remove() calls - staging: rtl8192e: Fix use after free in _rtl92e_pci_disconnect() - fuse: release pipe buf after last use - xen: don't continue xenstore initialization in case of errors - xen: detect uninitialized xenbus in xenbus_init - KVM: PPC: Book3S HV: Prevent POWER7/8 TLB flush flushing SLB - tracing/uprobe: Fix uprobe_perf_open probes iteration - tracing: Fix pid filtering when triggers are attached - mmc: sdhci-esdhc-imx: disable CMDQ support - mmc: sdhci: Fix ADMA for PAGE_SIZE >= 64KiB - mdio: aspeed: Fix "Link is Down" issue - powerpc/32: Fix hardlockup on vmap stack overflow - PCI: aardvark: Deduplicate code in advk_pcie_rd_conf() - PCI: aardvark: Implement re-issuing config requests on CRS response - PCI: aardvark: Simplify initialization of rootcap on virtual bridge - PCI: aardvark: Fix link training - proc/vmcore: fix clearing user buffer by properly using clear_user() - netfilter: ctnetlink: fix filtering with CTA_TUPLE_REPLY - netfilter: ctnetlink: do not erase error code with EINVAL - netfilter: ipvs: Fix reuse connection if RS weight is 0 - netfilter: flowtable: fix IPv6 tunnel addr match - ARM: dts: BCM5301X: Fix I2C controller interrupt - ARM: dts: BCM5301X: Add interrupt properties to GPIO node - ARM: dts: bcm2711: Fix PCIe interrupts - ASoC: qdsp6: q6routing: Conditionally reset FrontEnd Mixer - ASoC: qdsp6: q6asm: fix q6asm_dai_prepare error handling - ASoC: topology: Add missing rwsem around snd_ctl_remove() calls - ASoC: codecs: wcd934x: return error code correctly from hw_params - net: ieee802154: handle iftypes as u32 - firmware: arm_scmi: pm: Propagate return value to caller - NFSv42: Don't fail clone() unless the OP_CLONE operation failed - ARM: socfpga: Fix crash with CONFIG_FORTIRY_SOURCE - drm/nouveau/acr: fix a couple NULL vs IS_ERR() checks - scsi: mpt3sas: Fix kernel panic during drive powercycle test - drm/vc4: fix error code in vc4_create_object() - net: marvell: prestera: fix double free issue on err path - iavf: Prevent changing static ITR values if adaptive moderation is on - ALSA: intel-dsp-config: add quirk for JSL devices based on ES8336 codec - mptcp: fix delack timer - firmware: smccc: Fix check for ARCH_SOC_ID not implemented - ipv6: fix typos in __ip6_finish_output() - nfp: checking parameter process for rx-usecs/tx-usecs is invalid - net: stmmac: retain PTP clock time during SIOCSHWTSTAMP ioctls - net: ipv6: add fib6_nh_release_dsts stub - net: nexthop: release IPv6 per-cpu dsts when replacing a nexthop group - ice: fix vsi->txq_map sizing - ice: avoid bpf_prog refcount underflow
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
This bug was fixed in the package linux - 5.4.0-100.113
---
linux (5.4.0-100.113) focal; urgency=medium
* focal/linux: 5.4.0-100.113 -proposed tracker (LP: #1959900)
* CVE-2022-22942
- SAUCE: drm/vmwgfx: Fix stale file descriptors on failed usercopy
* CVE-2022-0330
- drm/i915: Flush TLBs before releasing backing store
* Focal update: v5.4.166 upstream stable release (LP: #1957008)
- netfilter: selftest: conntrack_vrf.sh: fix file permission
- Linux 5.4.166
- net/packet: rx_owner_map depends on pg_vec
- USB: gadget: bRequestType is a bitfield, not a enum
- HID: holtek: fix mouse probing
- udp: using datalen to cap ipv6 udp max gso segments
- selftests: Calculate udpgso segment count without header adjustment
* Focal update: v5.4.165 upstream stable release (LP: #1957007)
- serial: tegra: Change lower tolerance baud rate limit for tegra20 and
tegra30
- ntfs: fix ntfs_test_inode and ntfs_init_locked_inode function type
- HID: quirks: Add quirk for the Microsoft Surface 3 type-cover
- HID: google: add eel USB id
- HID: add hid_is_usb() function to make it simpler for USB detection
- HID: add USB_HID dependancy to hid-prodikeys
- HID: add USB_HID dependancy to hid-chicony
- HID: add USB_HID dependancy on some USB HID drivers
- HID: bigbenff: prevent null pointer dereference
- HID: wacom: fix problems when device is not a valid USB device
- HID: check for valid USB device for many HID drivers
- can: kvaser_usb: get CAN clock frequency from device
- can: kvaser_pciefd: kvaser_pciefd_rx_error_frame(): increase correct
stats->{rx,tx}_errors counter
- can: sja1000: fix use after free in ems_pcmcia_add_card()
- nfc: fix potential NULL pointer deref in nfc_genl_dump_ses_done
- selftests: netfilter: add a vrf+conntrack testcase
- vrf: don't run conntrack on vrf with !dflt qdisc
- bpf: Fix the off-by-two error in range markings
- ice: ignore dropped packets during init
- bonding: make tx_rebalance_counter an atomic
- nfp: Fix memory leak in nfp_cpp_area_cache_add()
- seg6: fix the iif in the IPv6 socket control block
- udp: using datalen to cap max gso segments
- iavf: restore MSI state on reset
- iavf: Fix reporting when setting descriptor count
- IB/hfi1: Correct guard on eager buffer deallocation
- mm: bdi: initialize bdi_min_ratio when bdi is unregistered
- ALSA: ctl: Fix copy of updated id with element read/write
- ALSA: hda/realtek - Add headset Mic support for Lenovo ALC897 platform
- ALSA: pcm: oss: Fix negative period/buffer sizes
- ALSA: pcm: oss: Limit the period size to 16MB
- ALSA: pcm: oss: Handle missing errors in snd_pcm_oss_change_params*()
- btrfs: clear extent buffer uptodate when we fail to write it
- btrfs: replace the BUG_ON in btrfs_del_root_ref with proper error handling
- nfsd: Fix nsfd startup race (again)
- tracefs: Have new files inherit the ownership of their parent
- clk: qcom: regmap-mux: fix parent clock lookup
- drm/syncobj: Deal with signalled fences in drm_syncobj_find_fence.
- can: pch_can: pch_can_rx_normal: fix use after free
- can: m_can: Disable and ignore ELO interrupt
- x86/sme: Explicitly map new EFI memmap table as encrypted
- libata: add horkage for ASMedia 1092
- wait: add wake_up_pollfree()
- SAUCE: binder: export __wake_up_pollfree for binder module
- binder: use wake_up_pollfree()
- signalfd: use wake_up_pollfree()
- aio: keep poll requests on waitqueue until completed
- aio: fix use-after-free due to missing POLLFREE handling
- tracefs: Set all files to the same group ownership as the mount option
- block: fix ioprio_get(IOPRIO_WHO_PGRP) vs setuid(2)
- qede: validate non LSO skb length
- ASoC: qdsp6: q6routing: Fix return value from msm_routing_put_audio_mixer
- i40e: Fix failed opcode appearing if handling messages from VF
- i40e: Fix pre-set max number of queues for VF
- mtd: rawnand: fsmc: Take instruction delay into account
- mtd: rawnand: fsmc: Fix timing computation
- dt-bindings: net: Reintroduce PHY no lane swap binding
- tools build: Remove needless libpython-version feature check that breaks
test-all fast path
- net: cdc_ncm: Allow for dwNtbOutMaxSize to be unset or zero
- net: altera: set a couple error code in probe()
- net: fec: only clear interrupt of handling queue in fec_enet_rx_queue()
- net, neigh: clear whole pneigh_entry at alloc time
- net/qla3xxx: fix an error code in ql_adapter_up()
- Revert "UBUNTU: SAUCE: selftests: fib_tests: assign address to dummy1 for
rp_filter tests"
- selftests/fib_tests: Rework fib_rp_filter_test()
- USB: gadget: detect too-big endpoint 0 requests
- USB: gadget: zero allocate endpoint 0 buffers
- usb: core: config: fix validation of wMaxPacketValue entries
- xhci:
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
Tested the proposed focal kernel - looks good as well: $ uname -r 5.4.0-98-generic $ apt policy linux-image-5.4.0-98-generic linux-image-5.4.0-98-generic: Installed: 5.4.0-98.111 Candidate: 5.4.0-98.111 Version table: *** 5.4.0-98.111 500 500 http://ppa.launchpad.net/canonical-kernel-team/proposed/ubuntu focal/main amd64 Packages 100 /var/lib/dpkg/status $ readlink /sys/class/net/enp130s0f0v0/device ../../../:82:00.3 $ sudo lspci -s :82:00.3 -v 82:00.3 Ethernet controller: Mellanox Technologies ConnectX Family mlx5Gen Virtual Function (rev 01) Subsystem: Mellanox Technologies ConnectX Family mlx5Gen Virtual Function Flags: bus master, fast devsel, latency 0, NUMA node 1 Memory at 3c00400 (64-bit, prefetchable) [virtual] [size=2M] Capabilities: [60] Express Endpoint, MSI 00 Capabilities: [48] Vital Product Data Capabilities: [9c] MSI-X: Enable+ Count=12 Masked- Capabilities: [100] Vendor Specific Information: ID= Rev=0 Len=00c Capabilities: [150] Alternative Routing-ID Interpretation (ARI) Kernel driver in use: mlx5_core Kernel modules: mlx5_core $ sudo lspci -s :82:00.0 -v 82:00.0 Ethernet controller: Mellanox Technologies MT42822 BlueField-2 integrated ConnectX-6 Dx network controller (rev 01) Subsystem: Mellanox Technologies MT42822 BlueField-2 integrated ConnectX-6 Dx network controller Flags: bus master, fast devsel, latency 0, IRQ 99, NUMA node 1 Memory at 3c00200 (64-bit, prefetchable) [size=32M] Expansion ROM at [disabled] Capabilities: [60] Express Endpoint, MSI 00 Capabilities: [48] Vital Product Data Capabilities: [9c] MSI-X: Enable+ Count=64 Masked- Capabilities: [c0] Vendor Specific Information: Len=18 Capabilities: [40] Power Management version 3 Capabilities: [100] Advanced Error Reporting Capabilities: [150] Alternative Routing-ID Interpretation (ARI) Capabilities: [180] Single Root I/O Virtualization (SR-IOV) Capabilities: [1c0] Secondary PCI Express Capabilities: [230] Access Control Services Capabilities: [320] Lane Margining at the Receiver Capabilities: [370] Physical Layer 16.0 GT/s Capabilities: [420] Data Link Feature Kernel driver in use: mlx5_core Kernel modules: mlx5_core $ sudo ip link set enp130s0f0 vf 0 vlan 1 ; echo $? RTNETLINK answers: Operation not permitted 2 $ sudo ip link set enp130s0f0 vf 0 vlan 0 ; echo $? 0 ** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
Tried the proposed impish kernel - looks good: $ uname -r 5.13.0-29-generic $ apt policy linux-image-5.13.0-29-generic linux-image-5.13.0-29-generic: Installed: 5.13.0-29.32 Candidate: 5.13.0-29.32 Version table: *** 5.13.0-29.32 500 500 http://ppa.launchpad.net/canonical-kernel-team/proposed/ubuntu impish/main amd64 Packages 100 /var/lib/dpkg/status $ readlink /sys/class/net/enp130s0f0v0/device ../../../:82:00.3 # VF $ sudo lspci -s :82:00.3 -v 82:00.3 Ethernet controller: Mellanox Technologies ConnectX Family mlx5Gen Virtual Function (rev 01) Subsystem: Mellanox Technologies ConnectX Family mlx5Gen Virtual Function Flags: bus master, fast devsel, latency 0, NUMA node 1 Memory at 3c00400 (64-bit, prefetchable) [virtual] [size=2M] Capabilities: [60] Express Endpoint, MSI 00 Capabilities: [48] Vital Product Data Capabilities: [9c] MSI-X: Enable+ Count=12 Masked- Capabilities: [100] Vendor Specific Information: ID= Rev=0 Len=00c Capabilities: [150] Alternative Routing-ID Interpretation (ARI) Kernel driver in use: mlx5_core Kernel modules: mlx5_core # Parent PF $ sudo lspci -s :82:00.0 -v 82:00.0 Ethernet controller: Mellanox Technologies MT42822 BlueField-2 integrated ConnectX-6 Dx network controller (rev 01) Subsystem: Mellanox Technologies MT42822 BlueField-2 integrated ConnectX-6 Dx network controller Flags: bus master, fast devsel, latency 0, IRQ 101, NUMA node 1 Memory at 3c00200 (64-bit, prefetchable) [size=32M] Expansion ROM at [disabled] Capabilities: [60] Express Endpoint, MSI 00 Capabilities: [48] Vital Product Data Capabilities: [9c] MSI-X: Enable+ Count=64 Masked- Capabilities: [c0] Vendor Specific Information: Len=18 Capabilities: [40] Power Management version 3 Capabilities: [100] Advanced Error Reporting Capabilities: [150] Alternative Routing-ID Interpretation (ARI) Capabilities: [180] Single Root I/O Virtualization (SR-IOV) Capabilities: [1c0] Secondary PCI Express Capabilities: [230] Access Control Services Capabilities: [320] Lane Margining at the Receiver Capabilities: [370] Physical Layer 16.0 GT/s Capabilities: [420] Data Link Feature Kernel driver in use: mlx5_core Kernel modules: mlx5_core $ sudo ip link set enp130s0f0 vf 0 vlan 1 ; echo $? RTNETLINK answers: Operation not permitted 2 $ sudo ip link set enp130s0f0 vf 0 vlan 0 ; echo $? 0 ** Tags removed: verification-needed-impish ** Tags added: verification-done-impish -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
This bug is awaiting verification that the linux/5.4.0-98.111 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! ** Tags added: verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
This bug is awaiting verification that the linux/5.13.0-29.32 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-impish' to 'verification-done-impish'. If the problem still exists, change the tag 'verification-needed-impish' to 'verification-failed-impish'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! ** Tags added: verification-needed-impish -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
** Changed in: linux (Ubuntu Focal) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
** Changed in: linux (Ubuntu Hirsute) Status: In Progress => Won't Fix ** Changed in: linux (Ubuntu Impish) Importance: Undecided => Medium ** Changed in: linux (Ubuntu Impish) Status: In Progress => Fix Committed ** Changed in: linux (Ubuntu Focal) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
https://lists.ubuntu.com/archives/kernel-team/2022-January/127401.html ** Description changed: [Impact] There is an issue with hypervisor host side mlx5 driver operation on Bluefield devices in kernels <=5.16 From patch description: When using libvirt to passthrough VF to VM it will always set the VF vlan to 0 even if user didn’t request it, this will cause libvirt to fail to boot in case the PF isn't eswitch owner. Example of such case is the DPU host PF which isn't eswitch manager, so any attempt to passthrough VF of it using libvirt will fail. [Fix] * 7846665d net/mlx5e: Unblock setting vid 0 for VF in case PF isn't - eswitch manager + eswitch manager This patch can be cherry-picked into Impish and newer kernels, but it requires some backport work on F/H due to they're missing commit b55b3538 that split the legacy code out. + + The ESW_ALLOWED marco was later converted into a helper routine in + commit b16f2bb6. [Test] Test kernels can be found here: F: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/F/ H: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/H/ I: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/I/ J: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/J/ Kernels tested on a SUT with this device by Dmitrii Shcherbakov, test passed with positive feedback. [Where problems could occur] If this patch is erroneous, it might cause issue to this mlx5 driver with certain operations (setting vid 0). And other programs such as libvirt that depends on this return value might be affected as well. - [Original Bug Description] There is an issue with hypervisor host side mlx5 driver operation on Bluefield devices in kernels <=5.16 that was recently fixed in master with a one-liner: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7846665d3504812acaebf920d1141851379a7f37 It would be good to have this fix in Focal+ kernels. This is not needed in https://bugs.launchpad.net/ubuntu/+source/linux- bluefield since it's used at the DPU side whereas the issue in question affects the hypervisor side. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
** Description changed: [Impact] - There is an issue with hypervisor host side mlx5 driver operation on Bluefield devices in kernels <=5.16 + There is an issue with hypervisor host side mlx5 driver operation on + Bluefield devices in kernels <=5.16 - Copied from patch description: + From patch description: When using libvirt to passthrough VF to VM it will always set the VF vlan to 0 even if user didn’t request it, this will cause libvirt to fail to boot in case the PF isn't eswitch owner. Example of such case is the DPU host PF which isn't eswitch manager, so any attempt to passthrough VF of it using libvirt will fail. [Fix] * 7846665d net/mlx5e: Unblock setting vid 0 for VF in case PF isn't - eswitch manager + eswitch manager This patch can be cherry-picked into Impish and newer kernels, but it requires some backport work on F/H due to they're missing commit b55b3538 that split the legacy code out. [Test] Test kernels can be found here: F: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/F/ H: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/H/ I: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/I/ J: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/J/ - Kernels tested by Dmitrii Shcherbakov with positive feedback. + Kernels tested on a SUT with this device by Dmitrii Shcherbakov, test + passed with positive feedback. [Where problems could occur] - If this patch is erroneous, it might cause issue to this mlx5 driver with certain operations (passing vlan 0). + If this patch is erroneous, it might cause issue to this mlx5 driver + with certain operations (setting vid 0). And other programs such as + libvirt that depends on this return value might be affected as well. + [Original Bug Description] There is an issue with hypervisor host side mlx5 driver operation on Bluefield devices in kernels <=5.16 that was recently fixed in master with a one-liner: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7846665d3504812acaebf920d1141851379a7f37 It would be good to have this fix in Focal+ kernels. This is not needed in https://bugs.launchpad.net/ubuntu/+source/linux- bluefield since it's used at the DPU side whereas the issue in question affects the hypervisor side. ** Changed in: linux (Ubuntu Focal) Assignee: (unassigned) => Po-Hsu Lin (cypressyew) ** Changed in: linux (Ubuntu Hirsute) Assignee: (unassigned) => Po-Hsu Lin (cypressyew) ** Changed in: linux (Ubuntu Jammy) Assignee: (unassigned) => Po-Hsu Lin (cypressyew) ** Changed in: linux (Ubuntu Impish) Assignee: (unassigned) => Po-Hsu Lin (cypressyew) ** Changed in: linux (Ubuntu Focal) Status: Confirmed => In Progress ** Changed in: linux (Ubuntu Hirsute) Status: Confirmed => In Progress ** Changed in: linux (Ubuntu Impish) Status: Confirmed => In Progress ** Changed in: linux (Ubuntu Jammy) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
** Description changed: - [Impact] + [Impact] There is an issue with hypervisor host side mlx5 driver operation on Bluefield devices in kernels <=5.16 Copied from patch description: When using libvirt to passthrough VF to VM it will always set the VF vlan to 0 even if user didn’t request it, this will cause libvirt to fail to boot in case the PF isn't eswitch owner. Example of such case is the DPU host PF which isn't eswitch manager, so - any attempt to passthrough VF of it using libvirt will fail. + any attempt to passthrough VF of it using libvirt will fail. [Fix] * 7846665d net/mlx5e: Unblock setting vid 0 for VF in case PF isn't - eswitch manager + eswitch manager This patch can be cherry-picked into Impish and newer kernels, but it requires some backport work on F/H due to they're missing commit b55b3538 that split the legacy code out. [Test] Test kernels can be found here: F: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/F/ H: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/H/ I: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/I/ J: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/J/ Kernels tested by Dmitrii Shcherbakov with positive feedback. [Where problems could occur] - If this patch is erroneous, it might cause issue to this mlx5 driver. - + If this patch is erroneous, it might cause issue to this mlx5 driver with certain operations (passing vlan 0). [Original Bug Description] There is an issue with hypervisor host side mlx5 driver operation on Bluefield devices in kernels <=5.16 that was recently fixed in master with a one-liner: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7846665d3504812acaebf920d1141851379a7f37 It would be good to have this fix in Focal+ kernels. This is not needed in https://bugs.launchpad.net/ubuntu/+source/linux- bluefield since it's used at the DPU side whereas the issue in question affects the hypervisor side. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
** Description changed: - There is an issue with hypervisor host side mlx5 driver operation on - Bluefield devices in kernels <=5.16 that was recently fixed in master - with a one-liner: + [Impact] + There is an issue with hypervisor host side mlx5 driver operation on Bluefield devices in kernels <=5.16 + + Copied from patch description: + When using libvirt to passthrough VF to VM it will always set the VF vlan + to 0 even if user didn’t request it, this will cause libvirt to fail to + boot in case the PF isn't eswitch owner. + + Example of such case is the DPU host PF which isn't eswitch manager, so + any attempt to passthrough VF of it using libvirt will fail. + + [Fix] + * 7846665d net/mlx5e: Unblock setting vid 0 for VF in case PF isn't + eswitch manager + + This patch can be cherry-picked into Impish and newer kernels, but it + requires some backport work on F/H due to they're missing commit + b55b3538 that split the legacy code out. + + [Test] + Test kernels can be found here: + F: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/F/ + H: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/H/ + I: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/I/ + J: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/J/ + + Kernels tested by Dmitrii Shcherbakov with positive feedback. + + [Where problems could occur] + If this patch is erroneous, it might cause issue to this mlx5 driver. + + + [Original Bug Description] + There is an issue with hypervisor host side mlx5 driver operation on Bluefield devices in kernels <=5.16 that was recently fixed in master with a one-liner: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7846665d3504812acaebf920d1141851379a7f37 It would be good to have this fix in Focal+ kernels. This is not needed in https://bugs.launchpad.net/ubuntu/+source/linux- bluefield since it's used at the DPU side whereas the issue in question affects the hypervisor side. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
Awesome! I will send the SRU request out, thanks for testing! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
And, finally, the Jammy kernel: $ uname -r 5.15.0-17-generic $ sudo ip link set enp130s0f0 vf 2 vlan 0 ; echo $? 0 $ sudo ip link set enp130s0f0 vf 2 vlan 1 ; echo $? RTNETLINK answers: Operation not permitted 2 ** Changed in: linux (Ubuntu Focal) Status: Incomplete => Confirmed ** Changed in: linux (Ubuntu Impish) Status: Incomplete => Confirmed ** Changed in: linux (Ubuntu Jammy) Status: Incomplete => Confirmed ** Changed in: linux (Ubuntu Hirsute) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
Impish kernel looks good: $ uname -r 5.13.0-28-generic $ sudo ip link set enp130s0f0 vf 2 vlan 1 ; echo $? RTNETLINK answers: Operation not permitted 2 $ sudo ip link set enp130s0f0 vf 2 vlan 0 ; echo $? 0 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
Hirsute kernel looks good as well: $ uname -r 5.11.0-50-generic $ sudo ip link set enp130s0f0 vf 2 vlan 1 ; echo $? RTNETLINK answers: Operation not permitted 2 $ sudo ip link set enp130s0f0 vf 2 vlan 0 ; echo $? 0 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
Focal: $ uname -r 5.4.0-97-generic $ sudo ip link set enp130s0f0 vf 2 vlan 1 RTNETLINK answers: Operation not permitted $ sudo ip link set enp130s0f0 vf 2 vlan 0 ; echo $? 0 Looks good - vlan 0 programming doesn't result in EPERM as expected contrary to non-zero vlans. Will try others as well. It would be good to backport it to currently released versions above Focal (for production, we are mostly looking for Focal GA + HWE kernels but it keeping it fixed consistently seems like the right approach). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
Note that it seems the current SRU cycle is the last one for Hirsute, so it's very likely that it won't get this fix. ** Changed in: linux (Ubuntu Impish) Status: New => Incomplete ** Changed in: linux (Ubuntu Focal) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
Hello Dmitrii, can you give these test kernel a try to see if they are working as expected? F: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/F/ H: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/H/ I: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/I/ J: https://people.canonical.com/~phlin/kernel/lp-1957753-mlx5e/J/ This patch can be cherry-picked into I/J, but required to be backported to F/H -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1957753] Re: net/mlx5e: EPERM on vlan 0 programming
** Also affects: linux (Ubuntu Hirsute) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Jammy) Importance: Undecided Status: Incomplete ** Also affects: linux (Ubuntu Impish) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1957753 Title: net/mlx5e: EPERM on vlan 0 programming To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1957753/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
