[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
** Changed in: opencpn (Ubuntu Jammy) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
@ddstreet: Thanks for review and uploading! Will try to remember. Next opportunity is backporting 5.6.2 to focal.,.. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
Ok that sounds good to me, thanks! One note for future changes, in this upload the bug reference was 'LP: 1971109', however the launchpad tooling requires that to be 'LP: #1971109' (with the '#'); it's not important enough to require a new upload but do try to remember for next upload. ** Also affects: opencpn (Ubuntu Jammy) Importance: Undecided Status: New ** Changed in: opencpn (Ubuntu) Status: New => Fix Released ** Changed in: opencpn (Ubuntu Jammy) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
As for 1): My initial description could and should have been better. I'm actually not aware of bugs that can and should be fixed by point patches. That is, the description is wrong. The core problem the backport tries to address is that OpenCPN users (thousands, for sure) are accustomed to using a PPA [1] These packages are not really "packaged" in the sense we are used to, there is no source package, no review, etc -- it's basically the auto-generated output from cmake/cpack. However, the PPA is up to date with the latest releases. If we want to offer proper repos instead, backports are necessary to make the official packaging useful. Until we get this running there are no issues reported through the Ubuntu channels. If I look in upstream there are of course all sorts of problems which are solved by latest release. But I honestly don't (yet) see the value of point-patching any of these. Of course, user input in upstream or here might change the situation. I am certainly prepared to handle this by updating the 5.6.0 package if/when the situation occurs. On a sidenote, 5.6.2 is backported not only to Bullseye but also Buster. [1] https://launchpad.net/~opencpn/+archive/ubuntu/opencpn -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
To start with 2): Application downloads plugins from external sources. There are not that many plugins available for jammy yet, and the Focal plugins are actually compatible so the patch makes these plugins available also for Jammy. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
Looks mostly ok, couple of questions though: 1) the description says 5.6.2 has several important bugfixes; if that means the 5.6.0 version in jammy is affected by those bugs, the correct approach is to patch that version to fix the bugs. The backports pocket shouldn't be used *instead* of the SRU process. Can you clarify if there are bugs in 5.6.0 in jammy that should be fixed? 2) I'm confused about 0004-Build-Use-20.04-plugins-on-22.04.patch; I see it's setting the plugin target version to 20.04, but how does that get the plugins from 20.04? It doesn't expect to get plugins from 20.04, right? Are the plugins included in the source, but expecting a '20.04' build? Or does the application download plugins from some external source at runtime? Or something else? I think it would be good to add some clarification either to the patch header, and/or here. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
Ok, sponsored again. To the Ubuntu Backporters team: Please review the latest upload and reject the first one. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
Ah, right. And yes, we want that patch. Sorry for the mess. Need to improve... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
On 2022-05-07 17:35, Alec Leamas wrote: > These two debdiffs are basically the same thing compared to > different baselines. We still talk past each other. I used the latest commit in your git branch, and applied that as a debdiff against the kinetic source. But that commit, unlike your debdiff attached in comment #7, does not include 0004-Build-Use-20.04-plugins- on-22.04.patch. > So, in the end, which diff to use is really something I must leave > in your hands. Nope. You need to decide if 0004-Build-Use-20.04-plugins-on-22.04.patch should be included or not. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
My bad, sorry, still learning. It is not until now I understand the role of the debdiff, that this is what you as sponsor upload. These two debdiffs are basically the same thing compared to different baselines. However, "my" diff is probably far easier to review being much smaller. If this is reason enough to upload that instead is something I cannot judge. Likewise, I don't know whether it is acceptable to use such a diff in this context. So, in the end, which diff to use is really something I must leave in your hands. Have still another backport one in my plans, kinetic -> focal. But I waited to file this until I had been through this process once more. Will not forget the debdiff next time, promise! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
No. The thing is that — since you hadn't attached a debdiff when I uploaded — I used fbdd5672 as the debdiff on top of 5.6.2+dfsg-1. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
Hi! [Please use English on bug reports.] I simply applied https://gitlab.com/leamas/opencpn/-/commit/fbdd5672 to the kinetic source. No patches. On 2022-05-07 15:46, Alec Leamas wrote: > PS: När skall jag lära mig att bifoga den till ärendet från början? DS Yeah.. And I should have asked instead of guessing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
Hm... are you confused by the fact that the diff in the upload queue is against 5.6.0+dfsg1-1 (huge!) whereas the debdiff here is against kinetic i. e., 5.6.2+dfsg-1? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
Hej Gunnar, On 07/05/2022 15:28, Gunnar Hjalmarsson wrote: > Hey, Alec, that debdiff you added differs from what I uploaded. What > now? Should I use the debdiff in a new upload? > Administrativa problem Hur ser din debdiff ut? --alec PS: När skall jag lära mig att bifoga den till ärendet från början? DS -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
Hey, Alec, that debdiff you added differs from what I uploaded. What now? Should I use the debdiff in a new upload? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
** Attachment added: "Debdiff against kinetic" https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+attachment/5587227/+files/debdiff.txt -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
Sponsored to the jammy unapproved queue. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1971109] Re: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy
** Summary changed: - [BPO] Backport opencpn 5.6.2 from Kinetic + [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1971109 Title: [BPO] Backport opencpn 5.6.2 from Kinetic to Jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/opencpn/+bug/1971109/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
