[Bug 2056578] Re: [SRU - Noble] Tor Browser - keyboard not functioning

2024-06-25 Thread Launchpad Bug Tracker
This bug was fixed in the package torbrowser-launcher - 0.3.7-1ubuntu1

---
torbrowser-launcher (0.3.7-1ubuntu1) noble; urgency=medium

  * Fix non-functional keyboard (LP: #2056578).

 -- Thomas Ward   Thu, 06 Jun 2024 19:15:35 -0500

** Changed in: torbrowser-launcher (Ubuntu Noble)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2056578

Title:
  [SRU - Noble] Tor Browser - keyboard not functioning

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/2056578/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2056578] Re: [SRU - Noble] Tor Browser - keyboard not functioning

2024-06-19 Thread AsciiWolf
** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2056578

Title:
  [SRU - Noble] Tor Browser - keyboard not functioning

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/2056578/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2056578] Re: [SRU - Noble] Tor Browser - keyboard not functioning

2024-06-18 Thread AsciiWolf
I did set up two (clean installation, fully updated) 24.04 VMs: one with
noble-proposed disabled and the other one with noble-proposed enabled.
Installed latest torbrowser-launcher on both of them.

- On the VM without noble-proposed enabled and using torbrowser-launcher 
version 0.3.7-1build2, the keyboard input in Tor Browser does not work.
- On the VM with noble-proposed enabled and using torbrowser-launcher version 
0.3.7-1ubuntu1, the keyboard input in Tor Browser *works fine*.

In other words, the 0.3.7-1ubuntu1 build fixes the issue. Thanks!

** Tags removed: verification-needed-noble
** Tags added: verification-done-noble

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2056578

Title:
  [SRU - Noble] Tor Browser - keyboard not functioning

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/2056578/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2056578] Re: [SRU - Noble] Tor Browser - keyboard not functioning

2024-06-17 Thread Mauricio Faria de Oliveira
Thanks for the upload as well.

Ideally, the version should be `0.3.7-1ubuntu0.1` (not `ubuntu1`), as this
is for stable release (see [1]), but in this case it's fine -- the version
hasn't been used (see [2]), and will not be used anymore, as devel release
is already at `0.3.7-2`.

Now, I'd suggest the following _style_ changes, which helps Ubuntu maintenance
over time. This isnt' required, but is recommended and has been popularly used.

Changelog entry with related files:
  * d/p/05-Add-IBus-socket-access.patch: Fix non-functional keyboard (LP: 
#2056578).

DEP-3 tags in .patch file [3]:
  Bug-Ubuntu: https://bugs.launchpad.net/bugs/2056578
  Origin: vendor, 
https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/fd38d605bc9160edaea2e5eaff665e550340f38e

Since the first point is fine in this case, and the remaining points are style,
this can be accepted as is into Noble.

Thanks for your contribution!
Mauricio

[1] https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging
[2] https://launchpad.net/ubuntu/+source/torbrowser-launcher/+publishinghistory
[3] https://dep-team.pages.debian.net/deps/dep3/

** Changed in: torbrowser-launcher (Ubuntu Noble)
   Status: Confirmed => Fix Committed

** Tags added: verification-needed verification-needed-noble

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2056578

Title:
  [SRU - Noble] Tor Browser - keyboard not functioning

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/2056578/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2056578] Re: [SRU - Noble] Tor Browser - keyboard not functioning

2024-06-17 Thread Mauricio Faria de Oliveira
Thanks for mentioning that the proposed change is present in Firefox AppArmor 
profiles.
Looking at its snap profiles, this can be traced back to snapd; that builds 
confidence.
For documentation purposes:

$ sudo apt update && sudo apt install -y firefox

$ dpkg -s firefox | grep ^Description:
Description: Transitional package - firefox -> firefox snap

$ snap list firefox
Name VersionRev   Tracking   Publisher  Notes
firefox  127.0-2.1  4424  latest/stable  mozilla✓   -

$ grep -rw ibus /var/lib/snapd/apparmor/profiles/
...
/var/lib/snapd/apparmor/profiles/snap.firefox.firefox:# when running with glib 
>= 2.75.0, ibus uses a regular socket
/var/lib/snapd/apparmor/profiles/snap.firefox.firefox:owner 
@{HOME}/.cache/ibus/dbus-* rw,

$ snap download firefox
$ unsquashfs -d firefox-snap firefox_4424.snap
... grep doesn't find it in firefox-snap/, but finds it in /snap/snapd/
$ grep -a -B1 '^owner .*/ibus/dbus-\*' /snap/snapd/21759/usr/lib/snapd/snapd
# when running with glib >= 2.75.0, ibus uses a regular socket
owner @{HOME}/.cache/ibus/dbus-* rw,

... confirmed it is in snapd source
$ apt source snapd
$ grep -r -B1 'owner.*/ibus/dbus-*' snapd-2.63+24.04/
snapd-2.63+24.04/interfaces/builtin/desktop_legacy.go-# when running with glib 
>= 2.75.0, ibus uses a regular socket
snapd-2.63+24.04/interfaces/builtin/desktop_legacy.go:owner 
@{HOME}/.cache/ibus/dbus-* rw,

$ dpkg -s libglib2.0-dev | grep Version:
Version: 2.80.0-6ubuntu3.1

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2056578

Title:
  [SRU - Noble] Tor Browser - keyboard not functioning

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/2056578/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2056578] Re: [SRU - Noble] Tor Browser - keyboard not functioning

2024-06-17 Thread Mauricio Faria de Oliveira
Marking Oracular as Fix Released.

torbrowser-launcher (0.3.7-2) unstable; urgency=medium

  [ Daniel Rusek ]
  * debian/patches:
- Add patch 05 to fix keyboard input issue.
...


** Changed in: torbrowser-launcher (Ubuntu Oracular)
   Status: Invalid => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2056578

Title:
  [SRU - Noble] Tor Browser - keyboard not functioning

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/2056578/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2056578] Re: [SRU - Noble] Tor Browser - keyboard not functioning

2024-06-14 Thread Lolo Repsol
Thank you very much gypearce, that worked just fine :)

I added the line right after:

# KDE 4
  owner @{HOME}/.kde/share/config/* r,

Thank you again for made the fix accessible for the noobs! <3

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2056578

Title:
  [SRU - Noble] Tor Browser - keyboard not functioning

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/2056578/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2056578] Re: [SRU - Noble] Tor Browser - keyboard not functioning

2024-06-06 Thread Thomas Ward
** Description changed:

  [Impact]
  Due to various changes in AppArmor, and the AppArmor policy for Tor Browser 
installed by the launcher, the default ibus/dbus abstractions don't include 
user-space access to DBUS/IBUS.
  
  This results in Tor Browser being unable to read keyboard input in
  userspace, resulting in a Non-Functional application.  While Tor Browser
  *launcher* still works, the underlying Tor Browser inherits the AppArmor
  profile from torbrowser-launcher, hence this needs updated here.
  
  [Test Plan]
  This fix has already been tested and implemented in Debian upstream.  
However, it was not available before FeatureFreeze, and was not available in 
Debian until post-Noble release.
  
  This has already been tested manually by others, but as soon as a
  version with the patch present is available, a user should install the
  updated torbrowser-launcher package and the updated AppArmor profile
  should apply, and the program should work as usual.
  
  [Regression Potential]
  Extremely limited.  This simply allows access to userspace dbus/ibus access 
for Keyboard input.
  
  Note that this exact same line being added to the AppArmor profile here
  exists in the Firefox AppArmor ruleset as well, and since Tor Browser
  and Firefox share much of the same code, this should have limited to no
  impact as this has existed in Firefox for a long time.
  
+ [Where problems could occur]
+ 
+ The only thing that might happen is extra access to dbus/ibus interfaces
+ for input handling.  However, as this change being added by SRU is
+ already in the Firefox apparmor profile, this shouldn't cause any
+ issues.
+ 
+ 
  [Other Info]
  This is already available in Debian Unstable, and also in Oracular due to the 
sync.
  
  Simon Quigley is handling the upload and prep of the SRU debdiff to
  noble-updates as a favor to Thomas Ward who is having computer scuff at
  the time of the uploading.
- 
  
  [Original Description]
  
  I have installed tor browser v13.0.11 on 24.04 (noble). The keyboard
  does not operate, when typing no characters are appearing.
  
  I have tried to enter a search and also type in a URL but this is not
  working.
  
  I am using default Ubuntu desktop with wayland.
  
  ProblemType: Bug
  DistroRelease: Ubuntu 24.04
  Package: torbrowser-launcher 0.3.7-1
  ProcVersionSignature: Ubuntu 6.8.0-11.11-generic 6.8.0-rc4
  Uname: Linux 6.8.0-11-generic x86_64
  ApportVersion: 2.28.0-0ubuntu1
  Architecture: amd64
  CasperMD5CheckResult: pass
  CurrentDesktop: ubuntu:GNOME
  Date: Fri Mar  8 16:01:36 2024
  InstallationDate: Installed on 2024-03-08 (0 days ago)
  InstallationMedia: Ubuntu 24.04 LTS "Noble Numbat" - Daily amd64 (20240306)
  ProcEnviron:
   LANG=en_US.UTF-8
   PATH=(custom, no user)
   SHELL=/bin/bash
   TERM=xterm-256color
   XDG_RUNTIME_DIR=
  SourcePackage: torbrowser-launcher
  UpgradeStatus: No upgrade log present (probably fresh install)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2056578

Title:
  [SRU - Noble] Tor Browser - keyboard not functioning

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/2056578/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs