[Bug 2055939] Re: FFE: enable riscv64 Milk-V Mars board
This bug was fixed in the package u-boot - 2024.01+dfsg-1ubuntu3 --- u-boot (2024.01+dfsg-1ubuntu3) noble; urgency=medium Add support for the Milk-V Mars board to the u-boot-starfive package. (LP: #2055939) -- Heinrich Schuchardt Mon, 04 Mar 2024 16:58:44 +0100 ** Changed in: u-boot (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2055939 Title: FFE: enable riscv64 Milk-V Mars board To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/2055939/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2055939] Re: FFE: enable riscv64 Milk-V Mars board
u-boot 2024.01+dfsg-1ubuntu3 just built on armhf -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2055939 Title: FFE: enable riscv64 Milk-V Mars board To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/2055939/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2055939] Re: FFE: enable riscv64 Milk-V Mars board
I think this is fine. My only concern is that the package now fails to build from source on armhf, but that's unrelated to the uploaded change. However, I'd ask the uploaders to keep a lookout on the package and making sure that the armhf build is rebuilt once the time_t craziness is over. For now, approving the FFe. ** Changed in: u-boot (Ubuntu) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2055939 Title: FFE: enable riscv64 Milk-V Mars board To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/2055939/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2055939] Re: FFE: enable riscv64 Milk-V Mars board
@Dave thanks for indicating the necessary information * Upstream changelog: The patches are not in upstream yet. This is the shortlog for applied patches: eeprom: starfive: function get_product_id_from_eeprom() riscv: set fdtfile on Milk-V Mars board: starfive: support Milk-V Mars board riscv: starfive: avoid including common.h doc: describe Milk-V Mars board * Buildlog: The package is available in ppa:xypron/gnu-efi. The riscv64 buildlog is https://launchpadlibrarian.net/717451106/buildlog_ubuntu- noble-riscv64.u-boot_2024.01+dfsg-1ubuntu3_BUILDING.txt.gz * Installation log: The u-boot-starfive package only provides the U-Boot files but does not copy them to the SD-card or flash. Flash-kernel is not involved as U-Boot does not provide device-trees. # dpkg -i u-boot-starfive_2024.01+dfsg-1ubuntu3_riscv64.deb (Reading database ... 150477 files and directories currently installed.) Preparing to unpack u-boot-starfive_2024.01+dfsg-1ubuntu3_riscv64.deb ... Unpacking u-boot-starfive:riscv64 (2024.01+dfsg-1ubuntu3) over (2024.01+dfsg-1ubuntu2) ... Setting up u-boot-starfive:riscv64 (2024.01+dfsg-1ubuntu3) ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2055939 Title: FFE: enable riscv64 Milk-V Mars board To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/2055939/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2055939] Re: FFE: enable riscv64 Milk-V Mars board
I suspect the FFe's going to a little bit more detail, specifically (from https://wiki.ubuntu.com/FreezeExceptionProcess): * the diff of the upstream changelog as changelog.diff -- I'm not sure that's actually necessary here since it's basically the content of your header e-mail which is immediately accessible from https://lore.kernel.org/u-boot/20240303130122.29983-1-heinrich.schucha...@canonical.com/ * the build log as a separate file; that's more likely useful here given lack of access to the hardware for those reviewing this * the template mentions an install log; that *might* be useful but speaks more to flash-kernel in this case than anything else, I suspect, so probably not required And you've already mentioned the testing you've done which I think is sufficient given the limited nature of the patch. Anyway, I'll go ahead and sponsor this now but you might want to consider attaching a build- log just in case the FFe reviewer wants it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2055939 Title: FFE: enable riscv64 Milk-V Mars board To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/2055939/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2055939] Re: FFE: enable riscv64 Milk-V Mars board
** Merge proposal linked: https://code.launchpad.net/~xypron/ubuntu/+source/u-boot/+git/u-boot/+merge/461725 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2055939 Title: FFE: enable riscv64 Milk-V Mars board To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/2055939/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2055939] Re: FFE: enable riscv64 Milk-V Mars board
Merge request https://code.launchpad.net/~xypron/ubuntu/+source/u-boot/+git/u-boot/+merge/461725 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2055939 Title: FFE: enable riscv64 Milk-V Mars board To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/2055939/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
