Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/disco into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/disco
This can be rejected since it's going to be overridden by 3.32.2 -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/366944 Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/disco into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/disco. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session_bionic into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/bionic
The proposal to merge ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session_bionic into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/bionic has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/369154 -- Your team Ubuntu Desktop is requested to review the proposed merge of ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session_bionic into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/bionic. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] lp:~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications into lp:unity-settings-daemon
The proposal to merge lp:~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications into lp:unity-settings-daemon has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications/+merge/369223 -- Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: [Merge] lp:~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications into lp:unity-settings-daemon
Review: Approve Thanks, looks fine. One comment, it would help if you included reference to upstream commits when it's a backport, e.g in this case seems to be https://gitlab.gnome.org/GNOME/gnome-settings-daemon/commit/88e384e3 -- https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications/+merge/369223 Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
[Merge] lp:~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications into lp:unity-settings-daemon
The proposal to merge lp:~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications into lp:unity-settings-daemon has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/fix-low-battery-notifications/+merge/369223 -- Your team Unity Settings Daemon Development Team is subscribed to branch lp:unity-settings-daemon. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
