Re: Syncope startup performance improvements

2016-08-29 Thread Francesco Chicchiriccò
Hi,
your improvement looks interesting; would you mind:

1. sending an ICLA, as explained in the last paragraph from

http://syncope.apache.org/contributing.html

2. opening an improvement on JIRA?

I'll take a deeper look once back at work, this Thursday.

Thanks for your contribution.
Regards.

On 29 aug 2016 16:04:50 CEST, Adrian Gonzalez  wrote:
>Hello,
>I'm using syncope 2.0.0-M4.Standalone startup takes 135s on my laptop.
>I would like to improve syncope's startup.
>I've made some experimentations :
>1. Restricting scanning on basePackages    I've changed
>ClassPathScanImplementationLookup to scan only some specific
>packages.    This results in a 32s startup.
>    https://github.com/apache/syncope/pull/36
>
>2. Adding startStopThreads="5" in server.xml    This results in a 26s
>startup.
>3. I've also tried to set  in
>context.xml, but no improvement.
>4. I've further modified ClassPathScanImplementationLookup to scan a
>fixed list of classes.   As is, this doesn't work.   I would have a
>20.7s startup (cumulated with change 2)  
>https://github.com/gonzalad/syncope/tree/2.0.0-M2-startup-perf2
>
>
>Could it be possible to incorporate first PR in syncope code (pull/36)
>? Sorry, I made PR on 2.0.0-M4, but could make 2.0.0-SNASPHOT work 
>Are you interested in improvement #4 ? (in this case, I can spend a bit
>more time on it)
>Thanks,Adrian


-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC,
CXF Committer, OpenJPA Committer
http://home.apache.org/~ilgrosso/


Syncope startup performance improvements

2016-08-29 Thread Adrian Gonzalez
Hello,
I'm using syncope 2.0.0-M4.Standalone startup takes 135s on my laptop.
I would like to improve syncope's startup.
I've made some experimentations :
1. Restricting scanning on basePackages    I've changed 
ClassPathScanImplementationLookup to scan only some specific packages.    This 
results in a 32s startup.
    https://github.com/apache/syncope/pull/36

2. Adding startStopThreads="5" in server.xml    This results in a 26s startup.
3. I've also tried to set  in context.xml, 
but no improvement.
4. I've further modified ClassPathScanImplementationLookup to scan a fixed list 
of classes.   As is, this doesn't work.   I would have a 20.7s startup 
(cumulated with change 2)   
https://github.com/gonzalad/syncope/tree/2.0.0-M2-startup-perf2


Could it be possible to incorporate first PR in syncope code (pull/36) ? Sorry, 
I made PR on 2.0.0-M4, but could make 2.0.0-SNASPHOT work 
Are you interested in improvement #4 ? (in this case, I can spend a bit more 
time on it)
Thanks,Adrian