Re: maven site : Too many open files

2003-12-04 Thread Emmanuel Venisse
Hi,

Some users have this problem with big project. I think it's due to jxr
plugin that doesn't close stream in JavaFileImpl class in the parse method.
I don't have time for correct this, but if you can try to write a patch for
it  and test it with your big project, it will be cool.

Emmanuel

- Original Message - 
From: Nicolas De Loof [EMAIL PROTECTED]
To: Maven Users List [EMAIL PROTECTED]
Sent: Thursday, December 04, 2003 9:55 AM
Subject: maven site : Too many open files


 Hello,

 I get troubles generating doc-site in a (big) webapp :

 I get lot's of

 Caught java.io.IOException: Too many open files processing xref/com



 Caught java.io.IOException: Too many open files processing team-list.html
 Exception Message: Too many open files

 BUILD FAILED
 File.. file:/C:/Documents and
Settings/ndeloof/.maven/plugins/maven-linkchec
 k-plugin-1.1/
 Element... linkcheck:linkcheck
 Line.. 73
 Column 9
 Too many open files
 Total time: 27 minutes 10 seconds
 Finished at: Thu Dec 04 09:29:04 CET 2003




 How too make linkcheck work without opeing so much (?) files ?

 Nico.

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: maven site : Too many open files

2003-12-04 Thread Joakim Erdfelt
Nicolas De Loof wrote:
I get troubles generating doc-site in a (big) webapp : 

I get lot's of 

Caught java.io.IOException: Too many open files processing xref/com
Move the jxr plugin to the top of the reports section in your 
project.xml.  It worked for our 4500+ java file project.
(and we are using Maven 1.0-rc1 on a solaris system)

It's not 100% jxr's fault, nearly all of the plugin's appear to leak
file descriptors (according to solaris truss).  jxr is just 
particullarly agressive with them.

/* Joakim Erdfelt - Cingular Wireless */

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: maven site : Too many open files

2003-12-04 Thread Nicolas De Loof
Ca peut peut-etre aider  ...


- Original Message - 
From: Emmanuel Venisse [EMAIL PROTECTED]
To: Maven Users List [EMAIL PROTECTED]
Sent: Thursday, December 04, 2003 3:58 PM
Subject: Re: maven site : Too many open files


 I'll apply the Nicolas patch for reduce a little open files.
 
 Emmanuel
 
 - Original Message - 
 From: Joakim Erdfelt [EMAIL PROTECTED]
 To: Maven Users List [EMAIL PROTECTED]
 Sent: Thursday, December 04, 2003 1:55 PM
 Subject: Re: maven site : Too many open files
 
 
  Nicolas De Loof wrote:
   I get troubles generating doc-site in a (big) webapp :
  
   I get lot's of
  
   Caught java.io.IOException: Too many open files processing
 xref/com
 
  Move the jxr plugin to the top of the reports section in your
  project.xml.  It worked for our 4500+ java file project.
  (and we are using Maven 1.0-rc1 on a solaris system)
 
  It's not 100% jxr's fault, nearly all of the plugin's appear to leak
  file descriptors (according to solaris truss).  jxr is just
  particullarly agressive with them.
 
  /* Joakim Erdfelt - Cingular Wireless */
 
 
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]Index: JavaFileImpl.java
===
RCS file: 
/home/cvspublic/maven-plugins/jxr/src/main/org/apache/maven/jxr/pacman/JavaFileImpl.java,v
retrieving revision 1.2
diff -u -r1.2 JavaFileImpl.java
--- JavaFileImpl.java   2 Oct 2003 00:18:52 -   1.2
+++ JavaFileImpl.java   4 Dec 2003 10:45:38 -
@@ -62,6 +62,8 @@
  */
 public class JavaFileImpl extends JavaFile
 {
+
+private Reader reader;
 
 /**
  * Create a new JavaFileImpl that points to a given file...
@@ -92,8 +94,9 @@
 private void parse()
 throws IOException
 {
-
-StreamTokenizer stok = this.getTokenizer();
+StreamTokenizer stok = null; 
+try {
+stok = this.getTokenizer();
 
 while (stok.nextToken() != StreamTokenizer.TT_EOF)
 {
@@ -144,7 +147,13 @@
 }
 
 }
-
+}
+finally {
+stok = null;
+if (this.reader != null) {
+this.reader.close();
+}
+}
 }
 
 /** Get a StreamTokenizer for this file.  */
@@ -157,7 +166,7 @@
 throw new IOException(this.getFilename() +  does not exist!);
 }
 
-FileReader reader = new FileReader(this.getFilename());
+this.reader = new FileReader(this.getFilename());
 
 StreamTokenizer stok = new StreamTokenizer(reader);
 //int tok;

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: maven site : Too many open files

2003-12-04 Thread Emmanuel Venisse
I'll apply the Nicolas patch for reduce a little open files.

Emmanuel

- Original Message - 
From: Joakim Erdfelt [EMAIL PROTECTED]
To: Maven Users List [EMAIL PROTECTED]
Sent: Thursday, December 04, 2003 1:55 PM
Subject: Re: maven site : Too many open files


 Nicolas De Loof wrote:
  I get troubles generating doc-site in a (big) webapp :
 
  I get lot's of
 
  Caught java.io.IOException: Too many open files processing
xref/com

 Move the jxr plugin to the top of the reports section in your
 project.xml.  It worked for our 4500+ java file project.
 (and we are using Maven 1.0-rc1 on a solaris system)

 It's not 100% jxr's fault, nearly all of the plugin's appear to leak
 file descriptors (according to solaris truss).  jxr is just
 particullarly agressive with them.

 /* Joakim Erdfelt - Cingular Wireless */


 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: maven site : Too many open files

2003-12-04 Thread Nicolas De Loof
That works !

I just had to disable linkcheck because I got OutOfMemory.

thanks.

Nico.



 Nicolas De Loof wrote:
  I get troubles generating doc-site in a (big) webapp : 
  
  I get lot's of 
  
  Caught java.io.IOException: Too many open files processing xref/com
 
 Move the jxr plugin to the top of the reports section in your 
 project.xml.  It worked for our 4500+ java file project.
 (and we are using Maven 1.0-rc1 on a solaris system)
 
 It's not 100% jxr's fault, nearly all of the plugin's appear to leak
 file descriptors (according to solaris truss).  jxr is just 
 particullarly agressive with them.
 
 /* Joakim Erdfelt - Cingular Wireless */
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: maven site : Too many open files

2003-12-04 Thread Erdfelt, Joakim
  From: Nicolas De Loof [mailto:[EMAIL PROTECTED] 
  Sent: 04 December 2003 14:09
  
  That works !
  
  I just had to disable linkcheck because I got OutOfMemory.
  
  thanks.
  
  Nico.
 From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
 Sent: Thursday, December 04, 2003 9:12 AM
 
 You can (hopefully) resolve that one by increasing the JVM memory
 allocation. Set MAVEN_OPTS to something like -Xmx512m. That works for
 me, but given that you already say yours is a large project, 
 maybe even
 that is too little...
 
 Nick

We cannot run either linkcheck or tasklist on our 4500+ file project.
They both crap out (even with 4GB allocated via -Xmx4096m).

If you figgure those out, let me know how.

/* Joakim Erdfelt - Cingular Wireless */


Re: maven site : Too many open files

2003-12-04 Thread Nicolas De Loof
I tried with -Xmx1024m and it fails Out of memory. 

Why is linkcheck such a memory consumer ?

Nico.



   From: Nicolas De Loof [mailto:[EMAIL PROTECTED] 
   Sent: 04 December 2003 14:09
   
   That works !
   
   I just had to disable linkcheck because I got OutOfMemory.
   
   thanks.
   
   Nico.
  From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
  Sent: Thursday, December 04, 2003 9:12 AM
  
  You can (hopefully) resolve that one by increasing the JVM memory
  allocation. Set MAVEN_OPTS to something like -Xmx512m. That works for
  me, but given that you already say yours is a large project, 
  maybe even
  that is too little...
  
  Nick
 
 We cannot run either linkcheck or tasklist on our 4500+ file project.
 They both crap out (even with 4GB allocated via -Xmx4096m).
 
 If you figgure those out, let me know how.
 
 /* Joakim Erdfelt - Cingular Wireless */
 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]