Re: Multi-tabs and back-button support 1.5.2

2011-10-28 Thread Charlie Midtlyng
I have now created an issue on jira with the actual problems described above.
 
https://issues.apache.org/jira/browse/WICKET-4182
https://issues.apache.org/jira/browse/WICKET-4182 

--
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/Multi-tabs-and-back-button-support-1-5-2-tp3943445p3947091.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Multi-tabs and back-button support 1.5.2

2011-10-27 Thread Martin Grigorov
On Thu, Oct 27, 2011 at 5:53 PM, Igor Vaynberg  wrote:
> no, not necessarily ajax. simple links that instead of navigating to a
> different page do panel replacement.

ok

I think back button should not be harmed by the stale check.

@Charlie: can you create a quickstart, attach it to a ticket and
describe the steps ?
Thanks!

>
> -igor
>
> On Thu, Oct 27, 2011 at 8:51 AM, Martin Grigorov  wrote:
>> On Thu, Oct 27, 2011 at 5:48 PM, Igor Vaynberg  
>> wrote:
>>> hrm. i dont think the rendercount should prevent me from using the
>>> page. if i write my application as a single page then our back button
>>> support is completely hosed. i should be able to back button and
>>> re-submit the form.
>>
>> As single page - i.e. completely Ajax navigation ?
>> In this case back button support is on your own.
>>
>> Do you suggest to remove the check for stale page ?
>>
>>>
>>> -igor
>>>
>>> On Thu, Oct 27, 2011 at 3:20 AM, Martin Grigorov  
>>> wrote:
 The only option is see is to make the check for stale page
 configurable via IPageSettings for example.

 On Thu, Oct 27, 2011 at 12:16 PM, Charlie Midtlyng
  wrote:
> I would actually like to accept the data from both tabs as long as they 
> are
> valid.
> The same effect should be available on back-button and changing values.
>
> --
> View this message in context: 
> http://apache-wicket.1842946.n4.nabble.com/Multi-tabs-and-back-button-support-1-5-2-tp3943445p3943856.html
> Sent from the Users forum mailing list archive at Nabble.com.
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>



 --
 Martin Grigorov
 jWeekend
 Training, Consulting, Development
 http://jWeekend.com

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


>>>
>>> -
>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>>> For additional commands, e-mail: users-h...@wicket.apache.org
>>>
>>>
>>
>>
>>
>> --
>> Martin Grigorov
>> jWeekend
>> Training, Consulting, Development
>> http://jWeekend.com
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Multi-tabs and back-button support 1.5.2

2011-10-27 Thread Igor Vaynberg
no, not necessarily ajax. simple links that instead of navigating to a
different page do panel replacement.

-igor

On Thu, Oct 27, 2011 at 8:51 AM, Martin Grigorov  wrote:
> On Thu, Oct 27, 2011 at 5:48 PM, Igor Vaynberg  
> wrote:
>> hrm. i dont think the rendercount should prevent me from using the
>> page. if i write my application as a single page then our back button
>> support is completely hosed. i should be able to back button and
>> re-submit the form.
>
> As single page - i.e. completely Ajax navigation ?
> In this case back button support is on your own.
>
> Do you suggest to remove the check for stale page ?
>
>>
>> -igor
>>
>> On Thu, Oct 27, 2011 at 3:20 AM, Martin Grigorov  
>> wrote:
>>> The only option is see is to make the check for stale page
>>> configurable via IPageSettings for example.
>>>
>>> On Thu, Oct 27, 2011 at 12:16 PM, Charlie Midtlyng
>>>  wrote:
 I would actually like to accept the data from both tabs as long as they are
 valid.
 The same effect should be available on back-button and changing values.

 --
 View this message in context: 
 http://apache-wicket.1842946.n4.nabble.com/Multi-tabs-and-back-button-support-1-5-2-tp3943445p3943856.html
 Sent from the Users forum mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


>>>
>>>
>>>
>>> --
>>> Martin Grigorov
>>> jWeekend
>>> Training, Consulting, Development
>>> http://jWeekend.com
>>>
>>> -
>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>>> For additional commands, e-mail: users-h...@wicket.apache.org
>>>
>>>
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>>
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Multi-tabs and back-button support 1.5.2

2011-10-27 Thread Martin Grigorov
On Thu, Oct 27, 2011 at 5:48 PM, Igor Vaynberg  wrote:
> hrm. i dont think the rendercount should prevent me from using the
> page. if i write my application as a single page then our back button
> support is completely hosed. i should be able to back button and
> re-submit the form.

As single page - i.e. completely Ajax navigation ?
In this case back button support is on your own.

Do you suggest to remove the check for stale page ?

>
> -igor
>
> On Thu, Oct 27, 2011 at 3:20 AM, Martin Grigorov  wrote:
>> The only option is see is to make the check for stale page
>> configurable via IPageSettings for example.
>>
>> On Thu, Oct 27, 2011 at 12:16 PM, Charlie Midtlyng
>>  wrote:
>>> I would actually like to accept the data from both tabs as long as they are
>>> valid.
>>> The same effect should be available on back-button and changing values.
>>>
>>> --
>>> View this message in context: 
>>> http://apache-wicket.1842946.n4.nabble.com/Multi-tabs-and-back-button-support-1-5-2-tp3943445p3943856.html
>>> Sent from the Users forum mailing list archive at Nabble.com.
>>>
>>> -
>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>>> For additional commands, e-mail: users-h...@wicket.apache.org
>>>
>>>
>>
>>
>>
>> --
>> Martin Grigorov
>> jWeekend
>> Training, Consulting, Development
>> http://jWeekend.com
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Multi-tabs and back-button support 1.5.2

2011-10-27 Thread Igor Vaynberg
hrm. i dont think the rendercount should prevent me from using the
page. if i write my application as a single page then our back button
support is completely hosed. i should be able to back button and
re-submit the form.

-igor

On Thu, Oct 27, 2011 at 3:20 AM, Martin Grigorov  wrote:
> The only option is see is to make the check for stale page
> configurable via IPageSettings for example.
>
> On Thu, Oct 27, 2011 at 12:16 PM, Charlie Midtlyng
>  wrote:
>> I would actually like to accept the data from both tabs as long as they are
>> valid.
>> The same effect should be available on back-button and changing values.
>>
>> --
>> View this message in context: 
>> http://apache-wicket.1842946.n4.nabble.com/Multi-tabs-and-back-button-support-1-5-2-tp3943445p3943856.html
>> Sent from the Users forum mailing list archive at Nabble.com.
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>>
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Multi-tabs and back-button support 1.5.2

2011-10-27 Thread Martin Grigorov
The only option is see is to make the check for stale page
configurable via IPageSettings for example.

On Thu, Oct 27, 2011 at 12:16 PM, Charlie Midtlyng
 wrote:
> I would actually like to accept the data from both tabs as long as they are
> valid.
> The same effect should be available on back-button and changing values.
>
> --
> View this message in context: 
> http://apache-wicket.1842946.n4.nabble.com/Multi-tabs-and-back-button-support-1-5-2-tp3943445p3943856.html
> Sent from the Users forum mailing list archive at Nabble.com.
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Multi-tabs and back-button support 1.5.2

2011-10-27 Thread Charlie Midtlyng
I would actually like to accept the data from both tabs as long as they are
valid. 
The same effect should be available on back-button and changing values. 

--
View this message in context: 
http://apache-wicket.1842946.n4.nabble.com/Multi-tabs-and-back-button-support-1-5-2-tp3943445p3943856.html
Sent from the Users forum mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Multi-tabs and back-button support 1.5.2

2011-10-27 Thread Martin Grigorov
Hi,

I think Page.renderCount is what stops the storing of the values.
This flag indicates that the page the user uses is stale, i.e. there
is another render of the same page happened after.
The actual check is in PageProvider class.

I don't see any clean solution for now.

What should happen if the user opens an edit page for the same entity
in two tabs ?
For example she saves some changes in tab2 and then goes to tab1 makes
another changes and tries to save them too ?
I guess you will want to abort the second save because it works with stale data.

On Thu, Oct 27, 2011 at 7:51 AM, Charlie Midtlyng
 wrote:
>
> We are developing an application with forms and currently using wicket
> 1.4.18.
>
> There are primarily  two issues that we are struggeling with when upgrading
> to wicket 1.5.2.
>
> Let's say we open Page A in two tabs, first Tab1 and then Tab2. If we fill
> the form in Tab1 and submit it will be valid data, but they are not stored
> on our models.
> However, if we fill in form in Tab2 they are stored since this tab has a
> higher version number than Tab1.
>
> More or less the same issue exists when using back-button. Open PageA, fill
> in the form and submit. Use back-button and change values and submit. The
> new values are not stored on the models. In our case it would have been
> better if the version number increased when using the back-button.
>
> Is it supposed to work in 1.5.2, and are there some special settings one
> must be aware of?
>
> Charlie
>
>
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Multi-tabs and back-button support 1.5.2

2011-10-27 Thread Charlie Midtlyng

We are developing an application with forms and currently using wicket
1.4.18.

There are primarily  two issues that we are struggeling with when upgrading
to wicket 1.5.2.

Let's say we open Page A in two tabs, first Tab1 and then Tab2. If we fill
the form in Tab1 and submit it will be valid data, but they are not stored
on our models.
However, if we fill in form in Tab2 they are stored since this tab has a
higher version number than Tab1.

More or less the same issue exists when using back-button. Open PageA, fill
in the form and submit. Use back-button and change values and submit. The
new values are not stored on the models. In our case it would have been
better if the version number increased when using the back-button.

Is it supposed to work in 1.5.2, and are there some special settings one
must be aware of?

Charlie