Change in vdsm[master]: Fix fix getDomUuidFromVolumePath()
Dan Kenigsberg has posted comments on this change. Change subject: Fix fix getDomUuidFromVolumePath() .. Patch Set 1: Could you tell why 20790 is less robust? Your own patch assumes that the leading path does not have /images in it. -- To view, visit http://gerrit.ovirt.org/20783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I648e6a3f4e877c8f2471e82d7064c3e5a021d4d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configuring selinux allowing qemu-kvm to generate coredumps.
oVirt Jenkins CI Server has posted comments on this change. Change subject: configuring selinux allowing qemu-kvm to generate coredumps. .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4372/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5176/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5252/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia22181fe0c60ccab1cc8004213e216292ccc8283 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configuring selinux allowing qemu-kvm to generate coredumps.
Dan Kenigsberg has posted comments on this change. Change subject: configuring selinux allowing qemu-kvm to generate coredumps. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia22181fe0c60ccab1cc8004213e216292ccc8283 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix fix fix getDomUuidFromVolumePath()
Dan Kenigsberg has abandoned this change. Change subject: Fix fix fix getDomUuidFromVolumePath() .. Abandoned I do not see any reason why this patch is lesser than the one suggested in http://gerrit.ovirt.org/20783. Both reimplement the function, and neither fixes the deeper problem of having to use it. However, I do note care enough about this matter in order to argue. -- To view, visit http://gerrit.ovirt.org/20790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I96b71b7839666d402ec5166eefeac618685c0ab0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix fix getDomUuidFromVolumePath()
Dan Kenigsberg has posted comments on this change. Change subject: Fix fix getDomUuidFromVolumePath() .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I648e6a3f4e877c8f2471e82d7064c3e5a021d4d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix fix getDomUuidFromVolumePath()
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix fix getDomUuidFromVolumePath() .. Fix fix getDomUuidFromVolumePath() Change-Id: I648e6a3f4e877c8f2471e82d7064c3e5a021d4d1 Bug-Url: http://bugzilla.redhat.com/1017735 Signed-off-by: Eduardo ewars...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20783 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/fileVolume.py 1 file changed, 5 insertions(+), 12 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I648e6a3f4e877c8f2471e82d7064c3e5a021d4d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: StatsThread: dropped unused methods
Petr Šebek has posted comments on this change. Change subject: sampling: StatsThread: dropped unused methods .. Patch Set 1: Verified+1 Code-Review+1 VdsStats works as should. Pausing thread is not used anywhere so it's needless, same of constant MBITOBYTES. -- To view, visit http://gerrit.ovirt.org/20672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id92031ea787aa41a97f7a1ab488065b06f29673e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: drop unused checkPathStat
Petr Šebek has posted comments on this change. Change subject: drop unused checkPathStat .. Patch Set 1: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d3017b2cc13134253284248258879c6140d26de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.utils: drop unused ImagePathStatus and getPidNiceness
Petr Šebek has posted comments on this change. Change subject: vdsm.utils: drop unused ImagePathStatus and getPidNiceness .. Patch Set 2: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78a732c6204385a3c33c4a1aea2cc78e3f404bb6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 22: This part should be in pre_start tasks, I will check why it was added as configuration . but currently this patch should stable vdsm-tool api and not focus on the sanlock part imo -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 23: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4373/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5177/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5253/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configuring selinux allowing qemu-kvm to generate coredumps.
Yaniv Bronhaim has posted comments on this change. Change subject: configuring selinux allowing qemu-kvm to generate coredumps. .. Patch Set 6: Code-Review+1 (1 comment) File vdsm.spec.in Line 643: /bin/sed -i '/# VDSM section begin/,/# VDSM section end/d' \ Line 644: /etc/sysctl.conf Line 645: fi Line 646: Line 647: # hack until we replace core dump with abrt todo: ? Line 648: /usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?' Line 649: /sbin/restorecon -R -v /var/log/core Line 650: Line 651: %if 0%{?rhel} -- To view, visit http://gerrit.ovirt.org/20705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia22181fe0c60ccab1cc8004213e216292ccc8283 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Alon Bar-Lev has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 23: but currently this patch should stable vdsm-tool api and not focus on the sanlock part imo I do not think it is that hard to make it complete (libvirt and sanlock) -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.utils: drop unused ImagePathStatus and getPidNiceness
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm.utils: drop unused ImagePathStatus and getPidNiceness .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78a732c6204385a3c33c4a1aea2cc78e3f404bb6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Quarantine ovirt-3.0.0 network upgrade
Dan Kenigsberg has uploaded a new change for review. Change subject: Quarantine ovirt-3.0.0 network upgrade .. Quarantine ovirt-3.0.0 network upgrade Since ovirt-3.0.z, Vdsm uses libvirt networks (with names vdsm-*) to store its own networks. Older Vdsms did not have those defined, and used only Linux bridges. _syncLibvirtNetworks created a vdsm-bla network for every bridge named bla, even if that bridge had nothing to do with ovirt. This patch replaces _syncLibvirtNetworks with a help script that does this conversion on the rare occasion that upgrade is needed. It identifies this occasion by the existence of ovirtmgmt bridge and nonexistence of a vdsm-ovirtmgmt network. Moving the code to a separate script would make it easier to get rid of it once ovirt-3.0.0 hosts are no longer supported. Change-Id: Icb21715dc3b92fc6c198dbb4c49f0bbef0cb Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm.install M init/vdsmd_init_common.sh.in M vdsm.spec.in M vdsm/Makefile.am M vdsm/clientIF.py A vdsm/upgrade-3.0.0-networks 6 files changed, 63 insertions(+), 23 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/20803/1 diff --git a/debian/vdsm.install b/debian/vdsm.install index 55464a3..442ed2a 100644 --- a/debian/vdsm.install +++ b/debian/vdsm.install @@ -126,6 +126,7 @@ ./usr/share/vdsm/supervdsm.py ./usr/share/vdsm/supervdsmServer ./usr/share/vdsm/tc.py +./usr/share/vdsm/upgrade-3.0.0-networks ./usr/share/vdsm/vdsm ./usr/share/vdsm/vdsm-restore-net-config ./usr/share/vdsm/vdsm-store-net-config diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in index 43a86ef..8470a03 100644 --- a/init/vdsmd_init_common.sh.in +++ b/init/vdsmd_init_common.sh.in @@ -199,6 +199,10 @@ fi return 0 } + +task_upgrade_300_nets(){ +@VDSMDIR@/upgrade-3.0.0-networks +} pre-start tasks end @@ -246,6 +250,7 @@ test_lo \ test_conflicting_conf \ restore_nets \ +upgrade_300_nets \ ;; --post-stop) diff --git a/vdsm.spec.in b/vdsm.spec.in index 34bdc2d..3ae7102 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -833,6 +833,7 @@ %{_datadir}/%{vdsm_name}/supervdsmServer %{_datadir}/%{vdsm_name}/vmChannels.py* %{_datadir}/%{vdsm_name}/tc.py* +%{_datadir}/%{vdsm_name}/upgrade-3.0.0-networks %{_datadir}/%{vdsm_name}/vdsm %{_datadir}/%{vdsm_name}/vdsm-restore-net-config %{_datadir}/%{vdsm_name}/vdsm-store-net-config diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am index 7fd9ead..3975adf 100644 --- a/vdsm/Makefile.am +++ b/vdsm/Makefile.am @@ -85,6 +85,7 @@ get-conf-item \ set-conf-item \ supervdsmServer \ + upgrade-3.0.0-networks \ vdsm \ vdsm-restore-net-config \ $(NULL) diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py index 47851b1..9e2f1b4 100644 --- a/vdsm/clientIF.py +++ b/vdsm/clientIF.py @@ -38,7 +38,6 @@ import vm from vdsm import constants from vdsm import utils -from netconf import ifcfg import caps from vmChannels import Listener from vm import Vm @@ -196,27 +195,6 @@ self.log.warn(MOM is not available, fallback to KsmMonitor) self.ksmMonitor = ksm.KsmMonitorThread(self) - -def _syncLibvirtNetworks(self): - -function is mostly for upgrade from versions that did not -have a libvirt network per vdsm network - -# add libvirt networks -nets = netinfo.networks() -bridges = netinfo.bridges() -configWriter = ifcfg.ConfigWriter() -for bridge in bridges: -if not bridge in nets: -configWriter.createLibvirtNetwork(network=bridge, - bridged=True, - skipBackup=True) -# remove bridged networks that their bridge not exists -#TODO: -# this should probably go into vdsm-restore-net script -for network in nets: -if nets[network]['bridged'] and network not in bridges: -configWriter.removeLibvirtNetwork(network, skipBackup=True) def prepareForShutdown(self): @@ -405,7 +383,6 @@ return {'status': doneCode, 'vmList': vm.status()} def _initializingLibvirt(self): -self._syncLibvirtNetworks() mog = min(config.getint('vars', 'max_outgoing_migrations'), caps.CpuTopology().cores()) vm.MigrationSourceThread.setMaxOutgoingMigrations(mog) diff --git a/vdsm/upgrade-3.0.0-networks b/vdsm/upgrade-3.0.0-networks new file mode 100644 index 000..8c3453a --- /dev/null +++ b/vdsm/upgrade-3.0.0-networks @@ -0,0 +1,55 @@ +#!/usr/bin/python +# +# Copyright 2011-2013 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License
Change in vdsm[master]: drop unused checkPathStat
Dan Kenigsberg has posted comments on this change. Change subject: drop unused checkPathStat .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d3017b2cc13134253284248258879c6140d26de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: StatsThread: dropped unused methods
Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: StatsThread: dropped unused methods .. sampling: StatsThread: dropped unused methods This is only a first step twards removal of the useless base class StatsThread. Change-Id: Id92031ea787aa41a97f7a1ab488065b06f29673e Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20672 Tested-by: Petr Šebek pse...@redhat.com Reviewed-by: Petr Šebek pse...@redhat.com --- M vdsm/sampling.py 1 file changed, 9 insertions(+), 19 deletions(-) Approvals: Petr Šebek: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id92031ea787aa41a97f7a1ab488065b06f29673e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: drop unused checkPathStat
Dan Kenigsberg has submitted this change and it was merged. Change subject: drop unused checkPathStat .. drop unused checkPathStat We actually have two copies of this junk DNA. Trim it. Change-Id: I6d3017b2cc13134253284248258879c6140d26de Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20673 Reviewed-by: Mark Wu wu...@linux.vnet.ibm.com Tested-by: Petr Šebek pse...@redhat.com Reviewed-by: Petr Šebek pse...@redhat.com --- M lib/vdsm/utils.py M vdsm/sampling.py 2 files changed, 0 insertions(+), 20 deletions(-) Approvals: Mark Wu: Looks good to me, but someone else must approve Petr Šebek: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d3017b2cc13134253284248258879c6140d26de Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: StatsThread: dropped unused methods
Dan Kenigsberg has posted comments on this change. Change subject: sampling: StatsThread: dropped unused methods .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id92031ea787aa41a97f7a1ab488065b06f29673e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Quarantine ovirt-3.0.0 network upgrade
oVirt Jenkins CI Server has posted comments on this change. Change subject: Quarantine ovirt-3.0.0 network upgrade .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4374/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5178/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5254/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb21715dc3b92fc6c198dbb4c49f0bbef0cb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.utils: drop unused ImagePathStatus and getPidNiceness
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.utils: drop unused ImagePathStatus and getPidNiceness .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78a732c6204385a3c33c4a1aea2cc78e3f404bb6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.utils: drop unused ImagePathStatus and getPidNiceness
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm.utils: drop unused ImagePathStatus and getPidNiceness .. vdsm.utils: drop unused ImagePathStatus and getPidNiceness Change-Id: I78a732c6204385a3c33c4a1aea2cc78e3f404bb6 Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20674 Reviewed-by: Mark Wu wu...@linux.vnet.ibm.com Reviewed-by: Petr Šebek pse...@redhat.com Tested-by: Petr Šebek pse...@redhat.com Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com --- M lib/vdsm/utils.py 1 file changed, 0 insertions(+), 44 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Mark Wu: Looks good to me, but someone else must approve Petr Šebek: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78a732c6204385a3c33c4a1aea2cc78e3f404bb6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getVolumeInfo() new implementation.
oVirt Jenkins CI Server has posted comments on this change. Change subject: getVolumeInfo() new implementation. .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4375/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5179/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5255/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reduce the number of getVolumeSize() calls.
Dan Kenigsberg has posted comments on this change. Change subject: Reduce the number of getVolumeSize() calls. .. Patch Set 9: Code-Review-1 (2 comments) File vdsm/storage/blockVolume.py Line 204: self.prepare(justme=True, rw=True, chainrw=force, setrw=True, Line 205: force=True) Line 206: try: Line 207: misc.ddWatchCopy( Line 208: /dev/zero, vol_path, vars.task.aborting, int(zeroLen), int() is now redundant and misleading. Line 209: recoveryCallback=volume.baseAsyncTasksRollback) Line 210: except utils.ActionStopped: Line 211: raise Line 212: except Exception: File vdsm/storage/hsm.py Line 695: Line 696: if volFormat != volume.COW_FORMAT: Line 697: # This method is used only with COW volumes (see docstring), Line 698: # for RAW volumes we just return the volume size. Line 699: return dict(size=str(domain.getVSize(imgUUID, volUUID))) needs a rebase - this bug has been fixed by http://gerrit.ovirt.org/19279 Line 700: Line 701: qemuImgFormat = volume.fmt2str(volume.COW_FORMAT) Line 702: Line 703: volToExtend.prepare() -- To view, visit http://gerrit.ovirt.org/18203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic82fab1966bc6606e3c29483bea62dd17b4c56bc Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
Sergey Gotliv has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches