Change in vdsm[master]: lib: Revert and refine error handling in tmap()
Yaniv Bronhaim has posted comments on this change. Change subject: lib: Revert and refine error handling in tmap() .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/39211/1//COMMIT_MSG Commit Message: Line 52: Line 53: succeeded = concurrent.tmap(func, values) Line 54: Line 55: if not all(succeeded): Line 56: ... We knew that... I'm not sure I understand why you changed your mind. checking each result is less efficient but you keep the error for later use and I thought your usage could require that Line 57: Line 58: We can ignore unexpected errors, since tmap() will log them and fail Line 59: loudly. We can also minimize try except block for expected errors. Line 60: https://gerrit.ovirt.org/#/c/39211/1/lib/vdsm/concurrent.py File lib/vdsm/concurrent.py: Line 66: t.join() Line 67: Line 68: if error[0] is not None: Line 69: t, v, tb = error[0] Line 70: raise t, v, tb just raise error[0]. and if you raise, the caller doesn't need to check - if not all(succeeded), just cover with try block Line 71: https://gerrit.ovirt.org/#/c/39211/1/tests/concurrentTests.py File tests/concurrentTests.py: Line 56: raise Error(x) Line 57: try: Line 58: concurrent.tmap(func, (1, 2, 3)) Line 59: except Error as e: Line 60: self.assertEqual(e.args, (3,)) can't you just check assertRaises ? simpler .. Line 61: else: -- To view, visit https://gerrit.ovirt.org/39211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0154b28ff7822c63e77181bbbf444c712bd0c31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/682/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/674/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17145/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1241/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17319/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1223/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vladik Romanovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: make _ADDRESS and _PORT public
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscli: make _ADDRESS and _PORT public .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17146/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17320/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5d9f627e572df11f01600fd4ebc5e19f85fc5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
Ido Barkan has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) .. Patch Set 9: Verified+1 commit order in this branch changed (2 commits replaced). -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vladik Romanovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: make _ADDRESS and _PORT public
Ido Barkan has posted comments on this change. Change subject: vdscli: make _ADDRESS and _PORT public .. Patch Set 2: Verified+1 replaced the commit order, as nsoffer requested -- To view, visit https://gerrit.ovirt.org/39055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5d9f627e572df11f01600fd4ebc5e19f85fc5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: make _ADDRESS and _PORT public
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscli: make _ADDRESS and _PORT public .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17320/ -- To view, visit https://gerrit.ovirt.org/39055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5d9f627e572df11f01600fd4ebc5e19f85fc5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) .. Patch Set 9: Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17319/ -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vladik Romanovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) .. Patch Set 9: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/682/ -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vladik Romanovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) .. Patch Set 9: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1241/ -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vladik Romanovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) .. Patch Set 9: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1223/ -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vladik Romanovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) .. Patch Set 9: Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17145/ -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vladik Romanovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: make _ADDRESS and _PORT public
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscli: make _ADDRESS and _PORT public .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17146/ -- To view, visit https://gerrit.ovirt.org/39055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5d9f627e572df11f01600fd4ebc5e19f85fc5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
automat...@ovirt.org has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vladik Romanovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: make _ADDRESS and _PORT public
automat...@ovirt.org has posted comments on this change. Change subject: vdscli: make _ADDRESS and _PORT public .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5d9f627e572df11f01600fd4ebc5e19f85fc5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) .. Patch Set 9: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/674/ -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vladik Romanovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Prevent systemd to kill dhclient once vdsm-network service i...
Ido Barkan has posted comments on this change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/39213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Prevent systemd to kill dhclient once vdsm-network service i...
automat...@ovirt.org has posted comments on this change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Patch Set 1: * Update tracker::#1204782::OK * Check Bug-Url::OK * Check Public Bug::#1204782::OK, public bug * Check Product::#1204782::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1204782::OK, correct target release 3.5.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/39213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Prevent systemd to kill dhclient once vdsm-network service i...
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/39213 to review the following change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Prevent systemd to kill dhclient once vdsm-network service is stopped When upgrading VDSM or for that matter, stopping vdsm-network process, systemd would kill all the descendants of the service (including dhclient). When vdsm-network starts again, it discovers /var/run/vdsm/nets_restored and does not restore any network, possibly leaving the system with interfaces that have an IP with a timer but no dhclient to renew it. Adding KillMode=Process tells systemd to only kill the service main process and nothing more. Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Bug-Url: https://bugzilla.redhat.com/1204782 Signed-off-by: Ido Barkan Reviewed-on: https://gerrit.ovirt.org/39137 Reviewed-by: Dan Kenigsberg --- M init/systemd/vdsm-network.service.in 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/39213/1 diff --git a/init/systemd/vdsm-network.service.in b/init/systemd/vdsm-network.service.in index d863f1b..8315187 100644 --- a/init/systemd/vdsm-network.service.in +++ b/init/systemd/vdsm-network.service.in @@ -10,7 +10,8 @@ ExecStartPre=@BINDIR@/vdsm-tool --vvverbose --append --logfile=@VDSMLOGDIR@/upgrade.log upgrade-unified-persistence ExecStartPre=@BINDIR@/vdsm-tool --vvverbose --append --logfile=@VDSMLOGDIR@/upgrade.log upgrade-3.0.0-networks ExecStart=@VDSMDIR@/vdsm-restore-net-config +KillMode=process RemainAfterExit=yes [Install] -WantedBy=multi-user.target \ No newline at end of file +WantedBy=multi-user.target -- To view, visit https://gerrit.ovirt.org/39213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
Bala.FA has posted comments on this change.
Change subject: gluster: fix build error in F20 due to blivet version issue
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/38942/10/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 250:
Line 251: stripeSize = raidParams.get('stripeSize', 0) / 1024.0
Line 252: # bz#1198568: The latest version of blivet does not accepts float
Line 253: # value for peSize in LVMVolumeGroupDevice function.
Line 254: # It will be enhanced once the support is available in blivet.
> Below i am passing Size object (which may contain any float value) to _crea
OK.
If f20 and f21 blivet supports int value, why can't you pass int till the bz
get fixed fully?
Line 255: if stripeSize and supportSizeObj:
Line 256: stripeSize = size.Size("%s MiB" % stripeSize)
Line 257: vg = _createVG(vgName, pvDeviceList, stripeSize)
Line 258:
--
To view, visit https://gerrit.ovirt.org/38942
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eyal Edri
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Max Kovgan
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Sandro Bonazzola
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/799/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/395/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4781/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/401/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/805/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/402/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/390/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/806/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 5: Build Started (9/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/390/ -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 5: Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/806/ -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 5: Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/401/ -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 5: Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/799/ -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 5: Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/395/ -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
Dan Kenigsberg has submitted this change and it was merged. Change subject: misc: Support zero-time in getReadDelay() .. misc: Support zero-time in getReadDelay() We found out that dd returned the following output: "517 bytes (517 B) copied, 0 s, Infinity B/s" The root cause for getting zero/Infinity stats in dd is erratic behavior of clock_gettime. Testing in the field shows that clock_gettime() using CLOCK_MONOTONIC may return the same value for duration of up to 11 milliseconds. We ran a tool sampling current time using clock_gettime(), and recording the uniqe readings and the difference between the previous and the current sample: #samples difference 177 0.1 175 0.000999812 9462 0.000999813 183 0.000999814 1 0.001999626 1 0.010997944 1 0.011997756 In dd, if the start time is equal to the end time, dd returns "0 s, Infinity B/s" misc.readpeed() fails to parse that output. This causes the domain monitor to fail and the domain to move into invalid state. This failure could cause the host to become non-operational, leading to migration storm while storage is actually valid. misc.readpeed() changed to parse the returned output. Engine tested and is not affected by this change. Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Bug-Url: https://bugzilla.redhat.com/1191549 Signed-off-by: Ala Hino Signed-off-by: Tobias Fiebig Reviewed-on: https://gerrit.ovirt.org/38082 Reviewed-by: Nir Soffer Reviewed-by: Adam Litke --- M tests/miscTests.py M vdsm/storage/misc.py 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 5: Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/772/ -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 5: Build Started (4/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/805/ -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 5: Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4781/ -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 5: Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/402/ -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
automat...@ovirt.org has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 5: * Update tracker::#1191549::OK * Set MODIFIED::bug 1191549#1191549IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 12:
(3 comments)
https://gerrit.ovirt.org/#/c/37509/12/vdsm/v2v.py
File vdsm/v2v.py:
Line 338: self._proc.blocking = True
Line 339: self._watch_process_output()
Line 340:
Line 341: if self._proc.returncode != 0:
Line 342: self._status = STATUS.ERROR
> We log this when we handle this error - why log twice?
ah, /me missed the following line. Just add the returncode to the raised
exception.
Line 343: raise V2VProcessError("Process failed: %s" %
Line 344: self._proc.stderr.read(5120))
Line 345: self._status = STATUS.DONE
Line 346:
Line 434: if res['status']['code']:
Line 435: self._status = STATUS.ERROR
Line 436: self._status_msg = 'Bad volume specification: %s' %
drive
Line 437: raise VolumeError(drive)
Line 438: self._preparedVolumes.append([drive])
> Isn't this handled in _run already?
oh it does. good.
Line 439:
Line 440: return
self._extract_storage_path(self._preparedVolumes[0]['path'])
Line 441:
Line 442: def _extract_storage_path(self, path):
Line 455: except Exception as e:
Line 456: logging.error('Error teardownVolumePath: %s', e)
Line 457:
Line 458:
Line 459: class OutputParser(object):
> self is used to get the XXX_RE class variables, and I think that this is a
this is not a real object, as it has no identity. it's using the class as a
name space, which is fine, though a bit superfluous in this case.
In any case the functions does not use self; there is never a need to
instantiate it; so they may well be @classmethods
Line 460: COPY_DISK_RE = re.compile(r'.*(Copying disk (\d+)/(\d+)).*')
Line 461: DISK_PROGRESS_RE = re.compile(r'\s+\((\d+).*')
Line 462:
Line 463: def parse(self, stream):
--
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: keep libvirt's element
Dan Kenigsberg has posted comments on this change. Change subject: virt: keep libvirt's element .. Patch Set 3: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Report info needed for refreshing devices
Adam Litke has posted comments on this change. Change subject: hsm: Report info needed for refreshing devices .. Patch Set 2: Code-Review-1 You need to update the API schema to add the new field to the GetDeviceList return structure. -- To view, visit https://gerrit.ovirt.org/38675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfa5cf4321202362f5a00dad7c9a0347ba52ec71 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
Adam Litke has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17144/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17318/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 11: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17318/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 11: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17144/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
automat...@ovirt.org has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
Timothy Asir has posted comments on this change.
Change subject: gluster: fix build error in F20 due to blivet version issue
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/38942/10/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 250:
Line 251: stripeSize = raidParams.get('stripeSize', 0) / 1024.0
Line 252: # bz#1198568: The latest version of blivet does not accepts float
Line 253: # value for peSize in LVMVolumeGroupDevice function.
Line 254: # It will be enhanced once the support is available in blivet.
> 1. I am not able to understand this bz. Below you pass stripeSize in float
Below i am passing Size object (which may contain any float value) to _createVG
if its support size object otherwise i am passing float value.
Because latest blivet version (in F21) support size obj (may contain any float)
and the older version (in F20) does not support size obj and it will work with
numerical value (in MiB) only.
The latest blivet version (in F21) should support float value also in addition
to size obj to provide backward compatibility but it does not support any float
value for peSize.
f20
~~
* support any numerical value
f21
~~
* support any numerical value in the size obj
* does not support float value
* does support int value
Note about the bug:
The bug 1198568 created before we identify this issue. Actually the function
LVMVolumeGroupDevice does not work if the size obj contain any float value
before. But that part is fixed and its available in the latest version.
However working with a float value for the given peSize (not a size obj)) part
is not yet fixed. Once that part is also fixed the bug status will be moved to
next state. Hope you are clear now.
Line 255: if stripeSize and supportSizeObj:
Line 256: stripeSize = size.Size("%s MiB" % stripeSize)
Line 257: vg = _createVG(vgName, pvDeviceList, stripeSize)
Line 258:
Line 271: metaDataSize = (metaDataSize - (metaDataSize % alignment)) /
1024.0
Line 272: poolDataSize = (poolDataSize - (poolDataSize % alignment)) /
1024.0
Line 273: # bz#1205553: The latest version of blivet does not accepts
float
Line 274: # value for size parm in LVMLogicalVolumeDevice function.
Line 275: # This part will be enhanced once the support is available in
blivet.
> Same as above
Same as above. There it is peSize param inLVMVolumeGroupDevice function but
here it is size param in LVMLogicalVolumeDevice function.
Line 276: if supportSizeObj:
Line 277: metaDataSize = size.Size("%s MiB" % metaDataSize)
Line 278: poolDataSize = size.Size("%s MiB" % poolDataSize)
Line 279: pool = _createThinPool(poolName, vg, chunkSize, metaDataSize,
poolDataSize)
--
To view, visit https://gerrit.ovirt.org/38942
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eyal Edri
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Max Kovgan
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Sandro Bonazzola
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: make _ADDRESS and _PORT public
Nir Soffer has posted comments on this change. Change subject: vdscli: make _ADDRESS and _PORT public .. Patch Set 1: Ido, can you remove the change in vdsm_dump_chains.py, and move this patch bellow the dump chains patch? This is a small and easy change and we can merge it soon, while reviewing and merging the new tool command will take more time. -- To view, visit https://gerrit.ovirt.org/39055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5d9f627e572df11f01600fd4ebc5e19f85fc5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: Revert and refine error handling in tmap()
oVirt Jenkins CI Server has posted comments on this change. Change subject: lib: Revert and refine error handling in tmap() .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17143/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17317/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0154b28ff7822c63e77181bbbf444c712bd0c31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-scan: Use utilities from vdsm library.
oVirt Jenkins CI Server has posted comments on this change. Change subject: fc-scan: Use utilities from vdsm library. .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17142/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17316/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48748d6a43d41e034e16cb4f636ebe627881590 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: Revert and refine error handling in tmap()
oVirt Jenkins CI Server has posted comments on this change. Change subject: lib: Revert and refine error handling in tmap() .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17317/ -- To view, visit https://gerrit.ovirt.org/39211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0154b28ff7822c63e77181bbbf444c712bd0c31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/681/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/673/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17141/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1240/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17315/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1222/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-scan: Use utilities from vdsm library.
oVirt Jenkins CI Server has posted comments on this change. Change subject: fc-scan: Use utilities from vdsm library. .. Patch Set 4: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17316/ -- To view, visit https://gerrit.ovirt.org/38466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48748d6a43d41e034e16cb4f636ebe627881590 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17138/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17312/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 11: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17315/ -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: change destServer attribute to private
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: change destServer attribute to private .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17140/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17314/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a12439ec15110909706038d31f2a2900fe8c17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: change destServer attribute to private
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: change destServer attribute to private .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17314/ -- To view, visit https://gerrit.ovirt.org/39204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a12439ec15110909706038d31f2a2900fe8c17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17139/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17313/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17313/ -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17312/ -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-scan: Use utilities from vdsm library.
Nir Soffer has posted comments on this change. Change subject: fc-scan: Use utilities from vdsm library. .. Patch Set 4: This version simplify and improve error handling based on error handling changes in tmap. - rescan_host handle now only expect errors - try except blocks are minimized to code that is expected to fail -- To view, visit https://gerrit.ovirt.org/38466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48748d6a43d41e034e16cb4f636ebe627881590 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17137/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17311/ : FAILURE -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: configurable sampling interval for HostStatsThread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: configurable sampling interval for HostStatsThread .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17136/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17310/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I526029a6a45a928fd0af2f320fe64ac842e205a2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 5: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17311/ -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
Nir Soffer has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 11: This version simplify and improve error handling based on error handling changes in tmap. - rescan_path handle now only expect errors - try except blocks are minimized to code that is expected to fail -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: configurable sampling interval for HostStatsThread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: configurable sampling interval for HostStatsThread .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17310/ -- To view, visit https://gerrit.ovirt.org/39191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I526029a6a45a928fd0af2f320fe64ac842e205a2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: net: getXML: supply alias when known
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: net: getXML: supply alias when known .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17135/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17309/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01a881144514ad8abbd0b1d3e4e2bc877b0e88c9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: net: getXML: supply alias when known
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: net: getXML: supply alias when known .. Patch Set 4: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17309/ -- To view, visit https://gerrit.ovirt.org/38880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01a881144514ad8abbd0b1d3e4e2bc877b0e88c9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: stop VmStatsThread on shutdown
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: stop VmStatsThread on shutdown .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17134/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17308/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: stop VmStatsThread on shutdown
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: stop VmStatsThread on shutdown .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17308/ -- To view, visit https://gerrit.ovirt.org/39038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add stopVmStats method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add stopVmStats method .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17133/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17307/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17132/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17306/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add stopVmStats method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add stopVmStats method .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17307/ -- To view, visit https://gerrit.ovirt.org/39037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: keep libvirt's element
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: keep libvirt's element .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17131/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17305/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17306/ -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: net: getXML: supply alias when known
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: net: getXML: supply alias when known .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17130/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17304/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01a881144514ad8abbd0b1d3e4e2bc877b0e88c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: keep libvirt's element
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: keep libvirt's element .. Patch Set 3: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17305/ -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Safer and simpler itmap
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Safer and simpler itmap .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17129/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17303/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6116ac4003702c8e921cebaf494491a6f9afaf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: net: getXML: supply alias when known
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: net: getXML: supply alias when known .. Patch Set 3: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17304/ -- To view, visit https://gerrit.ovirt.org/38880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01a881144514ad8abbd0b1d3e4e2bc877b0e88c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Safer and simpler itmap
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Safer and simpler itmap .. Patch Set 6: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17303/ -- To view, visit https://gerrit.ovirt.org/39119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6116ac4003702c8e921cebaf494491a6f9afaf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/680/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/672/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17128/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1239/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17302/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1221/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 11: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1222/ -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 12: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17302/ -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: Revert and refine error handling in tmap()
oVirt Jenkins CI Server has posted comments on this change. Change subject: lib: Revert and refine error handling in tmap() .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17143/ -- To view, visit https://gerrit.ovirt.org/39211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0154b28ff7822c63e77181bbbf444c712bd0c31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 11: Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/673/ -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-scan: Use utilities from vdsm library.
oVirt Jenkins CI Server has posted comments on this change. Change subject: fc-scan: Use utilities from vdsm library. .. Patch Set 4: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17142/ -- To view, visit https://gerrit.ovirt.org/38466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48748d6a43d41e034e16cb4f636ebe627881590 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 11: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17141/ -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 11: Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1240/ -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-scan: Use utilities from vdsm library.
automat...@ovirt.org has posted comments on this change. Change subject: fc-scan: Use utilities from vdsm library. .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48748d6a43d41e034e16cb4f636ebe627881590 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 11: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/681/ -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
automat...@ovirt.org has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: Revert and refine error handling in tmap()
automat...@ovirt.org has posted comments on this change. Change subject: lib: Revert and refine error handling in tmap() .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0154b28ff7822c63e77181bbbf444c712bd0c31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: Revert and refine error handling in tmap()
Nir Soffer has uploaded a new change for review.
Change subject: lib: Revert and refine error handling in tmap()
..
lib: Revert and refine error handling in tmap()
In commit 2b7155b696 (lib: Simplify and generalize concurrent.tmap()),
we simplified error handling by returning a named tuple with function
results. This turned out less useful then the original error handling.
This patch returns the previous error handling:
- Functions passed to tmap() should not raise - if they raise, this is
considered a bug in the function.
- The last error is raised by tmap() instead of returning the result.
This make it easier to fail loudly for unexpected errors.
- The original exception is re-raised now with the original traceback.
- Error handling is documented properly now
Previously you had to make sure function raises to signal failures:
def func():
try:
code that should not fail...
code that may fail...
code that should not fail...
except ExpectedError:
log.error(...)
raise
except Exception:
log.exception(...)
raise
results = concurrent.tmap(func, values)
if not all(r.succeeded for r in results):
...
Returning the result as is lets us have nicer code:
def func():
code that should not fail...
try:
code that may fail...
except ExpectedError:
log.error(...)
return False
code that should not fail...
return True
succeeded = concurrent.tmap(func, values)
if not all(succeeded):
...
We can ignore unexpected errors, since tmap() will log them and fail
loudly. We can also minimize try except block for expected errors.
Change-Id: I0154b28ff7822c63e77181bbbf444c712bd0c31e
Signed-off-by: Nir Soffer
---
M lib/vdsm/concurrent.py
M tests/concurrentTests.py
2 files changed, 45 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/39211/1
diff --git a/lib/vdsm/concurrent.py b/lib/vdsm/concurrent.py
index 64e072d..5498052 100644
--- a/lib/vdsm/concurrent.py
+++ b/lib/vdsm/concurrent.py
@@ -18,22 +18,42 @@
# Refer to the README and COPYING files for full details of the license
#
+import logging
import threading
-from collections import namedtuple
-
-
-Result = namedtuple("Result", ["succeeded", "value"])
+import sys
def tmap(func, iterable):
+"""
+Run func with arguments from iterable in multiple threads, a returning the
+output in order of arguments.
+
+func should not raise exceptions - we consider this a bug in func, and will
+fail the call and re-raise the exception in the caller thread.
+
+Expected exceptions should be handled in func. If the caller likes to
+handle the error later, func should return it:
+
+def func(value):
+try:
+return something(value)
+except ExpectedError as e:
+return e
+
+Unexpected exceptions should not be handled, as they are logged in the
+worker threads and re-raised in the caller thread. If multiple excpetions
+raised, only the last one will be re-raised in the caller thread.
+"""
args = list(iterable)
results = [None] * len(args)
+error = [None]
def worker(i, f, arg):
try:
-results[i] = Result(True, f(arg))
-except Exception as e:
-results[i] = Result(False, e)
+results[i] = f(arg)
+except Exception:
+error[0] = sys.exc_info()
+logging.exception("Unhandled exception in tmap worker thread")
threads = []
for i, arg in enumerate(args):
@@ -45,4 +65,8 @@
for t in threads:
t.join()
+if error[0] is not None:
+t, v, tb = error[0]
+raise t, v, tb
+
return results
diff --git a/tests/concurrentTests.py b/tests/concurrentTests.py
index 307e397..5c0646b 100644
--- a/tests/concurrentTests.py
+++ b/tests/concurrentTests.py
@@ -26,13 +26,16 @@
from vdsm import concurrent
+class Error(Exception):
+pass
+
+
class TMapTests(VdsmTestCase):
def test_results(self):
values = tuple(range(10))
results = concurrent.tmap(lambda x: x, values)
-expected = [concurrent.Result(True, x) for x in values]
-self.assertEqual(results, expected)
+self.assertEqual(results, list(values))
def test_results_order(self):
def func(x):
@@ -40,8 +43,7 @@
return x
values = tuple(random.random() * 0.1 for x in range(10))
results = concurrent.tmap(func, values)
-expected = [concurrent.Result(True, x) for x in values]
-self.assertEqual(results, expected)
+self.assertEqual(results, list(values))
def test_concurrency(self):
start = time.time()
@@ -49,12 +51,12 @@
elapsed = time.tim
Change in vdsm[master]: misc: Safer and simpler itmap
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Safer and simpler itmap .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17127/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17301/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6116ac4003702c8e921cebaf494491a6f9afaf Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Safer and simpler itmap
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Safer and simpler itmap .. Patch Set 5: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17301/ -- To view, visit https://gerrit.ovirt.org/39119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6116ac4003702c8e921cebaf494491a6f9afaf Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Safer and simpler itmap
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Safer and simpler itmap .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17126/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17300/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6116ac4003702c8e921cebaf494491a6f9afaf Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Safer and simpler itmap
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Safer and simpler itmap .. Patch Set 4: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17300/ -- To view, visit https://gerrit.ovirt.org/39119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6116ac4003702c8e921cebaf494491a6f9afaf Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. .. Patch Set 32: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17125/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17299/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/17644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verb to setup geo-rep mount broker.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verb to setup geo-rep mount broker. .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/679/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/671/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17124/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1238/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17298/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1220/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9498c937bdf44b7747253e9bc203cb9eca1e671f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: David Caro Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. .. Patch Set 32: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17299/ -- To view, visit https://gerrit.ovirt.org/17644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verb to setup geo-rep mount broker.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verb to setup geo-rep mount broker. .. Patch Set 7: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17298/ -- To view, visit https://gerrit.ovirt.org/38444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9498c937bdf44b7747253e9bc203cb9eca1e671f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: David Caro Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: keep libvirt's element
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: keep libvirt's element .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17123/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17297/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: keep libvirt's element
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: keep libvirt's element .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17297/ -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Prevent systemd to kill dhclient once vdsm-network service i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17122/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17296/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Prevent systemd to kill dhclient once vdsm-network service i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17296/ -- To view, visit https://gerrit.ovirt.org/39137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: revert build dependency on non-existing blivet
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: revert build dependency on non-existing blivet .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/678/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/670/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17121/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1237/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17295/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1219/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fc8f3c802e711a844b8aed0b927111cf0d593f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: revert build dependency on non-existing blivet
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: revert build dependency on non-existing blivet .. Patch Set 1: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17295/ -- To view, visit https://gerrit.ovirt.org/39132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fc8f3c802e711a844b8aed0b927111cf0d593f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
